coreboot-gerrit May 2024

coreboot-gerrit@coreboot.org

1 participants
3267 discussions

[S] Change in coreboot[main]: tree: Remove duplicated <soc/gpio.h>
by Elyes Haouas (Code Review) 29 May '24

29 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82691?usp=email ) Change subject: tree: Remove duplicated <soc/gpio.h> ...................................................................... tree: Remove duplicated <soc/gpio.h> <gpio.h> is supposed to prvide <soc/gpio.h>. Change-Id: Ib25581bd2c8dd38cdd0396561ce5f9a782365f14 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/lenovo/m900_tiny/ramstage.c M src/mainboard/msi/ms7d25/die.c M src/mainboard/msi/ms7e06/die.c M src/mainboard/protectli/vault_cml/die.c M src/soc/qualcomm/common/pcie_common.c M src/soc/qualcomm/common/qspi.c M src/soc/qualcomm/sc7280/pcie.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/sifive/fu740/clock.c M src/soc/sifive/fu740/gpio.c 14 files changed, 0 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/82691/1 diff --git a/src/mainboard/lenovo/m900_tiny/ramstage.c b/src/mainboard/lenovo/m900_tiny/ramstage.c index 47add6f..6e66f3a 100644 --- a/src/mainboard/lenovo/m900_tiny/ramstage.c +++ b/src/mainboard/lenovo/m900_tiny/ramstage.c @@ -5,7 +5,6 @@ #include <drivers/intel/gma/int15.h> #include <gpio.h> #include <mainboard/gpio.h> -#include <soc/gpio.h> #include <soc/ramstage.h> static void print_board_id(void) diff --git a/src/mainboard/msi/ms7d25/die.c b/src/mainboard/msi/ms7d25/die.c index 52b3338..34fa75b 100644 --- a/src/mainboard/msi/ms7d25/die.c +++ b/src/mainboard/msi/ms7d25/die.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <pc80/i8254.h> -#include <soc/gpio.h> #include <delay.h> #include <gpio.h> diff --git a/src/mainboard/msi/ms7e06/die.c b/src/mainboard/msi/ms7e06/die.c index 52b3338..34fa75b 100644 --- a/src/mainboard/msi/ms7e06/die.c +++ b/src/mainboard/msi/ms7e06/die.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <pc80/i8254.h> -#include <soc/gpio.h> #include <delay.h> #include <gpio.h> diff --git a/src/mainboard/protectli/vault_cml/die.c b/src/mainboard/protectli/vault_cml/die.c index 52b3338..34fa75b 100644 --- a/src/mainboard/protectli/vault_cml/die.c +++ b/src/mainboard/protectli/vault_cml/die.c @@ -2,7 +2,6 @@ #include <console/console.h> #include <pc80/i8254.h> -#include <soc/gpio.h> #include <delay.h> #include <gpio.h> diff --git a/src/soc/qualcomm/common/pcie_common.c b/src/soc/qualcomm/common/pcie_common.c index 65c2940..b877563 100644 --- a/src/soc/qualcomm/common/pcie_common.c +++ b/src/soc/qualcomm/common/pcie_common.c @@ -9,7 +9,6 @@ #include <device/pci_ids.h> #include <gpio.h> #include <soc/clock.h> -#include <soc/gpio.h> #include <soc/qcom_qmp_phy.h> #include <soc/pcie.h> #include <timer.h> diff --git a/src/soc/qualcomm/common/qspi.c b/src/soc/qualcomm/common/qspi.c index 3340c00..088c79d 100644 --- a/src/soc/qualcomm/common/qspi.c +++ b/src/soc/qualcomm/common/qspi.c @@ -6,7 +6,6 @@ #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/qspi_common.h> -#include <soc/gpio.h> #include <soc/clock.h> #include <symbols.h> #include <assert.h> diff --git a/src/soc/qualcomm/sc7280/pcie.c b/src/soc/qualcomm/sc7280/pcie.c index 84fa44c..e904455 100644 --- a/src/soc/qualcomm/sc7280/pcie.c +++ b/src/soc/qualcomm/sc7280/pcie.c @@ -7,7 +7,6 @@ #include <gpio.h> #include <soc/addressmap.h> #include <soc/clock.h> -#include <soc/gpio.h> #include <soc/qcom_qmp_phy.h> #include <soc/pcie.h> diff --git a/src/soc/rockchip/common/gpio.c b/src/soc/rockchip/common/gpio.c index 73ddfd7..5629e6b 100644 --- a/src/soc/rockchip/common/gpio.c +++ b/src/soc/rockchip/common/gpio.c @@ -3,7 +3,6 @@ #include <device/mmio.h> #include <assert.h> #include <gpio.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h> #include <types.h> diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index 9d6cca1..f9f41e2 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -13,7 +13,6 @@ #include <soc/display.h> #include <soc/edp.h> #include <soc/hdmi.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h> #include <soc/vop.h> diff --git a/src/soc/rockchip/rk3288/gpio.c b/src/soc/rockchip/rk3288/gpio.c index ed09d02..a1da1d7 100644 --- a/src/soc/rockchip/rk3288/gpio.c +++ b/src/soc/rockchip/rk3288/gpio.c @@ -2,7 +2,6 @@ #include <gpio.h> #include <soc/addressmap.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/pmu.h> #include <soc/soc.h> diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index 728f45d..f0b7871 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -12,7 +12,6 @@ #include <soc/clock.h> #include <soc/display.h> #include <soc/edp.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/mmu_operations.h> #include <soc/mipi.h> diff --git a/src/soc/rockchip/rk3399/gpio.c b/src/soc/rockchip/rk3399/gpio.c index 6c022d8..8c66987 100644 --- a/src/soc/rockchip/rk3399/gpio.c +++ b/src/soc/rockchip/rk3399/gpio.c @@ -2,7 +2,6 @@ #include <gpio.h> #include <soc/addressmap.h> -#include <soc/gpio.h> #include <soc/grf.h> #include <soc/soc.h> diff --git a/src/soc/sifive/fu740/clock.c b/src/soc/sifive/fu740/clock.c index 91e7992..299409d 100644 --- a/src/soc/sifive/fu740/clock.c +++ b/src/soc/sifive/fu740/clock.c @@ -7,7 +7,6 @@ #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/clock.h> -#include <soc/gpio.h> #include <gpio.h> #include <stdint.h> diff --git a/src/soc/sifive/fu740/gpio.c b/src/soc/sifive/fu740/gpio.c index d5576f2..a38e590 100644 --- a/src/soc/sifive/fu740/gpio.c +++ b/src/soc/sifive/fu740/gpio.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <soc/addressmap.h> -#include <soc/gpio.h> #include <stdint.h> #include <arch/mmio.h> #include <assert.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib25581bd2c8dd38cdd0396561ce5f9a782365f14 Gerrit-Change-Number: 82691 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: tree: Remove unused <option.h>
by Elyes Haouas (Code Review) 29 May '24

29 May '24

Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/82690?usp=email ) Change subject: tree: Remove unused <option.h> ...................................................................... tree: Remove unused <option.h> Change-Id: Ia3df14ebd365c00902b5d2ba300d8ade4c2d6c26 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/lenovo/haswell/variants/w541/romstage.c M src/mainboard/starlabs/starbook/variants/kbl/romstage.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/82690/1 diff --git a/src/mainboard/lenovo/haswell/variants/w541/romstage.c b/src/mainboard/lenovo/haswell/variants/w541/romstage.c index 4a189d4..a410f56 100644 --- a/src/mainboard/lenovo/haswell/variants/w541/romstage.c +++ b/src/mainboard/lenovo/haswell/variants/w541/romstage.c @@ -4,7 +4,6 @@ #include <northbridge/intel/haswell/haswell.h> #include <northbridge/intel/haswell/raminit.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <option.h> #include <ec/lenovo/pmh7/pmh7.h> #include <device/pci_ops.h> diff --git a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c index d1e928e..30d7c14 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/romstage.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <option.h> #include <soc/romstage.h> #include <spd_bin.h> #include <string.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82690?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3df14ebd365c00902b5d2ba300d8ade4c2d6c26 Gerrit-Change-Number: 82690 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[M] Change in coreboot[main]: tree: Remove unused <string.h>
by Elyes Haouas (Code Review) 29 May '24

29 May '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82666?usp=email ) Change subject: tree: Remove unused <string.h> ...................................................................... tree: Remove unused <string.h> Change-Id: I9ed1a82fcd3fc29124ddc406592bd45dc84d4628 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82666 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Reviewed-by: Yidi Lin <yidilin(a)google.com> --- M src/arch/arm64/smbios.c M src/arch/riscv/include/vm.h M src/arch/x86/smbios.c M src/console/vsprintf.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/include/bootstate.h M src/include/rmodule.h M src/lib/smbios_defaults.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/avenuecity_crb/romstage.c M src/mainboard/intel/beechnutcity_crb/romstage.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/soc/mediatek/common/display.c 41 files changed, 12 insertions(+), 41 deletions(-) Approvals: Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index 8042057..a8d0523 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -6,7 +6,6 @@ #include <console/console.h> #include <smbios.h> #include <stdio.h> -#include <string.h> static void smbios_processor_id(u32 *processor_id) { diff --git a/src/arch/riscv/include/vm.h b/src/arch/riscv/include/vm.h index c1894c7..9219f10 100644 --- a/src/arch/riscv/include/vm.h +++ b/src/arch/riscv/include/vm.h @@ -3,7 +3,6 @@ #ifndef _VM_H #define _VM_H -#include <string.h> #include <stdint.h> #include <arch/encoding.h> diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index f42de71..ef2c19a 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <smbios.h> #include <console/console.h> #include <arch/cpu.h> diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 4ffc677..086ed7c 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -2,7 +2,6 @@ #include <console/vtxprintf.h> #include <stdio.h> -#include <string.h> struct vsnprintf_context { char *str_buf; diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index b1016cd..e491f75 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -7,7 +7,6 @@ #include <device/device.h> #include <stdio.h> #include <stdlib.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 28377a1..5f43e4f 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <console/console.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 97a4e05..f5df0c4 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a3d8ef2..98c59e6 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -8,7 +8,7 @@ #include <device/device.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 8efcf21..2e2d685 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index a7dcd64..1e1ea45 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <device/device.h> #include <stdio.h> -#include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index 06b31d1..c91b04a 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -5,7 +5,7 @@ #include <assert.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include <gpio.h> #include <console/console.h> diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index a4bdb15..19eda30 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9310_ACPI_ID "STH9310" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 041991e..f2753ea 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9324_ACPI_ID "STH9324" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index d72f28d..63180c7 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define I2C_SX9360_ACPI_ID "STH9360" diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 534c0d8..9211100 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -2,7 +2,7 @@ #include <acpi/acpigen.h> #include <stdio.h> -#include <string.h> + #include "i915.h" void diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 3c867d4..3769fc9 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -8,7 +8,7 @@ #include <drivers/usb/acpi/chip.h> #include <gpio.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #include "retimer.h" diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 3c4fac1..8a451c4 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index 75d6dc9..6d92776 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,7 @@ #include <device/spi.h> #include <spi-generic.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index 716d522..bfa50c6 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <stdio.h> -#include <string.h> + #include "chip.h" static bool uart_acpi_add_gpios_to_crs(struct drivers_uart_acpi_config *config) diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index fc6b759..4fa32e6 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <stdio.h> -#include <string.h> + #include "chip.h" #define CROS_EC_I2C_TUNNEL_HID "GOOG0012" diff --git a/src/include/bootstate.h b/src/include/bootstate.h index 30231ce..ab055af 100644 --- a/src/include/bootstate.h +++ b/src/include/bootstate.h @@ -3,7 +3,6 @@ #define BOOTSTATE_H #include <assert.h> -#include <string.h> #include <stddef.h> /* Only declare main() when in ramstage. */ #if ENV_RAMSTAGE diff --git a/src/include/rmodule.h b/src/include/rmodule.h index bf26ad0..72faecc 100644 --- a/src/include/rmodule.h +++ b/src/include/rmodule.h @@ -4,7 +4,6 @@ #include <stdint.h> #include <stddef.h> -#include <string.h> #include <commonlib/rmodule-defs.h> enum { diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 56bddab..0ad6442 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -4,7 +4,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h> /* this function will fill the corresponding locator */ __weak void smbios_fill_dimm_locator(const struct dimm_info *dimm, struct smbios_type17 *t) diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 257a27f..795d96e 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -15,7 +15,6 @@ #include <soc/pci_devs.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <timer.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 971b671..02790b0 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <soc/sdram.h> #include <stdio.h> -#include <string.h> #include <types.h> static const char *sdram_configs[] = { diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 1290b97..685414e 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <amdblocks/acpi.h> -#include <string.h> #include <console/console.h> #include <device/device.h> #include <device/mmio.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index bc70db5..22f8150 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -20,7 +20,6 @@ #include <soc/spm.h> #include <soc/usb.h> #include <stdio.h> -#include <string.h> #include "gpio.h" #include "panel.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 172581f..7bdfb5e 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -14,7 +14,6 @@ #include <smbios.h> #include <soc/ramstage.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h> #include <gpio.h> #include <delay.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index d21acd6..b77513b 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -7,7 +7,6 @@ #include <device/pci_ops.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <variant/sku.h> #define R_PCH_OC_WDT_CTL 0x54 diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index e8c7e69..7eafebc 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -4,7 +4,6 @@ #include <ec/google/chromeec/ec.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <sar.h> #define SKU_UNKNOWN 0xFFFFFFFF diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 4b1b32d..964fc1c 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -11,7 +11,6 @@ #include <smbios.h> #include <soc/nhlt.h> #include <stdio.h> -#include <string.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index f6321e8..c02cbf9 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -12,7 +12,6 @@ #include <soc/gpio.h> #include <stdint.h> #include <stdio.h> -#include <string.h> #include "board_id.h" diff --git a/src/mainboard/intel/avenuecity_crb/romstage.c b/src/mainboard/intel/avenuecity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/avenuecity_crb/romstage.c +++ b/src/mainboard/intel/avenuecity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" diff --git a/src/mainboard/intel/beechnutcity_crb/romstage.c b/src/mainboard/intel/beechnutcity_crb/romstage.c index 9cd8ccc..f0e67af 100644 --- a/src/mainboard/intel/beechnutcity_crb/romstage.c +++ b/src/mainboard/intel/beechnutcity_crb/romstage.c @@ -9,7 +9,6 @@ #include <soc/ddr.h> #include <soc/iio.h> #include <soc/romstage.h> -#include <string.h> #include "chip.h" diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 85c2dd4..93cec47 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -9,7 +9,6 @@ #include <smbios.h> #include <stdint.h> #include <stdio.h> -#include <string.h> const char *smbios_system_sku(void) { diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index 8f38ca2..b15f2c1 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -7,7 +7,6 @@ #include <soc/gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h> const char *smbios_system_sku(void) { diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 01815ed..bd50fc3 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -#include <string.h> #include <types.h> #include <device/device.h> #include <console/console.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index b21c7ed..242ad9d 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -17,7 +17,6 @@ #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <AGESA.h> #include "gpio_ftns.h" diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index a70bbae..8488836 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -6,7 +6,6 @@ #include <gpio.h> #include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h> #include "gpio.h" diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 9671555..2f2869a 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -2,7 +2,6 @@ #include <smbios.h> #include <stdio.h> -#include <string.h> #include <types.h> #include "eeprom.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0c23e49..a212805 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -11,7 +11,6 @@ #include <soc/dsi.h> #include <soc/mtcmos.h> #include <stdio.h> -#include <string.h> static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) { -- To view, visit https://review.coreboot.org/c/coreboot/+/82666?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ed1a82fcd3fc29124ddc406592bd45dc84d4628 Gerrit-Change-Number: 82666 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: tree: Use <stdio.h> for snprintf
by Elyes Haouas (Code Review) 29 May '24

29 May '24

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82665?usp=email ) Change subject: tree: Use <stdio.h> for snprintf ...................................................................... tree: Use <stdio.h> for snprintf <stdio.h> header is used for input/output operations (such as printf, scanf, fopen, etc.). Although some input/output functions can manipulate strings, they do not need to directly include <string.h> because they are declared independently. Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82665 Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/acpi/acpigen.c M src/acpi/acpigen_dptf.c M src/acpi/acpigen_usb.c M src/acpi/device.c M src/arch/arm64/smbios.c M src/arch/x86/smbios.c M src/console/vsprintf.c M src/cpu/x86/smm/smm_module_loader.c M src/device/device_util.c M src/device/pci_rom.c M src/drivers/acpi/thermal_zone/thermal_zone.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/cs35l53/cs35l53.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/max98396/max98396.c M src/drivers/i2c/rt1011/rt1011.c M src/drivers/i2c/rt5645/rt5645.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/i2c/sx9360/sx9360.c M src/drivers/intel/dptf/dptf.c M src/drivers/intel/fsp2_0/util.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/mipi_camera/camera.c M src/drivers/intel/pmc_mux/conn/conn.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/nxp/uwb/uwb.c M src/drivers/ocp/dmi/smbios.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/drivers/usb/hub/acpi.c M src/drivers/usb/pci_xhci/pci_xhci.c M src/drivers/wifi/generic/acpi.c M src/ec/clevo/it5570e/ssdt.c M src/ec/google/chromeec/audio_codec/audio_codec.c M src/ec/google/chromeec/ec_dptf_helpers.c M src/ec/google/chromeec/ec_smbios.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/ec/google/chromeec/mux/conn/conn.c M src/ec/lenovo/h8/h8.c M src/ec/lenovo/h8/ssdt.c M src/include/stdio.h M src/include/string.h M src/lib/device_tree.c M src/lib/fit.c M src/lib/smbios.c M src/lib/smbios_defaults.c M src/lib/ux_locales.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/rex/mainboard.c M src/mainboard/google/volteer/mainboard.c M src/mainboard/ibm/sbp1/ramstage.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/mtlrvp/mainboard.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/lenovo/s230u/mainboard.c M src/mainboard/ocp/deltalake/ramstage.c M src/mainboard/pcengines/apu2/mainboard.c M src/mainboard/prodrive/atlas/mainboard.c M src/mainboard/prodrive/atlas/vpd.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/prodrive/hermes/smbios.c M src/security/tpm/tspi/crtm.c M src/soc/cavium/cn81xx/soc.c M src/soc/intel/common/block/acpi/cpu_hybrid.c M src/soc/intel/xeon_sp/acpi.c M src/soc/mediatek/common/display.c M src/southbridge/intel/common/rcba_pirq.c M src/southbridge/intel/lynxpoint/acpi.c M src/superio/common/ssdt.c M src/vendorcode/amd/opensil/genoa_poc/ramstage.c M src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c M src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c M src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c M src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c M src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c M src/vendorcode/google/smbios.c M tests/lib/lzma-test.c M tests/stubs/die.c M util/cbfstool/flashmap/kv_pair.c 93 files changed, 93 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index 9c04e84..4049df0 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -14,6 +14,7 @@ #include <console/console.h> #include <device/device.h> #include <device/soundwire.h> +#include <stdio.h> #include <types.h> static char *gencurrent; diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index aa8de1e..b28dcc6 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h> /* Defaults */ #define DEFAULT_RAW_UNIT "ma" diff --git a/src/acpi/acpigen_usb.c b/src/acpi/acpigen_usb.c index 221a215..c285360 100644 --- a/src/acpi/acpigen_usb.c +++ b/src/acpi/acpigen_usb.c @@ -5,6 +5,7 @@ #include <acpi/acpigen.h> #include <acpi/acpigen_usb.h> #include <device/device.h> +#include <stdio.h> static const char *power_role_to_str(enum usb_typec_power_role power_role) { diff --git a/src/acpi/device.c b/src/acpi/device.c index 7313639..af3d262 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -8,6 +8,7 @@ #include <acpi/acpigen_pci.h> #include <device/device.h> #include <stdlib.h> +#include <stdio.h> #include <types.h> #include <crc_byte.h> diff --git a/src/arch/arm64/smbios.c b/src/arch/arm64/smbios.c index 291659a..8042057 100644 --- a/src/arch/arm64/smbios.c +++ b/src/arch/arm64/smbios.c @@ -5,6 +5,7 @@ #include <arch/smc.h> #include <console/console.h> #include <smbios.h> +#include <stdio.h> #include <string.h> static void smbios_processor_id(u32 *processor_id) diff --git a/src/arch/x86/smbios.c b/src/arch/x86/smbios.c index 0338b60..f42de71 100644 --- a/src/arch/x86/smbios.c +++ b/src/arch/x86/smbios.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <arch/cpu.h> #include <cpu/x86/name.h> +#include <stdio.h> static int smbios_cpu_vendor(u8 *start) { diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 06b9e49..4ffc677 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/vtxprintf.h> +#include <stdio.h> #include <string.h> struct vsnprintf_context { diff --git a/src/cpu/x86/smm/smm_module_loader.c b/src/cpu/x86/smm/smm_module_loader.c index 02debfc..646f3bb 100644 --- a/src/cpu/x86/smm/smm_module_loader.c +++ b/src/cpu/x86/smm/smm_module_loader.c @@ -11,6 +11,7 @@ #include <device/mmio.h> #include <rmodule.h> #include <smmstore.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/device/device_util.c b/src/device/device_util.c index 5d62020..6a45770 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> #include <types.h> diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 7679552..d60720e 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -6,6 +6,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> +#include <stdio.h> #include <string.h> #include <cbfs.h> #include <cbmem.h> diff --git a/src/drivers/acpi/thermal_zone/thermal_zone.c b/src/drivers/acpi/thermal_zone/thermal_zone.c index ef95bed..b1016cd 100644 --- a/src/drivers/acpi/thermal_zone/thermal_zone.c +++ b/src/drivers/acpi/thermal_zone/thermal_zone.c @@ -5,6 +5,7 @@ #include <commonlib/bsd/helpers.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index 16ae48d..28377a1 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <console/console.h> diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 37b90ca..97a4e05 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/cs35l53/cs35l53.c b/src/drivers/i2c/cs35l53/cs35l53.c index 479ef7f..974a647 100644 --- a/src/drivers/i2c/cs35l53/cs35l53.c +++ b/src/drivers/i2c/cs35l53/cs35l53.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index a2d510b..a3d8ef2 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,6 +7,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 5487f6d..8efcf21 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index 91d4ebf..a7dcd64 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -4,6 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index fb3a439..06b31d1 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -4,6 +4,7 @@ #include <acpi/acpi_device.h> #include <assert.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include <gpio.h> diff --git a/src/drivers/i2c/max98390/max98390.c b/src/drivers/i2c/max98390/max98390.c index f4912c1..dced120 100644 --- a/src/drivers/i2c/max98390/max98390.c +++ b/src/drivers/i2c/max98390/max98390.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <identity.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/max98396/max98396.c b/src/drivers/i2c/max98396/max98396.c index ca07dbd..f71873a 100644 --- a/src/drivers/i2c/max98396/max98396.c +++ b/src/drivers/i2c/max98396/max98396.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/i2c/rt1011/rt1011.c b/src/drivers/i2c/rt1011/rt1011.c index e8ee8df..08a0fac 100644 --- a/src/drivers/i2c/rt1011/rt1011.c +++ b/src/drivers/i2c/rt1011/rt1011.c @@ -6,6 +6,7 @@ #include <device/i2c.h> #include <device/device.h> #include <stdint.h> +#include <stdio.h> #include <vendorcode/google/dsm_calib.h> #include "chip.h" diff --git a/src/drivers/i2c/rt5645/rt5645.c b/src/drivers/i2c/rt5645/rt5645.c index 28434ee..ea3837f 100644 --- a/src/drivers/i2c/rt5645/rt5645.c +++ b/src/drivers/i2c/rt5645/rt5645.c @@ -4,6 +4,8 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/device.h> +#include <stdio.h> + #include "chip.h" #define RT5645_ACPI_NAME "RT58" diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index e5142bc..a4bdb15 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 966726f..041991e 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/i2c/sx9360/sx9360.c b/src/drivers/i2c/sx9360/sx9360.c index df154f4..d72f28d 100644 --- a/src/drivers/i2c/sx9360/sx9360.c +++ b/src/drivers/i2c/sx9360/sx9360.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/i2c_simple.h> #include <device/device.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c index 5bbbc1b..b6f5005 100644 --- a/src/drivers/intel/dptf/dptf.c +++ b/src/drivers/intel/dptf/dptf.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <intelblocks/pmc_ipc.h> +#include <stdio.h> #include <soc/dptf.h> #include <soc/pci_devs.h> #include "chip.h" diff --git a/src/drivers/intel/fsp2_0/util.c b/src/drivers/intel/fsp2_0/util.c index 47dc3e8..d09b39b 100644 --- a/src/drivers/intel/fsp2_0/util.c +++ b/src/drivers/intel/fsp2_0/util.c @@ -8,6 +8,7 @@ #include <commonlib/fsp.h> #include <console/console.h> #include <fsp/util.h> +#include <stdio.h> #include <string.h> #include <types.h> #include <assert.h> diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 2ee1d63..534c0d8 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include "i915.h" diff --git a/src/drivers/intel/mipi_camera/camera.c b/src/drivers/intel/mipi_camera/camera.c index 190adc7..63a409a 100644 --- a/src/drivers/intel/mipi_camera/camera.c +++ b/src/drivers/intel/mipi_camera/camera.c @@ -9,6 +9,8 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <device/pci_def.h> +#include <stdio.h> + #include "chip.h" #define CSI2_DATA_STREAM_INTERFACE_GUID \ diff --git a/src/drivers/intel/pmc_mux/conn/conn.c b/src/drivers/intel/pmc_mux/conn/conn.c index 4b1b08c..dda1fe0 100644 --- a/src/drivers/intel/pmc_mux/conn/conn.c +++ b/src/drivers/intel/pmc_mux/conn/conn.c @@ -7,6 +7,7 @@ #include <console/console.h> #include <drivers/usb/acpi/chip.h> #include <intelblocks/acpi.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index 9e627de..3c867d4 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -7,6 +7,7 @@ #include <device/device.h> #include <drivers/usb/acpi/chip.h> #include <gpio.h> +#include <stdio.h> #include <string.h> #include "chip.h" #include "retimer.h" diff --git a/src/drivers/nxp/uwb/uwb.c b/src/drivers/nxp/uwb/uwb.c index 590b3f5..3c4fac1 100644 --- a/src/drivers/nxp/uwb/uwb.c +++ b/src/drivers/nxp/uwb/uwb.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/ocp/dmi/smbios.c b/src/drivers/ocp/dmi/smbios.c index ead9b4d..0ac3334 100644 --- a/src/drivers/ocp/dmi/smbios.c +++ b/src/drivers/ocp/dmi/smbios.c @@ -6,6 +6,7 @@ #include <delay.h> #include <cpu/x86/mp.h> #include <timer.h> +#include <stdio.h> #include <string.h> #include <soc/soc_util.h> #include <soc/util.h> diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index e87946f..75d6dc9 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/spi.h> #include <spi-generic.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index a245f2c..716d522 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/drivers/usb/hub/acpi.c b/src/drivers/usb/hub/acpi.c index ebbe4b2..15732a8 100644 --- a/src/drivers/usb/hub/acpi.c +++ b/src/drivers/usb/hub/acpi.c @@ -2,6 +2,7 @@ #include <acpi/acpigen.h> #include <acpi/acpi_device.h> +#include <stdio.h> #include "chip.h" diff --git a/src/drivers/usb/pci_xhci/pci_xhci.c b/src/drivers/usb/pci_xhci/pci_xhci.c index 47f69c0..b898642 100644 --- a/src/drivers/usb/pci_xhci/pci_xhci.c +++ b/src/drivers/usb/pci_xhci/pci_xhci.c @@ -7,6 +7,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <device/xhci.h> +#include <stdio.h> #include <stdlib.h> #define PCI_XHCI_CLASSCODE 0x0c0330 /* USB3.0 xHCI controller */ diff --git a/src/drivers/wifi/generic/acpi.c b/src/drivers/wifi/generic/acpi.c index 9e2936d..fd1da06 100644 --- a/src/drivers/wifi/generic/acpi.c +++ b/src/drivers/wifi/generic/acpi.c @@ -7,6 +7,7 @@ #include <device/pci_ids.h> #include <mtcl.h> #include <sar.h> +#include <stdio.h> #include <stdlib.h> #include <wrdd.h> diff --git a/src/ec/clevo/it5570e/ssdt.c b/src/ec/clevo/it5570e/ssdt.c index a0d746a..b5a5774 100644 --- a/src/ec/clevo/it5570e/ssdt.c +++ b/src/ec/clevo/it5570e/ssdt.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/mmio.h> +#include <stdio.h> #include "chip.h" #include "ec.h" diff --git a/src/ec/google/chromeec/audio_codec/audio_codec.c b/src/ec/google/chromeec/audio_codec/audio_codec.c index a8def98..fe2a459 100644 --- a/src/ec/google/chromeec/audio_codec/audio_codec.c +++ b/src/ec/google/chromeec/audio_codec/audio_codec.c @@ -5,6 +5,8 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> + #include "chip.h" #define CROS_EC_AUDIO_CODEC_HID "GOOG0013" diff --git a/src/ec/google/chromeec/ec_dptf_helpers.c b/src/ec/google/chromeec/ec_dptf_helpers.c index c44138f..3034010 100644 --- a/src/ec/google/chromeec/ec_dptf_helpers.c +++ b/src/ec/google/chromeec/ec_dptf_helpers.c @@ -4,6 +4,7 @@ #include <acpi/acpigen_dptf.h> #include <ec/google/common/dptf.h> #include <drivers/intel/dptf/chip.h> +#include <stdio.h> #include "chip.h" /* diff --git a/src/ec/google/chromeec/ec_smbios.c b/src/ec/google/chromeec/ec_smbios.c index cd7ac2e..5205ed3 100644 --- a/src/ec/google/chromeec/ec_smbios.c +++ b/src/ec/google/chromeec/ec_smbios.c @@ -2,6 +2,7 @@ #include <ec/google/chromeec/ec.h> #include <console/console.h> +#include <stdio.h> #include <string.h> #include <smbios.h> diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index 64812d4..fc6b759 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> +#include <stdio.h> #include <string.h> #include "chip.h" diff --git a/src/ec/google/chromeec/mux/conn/conn.c b/src/ec/google/chromeec/mux/conn/conn.c index bb3129b..1200b5c 100644 --- a/src/ec/google/chromeec/mux/conn/conn.c +++ b/src/ec/google/chromeec/mux/conn/conn.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-or-later */ #include <acpi/acpigen.h> +#include <stdio.h> #include "chip.h" diff --git a/src/ec/lenovo/h8/h8.c b/src/ec/lenovo/h8/h8.c index 35ca1d9..155a013 100644 --- a/src/ec/lenovo/h8/h8.c +++ b/src/ec/lenovo/h8/h8.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pnp.h> #include <ec/acpi/ec.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include <option.h> diff --git a/src/ec/lenovo/h8/ssdt.c b/src/ec/lenovo/h8/ssdt.c index 5dc334f..7d7bfac 100644 --- a/src/ec/lenovo/h8/ssdt.c +++ b/src/ec/lenovo/h8/ssdt.c @@ -2,6 +2,7 @@ #include <console/console.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include "h8.h" diff --git a/src/include/stdio.h b/src/include/stdio.h index d59b941..fe7cb58 100644 --- a/src/include/stdio.h +++ b/src/include/stdio.h @@ -1,8 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /** - * Note: This file is only for POSIX compatibility, and is meant to be - * chain-included via string.h. + * Note: This file is only for POSIX compatibility. */ #ifndef STDIO_H diff --git a/src/include/string.h b/src/include/string.h index 4a06556..33f0dfe 100644 --- a/src/include/string.h +++ b/src/include/string.h @@ -4,7 +4,6 @@ #define STRING_H #include <stddef.h> -#include <stdio.h> /* IWYU pragma: export */ void *memcpy(void *dest, const void *src, size_t n); void *memmove(void *dest, const void *src, size_t n); diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c index 2bfd5dd..aff9e15 100644 --- a/src/lib/device_tree.c +++ b/src/lib/device_tree.c @@ -8,6 +8,7 @@ #include <endian.h> #include <stdbool.h> #include <stdint.h> +#include <stdio.h> #include <string.h> #include <stddef.h> #include <stdlib.h> diff --git a/src/lib/fit.c b/src/lib/fit.c index 46ac972..7f0fe67 100644 --- a/src/lib/fit.c +++ b/src/lib/fit.c @@ -12,6 +12,7 @@ #include <memrange.h> #include <fit.h> #include <boardid.h> +#include <stdio.h> #include <stdlib.h> #include <types.h> diff --git a/src/lib/smbios.c b/src/lib/smbios.c index dcf12bf..ca71e3b 100644 --- a/src/lib/smbios.c +++ b/src/lib/smbios.c @@ -16,6 +16,7 @@ #include <device/pci_ids.h> #include <device/pci.h> #include <drivers/vpd/vpd.h> +#include <stdio.h> #include <stdlib.h> static u8 smbios_checksum(u8 *p, u32 length) diff --git a/src/lib/smbios_defaults.c b/src/lib/smbios_defaults.c index 8b62ebb..56bddab 100644 --- a/src/lib/smbios_defaults.c +++ b/src/lib/smbios_defaults.c @@ -3,6 +3,7 @@ #include <memory_info.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h> /* this function will fill the corresponding locator */ diff --git a/src/lib/ux_locales.c b/src/lib/ux_locales.c index 0a285d9..b389548 100644 --- a/src/lib/ux_locales.c +++ b/src/lib/ux_locales.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <security/vboot/misc.h> #include <stddef.h> +#include <stdio.h> #include <string.h> #include <ux_locales.h> #include <vb2_api.h> diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 0d631cc..257a27f 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -14,6 +14,7 @@ #include <smbios.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <timer.h> diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 64f45de..971b671 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -5,6 +5,7 @@ #include <console/console.h> #include <gpio.h> #include <soc/sdram.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 427f094..1290b97 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -16,6 +16,7 @@ #include <soc/acpi.h> #include <soc/pci_devs.h> #include <soc/southbridge.h> +#include <stdio.h> #include <amdblocks/acpimmio.h> #include <variant/ec.h> #include <variant/thermal.h> diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 69047fa..bc70db5 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -19,6 +19,7 @@ #include <soc/mtcmos.h> #include <soc/spm.h> #include <soc/usb.h> +#include <stdio.h> #include <string.h> #include "gpio.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index aaa51dd..172581f 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -13,6 +13,7 @@ #include <intelblocks/power_limit.h> #include <smbios.h> #include <soc/ramstage.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h> #include <gpio.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index 7350fb0..d21acd6 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci_ops.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <variant/sku.h> diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index 90cf7ce..e8c7e69 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -3,6 +3,7 @@ #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <sar.h> diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index ff3bb36..4b1b32d 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -10,6 +10,7 @@ #include <nhlt.h> #include <smbios.h> #include <soc/nhlt.h> +#include <stdio.h> #include <string.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/rex/mainboard.c b/src/mainboard/google/rex/mainboard.c index bf489ff..9157abb 100644 --- a/src/mainboard/google/rex/mainboard.c +++ b/src/mainboard/google/rex/mainboard.c @@ -9,6 +9,7 @@ #include <ec/ec.h> #include <fw_config.h> #include <soc/ramstage.h> +#include <stdio.h> #include <stdlib.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/google/volteer/mainboard.c b/src/mainboard/google/volteer/mainboard.c index fba9664..ae7519e 100644 --- a/src/mainboard/google/volteer/mainboard.c +++ b/src/mainboard/google/volteer/mainboard.c @@ -12,6 +12,7 @@ #include <intelblocks/tcss.h> #include <soc/pci_devs.h> #include <soc/ramstage.h> +#include <stdio.h> #include <variant/gpio.h> #include <vb2_api.h> diff --git a/src/mainboard/ibm/sbp1/ramstage.c b/src/mainboard/ibm/sbp1/ramstage.c index d748b1b..98aa999 100644 --- a/src/mainboard/ibm/sbp1/ramstage.c +++ b/src/mainboard/ibm/sbp1/ramstage.c @@ -2,6 +2,7 @@ #include <cpu/x86/smm.h> #include <soc/ramstage.h> #include <soc/smmrelocate.h> +#include <stdio.h> #include "include/spr_sbp1_gpio.h" #include <bootstate.h> diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index 9ac480d..f6321e8 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -11,6 +11,7 @@ #include <smbios.h> #include <soc/gpio.h> #include <stdint.h> +#include <stdio.h> #include <string.h> #include "board_id.h" diff --git a/src/mainboard/intel/mtlrvp/mainboard.c b/src/mainboard/intel/mtlrvp/mainboard.c index 2e515f7..85c2dd4 100644 --- a/src/mainboard/intel/mtlrvp/mainboard.c +++ b/src/mainboard/intel/mtlrvp/mainboard.c @@ -8,6 +8,7 @@ #include <soc/ramstage.h> #include <smbios.h> #include <stdint.h> +#include <stdio.h> #include <string.h> const char *smbios_system_sku(void) diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index bbce927..8f38ca2 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -6,6 +6,7 @@ #include <ec/ec.h> #include <soc/gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h> const char *smbios_system_sku(void) diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index dbdd059..01815ed 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -6,6 +6,7 @@ #include <console/console.h> #include <drivers/intel/gma/int15.h> #include <option.h> +#include <stdio.h> #include <superio/hwm5_conf.h> #include <superio/nuvoton/common/hwm.h> diff --git a/src/mainboard/lenovo/s230u/mainboard.c b/src/mainboard/lenovo/s230u/mainboard.c index b5e3b87..f51ec67 100644 --- a/src/mainboard/lenovo/s230u/mainboard.c +++ b/src/mainboard/lenovo/s230u/mainboard.c @@ -5,6 +5,7 @@ #include <drivers/intel/gma/int15.h> #include <ec/acpi/ec.h> #include <southbridge/intel/common/gpio.h> +#include <stdio.h> #include <string.h> #include <smbios.h> #include "ec.h" diff --git a/src/mainboard/ocp/deltalake/ramstage.c b/src/mainboard/ocp/deltalake/ramstage.c index 6dd7c10..55a10ad 100644 --- a/src/mainboard/ocp/deltalake/ramstage.c +++ b/src/mainboard/ocp/deltalake/ramstage.c @@ -20,6 +20,7 @@ #include <soc/smmrelocate.h> #include <soc/soc_util.h> #include <soc/util.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/pcengines/apu2/mainboard.c b/src/mainboard/pcengines/apu2/mainboard.c index ac5c928..b21c7ed 100644 --- a/src/mainboard/pcengines/apu2/mainboard.c +++ b/src/mainboard/pcengines/apu2/mainboard.c @@ -16,6 +16,7 @@ #include <southbridge/amd/common/amd_pci_util.h> #include <superio/nuvoton/nct5104d/nct5104d.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <AGESA.h> #include "gpio_ftns.h" diff --git a/src/mainboard/prodrive/atlas/mainboard.c b/src/mainboard/prodrive/atlas/mainboard.c index 0128670..a70bbae 100644 --- a/src/mainboard/prodrive/atlas/mainboard.c +++ b/src/mainboard/prodrive/atlas/mainboard.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <gpio.h> #include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/atlas/vpd.c b/src/mainboard/prodrive/atlas/vpd.c index ba249a9..badbc6e 100644 --- a/src/mainboard/prodrive/atlas/vpd.c +++ b/src/mainboard/prodrive/atlas/vpd.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <console/console.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index b0bf0dd..6d0da8d 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -16,6 +16,7 @@ #include <intelblocks/pmclib.h> #include <smbios.h> #include <soc/pm.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/prodrive/hermes/smbios.c b/src/mainboard/prodrive/hermes/smbios.c index 923ce81..9671555 100644 --- a/src/mainboard/prodrive/hermes/smbios.c +++ b/src/mainboard/prodrive/hermes/smbios.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <smbios.h> +#include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c index 621d7cd..4e0a9b7 100644 --- a/src/security/tpm/tspi/crtm.c +++ b/src/security/tpm/tspi/crtm.c @@ -6,6 +6,7 @@ #include <cbfs.h> #include <symbols.h> #include "crtm.h" +#include <stdio.h> #include <string.h> static int tpm_log_initialized; diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 5e606d3..81c9a64 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -13,6 +13,7 @@ #include <soc/uart.h> #include <stddef.h> #include <stdlib.h> +#include <stdio.h> #include <string.h> #include <symbols.h> #include <libbdk-boot/bdk-boot.h> diff --git a/src/soc/intel/common/block/acpi/cpu_hybrid.c b/src/soc/intel/common/block/acpi/cpu_hybrid.c index f52b68f..68abba7 100644 --- a/src/soc/intel/common/block/acpi/cpu_hybrid.c +++ b/src/soc/intel/common/block/acpi/cpu_hybrid.c @@ -9,6 +9,7 @@ #include <device/path.h> #include <intelblocks/acpi.h> #include <soc/cpu.h> +#include <stdio.h> #include <types.h> #define CPPC_NOM_FREQ_IDX 22 diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 0d66aec..1c493af 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -6,6 +6,7 @@ #include <soc/pci_devs.h> #include <soc/util.h> #include <stdint.h> +#include <stdio.h> #include <stdlib.h> #include "chip.h" diff --git a/src/soc/mediatek/common/display.c b/src/soc/mediatek/common/display.c index 0dea58c..0c23e49 100644 --- a/src/soc/mediatek/common/display.c +++ b/src/soc/mediatek/common/display.c @@ -10,6 +10,7 @@ #include <soc/dptx.h> #include <soc/dsi.h> #include <soc/mtcmos.h> +#include <stdio.h> #include <string.h> static struct panel_serializable_data *get_mipi_cmd_from_cbfs(struct panel_description *desc) diff --git a/src/southbridge/intel/common/rcba_pirq.c b/src/southbridge/intel/common/rcba_pirq.c index ce44bc4..956fe63 100644 --- a/src/southbridge/intel/common/rcba_pirq.c +++ b/src/southbridge/intel/common/rcba_pirq.c @@ -4,6 +4,7 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <stdio.h> #include <stdlib.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/rcba_pirq.h> diff --git a/src/southbridge/intel/lynxpoint/acpi.c b/src/southbridge/intel/lynxpoint/acpi.c index aa6e650..c3aee1f 100644 --- a/src/southbridge/intel/lynxpoint/acpi.c +++ b/src/southbridge/intel/lynxpoint/acpi.c @@ -3,6 +3,7 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <acpi/acpigen.h> +#include <stdio.h> #include <string.h> #include <version.h> #include <soc/nvs.h> diff --git a/src/superio/common/ssdt.c b/src/superio/common/ssdt.c index 4fd1eed..a63ca9c 100644 --- a/src/superio/common/ssdt.c +++ b/src/superio/common/ssdt.c @@ -8,6 +8,7 @@ #include <acpi/acpi.h> #include <console/console.h> #include <types.h> +#include <stdio.h> #include <string.h> struct superio_dev { diff --git a/src/vendorcode/amd/opensil/genoa_poc/ramstage.c b/src/vendorcode/amd/opensil/genoa_poc/ramstage.c index 758b284..843f073 100644 --- a/src/vendorcode/amd/opensil/genoa_poc/ramstage.c +++ b/src/vendorcode/amd/opensil/genoa_poc/ramstage.c @@ -9,6 +9,7 @@ #include <cpu/cpu.h> #include <device/device.h> #include <soc/soc_chip.h> +#include <stdio.h> #include <xSIM-api.h> #include "opensil_console.h" #include "opensil.h" diff --git a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c index 1cf01a2..a2a0b62 100644 --- a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-config.c @@ -37,6 +37,7 @@ * ARISING OUT OF USE OR PERFORMANCE OF THE SOFTWARE LIES WITH YOU. ***********************license end**************************************/ #include <bdk.h> +#include <stdio.h> #include <string.h> #include <libbdk-hal/bdk-config.h> #include <libbdk-hal/bdk-l2c.h> diff --git a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c index fdca040..0d6bd86 100644 --- a/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c +++ b/src/vendorcode/cavium/bdk/libbdk-dram/bdk-dram-test.c @@ -48,6 +48,7 @@ #include <libbdk-hal/bdk-utils.h> #include <libbdk-os/bdk-init.h> #include <libbdk-os/bdk-thread.h> +#include <stdio.h> /* This code is an optional part of the BDK. It is only linked in if BDK_REQUIRE() needs it */ diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c index eec4443..b057353 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/bdk-config.c @@ -14,6 +14,7 @@ #include <string.h> #include <assert.h> #include <lame_string.h> +#include <stdio.h> static struct bdk_devicetree_key_value *config_fdt; diff --git a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c index 21e43a4..a099345 100644 --- a/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c +++ b/src/vendorcode/cavium/bdk/libbdk-hal/device/bdk-device.c @@ -38,6 +38,7 @@ ***********************license end**************************************/ #include <bdk.h> #include <stdlib.h> +#include <stdio.h> #include <string.h> #include "libbdk-arch/bdk-csrs-ap.h" #include "libbdk-arch/bdk-csrs-pccpf.h" diff --git a/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c b/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c index 12d49d8..ec785dd 100644 --- a/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c +++ b/src/vendorcode/cavium/bdk/libdram/dram-init-ddr3.c @@ -43,6 +43,7 @@ #include "dram-internal.h" #include <stdlib.h> +#include <stdio.h> #include <string.h> #include <libbdk-hal/bdk-config.h> #include <libbdk-hal/bdk-l2c.h> diff --git a/src/vendorcode/google/smbios.c b/src/vendorcode/google/smbios.c index 938a8f1..2bcd8db 100644 --- a/src/vendorcode/google/smbios.c +++ b/src/vendorcode/google/smbios.c @@ -2,6 +2,7 @@ #include <boardid.h> #include <smbios.h> +#include <stdio.h> #include <string.h> const char *smbios_mainboard_version(void) diff --git a/tests/lib/lzma-test.c b/tests/lib/lzma-test.c index 48d629a..e4bff56 100644 --- a/tests/lib/lzma-test.c +++ b/tests/lib/lzma-test.c @@ -4,6 +4,7 @@ #include <helpers/file.h> #include <lib.h> #include <lib/lzmadecode.h> +#include <stdio.h> #include <stdlib.h> #include <string.h> #include <sys/types.h> diff --git a/tests/stubs/die.c b/tests/stubs/die.c index 84bb401..86e5056 100644 --- a/tests/stubs/die.c +++ b/tests/stubs/die.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <stdarg.h> -#include <stdio.h> #include <tests/test.h> void die(const char *msg, ...) diff --git a/util/cbfstool/flashmap/kv_pair.c b/util/cbfstool/flashmap/kv_pair.c index b711302..5d033b3 100644 --- a/util/cbfstool/flashmap/kv_pair.c +++ b/util/cbfstool/flashmap/kv_pair.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause or GPL-2.0-only */ -#include <stdio.h> #include <stdlib.h> #include <stdarg.h> -- To view, visit https://review.coreboot.org/c/coreboot/+/82665?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe2a4ff6f68843a6d99cfdfe182cf2dd922802aa Gerrit-Change-Number: 82665 Gerrit-PatchSet: 8 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/trulo: Support OCP fault on A0/1 ports
by Dinesh Gehlot (Code Review) 29 May '24

29 May '24

Attention is currently required from: Kapil Porwal, Nick Vaccaro, Paul Menzel, Pranava Y N. Dinesh Gehlot has posted comments on this change by Pranava Y N. ( https://review.coreboot.org/c/coreboot/+/82637?usp=email ) Change subject: mb/google/trulo: Support OCP fault on A0/1 ports ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/82637?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic17debc5eecebca8c000c43a660e1b52d2932f2a Gerrit-Change-Number: 82637 Gerrit-PatchSet: 5 Gerrit-Owner: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 29 May 2024 10:32:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/razer/blade_stealth_kbl: Add H3Q variant
by Reagan (Code Review) 29 May '24

29 May '24

Attention is currently required from: Nico Huber, Paul Menzel. Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82506?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/razer/blade_stealth_kbl: Add H3Q variant ...................................................................... mb/razer/blade_stealth_kbl: Add H3Q variant The Razer Blade Stealth Kaby Lake has 2 variants. One is the H2U variant, as originally commited, with the SKU number RZ09-01962, also known as the 2016 model, and the H3Q model with SKU numbers RZ09-01963 and RZ09-01964, known as the Mid 2017 model. This commit adds support for the H3Q model. With respect to coreboot, there are few known differences: 1. Only the H2U has TPM. 2. The USB ports are different. 3. The screen size (and therefore VBIOS Table) is different. 4. The hda_verb is very slightly different. Change-Id: I493a651e52c2eb938daa67a05e9caaa784020fa4 Signed-off-by: Reagan Bohan <xbjfk.github(a)gmail.com> --- M src/mainboard/razer/blade_stealth_kbl/Kconfig M src/mainboard/razer/blade_stealth_kbl/Kconfig.name M src/mainboard/razer/blade_stealth_kbl/Makefile.mk M src/mainboard/razer/blade_stealth_kbl/board_info.txt M src/mainboard/razer/blade_stealth_kbl/devicetree.cb A src/mainboard/razer/blade_stealth_kbl/variants/h2u/board_info.txt R src/mainboard/razer/blade_stealth_kbl/variants/h2u/hda_verb.c A src/mainboard/razer/blade_stealth_kbl/variants/h2u/overridetree.cb A src/mainboard/razer/blade_stealth_kbl/variants/h3q/board_info.txt C src/mainboard/razer/blade_stealth_kbl/variants/h3q/hda_verb.c A src/mainboard/razer/blade_stealth_kbl/variants/h3q/overridetree.cb 11 files changed, 114 insertions(+), 46 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/82506/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/82506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I493a651e52c2eb938daa67a05e9caaa784020fa4 Gerrit-Change-Number: 82506 Gerrit-PatchSet: 7 Gerrit-Owner: Reagan <xbjfk.github(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/razer/blade_stealth_kbl: add panel_cfg
by Reagan (Code Review) 29 May '24

29 May '24

Attention is currently required from: Paul Menzel, Reagan. Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82458?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified+1 by build bot (Jenkins) Change subject: mb/razer/blade_stealth_kbl: add panel_cfg ...................................................................... mb/razer/blade_stealth_kbl: add panel_cfg This commit defines the panel_cfg register for the Razer Blade Stealth (Kaby Lake). This enables libgfxinit support. These values are derived from the stock firmware. First, VBIOSes were extracted from the stock firmware. Then, intelvbtool was used to extract the VBT from each of the VBIOS tables. Finally, intel_vbt_decode from igt-gpu-tools was used to extract the register values. Although there were multiple VBIOSes present in the firmware, all VBIOSes across both firmwares (on version 1.50 for the H2U and 8.02 for the H3Q) had the same register values. Change-Id: I4c8b26ffb7a70d08655986084a714206d9d0c96a Signed-off-by: Reagan Bohan <xbjfk.github(a)gmail.com> --- M src/mainboard/razer/blade_stealth_kbl/devicetree.cb 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/82458/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/82458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4c8b26ffb7a70d08655986084a714206d9d0c96a Gerrit-Change-Number: 82458 Gerrit-PatchSet: 14 Gerrit-Owner: Reagan <xbjfk.github(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reagan <xbjfk.github(a)gmail.com>

1 0

[XS] Change in coreboot[main]: libpayload: Include libpayload-config.h in lib target
by Subrata Banik (Code Review) 29 May '24

29 May '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82687?usp=email ) Change subject: libpayload: Include libpayload-config.h in lib target ...................................................................... libpayload: Include libpayload-config.h in lib target - Added `$(obj)/libpayload-config.h` as a dependency for the `lib` target. - This ensures the config header is up-to-date before building the library. TEST=Able to build google/rex. Change-Id: If26336f6261aadf611fa5338c4300873156cc3da Signed-off-by: Subrata Banik <subratabanik(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/82687 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> --- M payloads/libpayload/Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved Dinesh Gehlot: Looks good to me, approved Julius Werner: Looks good to me, approved diff --git a/payloads/libpayload/Makefile.mk b/payloads/libpayload/Makefile.mk index d5a9a81..6dd33e1 100644 --- a/payloads/libpayload/Makefile.mk +++ b/payloads/libpayload/Makefile.mk @@ -115,7 +115,7 @@ printf " AR $(subst $(CURDIR)/,,$(@))\n" printf "create $@\n$(foreach objc,$(filter-out %.a,$^),addmod $(objc)\n)$(foreach lib,$(filter %.a,$^),addlib $(lib)\n)save\nend\n" | $(AR) -M -$(obj)/libpayload.ldscript: arch/$(ARCHDIR-y)/libpayload.ldscript +$(obj)/libpayload.ldscript: arch/$(ARCHDIR-y)/libpayload.ldscript $(obj)/libpayload-config.h @printf " LDSCRIPT $@\n" $(CC) $(CFLAGS) $(EXTRA_CFLAGS) -E -P -x assembler-with-cpp -undef -o $@ $< -- To view, visit https://review.coreboot.org/c/coreboot/+/82687?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If26336f6261aadf611fa5338c4300873156cc3da Gerrit-Change-Number: 82687 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in libgfxinit[cros]: gma: Add TWL graphics device IDs
by Subrata Banik (Code Review) 29 May '24

29 May '24

Subrata Banik has submitted this change. ( https://review.coreboot.org/c/libgfxinit/+/82681?usp=email ) Change subject: gma: Add TWL graphics device IDs ...................................................................... gma: Add TWL graphics device IDs Add the TWL graphics device IDs for the tivviks board. BUG=b:343004931 TEST=eSOL verified on tivviks board. Change-Id: I23a19ab99e1bd1bc88f472116097f364b48d5b79 Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/82681 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M common/hw-gfx-gma-config.ads.template 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Angel Pons: Looks good to me, approved Kapil Porwal: Looks good to me, approved Subrata Banik: Looks good to me, approved Dinesh Gehlot: Verified diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template index 13fe224..cb46fda 100644 --- a/common/hw-gfx-gma-config.ads.template +++ b/common/hw-gfx-gma-config.ads.template @@ -563,7 +563,9 @@ function Is_Alder_Lake_N (Device_ID : Word16) return Boolean is (Device_Id = 16#46d0# or Device_Id = 16#46d1# or - Device_Id = 16#46d2#); + Device_Id = 16#46d2# or + Device_Id = 16#46d3# or + Device_Id = 16#46d4#); function Is_Raptor_Lake_P (Device_ID : Word16) return Boolean is (Device_Id = 16#a720# or Device_Id = 16#a721# or -- To view, visit https://review.coreboot.org/c/libgfxinit/+/82681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libgfxinit Gerrit-Branch: cros Gerrit-Change-Id: I23a19ab99e1bd1bc88f472116097f364b48d5b79 Gerrit-Change-Number: 82681 Gerrit-PatchSet: 4 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in libgfxinit[cros]: gma: Add TWL graphics device IDs
by Kapil Porwal (Code Review) 29 May '24

29 May '24

Attention is currently required from: Angel Pons, Dinesh Gehlot. Kapil Porwal has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/libgfxinit/+/82681?usp=email ) Change subject: gma: Add TWL graphics device IDs ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/82681?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libgfxinit Gerrit-Branch: cros Gerrit-Change-Id: I23a19ab99e1bd1bc88f472116097f364b48d5b79 Gerrit-Change-Number: 82681 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Wed, 29 May 2024 09:17:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2024