Attention is currently required from: cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81625?usp=email )
Change subject: drivers/mipi: Fine tune clock for IVO_T109NW41
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81625?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I128b33fbcda9759330a363ebb6cf66415405c488
Gerrit-Change-Number: 81625
Gerrit-PatchSet: 1
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Apr 2024 02:34:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Yidi Lin, Yu-Ping Wu, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81438?usp=email )
Change subject: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS5:
> gentle ping
Done
Patchset:
PS6:
Another CL has been separated.
https://review.coreboot.org/c/coreboot/+/81625/1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797
Gerrit-Change-Number: 81438
Gerrit-PatchSet: 6
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Apr 2024 02:34:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Ruihai Zhou, Yu-Ping Wu, cong yang.
Hello Yidi Lin, Yu-Ping Wu, build bot (Jenkins), cong yang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81438?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by cong yang, Verified+1 by build bot (Jenkins)
Change subject: drivers/mipi: Fine tune clock for BOE_NV110WUM_L60
......................................................................
drivers/mipi: Fine tune clock for BOE_NV110WUM_L60
Fine tune the panel clock to prevent mipi noise from affecting wifi
band. After tuning, the panel refresh rate keeps at 60Hz and wifi test
passed. Just keep consistent with the Linux kernel panel driver
panel-boe-tv101wum-nl6 configuration.
BUG=b:330807136
TEST=fw screen display normally
Signed-off-by: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797
---
M src/drivers/mipi/panel-BOE_NV110WUM_L60.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/81438/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81438?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic44c86f062d4e836f403ee97f2fc6370fff02797
Gerrit-Change-Number: 81438
Gerrit-PatchSet: 6
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, Xuxin Xiong, Yang Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81584?usp=email )
Change subject: mb/google/corsola: Add new board variant Wugtrio
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
https://qa.coreboot.org/job/coreboot-gerrit/255042/consoleText
```
aarch64-elf-ld.bfd: warning: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/cbfs/fallback/ramstage.debug has a LOAD segment with RWX permissions
aarch64-elf-ld.bfd: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/ramstage/mainboard/google/corsola/panel.o: in function `get_active_panel':
/home/coreboot/node-root/workspace/coreboot-gerrit/src/mainboard/google/corsola/panel.c:53:(.text.get_active_panel+0x0): undefined reference to `get_panel_description'
/home/coreboot/node-root/workspace/coreboot-gerrit/src/mainboard/google/corsola/panel.c:53:(.text.get_active_panel+0x0): relocation truncated to fit: R_AARCH64_JUMP26 against undefined symbol `get_panel_description'
make[2]: *** [src/arch/arm64/Makefile.mk:136: /cb-build/coreboot-gerrit.0/gcc/GOOGLE_WUGTRIO/cbfs/fallback/ramstage.debug] Error 1
```
The panel.c logic forces the variant that uses MIPI panel implementing `get_panel_description` at the board creation. I would suggest reordering the panel configuration patch and squashing CB:81585 into this patch.
The patch order will be
```
mb/google/corsola: Add new board variant Wugtrio
mb/google/corsola: Move MIPI panel to BOARD_SPECIFIC_OPTIONS section
drivers/mipi: Add support for KD_KD101NE3_40TI panel
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/81584?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I84cb86bf4eb2762b3072cb030b3c34a08c6b869d
Gerrit-Change-Number: 81584
Gerrit-PatchSet: 7
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 02 Apr 2024 02:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Jamie Chen, Kapil Porwal, Nick Vaccaro, Paul Menzel, SH Kim, Subrata Banik, Sumeet R Pawnikar.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81614?usp=email )
Change subject: mb/google/brya/var/xol: Reduce power limits according to battery status
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/81614?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5d71e9edde0ecbd7aaf316cd754a6ebcff9da77d
Gerrit-Change-Number: 81614
Gerrit-PatchSet: 5
Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 02 Apr 2024 02:08:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment