Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Felix Held, Fred Reitberger, Jason Glenesk, Kapil Porwal, Matt DeVillier, Nick Vaccaro.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81814?usp=email )
Change subject: tree: Drop unused <stdio.h>
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81814?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26c2abfce3417ed096d945745770fcae91a1e4ad
Gerrit-Change-Number: 81814
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 10 Apr 2024 03:36:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar, Varshit Pandya.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81627?usp=email
to look at the new patch set (#18).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai, Code-Review+1 by Varshit Pandya, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya: Create trulo variant
......................................................................
mb/google/brya: Create trulo variant
This patch adds a new variant trulo for the baseboard trulo.
BUG=b:333314089
TEST=abuild -a -x -p none -t google/brya
Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/Kconfig.name
A src/mainboard/google/brya/variants/trulo/include/variant/ec.h
A src/mainboard/google/brya/variants/trulo/include/variant/gpio.h
A src/mainboard/google/brya/variants/trulo/memory/Makefile.mk
A src/mainboard/google/brya/variants/trulo/memory/dram_id.generated.txt
A src/mainboard/google/brya/variants/trulo/memory/mem_parts_used.txt
A src/mainboard/google/brya/variants/trulo/overridetree.cb
8 files changed, 52 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81627/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Gerrit-Change-Number: 81627
Gerrit-PatchSet: 18
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar, Varshit Pandya.
Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Sumeet R Pawnikar, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81626?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai, Code-Review+1 by Varshit Pandya, Code-Review+2 by Kapil Porwal, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: mb/google/brya: Add new baseboard trulo
......................................................................
mb/google/brya: Add new baseboard trulo
This patch adds a new baseboard trulo. This commit is a stub which
only adds the minimum code needed for a successful build.
BUG=b:333314089
TEST=abuild -a -x -p none -t google/brya
Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
---
M src/mainboard/google/brya/Kconfig
A src/mainboard/google/brya/variants/baseboard/trulo/Makefile.mk
A src/mainboard/google/brya/variants/baseboard/trulo/devicetree.cb
A src/mainboard/google/brya/variants/baseboard/trulo/gpio.c
A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/ec.h
A src/mainboard/google/brya/variants/baseboard/trulo/include/baseboard/gpio.h
A src/mainboard/google/brya/variants/baseboard/trulo/memory.c
7 files changed, 134 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/81626/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Gerrit-Change-Number: 81626
Gerrit-PatchSet: 16
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81626?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Add new baseboard trulo
......................................................................
Patch Set 15:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81626/comment/2edc86c5_9bec11c6 :
PS15, Line 111: SOC_INTEL_ALDERLAKE_PCH_N
SOC_INTEL_TWINLAKE
move at line 115
--
To view, visit https://review.coreboot.org/c/coreboot/+/81626?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6230064c6b8359698d37c3e0440614cc7b073d
Gerrit-Change-Number: 81626
Gerrit-PatchSet: 15
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 10 Apr 2024 03:35:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kyoung Il Kim, Paul Menzel, Shaunak Saha.
Hello Cliff Huang, Kyoung Il Kim, Shaunak Saha, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81674?usp=email
to look at the new patch set (#4).
Change subject: vc/intel/fsp/mtl: Add Intel Touch Controller UPD in Partial Header
......................................................................
vc/intel/fsp/mtl: Add Intel Touch Controller UPD in Partial Header
Update header files for FSP for Meteor Lake platform to include Intel Touch Controller UPD's.
FSPS:
1. Added UPD's ThcMode, ThcWakeOnTouch
2. Reserved bit changes
BUG=b:332882101,b:307775082
TEST=Able to build and boot google/rex to ChromeOS.
Change-Id: I9a18b83fbb2d7760bd58027a4203919489b01580
Signed-off-by: Srinivas Kulkarni <srinivas.kulkarni(a)intel.com>
---
M src/vendorcode/intel/fsp/fsp2_0/meteorlake/FspsUpd.h
1 file changed, 51 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/81674/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81674?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a18b83fbb2d7760bd58027a4203919489b01580
Gerrit-Change-Number: 81674
Gerrit-PatchSet: 4
Gerrit-Owner: srinivas.kulkarni(a)intel.com
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Kyoung Il Kim <kyoung.il.kim(a)intel.com>
Gerrit-Reviewer: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shaunak Saha <shaunak.saha(a)intel.com>
Gerrit-Attention: Kyoung Il Kim <kyoung.il.kim(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Paul Menzel.
srinivas.kulkarni(a)intel.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81674?usp=email )
Change subject: vc/intel/fsp/mtl: Add Intel Touch Controller UPD in Partial Header
......................................................................
Patch Set 3:
(3 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81674/comment/3732b7ea_a013b2ef :
PS1, Line 2: Kulkarni, Srinivas
> Please use Srinivas Kulkarni.
Acknowledged
https://review.coreboot.org/c/coreboot/+/81674/comment/2f95c7a8_5b1e8b70 :
PS1, Line 7: Adding
> Please use imperative mood: Add ….
Acknowledged
https://review.coreboot.org/c/coreboot/+/81674/comment/41e47061_62091f50 :
PS1, Line 7: THC
> Please spell this out in the message below.
Updated to reflect the full name
--
To view, visit https://review.coreboot.org/c/coreboot/+/81674?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9a18b83fbb2d7760bd58027a4203919489b01580
Gerrit-Change-Number: 81674
Gerrit-PatchSet: 3
Gerrit-Owner: srinivas.kulkarni(a)intel.com
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 10 Apr 2024 03:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Nick Vaccaro, Sumeet R Pawnikar.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81627?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Create trulo variant
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/81627/comment/efd59894_db4b6ff3 :
PS17, Line 499: SOC_INTEL_TWINLAKE
can be moved to baseboard Trulo.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81627?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91157d252ef56c8938bfc08ed0f734c5dc7e614d
Gerrit-Change-Number: 81627
Gerrit-PatchSet: 17
Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Wed, 10 Apr 2024 03:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment