Attention is currently required from: Cliff Huang, Dolan Liu, Eric Lai, Kapil Porwal, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Jianeng Ceng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
Patch Set 9:
(4 comments)
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/89c6d435_a9f2dc30 :
PS6, Line 46:
> > I would like to add check the pointer in case of NULL pointer. […]
Done
https://review.coreboot.org/c/coreboot/+/81788/comment/1ddaec21_68e19a7e :
PS6, Line 51: ret = *curr_index;
> ret = *curr_index++;
Done
https://review.coreboot.org/c/coreboot/+/81788/comment/aa2483c6_741cf55c :
PS6, Line 52: (*curr_index)++;
> don't need
Done
File src/acpi/device.c:
https://review.coreboot.org/c/coreboot/+/81788/comment/df787ce5_3cbdfd8a :
PS7, Line 47: !gpio
> | !curr_index
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:05:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Dolan Liu, Jianeng Ceng, Kapil Porwal, Lance Zhao, Tim Wawrzynczak.
Hello Cliff Huang, Dolan Liu, Eric Lai, Lance Zhao, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
to look at the new patch set (#9).
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
acpi: Add acpi_device_write_dsd_gpio for public
Make sure it can be use for other driver.
BUG=None
TEST= Build BIOS FW pass and it can be use for other driver.
Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/acpi/device.c
M src/drivers/i2c/generic/generic.c
M src/include/acpi/acpi_device.h
3 files changed, 23 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81788/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 9
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Cliff Huang, Dolan Liu, Jianeng Ceng, Kapil Porwal, Lance Zhao, Tim Wawrzynczak.
Hello Cliff Huang, Dolan Liu, Eric Lai, Lance Zhao, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
to look at the new patch set (#8).
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
acpi: Add acpi_device_write_dsd_gpio for public
Make sure it can be use for other driver.
BUG=None
TEST= Build BIOS FW pass and it can be use for other driver.
Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/acpi/device.c
M src/drivers/i2c/generic/generic.c
M src/include/acpi/acpi_device.h
3 files changed, 23 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81788/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 8
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Poornima Tom.
Jian Tong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81945?usp=email )
Change subject: mb/google/brox: Move hda verb to variant dir
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/81945?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id987c248c37dc8bdc63be7a2513fa8997b5ddc33
Gerrit-Change-Number: 81945
Gerrit-PatchSet: 4
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 07:57:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81377?usp=email )
Change subject: soc/intel/xeon_sp/spr: Support dynamic domain SSDT generation
......................................................................
Patch Set 21:
(1 comment)
File src/soc/intel/xeon_sp/spr/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/81377/comment/c55d993e_3be70b1e :
PS19, Line 226: Domain0 device defined in uncore.asl
> maybe state that it's needed to access IO on PCH in DSDT?
Sure, updated the comments.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81377?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc5843feadc840d87c49b2aa4259716264520dba
Gerrit-Change-Number: 81377
Gerrit-PatchSet: 21
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 07:55:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Christian Walter, Jérémy Compostella, Michał Kopeć, Michał Żygowski, Nico Huber, Patrick Rudolph.
Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81276?usp=email )
Change subject: drivers/pc80/tpm: Support Xeon-SP
......................................................................
Patch Set 7:
(1 comment)
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/81276/comment/0ba2676d_fab45991 :
PS7, Line 808: /* Windows 11 requires the following path for TPM to be detected */
> Do we know that for sure? i.e. do we know that Windows 11 would accept a TPM […]
Due to we might need to clarify opens in this thread, for SPR support, I use https://review.coreboot.org/c/coreboot/+/81956 as an alternative.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81276?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6130b937ec81bbde78d2619eb859ecf354fc3854
Gerrit-Change-Number: 81276
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Wed, 17 Apr 2024 07:52:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Dolan Liu, Eric Lai, Jianeng Ceng, Kapil Porwal, Lance Zhao, Tim Wawrzynczak.
Hello Cliff Huang, Dolan Liu, Eric Lai, Lance Zhao, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81788?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins)
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
acpi: Add acpi_device_write_dsd_gpio for public
Make sure it can be use for other driver.
BUG=None
TEST= Build BIOS FW pass and it can be use for other driver.
Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
---
M src/acpi/device.c
M src/drivers/i2c/generic/generic.c
M src/include/acpi/acpi_device.h
3 files changed, 24 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/81788/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 7
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Shuo Liu, Tim Chu.
Hello Arthur Heymans, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Patrick Rudolph, Tim Chu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81377?usp=email
to look at the new patch set (#21).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: soc/intel/xeon_sp/spr: Support dynamic domain SSDT generation
......................................................................
soc/intel/xeon_sp/spr: Support dynamic domain SSDT generation
Domain SSDT is dynamically generated by soc_pci_domain_fill_ssdt.
SPR has 2 SKUs, XCC and MCC. Dynamic domain SSDT generation could
better fit both. One possible side-effect might be the extra
performance cost for generating these tables, which should not bring
big impact on high performance server CPUs.
TEST=Build and boot intel/archercity CRB
Linux ACPI host bridge parsing logs are kept the same before and
after, with below issue fixed.
[ 5.124087] ACPI BIOS Error (bug): Could not resolve symbol
[\_SB.PC16], AE_NOT_FOUND (20221020/dswload2-162)
[ 5.124087] ACPI Error: AE_NOT_FOUND, During name lookup/catalog
(20221020/psobject-220)
[ 5.124087] ACPI: Skipping parse of AML opcode: OpcodeName
unavailable (0x0010)
Change-Id: Icc5843feadc840d87c49b2aa4259716264520dba
Signed-off-by: Shuo Liu <shuo.liu(a)intel.com>
---
M src/soc/intel/xeon_sp/acpi.c
M src/soc/intel/xeon_sp/chip_gen1.c
M src/soc/intel/xeon_sp/include/soc/acpi.h
D src/soc/intel/xeon_sp/spr/acpi/cxl_resource.asl
D src/soc/intel/xeon_sp/spr/acpi/dino_resource.asl
D src/soc/intel/xeon_sp/spr/acpi/iiostack.asl
D src/soc/intel/xeon_sp/spr/acpi/pci_resource.asl
D src/soc/intel/xeon_sp/spr/acpi/ubox_resource.asl
M src/soc/intel/xeon_sp/spr/acpi/uncore.asl
M src/soc/intel/xeon_sp/spr/ioat.c
M src/soc/intel/xeon_sp/spr/soc_acpi.c
11 files changed, 105 insertions(+), 327 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/81377/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/81377?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icc5843feadc840d87c49b2aa4259716264520dba
Gerrit-Change-Number: 81377
Gerrit-PatchSet: 21
Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset