Attention is currently required from: Daniel Peng, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81955?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/glassway: Add New SPD ID for supported memory parts
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81955/comment/9717e992_89d38e5f :
PS2, Line 7: Add New SPD ID for supported memory parts
Maybe:
> Add SPD IDs for two new memory parts
https://review.coreboot.org/c/coreboot/+/81955/comment/11d9127c_8b21951b :
PS2, Line 9: Add to support
“Support” or “Add support for memory …”
--
To view, visit https://review.coreboot.org/c/coreboot/+/81955?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic07ec36a8015ce6433196a93e894b818a515b954
Gerrit-Change-Number: 81955
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Cliff Huang, Dolan Liu, Jianeng Ceng, Kapil Porwal, Lance Zhao, Subrata Banik, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81788?usp=email )
Change subject: acpi: Add acpi_device_write_dsd_gpio for public
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81788/comment/2751cb06_97e015dc :
PS8, Line 7: Add acpi_device_write_dsd_gpio for public
Make acpi_device_write_dsd_gpio() public
https://review.coreboot.org/c/coreboot/+/81788/comment/b9e9fd7c_9e590980 :
PS8, Line 9: use
used
--
To view, visit https://review.coreboot.org/c/coreboot/+/81788?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifb2e60690711b39743afd455c6776c5ace863378
Gerrit-Change-Number: 81788
Gerrit-PatchSet: 8
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:24:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Aseda Aboagye.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81863?usp=email )
Change subject: acpigen_ps2_keybd: Add support for dictation key
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81863/comment/204b88dd_597df228 :
PS2, Line 14: Flash DUT that emits a scancode for a dictation key, verify that it
: is mapped to KEY_DICTATE in the Linux kernel.
> ACK, will do. Yes, I used `evtest` to verify.
Acknowledged
File src/acpi/acpigen_ps2_keybd.c:
https://review.coreboot.org/c/coreboot/+/81863/comment/28223787_12ac6438 :
PS2, Line 59: [PS2_KEY_DICTATE] = KEYMAP(0xa7, KEY_DICTATE), /* e027*/
> Could you be a bit more specific as to what it should have been sorted by? This table is currently s […]
0xa7 < 0xdd
--
To view, visit https://review.coreboot.org/c/coreboot/+/81863?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iabc56662a9d6b29e84ab81ed93cb46d2e8372de9
Gerrit-Change-Number: 81863
Gerrit-PatchSet: 2
Gerrit-Owner: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jérémy Compostella, Subrata Banik.
Hello Jérémy Compostella, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81927?usp=email
to look at the new patch set (#4).
Change subject: [MTL-x64]src/intel/common: Add support for 32bit memcpy.
......................................................................
[MTL-x64]src/intel/common: Add support for 32bit memcpy.
Details:
- 32bit memcpy is used to make MRC Cache R/W in X86_64 Arch.
BUG=b:242829490
TEST=Able to build with the patch and boot the mtl platform with MRC
Cache working.
Change-Id: I68ad6d3a95d51ef205640785804b73fcdc27a830
Signed-off-by: Saurabh Mishra <mishra.saurabh(a)intel.com>
---
M src/arch/x86/memcpy.c
M src/include/string.h
M src/soc/intel/common/block/fast_spi/fast_spi_flash.c
3 files changed, 34 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/81927/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/81927?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68ad6d3a95d51ef205640785804b73fcdc27a830
Gerrit-Change-Number: 81927
Gerrit-PatchSet: 4
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Saurabh Mishra.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81927?usp=email )
Change subject: [MTL-x64]src/intel/common: Add support for 32bit memcpy.
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/81927?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I68ad6d3a95d51ef205640785804b73fcdc27a830
Gerrit-Change-Number: 81927
Gerrit-PatchSet: 3
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Comment-Date: Wed, 17 Apr 2024 08:08:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment