Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/6e834ad4_2d84ee08 :
PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) {
> > > > AIUI, the payload handover and the coreboot tables are the most important
> > > > ABI pieces of coreboot. Making this a compile-time option would mean that
> > > > the resulting coreboot is suddenly incompatible to all prior (x86) payload
> > > > builds. So, shouldn't this be decided at runtime, maybe based on information
> > > > from CBFS?
> > >
> > > Is it not a fact that using a 64-bit toolchain to compile the libpayload is also a static piece of information? If so, then why are we not allowing a configuration to also enter LB in the desired 64-bit mode instead of limiting it to 32-bit?
> > >
> > > Currently, the default/non-configurable decision about LB entry is always in protected mode.
> > >
> > > This CL allows for one more option where 64-bit direct entry is also possible, hence all of the following options are now valid:
> > >
> > > 1. 64-bit CB / 32-bit LB (using protected mode)
> > > 2. 64-bit CB / 64-bit LB (using long mode)
> > > 3. 32-bit CB / 32-bit LB
> > >
> > > If we are relying on the runtime information about coreboot operational mode and using this information to decide whether to jump into LB, then wouldn't that limit #1 (where a protected mode entry into the libpayload is not possible while using 64-bit coreboot)? Perhaps not everyone wishes to use a 64-bit payload, so it would be better to keep those selections static based on the selection of payload mode.
> >
> > If you are thinking that coreboot in 64-bit mode would break the compatibility with other 32-bit mode payload if we are selecting this Kconfig explicitly then we can choose two below means
> >
> > 1. choose this Kconfig from mainboard rather than SOC directly
> > 2. allow this kconfig only select for chromeos booting (hence, only applies to depthcharge payload)
>
> I agree with Nico on this. You don't want a buildtime configurable ABI. In the past you could take any coreboot image and slap any payload on there. Also the ability to chainload payloads is an important feature. Now sometimes things break a little and a 10y old payload might not work with a modern coreboot or vise versa. I think a lot of us just build coreboot and payload together and never look back. However I still think there is value in that model, so lets not throw that away. Also the whole universal payload stuff is exactly about defining an ABI + payload info standard :-).
>
> It's ok to break the ABI in the sense that there is a new way to jump to a 64bit payload directly for 64bit coreboot, but that should be decided at runtime: i.e. the payload should have a new cbfs attribute to inform coreboot or the chainloading payload about the ABI. coreboot then needs multiple codepaths to deal with the different options and that's fine IMO. That way also chainloading 32bit payloads or 32bit coreboot could in principle load a 64bit payload.
noted! sounds like a mixmatch requirement for post processing the binary for in-field device which may/may not be the motivation for device manufacture to support. I value your opinion here.
Can you please let me know what is the way to add new cbfs attribute into the payload/libpayload here to tell that coreboot should hand-off to the libpayload in 64-bit mode rather trunking?
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:52:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber, Subrata Banik.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/72162b80_b14e977e :
PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) {
> > > AIUI, the payload handover and the coreboot tables are the most important
> > > ABI pieces of coreboot. Making this a compile-time option would mean that
> > > the resulting coreboot is suddenly incompatible to all prior (x86) payload
> > > builds. So, shouldn't this be decided at runtime, maybe based on information
> > > from CBFS?
> >
> > Is it not a fact that using a 64-bit toolchain to compile the libpayload is also a static piece of information? If so, then why are we not allowing a configuration to also enter LB in the desired 64-bit mode instead of limiting it to 32-bit?
> >
> > Currently, the default/non-configurable decision about LB entry is always in protected mode.
> >
> > This CL allows for one more option where 64-bit direct entry is also possible, hence all of the following options are now valid:
> >
> > 1. 64-bit CB / 32-bit LB (using protected mode)
> > 2. 64-bit CB / 64-bit LB (using long mode)
> > 3. 32-bit CB / 32-bit LB
> >
> > If we are relying on the runtime information about coreboot operational mode and using this information to decide whether to jump into LB, then wouldn't that limit #1 (where a protected mode entry into the libpayload is not possible while using 64-bit coreboot)? Perhaps not everyone wishes to use a 64-bit payload, so it would be better to keep those selections static based on the selection of payload mode.
>
> If you are thinking that coreboot in 64-bit mode would break the compatibility with other 32-bit mode payload if we are selecting this Kconfig explicitly then we can choose two below means
>
> 1. choose this Kconfig from mainboard rather than SOC directly
> 2. allow this kconfig only select for chromeos booting (hence, only applies to depthcharge payload)
I agree with Nico on this. You don't want a buildtime configurable ABI. In the past you could take any coreboot image and slap any payload on there. Also the ability to chainload payloads is an important feature. Now sometimes things break a little and a 10y old payload might not work with a modern coreboot or vise versa. I think a lot of us just build coreboot and payload together and never look back. However I still think there is value in that model, so lets not throw that away. Also the whole universal payload stuff is exactly about defining an ABI + payload info standard :-).
It's ok to break the ABI in the sense that there is a new way to jump to a 64bit payload directly for 64bit coreboot, but that should be decided at runtime: i.e. the payload should have a new cbfs attribute to inform coreboot or the chainloading payload about the ABI. coreboot then needs multiple codepaths to deal with the different options and that's fine IMO. That way also chainloading 32bit payloads or 32bit coreboot could in principle load a 64bit payload.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jian Tong, Paul Menzel, Shelley Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81945?usp=email )
Change subject: mb/google/brox: Move hda verb to variant dir
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> You means like this? Use Board CONFIG to return different array. […]
No, like what we did for gpio table override.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81945?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id987c248c37dc8bdc63be7a2513fa8997b5ddc33
Gerrit-Change-Number: 81945
Gerrit-PatchSet: 5
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:33:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Comment-In-Reply-To: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81928?usp=email )
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
Patch Set 7:
(1 comment)
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/81928/comment/c594bd01_db1461f7 :
PS4, Line 1802: reg.data.write_protect_en
> > Yes, that's what I meant. […]
Refer `enable_gpr0()` to check "Enabled" settings:
```c
reg.data.start = (gpr0_range_start >> 12) & 0x7fff;
reg.data.end = (gpr0_range_end >> 12) & 0x7fff;
reg.data.read_protect_en = 0;
reg.data.write_protect_en = 1;
```
Update patchset6, please help to review, thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 7
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:22:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Comment-In-Reply-To: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
Hello David Wu, Krishna P Bhat D, Reka Norman, Stefan Reinauer, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81928?usp=email
to look at the new patch set (#7).
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
util/ifdtool: Add support for checking GPR0 status
This patch adds support for the new command-line option `-c` to
the ifdtool, which is able to check GPR0 status.
Developers can use ifdtool with '-c' option to check whether GPR0
is set to enabled or disabled in the binary file.
BUG=none
TEST=(1) Run `ifdtool -p mtl -c image.bin` on a locked karis image,
show "GPRO status: Enabled".
(2) Run `ifdtool -p mtl -c unlock_image.bin` on a unlocked karis
image, show "GPRO status: Disabled".
Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
---
M util/ifdtool/ifdtool.c
1 file changed, 48 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/81928/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 7
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: David Wu, Krishna P Bhat D, Reka Norman, Reka Norman, Stefan Reinauer, Subrata Banik.
Hello David Wu, Krishna P Bhat D, Reka Norman, Stefan Reinauer, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81928?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by Subrata Banik, Verified+1 by build bot (Jenkins)
Change subject: util/ifdtool: Add support for checking GPR0 status
......................................................................
util/ifdtool: Add support for checking GPR0 status
This patch adds support for the new command-line option `-c` to
the ifdtool, which is able to check GPR0 status.
User can use ifdtool with '-c' option to check whether GPR0 is set to
enabled or disabled in the binary file.
BUG=none
TEST=(1) Run `ifdtool -p mtl -c image.bin` on a locked karis image,
show "GPRO status: Enabled".
(2) Run `ifdtool -p mtl -c unlock_image.bin` on a unlocked karis
image, show "GPRO status: Disabled".
Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
---
M util/ifdtool/ifdtool.c
1 file changed, 48 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/81928/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/81928?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6b3af973be784200b965a68e5f6b7737cba03ed7
Gerrit-Change-Number: 81928
Gerrit-PatchSet: 6
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Paul Menzel, Shelley Chen.
Jian Tong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81945?usp=email )
Change subject: mb/google/brox: Move hda verb to variant dir
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
> Suggest create the new API to return different array from variants.
You means like this? Use Board CONFIG to return different array.
#if CONFIG(BOARD_GOOGLE_BROX)
const u32 cim_verb_data[] = {}
#endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/81945?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id987c248c37dc8bdc63be7a2513fa8997b5ddc33
Gerrit-Change-Number: 81945
Gerrit-PatchSet: 5
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <ericllai(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 06:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Kapil Porwal, Nico Huber.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81960?usp=email )
Change subject: arch/x86: Enable long mode entry into payload for x86_64 support
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/boot.c:
https://review.coreboot.org/c/coreboot/+/81960/comment/456af28a_b0396e2d :
PS1, Line 25: if (CONFIG(PAYLOAD_X86_64_SUPPORT)) {
> > AIUI, the payload handover and the coreboot tables are the most important
> > ABI pieces of coreboot. Making this a compile-time option would mean that
> > the resulting coreboot is suddenly incompatible to all prior (x86) payload
> > builds. So, shouldn't this be decided at runtime, maybe based on information
> > from CBFS?
>
> Is it not a fact that using a 64-bit toolchain to compile the libpayload is also a static piece of information? If so, then why are we not allowing a configuration to also enter LB in the desired 64-bit mode instead of limiting it to 32-bit?
>
> Currently, the default/non-configurable decision about LB entry is always in protected mode.
>
> This CL allows for one more option where 64-bit direct entry is also possible, hence all of the following options are now valid:
>
> 1. 64-bit CB / 32-bit LB (using protected mode)
> 2. 64-bit CB / 64-bit LB (using long mode)
> 3. 32-bit CB / 32-bit LB
>
> If we are relying on the runtime information about coreboot operational mode and using this information to decide whether to jump into LB, then wouldn't that limit #1 (where a protected mode entry into the libpayload is not possible while using 64-bit coreboot)? Perhaps not everyone wishes to use a 64-bit payload, so it would be better to keep those selections static based on the selection of payload mode.
If you are thinking that coreboot in 64-bit mode would break the compatibility with other 32-bit mode payload if we are selecting this Kconfig explicitly then we can choose two below means
1. choose this Kconfig from mainboard rather than SOC directly
2. allow this kconfig only select for chromeos booting (hence, only applies to depthcharge payload)
--
To view, visit https://review.coreboot.org/c/coreboot/+/81960?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic5e6f0af11c05e8b075b8c20880c012747a1df9b
Gerrit-Change-Number: 81960
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 18 Apr 2024 05:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Singer, Martin L Roth, Zebreus.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80314?usp=email )
Change subject: util/crossgcc: Update LLVM from 17.0.6 to 18.1.3
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS13:
llvm-18.1.4 released
maybe wait until 24.05 release, and then upgrade to the latest release and CMake & llvm
--
To view, visit https://review.coreboot.org/c/coreboot/+/80314?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I03a44e0c23a925396f614f282882405dc886ba58
Gerrit-Change-Number: 80314
Gerrit-PatchSet: 13
Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Comment-Date: Thu, 18 Apr 2024 04:44:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment