Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#16).
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/libpayload.ldscript
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
27 files changed, 805 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 16
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
(
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
payloads/edk2: Add Kconfig to use LAPIC timer
Core 2 platforms have issues with HPET. Enable support to use the LAPIC
driver so those machines actually boot and don't hang.
The LAPIC is actually closer to the CPU than the HPET (on the PCH),
which reduces access latency, leading to higher resolution of the timer.
Tested on a Lenovo X200 with a Core 2 Duo.
Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Signed-off-by: Jean Lucas <jean(a)4ray.co>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82000
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M payloads/external/Makefile.mk
M payloads/external/edk2/Kconfig
M payloads/external/edk2/Makefile
M src/cpu/intel/model_1067x/Kconfig
M src/cpu/intel/model_6fx/Kconfig
5 files changed, 16 insertions(+), 0 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
Angel Pons: Looks good to me, approved
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
diff --git a/payloads/external/Makefile.mk b/payloads/external/Makefile.mk
index 13703af..c227402 100644
--- a/payloads/external/Makefile.mk
+++ b/payloads/external/Makefile.mk
@@ -197,6 +197,7 @@
CONFIG_EDK2_DISABLE_TPM=$(CONFIG_EDK2_DISABLE_TPM) \
CONFIG_EDK2_UFS_ENABLE=$(CONFIG_EDK2_UFS_ENABLE) \
CONFIG_EDK2_PCO_MMIO_EMMC=$(CONFIG_EDK2_PCO_MMIO_EMMC) \
+ CONFIG_EDK2_USE_LAPIC_TIMER=$(CONFIG_EDK2_USE_LAPIC_TIMER) \
GCC_CC_x86_32=$(GCC_CC_x86_32) \
GCC_CC_x86_64=$(GCC_CC_x86_64) \
GCC_CC_arm=$(GCC_CC_arm) \
diff --git a/payloads/external/edk2/Kconfig b/payloads/external/edk2/Kconfig
index 68eb455..57e38b9 100644
--- a/payloads/external/edk2/Kconfig
+++ b/payloads/external/edk2/Kconfig
@@ -308,6 +308,15 @@
It is needed for AMD Picasso boards with eMMC storage, but will conflict with the
PCI-based eMMC driver, so should only be enabled for AMD Picasso boards.
+config EDK2_USE_LAPIC_TIMER
+ bool "Use LAPIC timer instead of HPET"
+ default n
+ help
+ Select this option to use the LAPIC timer instead of HPET in edk2. The LAPIC is closer
+ to the CPU than the HPET (on the PCH), resulting in lower latency / higher resolution.
+ This setting is at least needed for platforms with Core 2 processors, which are reported
+ to have issues with HPET.
+
config EDK2_CUSTOM_BUILD_PARAMS
string "edk2 additional custom build parameters"
default "-D VARIABLE_SUPPORT=SMMSTORE" if EDK2_REPO_MRCHROMEBOX && SMMSTORE_V2
diff --git a/payloads/external/edk2/Makefile b/payloads/external/edk2/Makefile
index e7f11f0..4cb7f0f 100644
--- a/payloads/external/edk2/Makefile
+++ b/payloads/external/edk2/Makefile
@@ -141,6 +141,10 @@
ifeq ($(CONFIG_EDK2_PCO_MMIO_EMMC),y)
BUILD_STR += -D USE_PCO_MMIO_EMMC=TRUE
endif
+# TIMER_SUPPORT = HPET
+ifeq ($(CONFIG_EDK2_USE_LAPIC_TIMER),y)
+BUILD_STR += -D TIMER_SUPPORT=LAPIC
+endif
endif
diff --git a/src/cpu/intel/model_1067x/Kconfig b/src/cpu/intel/model_1067x/Kconfig
index 0b5434b..721e0e9 100644
--- a/src/cpu/intel/model_1067x/Kconfig
+++ b/src/cpu/intel/model_1067x/Kconfig
@@ -11,3 +11,4 @@
select CPU_INTEL_COMMON
select CPU_INTEL_COMMON_TIMEBASE
select SETUP_XIP_CACHE
+ select EDK2_USE_LAPIC_TIMER if PAYLOAD_EDK2
diff --git a/src/cpu/intel/model_6fx/Kconfig b/src/cpu/intel/model_6fx/Kconfig
index d1865f6..670a70f 100644
--- a/src/cpu/intel/model_6fx/Kconfig
+++ b/src/cpu/intel/model_6fx/Kconfig
@@ -12,3 +12,4 @@
select CPU_INTEL_COMMON
select CPU_INTEL_COMMON_TIMEBASE
select SETUP_XIP_CACHE
+ select EDK2_USE_LAPIC_TIMER if PAYLOAD_EDK2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 9
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: merged
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#15).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/libpayload.ldscript
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
27 files changed, 803 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/15
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 15
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Benjamin Doron, Lean Sheng Tan, Martin L Roth, Nicholas Chin, Sean Rhodes.
Jean Lucas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
Can someone merge this please?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 8
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 18:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#14).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
26 files changed, 798 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 14
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#13).
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
A payloads/libpayload/arch/x64/Kconfig
A payloads/libpayload/arch/x64/Makefile.mk
A payloads/libpayload/arch/x64/apic.c
A payloads/libpayload/arch/x64/boot_media.c
A payloads/libpayload/arch/x64/cache.c
A payloads/libpayload/arch/x64/coreboot.c
A payloads/libpayload/arch/x64/delay.c
A payloads/libpayload/arch/x64/exception.c
A payloads/libpayload/arch/x64/exception_asm.S
A payloads/libpayload/arch/x64/exec.S
A payloads/libpayload/arch/x64/gdb.c
A payloads/libpayload/arch/x64/head.S
A payloads/libpayload/arch/x64/libpayload.ldscript
A payloads/libpayload/arch/x64/main.c
A payloads/libpayload/arch/x64/multiboot.c
A payloads/libpayload/arch/x64/selfboot.c
A payloads/libpayload/arch/x64/string.c
A payloads/libpayload/arch/x64/sysinfo.c
A payloads/libpayload/arch/x64/timer.c
A payloads/libpayload/arch/x64/util.S
A payloads/libpayload/arch/x64/virtual.c
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
A payloads/libpayload/include/x64/arch/apic.h
A payloads/libpayload/include/x64/arch/barrier.h
A payloads/libpayload/include/x64/arch/cache.h
A payloads/libpayload/include/x64/arch/cpuid.h
A payloads/libpayload/include/x64/arch/exception.h
A payloads/libpayload/include/x64/arch/io.h
A payloads/libpayload/include/x64/arch/msr.h
A payloads/libpayload/include/x64/arch/rdtsc.h
A payloads/libpayload/include/x64/arch/types.h
A payloads/libpayload/include/x64/arch/virtual.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Makefile.mk
51 files changed, 3,849 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 13
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
A payloads/libpayload/arch/x64/Kconfig
A payloads/libpayload/arch/x64/Makefile.mk
A payloads/libpayload/arch/x64/apic.c
A payloads/libpayload/arch/x64/boot_media.c
A payloads/libpayload/arch/x64/cache.c
A payloads/libpayload/arch/x64/coreboot.c
A payloads/libpayload/arch/x64/delay.c
A payloads/libpayload/arch/x64/exception.c
A payloads/libpayload/arch/x64/exception_asm.S
A payloads/libpayload/arch/x64/exec.S
A payloads/libpayload/arch/x64/gdb.c
A payloads/libpayload/arch/x64/head.S
A payloads/libpayload/arch/x64/libpayload.ldscript
A payloads/libpayload/arch/x64/main.c
A payloads/libpayload/arch/x64/multiboot.c
A payloads/libpayload/arch/x64/selfboot.c
A payloads/libpayload/arch/x64/string.c
A payloads/libpayload/arch/x64/sysinfo.c
A payloads/libpayload/arch/x64/timer.c
A payloads/libpayload/arch/x64/util.S
A payloads/libpayload/arch/x64/virtual.c
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/libpayload.ldscript
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
A payloads/libpayload/include/x64/arch/apic.h
A payloads/libpayload/include/x64/arch/barrier.h
A payloads/libpayload/include/x64/arch/cache.h
A payloads/libpayload/include/x64/arch/cpuid.h
A payloads/libpayload/include/x64/arch/exception.h
A payloads/libpayload/include/x64/arch/io.h
A payloads/libpayload/include/x64/arch/msr.h
A payloads/libpayload/include/x64/arch/rdtsc.h
A payloads/libpayload/include/x64/arch/types.h
A payloads/libpayload/include/x64/arch/virtual.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Makefile.mk
53 files changed, 3,858 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 12
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
A payloads/libpayload/arch/x64/Kconfig
A payloads/libpayload/arch/x64/Makefile.mk
A payloads/libpayload/arch/x64/apic.c
A payloads/libpayload/arch/x64/boot_media.c
A payloads/libpayload/arch/x64/cache.c
A payloads/libpayload/arch/x64/coreboot.c
A payloads/libpayload/arch/x64/delay.c
A payloads/libpayload/arch/x64/exception.c
A payloads/libpayload/arch/x64/exception_asm.S
A payloads/libpayload/arch/x64/exec.S
A payloads/libpayload/arch/x64/gdb.c
A payloads/libpayload/arch/x64/head.S
A payloads/libpayload/arch/x64/libpayload.ldscript
A payloads/libpayload/arch/x64/main.c
A payloads/libpayload/arch/x64/multiboot.c
A payloads/libpayload/arch/x64/selfboot.c
A payloads/libpayload/arch/x64/string.c
A payloads/libpayload/arch/x64/sysinfo.c
A payloads/libpayload/arch/x64/timer.c
A payloads/libpayload/arch/x64/util.S
A payloads/libpayload/arch/x64/virtual.c
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
A payloads/libpayload/include/x64/arch/apic.h
A payloads/libpayload/include/x64/arch/barrier.h
A payloads/libpayload/include/x64/arch/cache.h
A payloads/libpayload/include/x64/arch/cpuid.h
A payloads/libpayload/include/x64/arch/exception.h
A payloads/libpayload/include/x64/arch/io.h
A payloads/libpayload/include/x64/arch/msr.h
A payloads/libpayload/include/x64/arch/rdtsc.h
A payloads/libpayload/include/x64/arch/types.h
A payloads/libpayload/include/x64/arch/virtual.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Makefile.mk
52 files changed, 3,854 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Felix Held, Felix Singer, Martin L Roth, Naveen Iyer.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 20 Apr 2024 16:44:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment