Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
security/tpm/tspi/crtm.c: Fix space required before open brace error
Fix checkpatch error.
Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/82001
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/security/tpm/tspi/crtm.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/security/tpm/tspi/crtm.c b/src/security/tpm/tspi/crtm.c
index 3c2760a..621d7cd 100644
--- a/src/security/tpm/tspi/crtm.c
+++ b/src/security/tpm/tspi/crtm.c
@@ -67,7 +67,7 @@
if (rc)
return rc;
}
- } else if (CONFIG(BOOTBLOCK_IN_CBFS)){
+ } else if (CONFIG(BOOTBLOCK_IN_CBFS)) {
/* Mapping measures the file. We know we can safely map here because
bootblock-as-a-file is only used on x86, where we don't need cache to map. */
enum cbfs_type type = CBFS_TYPE_BOOTBLOCK;
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 4
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Christian Walter, Naveen Iyer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Am new to this. What happens next? https://doc.coreboot.org/tutorial/part2. […]
No worries. Just ask if you have any questions.
A patch usually stays up for review for at least 24 hours. Depending on what the patch is about it might get multiple review rounds. Sometimes it happens that a patch stalls, because people get distracted by something or get busy. So just leave a ping here or reach out on one of our chats to keep it going.
However, this one is trivial and it passed the 24 hours mark. So I'm going to submit it.
Thanks for contributing!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sun, 21 Apr 2024 03:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Naveen Iyer
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> I read somewhere that I might need to do it to ensure progress. […]
Am new to this. What happens next? https://doc.coreboot.org/tutorial/part2.html#step-5-let-others-review-your-… doesn't tell me much. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Naveen Iyer
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3: -Code-Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:39:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Giving a review score to your own patches is rather unusual. So please remove it.
I read somewhere that I might need to do it to ensure progress. Thanks for letting me know that its not.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:39:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Jean Lucas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> just a FYI, the coreboot norm is to wait 24h to merge after a +2, to give reviewers in all time zone […]
Got it, thank you for letting me know!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 9
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:26:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Jean Lucas
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Naveen Iyer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Giving a review score to your own patches is rather unusual. So please remove it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:15:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Felix Held, Felix Singer, Martin L Roth.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:05:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 22:04:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82000?usp=email )
Change subject: payloads/edk2: Add Kconfig to use LAPIC timer
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> Can someone merge this please?
just a FYI, the coreboot norm is to wait 24h to merge after a +2, to give reviewers in all time zones a last chance before a patch is merged.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82000?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33144d6c1c120e7faa47b99e8262b0997c45c9b9
Gerrit-Change-Number: 82000
Gerrit-PatchSet: 9
Gerrit-Owner: Jean Lucas
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 21:58:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jean Lucas
Gerrit-MessageType: comment