Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Uploaded patch set 7 to modify the error msg I used in Makefile.mk: "cannot" -> "should not". The reason is that "cannot" is a strong word and could mislead people into believing that it's impossible to workaround BUILD_TIMELESS_WITH_GITREV. However, its not since anyone could simply cheat BUILD_TIMELESS_WITH_GITREV by pushing their local changes to some other remote. With patch set 7, I hope that people who encounter this error, understand the motivation behind BUILD_TIMELESS_WITH_GITREV.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 21 Apr 2024 13:31:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Hello Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82006?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Makefile.mk: Associate reproducible build to commit ID
There is a need for reproducible builds that are tied to specific
commit IDs. This helps in identifying the commit ID a specific binary
was built from. Being able to associate a binary to a specific commit
ID is useful for debugging as well as to keep track of features that
went into a given binary.
Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
---
M Makefile.mk
M util/genbuild_h/genbuild_h.sh
2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/82006/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Hello Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82006?usp=email
to look at the new patch set (#5).
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Makefile.mk: Associate reproducible build to commit ID
There is a need for reproducible builds that are tied to specific
commit IDs. This helps in identifying the commit ID a specific binary
was built from. Being able to associate a binary to a specific commit
ID is useful for debugging as well as to keep track of features that
went into a given binary.
Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
---
M Makefile.mk
M util/genbuild_h/genbuild_h.sh
2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/82006/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 5
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82006/comment/e9d6a955_271b9a8c :
PS3, Line 14:
> Please describe how it works. You introduce `BUILD_TIMELESS_WITH_GITREV`. […]
Done
Patchset:
PS3:
> Nice work.
Thanks and thanks for taking the time to review. I've addressed all of your review comments. Request another review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 21 Apr 2024 13:04:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, Paul Menzel.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82006/comment/6dc2214c_b21fa155 :
PS3, Line 14:
> Please describe how it works. You introduce `BUILD_TIMELESS_WITH_GITREV`. […]
Ya I was also hoping to find something about BUILD_TIMELESS inside Documentation/, but didn't find anything. I suppose the right place to document it would be in Makefile.mk itself since that's the first place to look at for all these cmdline options for the `make` cmd, from my limited understanding. Let me know if you think otherwise.
I also see how util/genbuild_h/genbuild_h.sh generates build.h, but did not need any change there for my specific testing of the built binary. However, in order to stay consistent I have added this new option there as well. Same goes for build_h_exports. I didn't need that while testing the built binary.
The way I tested originally (before this new patch) was to use QEMU to boot the built coreboot ELF payload. Once it booted, I pressed F2 for firmware options where I saw the version as the commit ID. Hence, didn't feel the need to add those additional stuff, like the modifications to util/genbuild_h/genbuild_h.sh and build_h_exports variable (in Makefile.mk).
Patchset:
PS3:
> Nice work. […]
I was misled by some online forum where I read that I might need to do it to ensure progress. Now I know that its not true. My apologies, I'm new to this. I've removed my +1 review. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 21 Apr 2024 13:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth.
Hello Christian Walter, Elyes Haouas, Felix Held, Felix Singer, Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82006?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by Elyes Haouas, Verified+1 by build bot (Jenkins)
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Makefile.mk: Associate reproducible build to commit ID
There is a need for reproducible builds that are tied to specific
commit IDs. This helps in identifying the commit ID a specific binary
was built from. Being able to associate a binary to a specific commit
ID is useful for debugging as well as to keep track of features that
went into a given binary.
Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Signed-off-by: Naveen R. Iyer <iyernaveenr(a)gmail.com>
---
M Makefile.mk
M util/genbuild_h/genbuild_h.sh
2 files changed, 15 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/82006/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 4
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Christian Walter, Felix Held, Felix Singer, Martin L Roth.
Naveen Iyer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82006?usp=email )
Change subject: Makefile.mk: Associate reproducible build to commit ID
......................................................................
Patch Set 3: -Code-Review
(1 comment)
Patchset:
PS3:
I was misled by some online forum where I read that I might need to do it to ensure progress. Now I know that its not true. My apologies, I'm new to this. I've removed my +1 review. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/82006?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 21 Apr 2024 12:36:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas, Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82009?usp=email )
Change subject: bsd/cbfs_serialized: Check the cbfs_file size also when using clang
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82009/comment/1ec96909_2444436f :
PS3, Line 8:
Please elaborate. Why was it introduced, and why can it be removed now?
--
To view, visit https://review.coreboot.org/c/coreboot/+/82009?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151
Gerrit-Change-Number: 82009
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 21 Apr 2024 11:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82009?usp=email
to look at the new patch set (#3).
Change subject: bsd/cbfs_serialized: Check the cbfs_file size also when using clang
......................................................................
bsd/cbfs_serialized: Check the cbfs_file size also when using clang
Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/82009/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/82009?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151
Gerrit-Change-Number: 82009
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Julius Werner.
Hello Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/82009?usp=email
to look at the new patch set (#2).
Change subject: bsd/cbfs_serialized: Check the cbfs_file size when using clang
......................................................................
bsd/cbfs_serialized: Check the cbfs_file size when using clang
Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/82009/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82009?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I106d3bc85862546592ad5625592fe2c4733a8151
Gerrit-Change-Number: 82009
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newpatchset