Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81857?usp=email )
Change subject: util/lint: Add lint rule to watch for Makefile.inc
......................................................................
util/lint: Add lint rule to watch for Makefile.inc
This should keep new makefiles from being named Makefile.inc.
Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81857
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Varshit Pandya <pandyavarshit(a)gmail.com>
---
A util/lint/lint-stable-030-makefile-inc
1 file changed, 24 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
Varshit Pandya: Looks good to me, but someone else must approve
diff --git a/util/lint/lint-stable-030-makefile-inc b/util/lint/lint-stable-030-makefile-inc
new file mode 100755
index 0000000..a586bea
--- /dev/null
+++ b/util/lint/lint-stable-030-makefile-inc
@@ -0,0 +1,24 @@
+#!/usr/bin/env sh
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# DESCR: Verify that Makefiles are not named Makefile.inc
+#
+
+LINTDIR="$(
+ cd -- "$(dirname "$0")" > /dev/null 2>&1 || return
+ pwd -P
+)"
+
+# shellcheck source=helper_functions.sh
+. "${LINTDIR}/helper_functions.sh"
+
+# Exit if the code isn't in a git repo
+if [ "${IN_GIT_TREE}" -eq 0 ]; then
+ exit 0
+fi
+
+MAKELIST="$(${FIND_FILES} | grep Makefile.inc)"
+if [ -n "${MAKELIST}" ]; then
+ echo "Error: Makefiles should be Makefile.mk not Makefile.inc"
+ echo "${MAKELIST}"
+fi
--
To view, visit https://review.coreboot.org/c/coreboot/+/81857?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77
Gerrit-Change-Number: 81857
Gerrit-PatchSet: 4
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Elyes Haouas, Eric Lai, Felix Held, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81857?usp=email )
Change subject: util/lint: Add lint rule to watch for Makefile.inc
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/81857?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a47998e1c997b82b8a15319eae96cdc0de64e77
Gerrit-Change-Number: 81857
Gerrit-PatchSet: 3
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sat, 20 Apr 2024 21:07:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82016?usp=email )
Change subject: NOTFORMERGE: Add 32bit entry point for x86-64 libpayload
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
you might need to rebase this CL as I have changed the 64-bit cl a bit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82016?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2f02b5874c0406b16f0b5d1491c95cc71f38d49
Gerrit-Change-Number: 82016
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sat, 20 Apr 2024 20:45:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Naveen Iyer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/82001?usp=email )
Change subject: security/tpm/tspi/crtm.c: Fix space required before open brace error
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/82001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I890fcfa4ad7b7abe032248b435271514e8e264f3
Gerrit-Change-Number: 82001
Gerrit-PatchSet: 3
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 20:36:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#18).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
A payloads/libpayload/arch/x86/libpayload_64.ldscript
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
27 files changed, 894 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/18
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 18
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: Daniel Schaefer, Kieran Levin, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81978?usp=email )
Change subject: mb/framework: Initial push of azalea (Framework 13 AMD 7040)
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81978/comment/8a32454e_5ee153e1 :
PS5, Line 7: Initial push of azalea
Make it a statement?
> Push initial azalea port
--
To view, visit https://review.coreboot.org/c/coreboot/+/81978?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ief4b5c75471a2ef5bedaaee9b4737510c2826b6e
Gerrit-Change-Number: 81978
Gerrit-PatchSet: 5
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Reviewer: Kieran Levin <ktl(a)frame.work>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jean Lucas
Gerrit-CC: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Daniel Schaefer <dhs(a)frame.work>
Gerrit-Attention: Kieran Levin <ktl(a)frame.work>
Gerrit-Comment-Date: Sat, 20 Apr 2024 20:21:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Paul Menzel, Varshit Pandya.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
Patch Set 8:
(3 comments)
Patchset:
PS7:
> It's because `chassis_type` is `uint8_t`. […]
Yeah, this was just carelessness on my side, not checking if this would compile, added the macro now, it's clearer that way.
File src/mainboard/dell/optiplex_9020/mainboard.c:
https://review.coreboot.org/c/coreboot/+/81529/comment/89e7560d_0af0c27c :
PS7, Line 290: -1
> Put this somewhere […]
Done
https://review.coreboot.org/c/coreboot/+/81529/comment/de52ef9e_bd22a7dd :
PS7, Line 380: -1
> `CHASSIS_TYPE_UNKNOWN`
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 8
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Sat, 20 Apr 2024 20:12:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Máté Kukri, Paul Menzel, Varshit Pandya.
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81529?usp=email
to look at the new patch set (#8).
The following approvals got outdated and were removed:
Code-Review+2 by Angel Pons
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
mb/dell/optiplex_9020: Implement late HWM initialization
There are 4 different chassis types specified by vendor firmware, each
with a slightly different HWM configuration.
The chassis type to use is determined at runtime by reading a set of
4 PCH GPIOs: 70, 38, 17, and 0.
Additionally vendor firmware also provides an option to run the fans at
full speed. This is substituted with a coreboot nvram option in this
implementation.
This was tested to make fan control work on my OptiPlex 7020 SFF.
NOTE: This is superficially similar to the OptiPlex 9010's SCH5545
however the OptiPlex 9020's SCH5555 does not use externally
programmed EC firmware.
Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com>
---
M src/mainboard/dell/optiplex_9020/Makefile.mk
M src/mainboard/dell/optiplex_9020/bootblock.c
M src/mainboard/dell/optiplex_9020/cmos.default
M src/mainboard/dell/optiplex_9020/cmos.layout
M src/mainboard/dell/optiplex_9020/mainboard.c
A src/mainboard/dell/optiplex_9020/sch5555_ec.c
A src/mainboard/dell/optiplex_9020/sch5555_ec.h
7 files changed, 462 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81529/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 8
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Subrata Banik.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81968?usp=email
to look at the new patch set (#17).
Change subject: libpayload: Add x86_64 (64-bit) support
......................................................................
libpayload: Add x86_64 (64-bit) support
This patch introduces x86_64 (64-bit) support to the payload, building
upon the existing x86 (32-bit) architecture. Files necessary for 64-bit
compilation are now guarded by the `CONFIG_LP_ARCH_X86_64` Kconfig
option.
BUG=b:242829490
TEST=Entered libpayload in long mode, successfully parsed coreboot
table.
Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M payloads/libpayload/Kconfig
M payloads/libpayload/Makefile
M payloads/libpayload/Makefile.mk
M payloads/libpayload/arch/x86/Kconfig
M payloads/libpayload/arch/x86/Makefile.mk
M payloads/libpayload/arch/x86/exception.c
A payloads/libpayload/arch/x86/exception_asm_64.S
A payloads/libpayload/arch/x86/exec_64.S
M payloads/libpayload/arch/x86/gdb.c
M payloads/libpayload/arch/x86/head.S
A payloads/libpayload/arch/x86/head_32.S
A payloads/libpayload/arch/x86/head_64.S
A payloads/libpayload/arch/x86/libpayload_64.ldscript
M payloads/libpayload/arch/x86/main.c
M payloads/libpayload/arch/x86/multiboot.c
M payloads/libpayload/arch/x86/string.c
M payloads/libpayload/bin/lpgcc
M payloads/libpayload/drivers/storage/ahci_common.c
M payloads/libpayload/drivers/timer/Kconfig
M payloads/libpayload/drivers/usb/Kconfig
M payloads/libpayload/drivers/usb/uhci.c
M payloads/libpayload/drivers/usb/xhci.c
M payloads/libpayload/include/sysinfo.h
M payloads/libpayload/libc/time.c
M payloads/libpayload/sample/Makefile
M payloads/libpayload/vboot/Kconfig
M payloads/libpayload/vboot/Makefile.mk
27 files changed, 894 insertions(+), 131 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/81968/17
--
To view, visit https://review.coreboot.org/c/coreboot/+/81968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I69fda47bedf1a14807b1515c4aed6e3a1d5b8585
Gerrit-Change-Number: 81968
Gerrit-PatchSet: 17
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset