coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: [RFC] doc/getting_started: Update embedded-table examples
by Nicholas Chin (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Nico Huber. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81503?usp=email ) Change subject: [RFC] doc/getting_started: Update embedded-table examples ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Markdown tables can also be used, but they seem to be limited compared to embedded rST tables. […] *each cell is one row and one column -- To view, visit https://review.coreboot.org/c/coreboot/+/81503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b0d0b029fd527e0e18c71371806cd248ea0ecdf Gerrit-Change-Number: 81503 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:48:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [RFC] doc/getting_started: Update embedded-table examples
by Nicholas Chin (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Nico Huber. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81503?usp=email ) Change subject: [RFC] doc/getting_started: Update embedded-table examples ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Not sure if that's the way to go, as IIUC we could also use markdown tables now? Markdown tables can also be used, but they seem to be limited compared to embedded rST tables. As far as I can tell, you can only have simple tables where each cell is row and one column (you can't merge cells) [1], but for many cases in our docs that's probably enough. However, with embedded rST tables you can have cells that span multiple rows or columns[2], which is useful in some situations. `Documentation/getting_started/gpio.md` is an example of a page that uses this feature. [1] https://myst-parser.readthedocs.io/en/latest/syntax/tables.html [2] https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#grid-tab… -- To view, visit https://review.coreboot.org/c/coreboot/+/81503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b0d0b029fd527e0e18c71371806cd248ea0ecdf Gerrit-Change-Number: 81503 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [RFC] doc/getting_started: Update embedded-table examples
by Nico Huber (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Nicholas Chin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81503?usp=email ) Change subject: [RFC] doc/getting_started: Update embedded-table examples ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Not sure if that's the way to go, as IIUC we could also use markdown tables now? -- To view, visit https://review.coreboot.org/c/coreboot/+/81503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b0d0b029fd527e0e18c71371806cd248ea0ecdf Gerrit-Change-Number: 81503 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:35:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: [RFC] doc/getting_started: Update embedded-table examples
by Nico Huber (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Nicholas Chin. Hello Nicholas Chin, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/81503?usp=email to review the following change. Change subject: [RFC] doc/getting_started: Update embedded-table examples ...................................................................... [RFC] doc/getting_started: Update embedded-table examples Since commit 35599f9a6671 (Docs: Replace Recommonmark with MyST Parser), `{eval-rst}' is used instead of `eval_rst' for embedded rST. Change-Id: I1b0d0b029fd527e0e18c71371806cd248ea0ecdf Signed-off-by: Nico Huber <nico.h(a)gmx.de> --- M Documentation/getting_started/writing_documentation.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/81503/1 diff --git a/Documentation/getting_started/writing_documentation.md b/Documentation/getting_started/writing_documentation.md index 51ea531..b9c30b0 100644 --- a/Documentation/getting_started/writing_documentation.md +++ b/Documentation/getting_started/writing_documentation.md @@ -99,7 +99,7 @@ Under Sphinx markdown tables are not supported. Therefore you can use following code block to write tables in reStructuredText and embed them into the markdown: - ```eval_rst + ```{eval-rst} +------------+------------+-----------+ | Header 1 | Header 2 | Header 3 | +============+============+===========+ @@ -144,7 +144,7 @@ You can import CSV files and let sphinx automatically convert them to human readable tables, using the following reStructuredText snipped: - ```eval_rst + ```{eval-rst} .. csv-table:: :header: "Key", "Value" :file: keyvalues.csv -- To view, visit https://review.coreboot.org/c/coreboot/+/81503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1b0d0b029fd527e0e18c71371806cd248ea0ecdf Gerrit-Change-Number: 81503 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: doc/releases: Fix embedded rST syntax for MyST Parser
by Nicholas Chin (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth, Nicholas Chin. Hello Angel Pons, Jason Glenesk, Martin L Roth, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81500?usp=email to look at the new patch set (#2). Change subject: doc/releases: Fix embedded rST syntax for MyST Parser ...................................................................... doc/releases: Fix embedded rST syntax for MyST Parser After commit 35599f9a6671 (Docs: Replace Recommonmark with MyST Parser), embedded rST should use `{eval-rst}` instead of `eval_rst`. This was missed during manual rebasing of that patch before it was merged. Change-Id: I648a95488df25d70e1b581872a19272c51f33b7b Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/releases/coreboot-24.02-relnotes.md 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/81500/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81500?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I648a95488df25d70e1b581872a19272c51f33b7b Gerrit-Change-Number: 81500 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: doc/releases: Fix embedded rST syntax for MyST Parser
by Nico Huber (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Angel Pons, Jason Glenesk, Martin L Roth, Nicholas Chin. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81500?usp=email ) Change subject: doc/releases: Fix embedded rST syntax for MyST Parser ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81500?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I648a95488df25d70e1b581872a19272c51f33b7b Gerrit-Change-Number: 81500 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:23:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: superio/ite: Add special fan vectors and further options
by Nico Huber (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Matt DeVillier. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email ) Change subject: superio/ite: Add special fan vectors and further options ...................................................................... Patch Set 4: (1 comment) File src/superio/ite/common/env_ctrl.c: https://review.coreboot.org/c/coreboot/+/81426/comment/999e33f0_35966f45 : PS1, Line 369: #endif > just set the vector count to 2 regardless of the Kconfig enablement, unless it causes an issue elsew […] I guess the original intention was to keep the configuration struct clean for chips that don't have this feature. Though, I agree wasting some space there might be better than overengineering it. I would decide between these two options: * have a separate C file for the fan vector code (if that doesn't bring other downsides I'm missing), or * always have the struct entries. -- To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94 Gerrit-Change-Number: 81426 Gerrit-PatchSet: 4 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/ite: Unify it8772f with common code
by Nico Huber (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Piotr Król. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email ) Change subject: superio/ite: Unify it8772f with common code ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/mainboard/google/beltino/devicetree.cb: https://review.coreboot.org/c/coreboot/+/81310/comment/f1b4f7f7_fad0a913 : PS4, Line 86: register "FAN2.mode" = "FAN_SMART_SOFTWARE" > Yes, until the OS picks up fans will run at 50%. […] Matt, would you have a Beltino at hand to test if this feels like a regression? Don't know how 50% sound. Might annoy users if this gets unnecessarily noisy on every (re)boot. -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 22:06:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: util/lint: Check Kconfig and cmos.default for license headers
by Martin L Roth (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Nicholas Chin, Nico Huber. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81424?usp=email ) Change subject: util/lint: Check Kconfig and cmos.default for license headers ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: I think this patch is fine. if the cmos.default files aren't marked as domain, that's the issue. they should still get spdx headers since they're text files. -- To view, visit https://review.coreboot.org/c/coreboot/+/81424?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6cc94b8e8b4ce6780ef1a72d49b88e85a7c4b832 Gerrit-Change-Number: 81424 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 21:11:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/ite: Unify it8772f with common code
by Matt DeVillier (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Michał Żygowski, MrChromebox, Nico Huber, Piotr Król. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81310?usp=email ) Change subject: superio/ite: Unify it8772f with common code ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: this is still a bit too much for a single patch, IMO the changes to the common code and non-8772F SIOs should be one change, then another porting over the 8772F and adjustments to boards that use it -- To view, visit https://review.coreboot.org/c/coreboot/+/81310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic4d9d5460628e444dc20f620179b39c90dbc28c6 Gerrit-Change-Number: 81310 Gerrit-PatchSet: 5 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Attention: MrChromebox <mrchromebox(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 20:48:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024