coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: soc/intel/common/block/cse: Remove return statement in void function
by Elyes Haouas (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Paul Menzel. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81429?usp=email ) Change subject: soc/intel/common/block/cse: Remove return statement in void function ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81429/comment/a2655449_abb5951a : PS1, Line 7: statment > statement Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/81429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8e07f48043452b329d255fe457f00317c017ae Gerrit-Change-Number: 81429 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Sun, 24 Mar 2024 18:12:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/common/block/cse: Remove return statement in void function
by Elyes Haouas (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Elyes Haouas. Hello Felix Singer, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81429?usp=email to look at the new patch set (#2). Change subject: soc/intel/common/block/cse: Remove return statement in void function ...................................................................... soc/intel/common/block/cse: Remove return statement in void function Return statement is not useful in void function. Change-Id: Idb8e07f48043452b329d255fe457f00317c017ae Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/81429/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81429?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8e07f48043452b329d255fe457f00317c017ae Gerrit-Change-Number: 81429 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/veyron_{mickey;rialto}: Remove return statement in void fun...
by Elyes Haouas (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Elyes Haouas. Hello Felix Singer, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81430?usp=email to look at the new patch set (#2). Change subject: mb/google/veyron_{mickey;rialto}: Remove return statement in void function ...................................................................... mb/google/veyron_{mickey;rialto}: Remove return statement in void function Return statement is not useful in void function. Change-Id: I8cf020de335e4da933b7bbdc27b7ac6f31afe885 Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr> --- M src/mainboard/google/veyron_mickey/mainboard.c M src/mainboard/google/veyron_rialto/mainboard.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/81430/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81430?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8cf020de335e4da933b7bbdc27b7ac6f31afe885 Gerrit-Change-Number: 81430 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: superio/ite: Disable 16-bit tacho counters for IT8728F
by Paul Menzel (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81499?usp=email ) Change subject: superio/ite: Disable 16-bit tacho counters for IT8728F ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81499/comment/471846ee_7f8e04f5 : PS2, Line 9: datasheet > Please mention the revision. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If65b2cab249144ae85e2bc9023f16b73106262df Gerrit-Change-Number: 81499 Gerrit-PatchSet: 3 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 18:04:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: superio/ite: Disable 16-bit tacho counters for IT8728F
by Joel Linn (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Nico Huber. Hello Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81499?usp=email to look at the new patch set (#3). Change subject: superio/ite: Disable 16-bit tacho counters for IT8728F ...................................................................... superio/ite: Disable 16-bit tacho counters for IT8728F According to the datasheet (V0.4.2), these are not supported on this model. Change-Id: If65b2cab249144ae85e2bc9023f16b73106262df Signed-off-by: Joel Linn <jl(a)conductive.de> --- M src/superio/ite/it8728f/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/81499/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If65b2cab249144ae85e2bc9023f16b73106262df Gerrit-Change-Number: 81499 Gerrit-PatchSet: 3 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: superio/ite: Disable 16-bit tacho counters for IT8728F
by Paul Menzel (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn, Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81499?usp=email ) Change subject: superio/ite: Disable 16-bit tacho counters for IT8728F ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81499/comment/9599b41d_9ece1a17 : PS2, Line 9: datasheet Please mention the revision. -- To view, visit https://review.coreboot.org/c/coreboot/+/81499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If65b2cab249144ae85e2bc9023f16b73106262df Gerrit-Change-Number: 81499 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 17:41:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: sb/intel/bd82x6x: Add four new USB currents
by Paul Menzel (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Joel Linn. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81427?usp=email ) Change subject: sb/intel/bd82x6x: Add four new USB currents ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/81427?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156787e533c2605e7440548a2d3bf711bb1af5d7 Gerrit-Change-Number: 81427 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 17:40:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: superio/ite: Add special fan vectors and further options
by Joel Linn (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Matt DeVillier, Nico Huber. Hello Matt DeVillier, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81426?usp=email to look at the new patch set (#3). Change subject: superio/ite: Add special fan vectors and further options ...................................................................... superio/ite: Add special fan vectors and further options A number of ITE SIOs support "special fan control vectors", which effectively allow non-linear fan speed control. This is for example used by the vendor firmware of the "HP Pro 3500 Series". The 3VSBSW# signal can now also be disabled again which is necessary to power components down properly in SMM when entering S5. A function to disable the PME# output was added as well. Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94 Signed-off-by: Joel Linn <jl(a)conductive.de> --- M src/superio/ite/Makefile.mk M src/superio/ite/common/Kconfig M src/superio/ite/common/early_serial.c M src/superio/ite/common/env_ctrl.c M src/superio/ite/common/env_ctrl.h M src/superio/ite/common/env_ctrl_chip.h M src/superio/ite/common/ite.h M src/superio/ite/it8728f/Kconfig M src/superio/ite/it8772f/Kconfig 9 files changed, 123 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/81426/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/81426?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93df2b5652fc3fde775b6161fa5bebc4a34d5e94 Gerrit-Change-Number: 81426 Gerrit-PatchSet: 3 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: soc/intel/xeon_sp: Add soc_acpigen_write_OSC_pci_domain
by Patrick Rudolph (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Shuo Liu, Tim Chu, Tim Wawrzynczak. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81375?usp=email ) Change subject: soc/intel/xeon_sp: Add soc_acpigen_write_OSC_pci_domain ...................................................................... Patch Set 7: (4 comments) File src/acpi/acpigen_pci.c: https://review.coreboot.org/c/coreboot/+/81375/comment/0d88aeb6_c2aeca88 : PS6, Line 217: soc_acpigen_OSC_handle_pcie_request drop this line File src/acpi/acpigen_pci.c: https://review.coreboot.org/c/coreboot/+/81375/comment/c8862589_ecaa3a8d : PS7, Line 175: acpigen_write_if_lequal_op_int In between the Arg1 "revision check" and Arg2 "number of arguments" check is missing compared to the DSDT. Without those checks using Local0 as branch hit indicator doesn't make much sense. https://review.coreboot.org/c/coreboot/+/81375/comment/332d50f4_2074acdc : PS7, Line 177: LOCAL1_OP Since RETE is always 0 here, Local1 is always 0. Thus there's no need to OR something, just write OSC_RET_UNRECOGNIZED_UUID into RETE File src/include/acpi/acpigen_pci.h: https://review.coreboot.org/c/coreboot/+/81375/comment/d5a54069_298e28a2 : PS7, Line 27: soc_acpigen_write_OSC_pci_domain function prototype should start with `acpigen_` since this code reside in `src/acpi/` -- To view, visit https://review.coreboot.org/c/coreboot/+/81375?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I711ce5350d718e47feb2912555108801ad7f918d Gerrit-Change-Number: 81375 Gerrit-PatchSet: 7 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Sun, 24 Mar 2024 16:40:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge)
by Nicholas Chin (Code Review) 24 Mar '24

24 Mar '24

Attention is currently required from: Felix Singer, Joel Linn, Matt DeVillier. Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81368?usp=email ) Change subject: mb/hp: Add Pro 3500 series (Sandy/Ivy Bridge) ...................................................................... Patch Set 4: (1 comment) File Documentation/mainboard/hp/pro_3500_series.md: https://review.coreboot.org/c/coreboot/+/81368/comment/f87f4428_84ffcaba : PS3, Line 17: eval_rst > Done […] Don't bother with a ticket; I can get those fixed pretty quickly. Those were missed when I was rebasing the patch to myst-parser switch to main and didn't fully account for new files. From what I can tell it's just the 24.02 release notes that need fixing, and then updating the `getting_started/writing_documentation` page with instructions to match the new syntax of MyST parser. -- To view, visit https://review.coreboot.org/c/coreboot/+/81368?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idf793fe915096cf2553572964faec5c7f8526b9a Gerrit-Change-Number: 81368 Gerrit-PatchSet: 4 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Comment-Date: Sun, 24 Mar 2024 16:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Joel Linn <jl_coreboot(a)conductive.de> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024