coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[main]: superio/ite: Fix incorrect warnings
by Joel Linn (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Joel Linn, Nico Huber. Hello Matt DeVillier, Nico Huber, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/81516?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: superio/ite: Fix incorrect warnings ...................................................................... superio/ite: Fix incorrect warnings Fix warning for disabled thermal inputs. Fix warning for PECI thermal inputs if one was set up previously. Depending on the mb, the superio will not go through power-on reset and retain its registers. Do not trigger a warning if the current register value aligns with the desired value. Don't return early if some input is already configured for PECI, simply overwrite the configuration. Change-Id: Ibabe1b1ef55f2acb2074eceb535ec684bffc8155 Signed-off-by: Joel Linn <jl(a)conductive.de> --- M src/superio/ite/common/env_ctrl.c 1 file changed, 9 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/81516/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81516?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibabe1b1ef55f2acb2074eceb535ec684bffc8155 Gerrit-Change-Number: 81516 Gerrit-PatchSet: 2 Gerrit-Owner: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libgfxinit[main]: gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/81524?usp=email ) Change subject: gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures ...................................................................... gma connectors: Add `Pipe' parameter to Pre_/Post_Off procedures Change-Id: I01dbf3cae3dfef2130fa10116f70f23238c7a48c Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/g45/hw-gfx-gma-connectors.adb M common/haswell_shared/hw-gfx-gma-connectors.adb M common/hw-gfx-gma-connectors.ads M common/hw-gfx-gma.adb M common/ironlake/hw-gfx-gma-connectors.adb M common/tigerlake/hw-gfx-gma-connectors.adb 6 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/24/81524/1 diff --git a/common/g45/hw-gfx-gma-connectors.adb b/common/g45/hw-gfx-gma-connectors.adb index ff689bb..114fae3 100644 --- a/common/g45/hw-gfx-gma-connectors.adb +++ b/common/g45/hw-gfx-gma-connectors.adb @@ -69,7 +69,7 @@ ---------------------------------------------------------------------------- - procedure Pre_Off (Port_Cfg : Port_Config) + procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); @@ -78,7 +78,7 @@ Panel.Off (Port_Cfg.Panel); end Pre_Off; - procedure Post_Off (Port_Cfg : Port_Config) + procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb index e81322e..b8a39ce 100644 --- a/common/haswell_shared/hw-gfx-gma-connectors.adb +++ b/common/haswell_shared/hw-gfx-gma-connectors.adb @@ -69,7 +69,7 @@ ---------------------------------------------------------------------------- - procedure Pre_Off (Port_Cfg : Port_Config) + procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); @@ -78,7 +78,7 @@ Panel.Off (Port_Cfg.Panel); end Pre_Off; - procedure Post_Off (Port_Cfg : Port_Config) + procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads index a1d0d1e..9a94e02 100644 --- a/common/hw-gfx-gma-connectors.ads +++ b/common/hw-gfx-gma-connectors.ads @@ -35,8 +35,8 @@ Success : out Boolean); pragma Warnings (GNATprove, On, "unused variable ""P*"""); - procedure Pre_Off (Port_Cfg : Port_Config); - procedure Post_Off (Port_Cfg : Port_Config); + procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config); + procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config); procedure Pre_All_Off; procedure Post_All_Off; diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb index c3073d3..6331020 100644 --- a/common/hw-gfx-gma.adb +++ b/common/hw-gfx-gma.adb @@ -200,7 +200,7 @@ if not Success then Display_Controller.Off (Pipe); - Connectors.Post_Off (Port_Cfg); + Connectors.Post_Off (Pipe, Port_Cfg); end if; end if; @@ -241,9 +241,9 @@ Display_Controller.Legacy_VGA_Off; end if; - Connectors.Pre_Off (Port_Cfg); + Connectors.Pre_Off (Pipe, Port_Cfg); Display_Controller.Off (Pipe); - Connectors.Post_Off (Port_Cfg); + Connectors.Post_Off (Pipe, Port_Cfg); PLLs.Free (Allocated_PLLs (Pipe)); end if; diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb index 1c3a243..bfe3047 100644 --- a/common/ironlake/hw-gfx-gma-connectors.adb +++ b/common/ironlake/hw-gfx-gma-connectors.adb @@ -104,7 +104,7 @@ ---------------------------------------------------------------------------- - procedure Pre_Off (Port_Cfg : Port_Config) + procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); @@ -115,7 +115,7 @@ end if; end Pre_Off; - procedure Post_Off (Port_Cfg : Port_Config) + procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); diff --git a/common/tigerlake/hw-gfx-gma-connectors.adb b/common/tigerlake/hw-gfx-gma-connectors.adb index 5e66b96..73fafee 100644 --- a/common/tigerlake/hw-gfx-gma-connectors.adb +++ b/common/tigerlake/hw-gfx-gma-connectors.adb @@ -51,14 +51,14 @@ Success := True; end Post_On; - procedure Pre_Off (Port_Cfg : Port_Config) is + procedure Pre_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); Panel.Backlight_Off (Port_Cfg.Panel); Panel.Off (Port_Cfg.Panel); end Pre_Off; - procedure Post_Off (Port_Cfg : Port_Config) is + procedure Post_Off (Pipe : Pipe_Index; Port_Cfg : Port_Config) is begin pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity)); end Post_Off; -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81524?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I01dbf3cae3dfef2130fa10116f70f23238c7a48c Gerrit-Change-Number: 81524 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in libgfxinit[main]: gma: Add `eDP' flag to Port_Config
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/81523?usp=email ) Change subject: gma: Add `eDP' flag to Port_Config ...................................................................... gma: Add `eDP' flag to Port_Config Start with a simple check if the dedicated eDP port is used. In the future, this might change if another port is used for eDP. Change-Id: Idd40b4258c08ba88ec7b0ab631e683aba848f9c1 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/hw-gfx-gma-config_helpers.adb M common/hw-gfx-gma.ads 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/23/81523/1 diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb index 868d514..d91dfd2 100644 --- a/common/hw-gfx-gma-config_helpers.adb +++ b/common/hw-gfx-gma-config_helpers.adb @@ -218,6 +218,7 @@ Panel => To_Panel (Port), Mode => Mode, Is_FDI => Config.Is_FDI_Port (Port), + Is_eDP => Port = eDP, FDI => Default_DP, DP => Default_DP); @@ -254,6 +255,7 @@ Panel => No_Panel, Mode => Invalid_Mode, Is_FDI => False, + Is_eDP => False, FDI => Default_DP, DP => Default_DP); end if; diff --git a/common/hw-gfx-gma.ads b/common/hw-gfx-gma.ads index 43e88e1..8ef2247 100644 --- a/common/hw-gfx-gma.ads +++ b/common/hw-gfx-gma.ads @@ -321,6 +321,7 @@ Panel : Panel_Control; Mode : Mode_Type; Is_FDI : Boolean; + Is_eDP : Boolean; FDI : DP_Link; DP : DP_Link; end record; -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81523?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Idd40b4258c08ba88ec7b0ab631e683aba848f9c1 Gerrit-Change-Number: 81523 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in libgfxinit[main]: gma display_probing: Make new TGL ports available
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email ) Change subject: gma display_probing: Make new TGL ports available ...................................................................... gma display_probing: Make new TGL ports available Change-Id: I9d96673f931be0086536044694ecd127ba2a823d Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/hw-gfx-gma-display_probing.adb M common/hw-gfx-gma-display_probing.ads 2 files changed, 26 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/22/81522/1 diff --git a/common/hw-gfx-gma-display_probing.adb b/common/hw-gfx-gma-display_probing.adb index 67f8ddf..fa2a4f7 100644 --- a/common/hw-gfx-gma-display_probing.adb +++ b/common/hw-gfx-gma-display_probing.adb @@ -75,12 +75,26 @@ declare DP_Port : constant GMA.DP_Port := - (case Port is - when eDP => DP_A, - when DP1 => DP_B, - when DP2 => DP_C, - when DP3 => DP_D, - when others => GMA.DP_Port'First); + (if Config.Has_Type_C_Ports then + (case Port is + when eDP => DP_A, -- FIXME: should be configurable which is used for eDP + when DP1 => DP_A, + when DP2 => DP_B, + when DP3 => DP_C, + when USBC1_DP => DP_D, + when USBC2_DP => DP_E, + when USBC3_DP => DP_F, + when USBC4_DP => DP_G, + when USBC5_DP => DP_H, + when USBC6_DP => DP_I, + when others => GMA.DP_Port'First) + else + (case Port is + when eDP => DP_A, + when DP1 => DP_B, + when DP2 => DP_C, + when DP3 => DP_D, + when others => GMA.DP_Port'First)); begin DP_Aux_Ch.I2C_Read (Port => DP_Port, diff --git a/common/hw-gfx-gma-display_probing.ads b/common/hw-gfx-gma-display_probing.ads index 5dcdbd4..7479fdd 100644 --- a/common/hw-gfx-gma-display_probing.ads +++ b/common/hw-gfx-gma-display_probing.ads @@ -17,10 +17,14 @@ package HW.GFX.GMA.Display_Probing is - type Port_List_Range is range 0 .. 8; + type Port_List_Range is range 0 .. 20; type Port_List is array (Port_List_Range) of Port_Type; All_Ports : constant Port_List := - (DP1, DP2, DP3, HDMI1, HDMI2, HDMI3, Analog, LVDS, eDP); + (DP1, DP2, DP3, + HDMI1, HDMI2, HDMI3, + USBC1_DP, USBC2_DP, USBC3_DP, USBC4_DP, USBC5_DP, USBC6_DP, + USBC1_HDMI, USBC2_HDMI, USBC3_HDMI, USBC4_HDMI, USBC5_HDMI, USBC6_HDMI, + Analog, LVDS, eDP); procedure Read_EDID (Raw_EDID : out EDID.Raw_EDID_Data; -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d Gerrit-Change-Number: 81522 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in libgfxinit[main]: gfxtest: Drop unnecessary with of ancestor
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/81521?usp=email ) Change subject: gfxtest: Drop unnecessary with of ancestor ...................................................................... gfxtest: Drop unnecessary with of ancestor Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M gfxtest/hw-gfx-gma-gfx_test.adb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/21/81521/1 diff --git a/gfxtest/hw-gfx-gma-gfx_test.adb b/gfxtest/hw-gfx-gma-gfx_test.adb index 86ec44b..a7579a0 100644 --- a/gfxtest/hw-gfx-gma-gfx_test.adb +++ b/gfxtest/hw-gfx-gma-gfx_test.adb @@ -7,7 +7,6 @@ with HW.Debug; with HW.PCI.Dev; with HW.MMIO_Range; -with HW.GFX.GMA; with HW.GFX.GMA.Config; with HW.GFX.GMA.Display_Probing; -- To view, visit https://review.coreboot.org/c/libgfxinit/+/81521?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: Ibc1a6710a5cd12be9190860635e7b951d4fe4775 Gerrit-Change-Number: 81521 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in libgfxinit[main]: gma tgl: Add port detection
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Angel Pons, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak. Nico Huber has uploaded a new patch set (#35) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67500?usp=email ) Change subject: gma tgl: Add port detection ...................................................................... gma tgl: Add port detection Mostly just detecting the _ISR registers, but during initialization, this module also blocks TCCOLD so that Modular FIA registers can be accessed. Instead of keeping track of the state of TCCOLD all of the time (and enabling and re-enabling), this patch just blocks TCCOLD once during initializaton and leaves it that way. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I674e7c2dcd7738e3d76266ff36675dbd52fa5ae2 --- M common/tigerlake/hw-gfx-gma-port_detect.adb 1 file changed, 144 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/00/67500/35 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67500?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I674e7c2dcd7738e3d76266ff36675dbd52fa5ae2 Gerrit-Change-Number: 67500 Gerrit-PatchSet: 35 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in libgfxinit[main]: gma tgl: Add connector programming
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Angel Pons, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak. Nico Huber has uploaded a new patch set (#35) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67499?usp=email ) Change subject: gma tgl: Add connector programming ...................................................................... gma tgl: Add connector programming This patch adds support for enabling displays on both combo PHY ports and Type-C ports over DP-Alt mode. Verified eDP, HDMI (not Type-C), and DP Alt mode on google/delbin. Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738 Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M common/hw-gfx-gma-config.ads.template M common/hw-gfx-gma.adb M common/hw-gfx-gma.ads M common/tigerlake/Makefile.inc A common/tigerlake/hw-gfx-gma-connectors-combo_phy.adb A common/tigerlake/hw-gfx-gma-connectors-combo_phy.ads A common/tigerlake/hw-gfx-gma-connectors-tc.adb A common/tigerlake/hw-gfx-gma-connectors-tc.ads M common/tigerlake/hw-gfx-gma-connectors.adb M common/tigerlake/hw-gfx-gma-power_and_clocks.adb 10 files changed, 1,632 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/99/67499/35 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67499?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738 Gerrit-Change-Number: 67499 Gerrit-PatchSet: 35 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in libgfxinit[main]: gma tgl: Add support for allocating PLLs
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Angel Pons, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak. Nico Huber has uploaded a new patch set (#34) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67498?usp=email ) Change subject: gma tgl: Add support for allocating PLLs ...................................................................... gma tgl: Add support for allocating PLLs This patch adds support for allocating both combo PHY PLLs and USB Type-C PLLs for Tiger Lake. Verified Combo PHY (HDMI, eDP) and Type-C (DP Alt mode) on Google/delbin. Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Change-Id: I9dd7e0d0180f70d73eb50d7e58718261e5e74071 --- M common/hw-gfx-gma-config.ads.template M common/tigerlake/Makefile.inc A common/tigerlake/hw-gfx-gma-plls-combo_phy.adb A common/tigerlake/hw-gfx-gma-plls-combo_phy.ads A common/tigerlake/hw-gfx-gma-plls-dkl.adb A common/tigerlake/hw-gfx-gma-plls-dkl.ads M common/tigerlake/hw-gfx-gma-plls.adb M common/tigerlake/hw-gfx-gma-plls.ads 8 files changed, 930 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/98/67498/34 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67498?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I9dd7e0d0180f70d73eb50d7e58718261e5e74071 Gerrit-Change-Number: 67498 Gerrit-PatchSet: 34 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in libgfxinit[main]: gma tgl: Fill out power and clocks module
by Nico Huber (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Angel Pons, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak. Nico Huber has uploaded a new patch set (#30) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67495?usp=email ) Change subject: gma tgl: Fill out power and clocks module ...................................................................... gma tgl: Fill out power and clocks module This is the modeset sequence for the display engine itself. TGL has similarities to both SKL and BXT, but also adds new programming, like MBUS credits, Bandwidth Buddy, and of course new chicken bits. Tested on google/delbin; can still boot successfully to the kernel and the kernel can still properly perform its own modeset and not crash :) Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535 --- M common/tigerlake/hw-gfx-gma-power_and_clocks.adb M common/tigerlake/hw-gfx-gma-power_and_clocks.ads 2 files changed, 818 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/95/67495/30 -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535 Gerrit-Change-Number: 67495 Gerrit-PatchSet: 30 Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache
by Jérémy Compostella (Code Review) 26 Mar '24

26 Mar '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Bora Guvendik, Paul Menzel, Ronak Kanabar, Shuo Liu. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81212?usp=email ) Change subject: drivers/intel/fsp2_0: Support FSP-M execution from CBFS cache ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81212/comment/efad42f1_c55e6c0c : PS2, Line 12: can > can be Done https://review.coreboot.org/c/coreboot/+/81212/comment/6cb89329_604a0858 : PS2, Line 25: | Overall boot time impact | +15.9 ms | +77.4 ms | > Where do the 14 ms difference for LZ4 come from? Done https://review.coreboot.org/c/coreboot/+/81212/comment/b032e5e2_7f9479c7 : PS2, Line 29: \ > Other way /? Done File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/81212/comment/e4703ea5_48ac29e4 : PS2, Line 225: Select this value when FSP-M execute from CBFS cache > Please add a dot/period at the end of the sentence. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/81212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d42d765eb0ecf2e7a8fc6d8d15eb2df8975f6f2 Gerrit-Change-Number: 81212 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Tue, 26 Mar 2024 17:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024