Attention is currently required from: Martin L Roth.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81023?usp=email )
Change subject: mb/google/oak: Don't build the ChromeEC codebase by default
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> For Oak/Elm/Hana, the ec/pd images are built by coreboot. […]
If that's a build system issue then IMHO fixing the build rules would be better than keeping the dependency in coreboot...
--
To view, visit https://review.coreboot.org/c/coreboot/+/81023?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd4fe45e52dbdd1c8dccf0d2c09d5cf6d61aa839
Gerrit-Change-Number: 81023
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Mon, 04 Mar 2024 08:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, SH Kim.
Hello Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81033?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brya/var/xol: Add VGPIO configurations for PEG60
......................................................................
mb/google/brya/var/xol: Add VGPIO configurations for PEG60
Add VGPIO configurations for NVMe on PEG60.
BUG=b:326481458, b:372086400
BRANCH=firmware-brya-14505.B
TEST=Verified DUT could detect NVMe.
Install ChromeOS into NVMe and boot from it.
Change-Id: I5520dc2a4bf6e788701a774674d223b7e8ad5b44
Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/xol/gpio.c
1 file changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/81033/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/81033?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5520dc2a4bf6e788701a774674d223b7e8ad5b44
Gerrit-Change-Number: 81033
Gerrit-PatchSet: 3
Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Arthur Heymans, Leah Rowe, Michael Büchler, Nico Huber, Paul Menzel, ilikenwf, nat ✨.
Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 33:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55232/comment/02ccdb4a_f06643e4 :
PS33, Line 11: PWN
> how to remove iommu support (needed for graphics cards to work): […]
I don't think the iommu issue is specific to this machine, it might very well affect all of Haswell.
Also the EC and Super I/O refer to the same SCH5555 in this case.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 33
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ben Westover <me(a)benthetechguy.net>
Gerrit-CC: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: ilikenwf <mparnell(a)gmail.com>
Gerrit-CC: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: ilikenwf <mparnell(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Mon, 04 Mar 2024 08:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: srinivas.kulkarni(a)intel.com.
Hello build bot (Jenkins), srinivas.kulkarni(a)intel.com,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80782?usp=email
to look at the new patch set (#2).
Change subject: vc/intel/fsp/mtl: Update header files from 3471_85 to 3471_91
......................................................................
vc/intel/fsp/mtl: Update header files from 3471_85 to 3471_91
Update header files for FSP for Meteor Lake platform to version 3471_91,
previous version being 3471_85.
FSPM:
1. Address offset changes
BUG=b:327688959
TEST=Able to build and boot google/rex to ChromeOS.
Change-Id: I5a71232018dfefec63b0a83d1e87717e238a4a0a
Signed-off-by: Ronak Kanabar <ronak.kanabar(a)intel.com>
---
M src/vendorcode/intel/fsp/fsp2_0/meteorlake/FspmUpd.h
1 file changed, 523 insertions(+), 523 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/80782/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80782?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5a71232018dfefec63b0a83d1e87717e238a4a0a
Gerrit-Change-Number: 80782
Gerrit-PatchSet: 2
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: srinivas.kulkarni(a)intel.com
Gerrit-Attention: srinivas.kulkarni(a)intel.com
Gerrit-MessageType: newpatchset
Attention is currently required from: srinivas.kulkarni(a)intel.com.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80782?usp=email )
Change subject: vc/intel/fsp/mtl: Update header files from 3471_85 to 3471_91
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80782?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5a71232018dfefec63b0a83d1e87717e238a4a0a
Gerrit-Change-Number: 80782
Gerrit-PatchSet: 1
Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: srinivas.kulkarni(a)intel.com
Gerrit-Attention: srinivas.kulkarni(a)intel.com
Gerrit-Comment-Date: Mon, 04 Mar 2024 07:52:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Michael Büchler, Máté Kukri, Nico Huber, Paul Menzel, ilikenwf, nat ✨.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email )
Change subject: mb/dell: Add OptiPlex 7020/9020 port
......................................................................
Patch Set 33:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55232/comment/028db943_06f4d5fc :
PS33, Line 11: PWN
> so long as the iommu issue is also mentioned in commit msg (and maybe tell how to remove it when bui […]
how to remove iommu support (needed for graphics cards to work):
src/northbridge/intel/haswell/early_init.c - remove haswell_setup_iommu() and the call to it in that same file. in my testing on debian 12, this was necessary to run xorg when using a graphics card. alternatively, don't do the above, but do iommu=off on Linux cmdline - or use my IOMMU toggle patch and turn it off in nvram: https://review.coreboot.org/c/coreboot/+/81016
--
To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a
Gerrit-Change-Number: 55232
Gerrit-PatchSet: 33
Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Ben Westover <me(a)benthetechguy.net>
Gerrit-CC: Leah Rowe <leahleahrowerowe(a)gmail.com>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: ilikenwf <mparnell(a)gmail.com>
Gerrit-CC: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: nat ✨ <nat(a)nekopon.pl>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: ilikenwf <mparnell(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Mon, 04 Mar 2024 07:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com>
Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-MessageType: comment