Attention is currently required from: Alicja Michalska, Arthur Heymans, Martin L Roth, Nick Vaccaro.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80848?usp=email )
Change subject: soc/intel/tigerlake: Add IRQ mapping for PEG PCI-E ports
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80848/comment/a09ad7f3_1e5a9429 :
PS1, Line 16: Boot Linux
> Yes, pci=nomsi breaks NVME altogether. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80848?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If102522efa1a67b362b14d859d9e27a37bad85a4
Gerrit-Change-Number: 80848
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Tue, 05 Mar 2024 23:28:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80849?usp=email )
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Mar 2024 23:19:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Nick Vaccaro, Subrata Banik.
Alicja Michalska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80849?usp=email )
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/80849/comment/e70606de_4c3782d3 :
PS1, Line 28: B0
> should be P0
Thanks for heads-up!
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Mar 2024 23:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska, Felix Singer, Nick Vaccaro, Subrata Banik.
Hello Felix Singer, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80849?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
soc/intel: Add definition of D0 stepping for TigerLake Halo
Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Signed-off-by: Alicja Michalska <ahplka19(a)gmail.com>
---
M src/include/cpu/intel/cpu_ids.h
M src/soc/intel/common/block/cpu/mp_init.c
M src/soc/intel/tigerlake/bootblock/report_platform.c
3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/80849/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Alicja Michalska, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80849?usp=email )
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Mar 2024 23:04:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Alicja Michalska, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80849?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/tigerlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/80849/comment/9e7bcd9b_f798aafb :
PS1, Line 28: B0
should be P0
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Mar 2024 23:04:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/blobs/+/80852?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: mb/erying/tgl: Add blobs necessary for platform bring-up
......................................................................
mb/erying/tgl: Add blobs necessary for platform bring-up
Flash Descriptor and Management Engine blobs extracted from stock.
Microcodes from public GitHub repository, as Intel doesn't carry
microcode for D0 stepping in their tree.
Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Signed-off-by: Alicja Michalska <ahplka19(a)gmail.com>
---
A mainboard/erying/tgl/cpu806D0_platC2_ver00000054_2021-05-07_PRD_B0F9E245.bin
A mainboard/erying/tgl/cpu806D1_platC2_ver00000046_2023-02-27_PRD_08E6188A.bin
A mainboard/erying/tgl/fd.bin
A mainboard/erying/tgl/me.bin
4 files changed, 0 insertions(+), 0 deletions(-)
Approvals:
Felix Singer: Verified; Looks good to me, approved
diff --git a/mainboard/erying/tgl/cpu806D0_platC2_ver00000054_2021-05-07_PRD_B0F9E245.bin b/mainboard/erying/tgl/cpu806D0_platC2_ver00000054_2021-05-07_PRD_B0F9E245.bin
new file mode 100644
index 0000000..a5182ce
--- /dev/null
+++ b/mainboard/erying/tgl/cpu806D0_platC2_ver00000054_2021-05-07_PRD_B0F9E245.bin
Binary files differ
diff --git a/mainboard/erying/tgl/cpu806D1_platC2_ver00000046_2023-02-27_PRD_08E6188A.bin b/mainboard/erying/tgl/cpu806D1_platC2_ver00000046_2023-02-27_PRD_08E6188A.bin
new file mode 100644
index 0000000..e1b6851
--- /dev/null
+++ b/mainboard/erying/tgl/cpu806D1_platC2_ver00000046_2023-02-27_PRD_08E6188A.bin
Binary files differ
diff --git a/mainboard/erying/tgl/fd.bin b/mainboard/erying/tgl/fd.bin
new file mode 100644
index 0000000..0ba6d5e
--- /dev/null
+++ b/mainboard/erying/tgl/fd.bin
Binary files differ
diff --git a/mainboard/erying/tgl/me.bin b/mainboard/erying/tgl/me.bin
new file mode 100644
index 0000000..05b2555
--- /dev/null
+++ b/mainboard/erying/tgl/me.bin
Binary files differ
--
To view, visit https://review.coreboot.org/c/blobs/+/80852?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I9ee9e031969b477d2d9f63f7e49a113bd4380f91
Gerrit-Change-Number: 80852
Gerrit-PatchSet: 2
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: merged
Attention is currently required from: Alicja Michalska, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80849?usp=email )
Change subject: soc/intel: Add definition of D0 stepping for TigerLake Halo
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80849?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic080ffe7912ad71c77af09d2f3d1d9b08d9ffac8
Gerrit-Change-Number: 80849
Gerrit-PatchSet: 1
Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 05 Mar 2024 22:50:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment