coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP...
by Felix Singer (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug, ron minnich. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81086?usp=email ) Change subject: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/81086/comment/4b9472f0_3ca2cc3c : PS1, Line 7: arch/riscv: Makefile.mk: Fix incorrect config variable : ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP How about: ``` arch/riscv/Makefile.mk: Fix config variable name ARCH_RISCV_PMP should be CONFIG_ARCH_RISCV_PMP. Rename it. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/81086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Gerrit-Change-Number: 81086 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 21:43:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cbfs: Remove broken remnants of PAYLOAD_INFO feature
by Julius Werner (Code Review) 06 Mar '24

06 Mar '24

Julius Werner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81087?usp=email ) Change subject: cbfs: Remove broken remnants of PAYLOAD_INFO feature ...................................................................... cbfs: Remove broken remnants of PAYLOAD_INFO feature PAYLOAD_INFO is a very old feature that can add an key/value information section to a payload file. It seems to have only ever been generated by coreinfo and never really read by anything. Since CB:1721 in 2012, the feature has been inadvertently broken in practice since the `.note.pinfo` sections that contain the information get discarded from the payload before cbfstool gets to see them. Since CB:28647 in 2018, support for the section in the SELF loader was (inadvertently?) dropped, so if someone actually fed cbfstool a payload ELF that did have a `.note.pinfo` section, modern coreboot would refuse to boot the payload entirely (which is probably not a good state to leave things in). This patch removes the code to generate PAYLOAD_INFO entries entirely, but leaves the support to parse and extract those sections from old payloads in place in cbfstool. Change-Id: I40d8e9b76a171ebcdaa2eae02d54a1ca5e592c85 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M payloads/coreinfo/Kconfig M payloads/coreinfo/coreinfo.c M payloads/libpayload/include/libpayload.h M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h M util/cbfstool/cbfs-mkpayload.c M util/cbfstool/cbfs_image.c 6 files changed, 12 insertions(+), 83 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/81087/1 diff --git a/payloads/coreinfo/Kconfig b/payloads/coreinfo/Kconfig index 2c1f91c..c0e314e 100644 --- a/payloads/coreinfo/Kconfig +++ b/payloads/coreinfo/Kconfig @@ -18,25 +18,13 @@ This option will increase the ELF file size by ca. 250 bytes. -config PAYLOAD_INFO_NAME +config COREINFO_NAME string "Payload name" default "coreinfo" help The name of this payload for use in (e.g.) Bayou. -config PAYLOAD_INFO_LISTNAME - string "Payload menu entry name" - default "System Information" - help - The name of this payload's menu entry for use in (e.g.) Bayou. - -config PAYLOAD_INFO_DESC - string "Payload description" - default "Display information about the system" - help - The description of this payload for use in (e.g.) Bayou. - -config PAYLOAD_INFO_VERSION +config COREINFO_VERSION string "Payload version" default "0.1" help diff --git a/payloads/coreinfo/coreinfo.c b/payloads/coreinfo/coreinfo.c index b357f97..b01dfeb 100644 --- a/payloads/coreinfo/coreinfo.c +++ b/payloads/coreinfo/coreinfo.c @@ -229,7 +229,7 @@ { int key; - center(0, CONFIG_PAYLOAD_INFO_NAME " " CONFIG_PAYLOAD_INFO_VERSION); + center(0, CONFIG_COREINFO_NAME " " CONFIG_COREINFO_VERSION); print_no_modules_selected(); refresh(); @@ -319,7 +319,3 @@ halt(); return 0; } - -PAYLOAD_INFO(name, CONFIG_PAYLOAD_INFO_NAME); -PAYLOAD_INFO(listname, CONFIG_PAYLOAD_INFO_LISTNAME); -PAYLOAD_INFO(desc, CONFIG_PAYLOAD_INFO_DESC); diff --git a/payloads/libpayload/include/libpayload.h b/payloads/libpayload/include/libpayload.h index 61dbd27..05164e5 100644 --- a/payloads/libpayload/include/libpayload.h +++ b/payloads/libpayload/include/libpayload.h @@ -84,18 +84,6 @@ #define MAX_ARGC_COUNT 32 -/* - * Payload information parameters - these are used to pass information - * to the entity loading the payload. - * Usage: PAYLOAD_INFO(key, value) - * Example: PAYLOAD_INFO(name, "CoreInfo!") - */ -#define _pstruct(key) __pinfo_ ##key -#define PAYLOAD_INFO(key, value) \ -static const char _pstruct(key)[] \ - __attribute__((__used__)) \ - __attribute__((section(".note.pinfo"),unused)) = #key "=" value - /** * @defgroup nvram NVRAM and RTC functions * @{ diff --git a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h index cebaf83..3d721f5 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h +++ b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h @@ -198,7 +198,8 @@ PAYLOAD_SEGMENT_CODE = 0x434F4445, /* BE: 'CODE' */ PAYLOAD_SEGMENT_DATA = 0x44415441, /* BE: 'DATA' */ PAYLOAD_SEGMENT_BSS = 0x42535320, /* BE: 'BSS ' */ - PAYLOAD_SEGMENT_PARAMS = 0x50415241, /* BE: 'PARA' */ + /* PARAMS for PAYLOAD_INFO feature. Broken since 2012, removed 2024. */ + PAYLOAD_SEGMENT_DEPRECATED_PARAMS = 0x50415241, /* BE: 'PARA' */ PAYLOAD_SEGMENT_ENTRY = 0x454E5452, /* BE: 'ENTR' */ }; diff --git a/util/cbfstool/cbfs-mkpayload.c b/util/cbfstool/cbfs-mkpayload.c index e9bcfba..a04d673 100644 --- a/util/cbfstool/cbfs-mkpayload.c +++ b/util/cbfstool/cbfs-mkpayload.c @@ -79,28 +79,8 @@ strtab = &header[shdr[ehdr.e_shstrndx].sh_offset]; - /* Count the number of headers - look for the .notes.pinfo - * section */ - - for (i = 0; i < ehdr.e_shnum; i++) { - char *name; - - if (i == ehdr.e_shstrndx) - continue; - - if (shdr[i].sh_size == 0) - continue; - - name = (char *)(strtab + shdr[i].sh_name); - - if (!strcmp(name, ".note.pinfo")) { - segments++; - isize += (unsigned int)shdr[i].sh_size; - } - } - - /* Now, regular headers - we only care about PT_LOAD headers, - * because that's what we're actually going to load + /* Count the number of segment headers - we only care about PT_LOAD + * headers, because that's what we're actually going to load */ for (i = 0; i < headers; i++) { @@ -144,30 +124,6 @@ */ segments = 0; - for (i = 0; i < ehdr.e_shnum; i++) { - char *name; - if (i == ehdr.e_shstrndx) - continue; - - if (shdr[i].sh_size == 0) - continue; - name = (char *)(strtab + shdr[i].sh_name); - if (!strcmp(name, ".note.pinfo")) { - segs[segments].type = PAYLOAD_SEGMENT_PARAMS; - segs[segments].load_addr = 0; - segs[segments].len = (unsigned int)shdr[i].sh_size; - segs[segments].offset = doffset; - - memcpy((unsigned long *)(output->data + doffset), - &header[shdr[i].sh_offset], shdr[i].sh_size); - - doffset += segs[segments].len; - osize += segs[segments].len; - - segments++; - } - } - for (i = 0; i < headers; i++) { if (phdr[i].p_type != PT_LOAD) continue; diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c index 1fde8cd..740a3b2 100644 --- a/util/cbfstool/cbfs_image.c +++ b/util/cbfstool/cbfs_image.c @@ -864,7 +864,7 @@ if (segments[i].type == PAYLOAD_SEGMENT_BSS || segments[i].type == PAYLOAD_SEGMENT_ENTRY) { continue; - } else if (segments[i].type == PAYLOAD_SEGMENT_PARAMS) { + } else if (segments[i].type == PAYLOAD_SEGMENT_DEPRECATED_PARAMS) { memcpy(out_ptr, in_ptr, segments[i].len); segments[i].offset = new_offset; new_offset += segments[i].len; @@ -1090,7 +1090,7 @@ segments++; } else if (payload_type == PAYLOAD_SEGMENT_BSS) { segments++; - } else if (payload_type == PAYLOAD_SEGMENT_PARAMS) { + } else if (payload_type == PAYLOAD_SEGMENT_DEPRECATED_PARAMS) { segments++; } else if (payload_type == PAYLOAD_SEGMENT_ENTRY) { /* The last segment in a payload is always ENTRY as @@ -1162,7 +1162,7 @@ shdr.sh_size = segs[i].len; name = strdup(".bss"); buffer_splice(&tbuff, buff, 0, 0); - } else if (segs[i].type == PAYLOAD_SEGMENT_PARAMS) { + } else if (segs[i].type == PAYLOAD_SEGMENT_DEPRECATED_PARAMS) { shdr.sh_type = SHT_NOTE; shdr.sh_flags = 0; shdr.sh_size = segs[i].len; @@ -1398,8 +1398,8 @@ seg->load_addr, seg->len); break; - case PAYLOAD_SEGMENT_PARAMS: - fprintf(fp, " parameters\n"); + case PAYLOAD_SEGMENT_DEPRECATED_PARAMS: + fprintf(fp, " parameters (deprecated)\n"); break; default: -- To view, visit https://review.coreboot.org/c/coreboot/+/81087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40d8e9b76a171ebcdaa2eae02d54a1ca5e592c85 Gerrit-Change-Number: 81087 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP...
by ron minnich (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81086?usp=email ) Change subject: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: will start using pmp in qemu so this stops being missed -- To view, visit https://review.coreboot.org/c/coreboot/+/81086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Gerrit-Change-Number: 81086 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 21:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP...
by ron minnich (Code Review) 06 Mar '24

06 Mar '24

ron minnich has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81086?usp=email ) Change subject: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP ...................................................................... arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com> --- M src/arch/riscv/Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/81086/1 diff --git a/src/arch/riscv/Makefile.mk b/src/arch/riscv/Makefile.mk index 0dbfd2a..1131bd5 100644 --- a/src/arch/riscv/Makefile.mk +++ b/src/arch/riscv/Makefile.mk @@ -59,7 +59,7 @@ all-y += boot.c all-y += smp.c all-y += misc.c -all-$(ARCH_RISCV_PMP) += pmp.c +all-$(CONFIG_ARCH_RISCV_PMP) += pmp.c all-y += \ $(top)/src/lib/memchr.c \ $(top)/src/lib/memcmp.c \ -- To view, visit https://review.coreboot.org/c/coreboot/+/81086?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Gerrit-Change-Number: 81086 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP...
by ron minnich (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug, ron minnich. ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81085?usp=email ) Change subject: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: next step is to build coreboot in a way that this would be caught. -- To view, visit https://review.coreboot.org/c/coreboot/+/81085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Gerrit-Change-Number: 81085 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 21:16:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP...
by ron minnich (Code Review) 06 Mar '24

06 Mar '24

ron minnich has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81085?usp=email ) Change subject: arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP ...................................................................... arch/riscv: Makefile.mk: Fix incorrect config variable ARCH_RISCV_PMP -> CONFIG_ARCH_RISCV_PMP Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Signed-off-by: Ronald G Minnich <rminnich(a)gmail.com> --- M src/arch/riscv/Makefile.mk 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/81085/1 diff --git a/src/arch/riscv/Makefile.mk b/src/arch/riscv/Makefile.mk index 0dbfd2a..1131bd5 100644 --- a/src/arch/riscv/Makefile.mk +++ b/src/arch/riscv/Makefile.mk @@ -59,7 +59,7 @@ all-y += boot.c all-y += smp.c all-y += misc.c -all-$(ARCH_RISCV_PMP) += pmp.c +all-$(CONFIG_ARCH_RISCV_PMP) += pmp.c all-y += \ $(top)/src/lib/memchr.c \ $(top)/src/lib/memcmp.c \ -- To view, visit https://review.coreboot.org/c/coreboot/+/81085?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a22acae5cd9f30e01c491653bf7fc7b7765d815 Gerrit-Change-Number: 81085 Gerrit-PatchSet: 1 Gerrit-Owner: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case
by Jérémy Compostella (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80575?usp=email ) Change subject: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80575/comment/1ad323e8_d1fc4eb9 : PS8, Line 14: Meteor Lake rex board > Yes, with `INTEL_FSP_MP_INIT` enabled and `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` disabled i […] Note: "boot fine" is a bit exaggerated. Cf. https://review.coreboot.org/c/coreboot/+/80691/comments/d1c21d3b_ccdab4c0 -- To view, visit https://review.coreboot.org/c/coreboot/+/80575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8cdfef7b4279da2c7dff344c95fe446a605934 Gerrit-Change-Number: 80575 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 06 Mar 2024 20:41:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case
by Jérémy Compostella (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80575?usp=email ) Change subject: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case ...................................................................... Patch Set 9: (1 comment) Patchset: PS5: > It does not have any dependency. The following patch "depends" on it though. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8cdfef7b4279da2c7dff344c95fe446a605934 Gerrit-Change-Number: 80575 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 06 Mar 2024 20:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case
by Jérémy Compostella (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Arthur Heymans, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80575?usp=email ) Change subject: soc/intel/common/mp_init: Fix USE_INTEL_FSP_MP_INIT use-case ...................................................................... Patch Set 9: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80575/comment/b0407e48_dcbc5c94 : PS8, Line 14: Meteor Lake rex board > with INTEL_FSP_MP_INIT config being enabled ? Yes, with `INTEL_FSP_MP_INIT` enabled and `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` disabled it compiles fine thanks to this patch. It also executes fine but because fsp_params.c discard `USE_INTEL_FSP_TO_CALL_COREBOOT_PUBLISH_MP_PPI` it still uses PPI callback. But that's okay to verify that it compiles and that `init_cpus()` got called and worked. Patchset: PS5: > > Done […] It does not have any dependency. The following patch "depends" on it though. -- To view, visit https://review.coreboot.org/c/coreboot/+/80575?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb8cdfef7b4279da2c7dff344c95fe446a605934 Gerrit-Change-Number: 80575 Gerrit-PatchSet: 9 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 06 Mar 2024 20:28:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Perform MP init post FSP-MultiPhase SI Init
by Jérémy Compostella (Code Review) 06 Mar '24

06 Mar '24

Attention is currently required from: Andrey Petrov, Ronak Kanabar, Subrata Banik. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80691?usp=email ) Change subject: drivers/intel/fsp2_0: Perform MP init post FSP-MultiPhase SI Init ...................................................................... Patch Set 6: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80691/comment/93aca95a_b8410ce4 : PS3, Line 7: FSP-S > i guess you mean to say `Add hooks to perform MP init post FSP-MultiPhase SI Init (if supported)` Done File src/drivers/intel/fsp2_0/silicon_init.c: https://review.coreboot.org/c/coreboot/+/80691/comment/6adf4239_65bd451e : PS3, Line 158: /* Reinitialize CPUs if FSP-S has done MP Init */ : if (CONFIG(USE_INTEL_FSP_MP_INIT)) : do_mpinit_after_fsp(); > if the goal is to skip do_mpinit_after_fsp() immediately after FSP-S API and wait till MultiPhaseSiI […] Done https://review.coreboot.org/c/coreboot/+/80691/comment/b0ef23d4_532540d3 : PS3, Line 159: goto fsp_init_done; > what is the point of calling `do_mpinit_after_fsp` when FSP itself is not compliant with FSP2. […] Done https://review.coreboot.org/c/coreboot/+/80691/comment/2296fa25_29a284b8 : PS3, Line 163: goto fsp_init_done; > same as before, assume FSP Multiphase Si Init itself is not enabled hence, why would we like to do d […] Done https://review.coreboot.org/c/coreboot/+/80691/comment/2a4de47a_90506f87 : PS3, Line 171: oto fsp_init_done; > again the same, if multi_phase_si_init itself is not implemented then what is the point of calling d […] Done https://review.coreboot.org/c/coreboot/+/80691/comment/e99d84fc_7543d39e : PS3, Line 204: USE_INTEL_FSP_MP_INIT > > Since this option exist, the idea of this patch is to keep working for new platforms. […] This is what we do. -- To view, visit https://review.coreboot.org/c/coreboot/+/80691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0397f5cc8d0f4f1872bd37a001fe42e0c37ec92 Gerrit-Change-Number: 80691 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Wed, 06 Mar 2024 20:25:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024