coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[XS] Change in coreboot[main]: libpayload: Make GPL commonlib includes available to payloads and tests
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81287?usp=email ) Change subject: libpayload: Make GPL commonlib includes available to payloads and tests ...................................................................... libpayload: Make GPL commonlib includes available to payloads and tests CB:77968 made some non-BSD commonlib files part of libpayload when CONFIG_LP_GPL is set. This patch exports those headers to the payload (again only when CONFIG_LP_GPL is set) so that payloads can also call the functions in them directly. Also make those includes available to tests so that their functions can be tested. There's no menuconfig for unit tests, so they are included unconditionally, but this should be fine since the tests are standalone and won't have to link with any proprietary third-party code. Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81287 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M payloads/libpayload/Makefile.mk M payloads/libpayload/bin/lpgcc M payloads/libpayload/tests/Makefile.mk 3 files changed, 8 insertions(+), 0 deletions(-) Approvals: Maximilian Brune: Looks good to me, approved build bot (Jenkins): Verified diff --git a/payloads/libpayload/Makefile.mk b/payloads/libpayload/Makefile.mk index e000868..afaa06d 100644 --- a/payloads/libpayload/Makefile.mk +++ b/payloads/libpayload/Makefile.mk @@ -133,6 +133,10 @@ find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} \; cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(abspath $(DESTDIR))/libpayload/{} \; cd $(coreboottop)/src/commonlib/bsd && find include -type f -exec install -m644 {} $(abspath $(DESTDIR))/libpayload/{} \; +ifeq ($(CONFIG_LP_GPL),y) + cd $(coreboottop)/src/commonlib && find include -type d -exec install -m755 -d $(abspath $(DESTDIR))/libpayload/{} \; + cd $(coreboottop)/src/commonlib && find include -type f -exec install -m644 {} $(abspath $(DESTDIR))/libpayload/{} \; +endif install -m 644 $(obj)/libpayload-config.h $(DESTDIR)/libpayload/include $(foreach item,$(includes), \ install -m 755 -d $(DESTDIR)/libpayload/include/$(call extract_nth,2,$(item)); \ diff --git a/payloads/libpayload/bin/lpgcc b/payloads/libpayload/bin/lpgcc index 35fa558..bdc1518 100755 --- a/payloads/libpayload/bin/lpgcc +++ b/payloads/libpayload/bin/lpgcc @@ -170,6 +170,9 @@ _CFLAGS="$_CFLAGS -include $BASE/../../../src/commonlib/bsd/include/commonlib/bsd/compiler.h" _CFLAGS="$_CFLAGS -I$BASE/../../../src/commonlib/bsd/include" + if [ "$CONFIG_LP_GPL" = y ]; then + _CFLAGS="$_CFLAGS -I$BASE/../../../src/commonlib/include" + fi _CFLAGS="$_CFLAGS -I$BASE/../../../3rdparty/vboot/firmware/include" else _CFLAGS="$_CFLAGS -include $BASE/../include/commonlib/bsd/compiler.h" diff --git a/payloads/libpayload/tests/Makefile.mk b/payloads/libpayload/tests/Makefile.mk index 9bac9e6..7118906 100644 --- a/payloads/libpayload/tests/Makefile.mk +++ b/payloads/libpayload/tests/Makefile.mk @@ -34,6 +34,7 @@ TEST_CFLAGS += -include $(coreboottop)/src/commonlib/bsd/include/commonlib/bsd/compiler.h TEST_CFLAGS += -Iinclude -Iinclude/mock TEST_CFLAGS += -I$(coreboottop)/src/commonlib/bsd/include +TEST_CFLAGS += -I$(coreboottop)/src/commonlib/include TEST_CFLAGS += -I$(dir $(TEST_KCONFIG_AUTOHEADER)) TEST_CFLAGS += -I$(VBOOT_SOURCE)/firmware/include -- To view, visit https://review.coreboot.org/c/coreboot/+/81287?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc3e52ee5c3e51520f7b7d44b483bfcb0e8380f8 Gerrit-Change-Number: 81287 Gerrit-PatchSet: 3 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: drivers/spi: Add support for GD25LR512ME flash rom
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81284?usp=email ) Change subject: drivers/spi: Add support for GD25LR512ME flash rom ...................................................................... drivers/spi: Add support for GD25LR512ME flash rom This device is used on the AMD BirmanPlus board. Change-Id: Iadb819e89a349d074e5ae9f4b62a06176f1f8f64 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81284 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/drivers/spi/gigadevice.c 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Felix Held: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/drivers/spi/gigadevice.c b/src/drivers/spi/gigadevice.c index 16ba27f..50bc222 100644 --- a/src/drivers/spi/gigadevice.c +++ b/src/drivers/spi/gigadevice.c @@ -124,6 +124,13 @@ .fast_read_dual_output_support = 1, .fast_read_dual_io_support = 1, }, + { + /* GD25LR512ME - 64MiB */ + .id[0] = 0x671A, + .nr_sectors_shift = 14, + .fast_read_dual_output_support = 1, + .fast_read_dual_io_support = 1, + }, }; const struct spi_flash_vendor_info spi_flash_gigadevice_vi = { -- To view, visit https://review.coreboot.org/c/coreboot/+/81284?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iadb819e89a349d074e5ae9f4b62a06176f1f8f64 Gerrit-Change-Number: 81284 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: payloads/edk2: Set the EDK2 repository to custom for UPL
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81277?usp=email ) Change subject: payloads/edk2: Set the EDK2 repository to custom for UPL ...................................................................... payloads/edk2: Set the EDK2 repository to custom for UPL UPL requires the Shim Layer, and those patches exist in the `starlabsltd` fork. Set the repository to custom, to allow this fork and branch to be selected correctly. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: Ieca72498bde51a184d689670449b66ccc78d658a Reviewed-on: https://review.coreboot.org/c/coreboot/+/81277 Reviewed-by: Benjamin Doron <benjamin.doron00(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M payloads/external/edk2/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Benjamin Doron: Looks good to me, approved Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve diff --git a/payloads/external/edk2/Kconfig b/payloads/external/edk2/Kconfig index e2cfb48..865ae67 100644 --- a/payloads/external/edk2/Kconfig +++ b/payloads/external/edk2/Kconfig @@ -43,6 +43,7 @@ choice prompt "Tianocore's EDK II payload" + default EDK2_REPO_CUSTOM if EDK2_UNIVERSAL_PAYLOAD default EDK2_REPO_MRCHROMEBOX help Select which type of payload edk2 will build (default is UefiPayload) -- To view, visit https://review.coreboot.org/c/coreboot/+/81277?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ieca72498bde51a184d689670449b66ccc78d658a Gerrit-Change-Number: 81277 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Attention is currently required from: Dinesh Gehlot, Frank Chu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81136?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/glassway: Tune I2C timings for 400 kHz ...................................................................... Patch Set 11: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81136/comment/86100ecc_5cb6ec4d : PS11, Line 19: Signed-off-by: FrankChu <frank_chu(a)pegatron.corp-partner.google.com> > `Duplicate signature` Please fix. Patchset: PS11: Good after fixing the issue in the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/81136?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65fb1298f9e96ab0b63aba436f6a319f21b38925 Gerrit-Change-Number: 81136 Gerrit-PatchSet: 11 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shawn Ku <shawnku(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 16:49:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/glassway: Adjust touchscreen power sequencing
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Attention is currently required from: Dinesh Gehlot, Eric Lai, Frank Chu, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81135?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/glassway: Adjust touchscreen power sequencing ...................................................................... Patch Set 17: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81135/comment/c01a9427_2ca85c20 : PS17, Line 11: The INX touch panel (eKTH5015M) contains a pull-up register which causes TCHSCR_REPORT_EN pull-up abnormally from Z1 power on.Because the t25 must be at least greater than 20ms, TCHSCR_REPORT_EN is initialized to GPO_L in the early stage (romstage) to meet the spec. > `Possible unwrapped commit description (prefer a maximum 72 chars per line)` Please fix. https://review.coreboot.org/c/coreboot/+/81135/comment/6cda98b3_16e861f2 : PS17, Line 16: [INFO ] input: Elan Touchscreen as /devices/pci0000:00/0000:00:15.1/i2c_designware.1/i2c-10/i2c-ELAN0001:00/input/in4 I think this one is okay to leave since it's the output of a logfile. -- To view, visit https://review.coreboot.org/c/coreboot/+/81135?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I50f9c21ddee2bc9c1d313f63049cb587b4ae047a Gerrit-Change-Number: 81135 Gerrit-PatchSet: 17 Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Sun, 17 Mar 2024 16:47:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: symbols: Add __maybe_unused flag to region variable symbols
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Lean Sheng Tan, Patrick Rudolph, Shuo Liu. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81209?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: symbols: Add __maybe_unused flag to region variable symbols ...................................................................... Patch Set 4: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/81209/comment/43dd3a87_86dd8657 : PS4, Line 12: comipler compiler Patchset: PS4: Good after fixing a typo in the commit message. Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/81209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41 Gerrit-Change-Number: 81209 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Sun, 17 Mar 2024 16:45:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/anraggar: Add pen insert/remove for wakeup
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81102?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/nissa/var/anraggar: Add pen insert/remove for wakeup ...................................................................... mb/google/nissa/var/anraggar: Add pen insert/remove for wakeup Currently, inserting the pen does not wake the system, only removing the pen does. This is caused by the wake event configuration being DEASSERTED, so change it to ANY. BUG=b:328351027 TEST=insert and remove pen can wakes system up. Change-Id: Icdea995c2be04ea459e985f79269e49faf88248d Signed-off-by: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81102 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eric Lai <ericllai(a)google.com> Reviewed-by: Shou-Chieh Hsu <shouchieh(a)google.com> Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-by: Derek Huang <derekhuang(a)google.com> Reviewed-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brya/variants/anraggar/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Shou-Chieh Hsu: Looks good to me, but someone else must approve Weimin Wu: Looks good to me, but someone else must approve Derek Huang: Looks good to me, approved Kapil Porwal: Looks good to me, approved Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb index 77ae2b6..e0e46f6 100644 --- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb +++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb @@ -252,7 +252,7 @@ register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_F13)" register "key.wake_gpe" = "GPE0_DW2_15" register "key.wakeup_route" = "WAKEUP_ROUTE_SCI" - register "key.wakeup_event_action" = "EV_ACT_DEASSERTED" + register "key.wakeup_event_action" = "EV_ACT_ANY" register "key.dev_name" = ""EJCT"" register "key.linux_code" = "SW_PEN_INSERTED" register "key.linux_input_type" = "EV_SW" -- To view, visit https://review.coreboot.org/c/coreboot/+/81102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icdea995c2be04ea459e985f79269e49faf88248d Gerrit-Change-Number: 81102 Gerrit-PatchSet: 4 Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/brya: Create bujia variant
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81198?usp=email ) Change subject: mb/google/brya: Create bujia variant ...................................................................... mb/google/brya: Create bujia variant Create the bujia variant of the brask reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:327549688 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_BUJIA Change-Id: I453a50f1aa64f8d4119bf0f860d928aa3e00a144 Signed-off-by: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81198 Reviewed-by: Eric Lai <ericllai(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Kevin Chiu <kevin.chiu.17802(a)gmail.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/bujia/include/variant/ec.h A src/mainboard/google/brya/variants/bujia/include/variant/gpio.h A src/mainboard/google/brya/variants/bujia/overridetree.cb 5 files changed, 32 insertions(+), 0 deletions(-) Approvals: Kevin Chiu: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 0602207..e269b9a 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -164,6 +164,10 @@ select SOC_INTEL_RAPTORLAKE select DRIVERS_GENERIC_NAU8315 +config BOARD_GOOGLE_BUJIA + select BOARD_GOOGLE_BASEBOARD_BRASK + select SOC_INTEL_RAPTORLAKE + config BOARD_GOOGLE_CRAASK select BOARD_GOOGLE_BASEBOARD_NISSA select CHROMEOS_WIFI_SAR if CHROMEOS @@ -604,6 +608,7 @@ default 0x1 if BOARD_GOOGLE_XOL default 0x0 if BOARD_GOOGLE_GLASSWAY default 0x1 if BOARD_GOOGLE_NOVA + default 0x1 if BOARD_GOOGLE_BUJIA config DRIVER_TPM_I2C_ADDR hex @@ -689,6 +694,7 @@ default "Xol" if BOARD_GOOGLE_XOL default "Glassway" if BOARD_GOOGLE_GLASSWAY default "Nova" if BOARD_GOOGLE_NOVA + default "Bujia" if BOARD_GOOGLE_BUJIA config VARIANT_DIR default "brya0" if BOARD_GOOGLE_BRYA0 @@ -745,6 +751,7 @@ default "xol" if BOARD_GOOGLE_XOL default "glassway" if BOARD_GOOGLE_GLASSWAY default "nova" if BOARD_GOOGLE_NOVA + default "bujia" if BOARD_GOOGLE_BUJIA config VBOOT select VBOOT_EARLY_EC_SYNC if !BOARD_GOOGLE_BASEBOARD_NISSA diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index c126558..e0e752c 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -163,3 +163,6 @@ config BOARD_GOOGLE_NOVA bool "-> Nova" + +config BOARD_GOOGLE_BUJIA + bool "-> Bujia" diff --git a/src/mainboard/google/brya/variants/bujia/include/variant/ec.h b/src/mainboard/google/brya/variants/bujia/include/variant/ec.h new file mode 100644 index 0000000..7a2a6ff --- /dev/null +++ b/src/mainboard/google/brya/variants/bujia/include/variant/ec.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef __VARIANT_EC_H__ +#define __VARIANT_EC_H__ + +#include <baseboard/ec.h> + +#endif diff --git a/src/mainboard/google/brya/variants/bujia/include/variant/gpio.h b/src/mainboard/google/brya/variants/bujia/include/variant/gpio.h new file mode 100644 index 0000000..c4fe342 --- /dev/null +++ b/src/mainboard/google/brya/variants/bujia/include/variant/gpio.h @@ -0,0 +1,8 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#ifndef VARIANT_GPIO_H +#define VARIANT_GPIO_H + +#include <baseboard/gpio.h> + +#endif diff --git a/src/mainboard/google/brya/variants/bujia/overridetree.cb b/src/mainboard/google/brya/variants/bujia/overridetree.cb new file mode 100644 index 0000000..4f2c04a --- /dev/null +++ b/src/mainboard/google/brya/variants/bujia/overridetree.cb @@ -0,0 +1,6 @@ +chip soc/intel/alderlake + + device domain 0 on + end + +end -- To view, visit https://review.coreboot.org/c/coreboot/+/81198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I453a50f1aa64f8d4119bf0f860d928aa3e00a144 Gerrit-Change-Number: 81198 Gerrit-PatchSet: 8 Gerrit-Owner: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: util/intelmetool: Print the address in `map_physical` errors in hex
by Martin L Roth (Code Review) 17 Mar '24

17 Mar '24

Attention is currently required from: Christian Walter, Máté Kukri, Nico Huber. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81191?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: util/intelmetool: Print the address in `map_physical` errors in hex ...................................................................... Patch Set 1: (1 comment) File util/intelmetool/mmap.c: https://review.coreboot.org/c/coreboot/+/81191/comment/85fe2c37_81fa4c49 : PS1, Line 22: (intmax_t)phys_addr, len, err, strerror(err)); > That's for `j`, which is only a length modifier. `x` is the conversion specifier and unsigned. I'm with Nico on this. An address value shouldn't be signed. I know that it's not *strictly* part of what you're changing here, but I think it's be best to update both at the same time if you wouldn't mind. -- To view, visit https://review.coreboot.org/c/coreboot/+/81191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib97bd86ee0e0c8fe8c3785e22a4d9f6def3cae61 Gerrit-Change-Number: 81191 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Sun, 17 Mar 2024 16:41:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: src/Kconfig: Make it possible to override CCACHE in site-local
by Arthur Heymans (Code Review) 17 Mar '24

17 Mar '24

Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81267?usp=email ) Change subject: src/Kconfig: Make it possible to override CCACHE in site-local ...................................................................... src/Kconfig: Make it possible to override CCACHE in site-local The value for CCACHE in site-local/Kconfig gets overridden by the default in src/Kconfig. Remove the default to make overrides possible. Change-Id: I6b9dbbb31caa3ef09afd7ecb355c01bd53807b39 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81267 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/src/Kconfig b/src/Kconfig index c895492..3a9a4e8 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -109,7 +109,6 @@ config CCACHE bool "Use ccache to speed up (re)compilation" - default n help Enables the use of ccache for faster builds. -- To view, visit https://review.coreboot.org/c/coreboot/+/81267?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6b9dbbb31caa3ef09afd7ecb355c01bd53807b39 Gerrit-Change-Number: 81267 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024