coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[S] Change in coreboot[master]: soc/intel/common/block/cse/Kconfig: Remove unused symbols
by Jon Murphy (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Elyes Haouas. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76693?usp=email ) Change subject: soc/intel/common/block/cse/Kconfig: Remove unused symbols ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > All of these items are used downstream in ChromeOS. […] https://source.chromium.org/search?q=CSE_IOMP_FILE&ss=chromiumos https://source.chromium.org/search?q=CSE_PMCP_FILE&ss=chromiumos https://source.chromium.org/search?q=CSE_TBTP_FILE&sq=&ss=chromiumos https://source.chromium.org/search?q=CSE_PCHC_FILE&ss=chromiumos https://source.chromium.org/search?q=CSE_IUNP_FILE&sq=&ss=chromiumos https://source.chromium.org/search?q=CSE_OEMP_FILE&ss=chromiumos -- To view, visit https://review.coreboot.org/c/coreboot/+/76693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35742721e049102a3e153b857824073a5d257cc3 Gerrit-Change-Number: 76693 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/cse/Kconfig: Remove unused symbols
by Jon Murphy (Code Review) 20 Mar '24

20 Mar '24

Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76693?usp=email ) Change subject: soc/intel/common/block/cse/Kconfig: Remove unused symbols ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: All of these items are used downstream in ChromeOS. We will need to determine a solution for managing this downstream or keeping it in place upstream. Adding a few Googlers for visibility and to work a solution. -- To view, visit https://review.coreboot.org/c/coreboot/+/76693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35742721e049102a3e153b857824073a5d257cc3 Gerrit-Change-Number: 76693 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vendorcode/cavium: Use unsigned integers in struct bitfields
by Felix Singer (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Arthur Heymans, Paul Menzel. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80638?usp=email ) Change subject: vendorcode/cavium: Use unsigned integers in struct bitfields ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b2add2f1078a88347fea7dc65d422d0e5a210a1 Gerrit-Change-Number: 80638 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:00:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: vendorcode/cavium: Use unsigned integers in struct bitfields
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Felix Singer, Paul Menzel. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80638?usp=email ) Change subject: vendorcode/cavium: Use unsigned integers in struct bitfields ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80638/comment/004842b5_06d861e3 : PS1, Line 7: Fix bitfields with signed integers > Maybe: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80638?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b2add2f1078a88347fea7dc65d422d0e5a210a1 Gerrit-Change-Number: 80638 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:47:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: amdfwtool: Check sanity before filling the data array
by Felix Held (Code Review) 20 Mar '24

20 Mar '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78763?usp=email ) Change subject: amdfwtool: Check sanity before filling the data array ...................................................................... amdfwtool: Check sanity before filling the data array Change-Id: I8284c35a0124ba4588d199024e28d3445c681896 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com>wq Reviewed-on: https://review.coreboot.org/c/coreboot/+/78763 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/amdfwtool/data_parse.c 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Martin L Roth: Looks good to me, approved diff --git a/util/amdfwtool/data_parse.c b/util/amdfwtool/data_parse.c index 728feae..5e06d97 100644 --- a/util/amdfwtool/data_parse.c +++ b/util/amdfwtool/data_parse.c @@ -618,11 +618,16 @@ match[4]: Optional directory level to be dropped match[6]: Optional hash table ID to put the hash for the entry */ - oneline[match[FW_TYPE].rm_eo] = '\0'; - oneline[match[FW_FILE].rm_eo] = '\0'; - oneline[match[OPT_LEVEL].rm_eo] = '\0'; - oneline[match[OPT_HASH_TABLE_ID].rm_eo] = '\0'; - oneline[match[OPT_FWID_TYPE].rm_eo] = '\0'; + if (match[FW_TYPE].rm_eo != -1) + oneline[match[FW_TYPE].rm_eo] = '\0'; + if (match[FW_FILE].rm_eo != -1) + oneline[match[FW_FILE].rm_eo] = '\0'; + if (match[OPT_LEVEL].rm_eo != -1) + oneline[match[OPT_LEVEL].rm_eo] = '\0'; + if (match[OPT_HASH_TABLE_ID].rm_eo != -1) + oneline[match[OPT_HASH_TABLE_ID].rm_eo] = '\0'; + if (match[OPT_FWID_TYPE].rm_eo != -1) + oneline[match[OPT_FWID_TYPE].rm_eo] = '\0'; retval = 1; } else { retval = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/78763?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8284c35a0124ba4588d199024e28d3445c681896 Gerrit-Change-Number: 78763 Gerrit-PatchSet: 8 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: device/pci_device.c: Avoid adding invalid resources
by Felix Held (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Arthur Heymans, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80466?usp=email ) Change subject: device/pci_device.c: Avoid adding invalid resources ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80466/comment/7888103f_a69e3e92 : PS1, Line 10: > Could you give an example? a 32 bit only system can't have resources above 4gb. in this case the old code resulted in the second mmio region to have a base of 4GiB and a limit of 4 GiB - 1, so the limit is lower than the base. the code has a comment about this -- To view, visit https://review.coreboot.org/c/coreboot/+/80466?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60d1f34178a491e66e4e935fd1a3d02451d6ca23 Gerrit-Change-Number: 80466 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/crossgcc: Also build LLVM LD
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Felix Singer, Martin L Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80732?usp=email ) Change subject: util/crossgcc: Also build LLVM LD ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > Not sure why the CI let the build pass, but it failed compiling the toolchain as it couldn't find ninja. I moved this CL before the ninja patch -- To view, visit https://review.coreboot.org/c/coreboot/+/80732?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3242585f8b5c3426fc6568d3dc47300164d56e3a Gerrit-Change-Number: 80732 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/elkhartlake/Kconfig: Rename FSPRel.bin to FSP.fd
by Felix Singer (Code Review) 20 Mar '24

20 Mar '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81344?usp=email ) Change subject: soc/intel/elkhartlake/Kconfig: Rename FSPRel.bin to FSP.fd ...................................................................... soc/intel/elkhartlake/Kconfig: Rename FSPRel.bin to FSP.fd With the last FSP submodule update for Elkhart Lake commit f8df905e7baf ("3rdparty/fsp: Update submodule to upstream master"), the binary name was changed to FSP.fd. Change-Id: Ibc87ea2744e971d58e9a402f7cf04ef3f316f3b8 Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/81344 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M src/soc/intel/elkhartlake/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved diff --git a/src/soc/intel/elkhartlake/Kconfig b/src/soc/intel/elkhartlake/Kconfig index 13fa925..cb080f4 100644 --- a/src/soc/intel/elkhartlake/Kconfig +++ b/src/soc/intel/elkhartlake/Kconfig @@ -191,7 +191,7 @@ config FSP_FD_PATH string depends on FSP_USE_REPO - default "3rdparty/fsp/ElkhartLakeFspBinPkg/FspBin/FSPRel.bin" + default "3rdparty/fsp/ElkhartLakeFspBinPkg/FspBin/FSP.fd" config PSE_ENABLE bool "Enable PSE ARM controller" -- To view, visit https://review.coreboot.org/c/coreboot/+/81344?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibc87ea2744e971d58e9a402f7cf04ef3f316f3b8 Gerrit-Change-Number: 81344 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: util/xcompile: Add target architecture to CPPFLAGS
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Julius Werner, Martin L Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75031?usp=email ) Change subject: util/xcompile: Add target architecture to CPPFLAGS ...................................................................... Patch Set 12: (2 comments) File src/arch/arm/armv4/Makefile.mk: https://review.coreboot.org/c/coreboot/+/75031/comment/a71357fc_5035c8c9 : PS11, Line 20: -target arm-eabi > Generally, I feel like this kind of stuff belongs in xcompile, not in the architecture Makefile. […] Done https://review.coreboot.org/c/coreboot/+/75031/comment/50755912_25d96f26 : PS11, Line 34: verstage-ld-ccopts += -target arm-eabi > nit: this would probably look cleaner if it always came right after the generic-ccopts. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75031?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4340681e30059d6f18a49a49937668cd3dd39ce1 Gerrit-Change-Number: 75031 Gerrit-PatchSet: 12 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 13:40:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Arthur Heymans, Jon Murphy. Hello Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74501?usp=email to look at the new patch set (#24). Change subject: arch/arm64: Add Clang as supported target ...................................................................... arch/arm64: Add Clang as supported target QEMU aarch64 boots to payload when compiled with clang. Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/Kconfig M src/arch/arm64/Kconfig M src/soc/qualcomm/sc7180/Kconfig 3 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/74501/24 -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024