coreboot-gerrit March 2024

coreboot-gerrit@coreboot.org

1 participants
3668 discussions

[NoOp] Change in coreboot[main]: mb/google/zork: Update APCB to increase UMA size to 128MB
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81364?usp=email ) Change subject: mb/google/zork: Update APCB to increase UMA size to 128MB ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81364?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c6487a4cb8155f826d20fd3ceca87859829199c Gerrit-Change-Number: 81364 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:59:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: mb/google/zork: Update APCB to increase UMA size to 128MB
by Martin L Roth (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81364?usp=email ) Change subject: mb/google/zork: Update APCB to increase UMA size to 128MB ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/81364?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c6487a4cb8155f826d20fd3ceca87859829199c Gerrit-Change-Number: 81364 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:54:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[NoOp] Change in coreboot[main]: mb/google/zork: Update APCB to increase UMA size to 128MB
by Matt DeVillier (Code Review) 20 Mar '24

20 Mar '24

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/81364?usp=email ) Change subject: mb/google/zork: Update APCB to increase UMA size to 128MB ...................................................................... mb/google/zork: Update APCB to increase UMA size to 128MB The previous value of 32MB was set to meet Google's ChromeOS reqs, but hampers real-world performance in Linux/Windows, so increase it to 128MB to match the "auto" default for the Picasso UEFI firmware. TEST=build/boot Windows on google/zork (morphius), verify UMA set to 128MB. Change-Id: I8c6487a4cb8155f826d20fd3ceca87859829199c Signed-off-by: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> --- M src/mainboard/google/zork/data.apcb 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/81364/1 diff --git a/src/mainboard/google/zork/data.apcb b/src/mainboard/google/zork/data.apcb index f7a3e78..ee12694 100644 --- a/src/mainboard/google/zork/data.apcb +++ b/src/mainboard/google/zork/data.apcb Binary files differ -- To view, visit https://review.coreboot.org/c/coreboot/+/81364?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8c6487a4cb8155f826d20fd3ceca87859829199c Gerrit-Change-Number: 81364 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Jon Murphy, Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74501?usp=email ) Change subject: arch/arm64: Add Clang as supported target ...................................................................... Patch Set 25: (1 comment) File src/arch/arm64/Kconfig: https://review.coreboot.org/c/coreboot/+/74501/comment/f6e944aa_67fbc75d : PS23, Line 7: default y if ARCH_ARM64 > AFAIK "no" is automatically the default for bool Kconfigs if no other is specified. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 25 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:44:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Jon Murphy. Hello Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74501?usp=email to look at the new patch set (#25). Change subject: arch/arm64: Add Clang as supported target ...................................................................... arch/arm64: Add Clang as supported target QEMU aarch64 boots to payload when compiled with clang. Split up the trogdor config in 2 files as enabling both TPM measured boot and verified boot causes a too large bootblock for sc7180 so use 2 config files to achieve the same level of build testing. Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- R configs/config.google_trogdor.cbfs_verification C configs/config.google_trogdor.tpm_measured_boot M src/arch/arm64/Kconfig 3 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/74501/25 -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 25 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: soc/qualcomm/sc7{1,2}80: Increase romstage/verstage section for clang
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80639?usp=email ) Change subject: soc/qualcomm/sc7{1,2}80: Increase romstage/verstage section for clang ...................................................................... Patch Set 4: (2 comments) File src/soc/qualcomm/sc7180/memlayout.ld: https://review.coreboot.org/c/coreboot/+/80639/comment/66398eef_4a4a3ef9 : PS3, Line 27: REGION(qcsdi, 0x1469C000, 55K, 4K) > You're actually adjusting this downward here, you don't need to do that. […] Done File src/soc/qualcomm/sc7280/memlayout.ld: https://review.coreboot.org/c/coreboot/+/80639/comment/f5d589c2_a5c2e4e5 : PS3, Line 30: REGION(modem_id, 0x146A7000, 4, 4) > Unfortunately modem_id is used as a communication buffer with an external blob and cannot be moved i […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80639?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide01233f209613678c5408f1afab19415c1071be Gerrit-Change-Number: 80639 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mainboard/qemu-riscv: Move DRAM resource setup to read_resources
by Alper Nebi Yasak (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Philipp Hug, ron minnich. Hello Arthur Heymans, Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80379?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Philipp Hug, Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: mainboard/qemu-riscv: Move DRAM resource setup to read_resources ...................................................................... mainboard/qemu-riscv: Move DRAM resource setup to read_resources A previous commit adds PCI support to the qemu-riscv mainboard code, in part by adding a read_resources() function. Move its DRAM resource setup there, similar to qemu-aarch64. Change-Id: Ic171cb7e22d9da2df18a9d171a5ab89c2cd3298b Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> --- M src/mainboard/emulation/qemu-riscv/mainboard.c 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/80379/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic171cb7e22d9da2df18a9d171a5ab89c2cd3298b Gerrit-Change-Number: 80379 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mainboard/qemu-riscv: Add PCI support
by Alper Nebi Yasak (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, ron minnich. Hello Arthur Heymans, Philipp Hug, build bot (Jenkins), ron minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80378?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Arthur Heymans, Verified+1 by build bot (Jenkins) Change subject: mainboard/qemu-riscv: Add PCI support ...................................................................... mainboard/qemu-riscv: Add PCI support Add PCI support for the qemu-riscv mainboard like how it is done for qemu-aarch64. The resulting build can be used with a QEMU command line like: qemu-system-riscv64 \ -display gtk,show-tabs=on \ -bios build/coreboot.rom \ -drive if=pflash,file=build/coreboot.rom,format=raw \ -M virt -m 1G \ -device pcie-root-port \ -serial stdio -device bochs-display \ ... One complication is that the PCIe high MMIO base depends on the amount of available RAM for 64-bit RISC-V VMs [1], but not for 32-bit ones. [1] https://gitlab.com/qemu-project/qemu/-/blob/v8.2.2/hw/riscv/virt.c#L1474-14… Change-Id: Ie57b35620af82c681d1f0d78fa8e514e4df0d2ac Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> --- A src/arch/riscv/include/arch/pci_ops.h M src/mainboard/emulation/qemu-riscv/Kconfig M src/mainboard/emulation/qemu-riscv/devicetree.cb M src/mainboard/emulation/qemu-riscv/include/mainboard/addressmap.h M src/mainboard/emulation/qemu-riscv/mainboard.c 5 files changed, 64 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/80378/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80378?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie57b35620af82c681d1f0d78fa8e514e4df0d2ac Gerrit-Change-Number: 80378 Gerrit-PatchSet: 2 Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Alper Nebi Yasak <alpernebiyasak(a)gmail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Arthur Heymans (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Jon Murphy. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74501?usp=email ) Change subject: arch/arm64: Add Clang as supported target ...................................................................... Patch Set 24: (1 comment) Patchset: PS24: I need https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_refere… to be in vboot for clang to be happy with the new neon code. -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 24 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/block/cse/Kconfig: Remove unused symbols
by Jon Murphy (Code Review) 20 Mar '24

20 Mar '24

Attention is currently required from: Elyes Haouas. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76693?usp=email ) Change subject: soc/intel/common/block/cse/Kconfig: Remove unused symbols ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > https://source.chromium.org/search?q=CSE_IOMP_FILE&ss=chromiumos […] Just noticed the revert. We should come up with a long term plan, but we are ok for now. I'll add a skip to the downstream bot so this doesn't conflict again. -- To view, visit https://review.coreboot.org/c/coreboot/+/76693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I35742721e049102a3e153b857824073a5d257cc3 Gerrit-Change-Number: 76693 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 20 Mar 2024 14:25:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2024