coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[XS] Change in coreboot[main]: mb/google/brox: Disable Early EC Sync
by Shelley Chen (Code Review) 21 Feb '24

21 Feb '24

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80689?usp=email ) Change subject: mb/google/brox: Disable Early EC Sync ...................................................................... mb/google/brox: Disable Early EC Sync Early EC Sync does not need to be enabled in coreboot as EFS2 is being enabled in the EC. BUG=b:326152804 BRANCH=None TEST=emerge-brox coreboot To be tested with EC sync enabled Change-Id: I08bdbe9f3dcea837b0b148adc137c03d3461877a Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/brox/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/80689/1 diff --git a/src/mainboard/google/brox/Kconfig b/src/mainboard/google/brox/Kconfig index 007328f..2260fe1 100644 --- a/src/mainboard/google/brox/Kconfig +++ b/src/mainboard/google/brox/Kconfig @@ -111,7 +111,6 @@ default "brox" if BOARD_GOOGLE_BROX config VBOOT - select VBOOT_EARLY_EC_SYNC select VBOOT_LID_SWITCH config DIMM_SPD_SIZE -- To view, visit https://review.coreboot.org/c/coreboot/+/80689?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I08bdbe9f3dcea837b0b148adc137c03d3461877a Gerrit-Change-Number: 80689 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Add kconfig for Twin Lake
by Subrata Banik (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Kapil Porwal, Nick Vaccaro. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80688?usp=email ) Change subject: soc/intel/alderlake: Add kconfig for Twin Lake ...................................................................... Patch Set 1: (2 comments) File src/soc/intel/alderlake/Kconfig: https://review.coreboot.org/c/coreboot/+/80688/comment/0eb9b4b8_34925495 : PS1, Line 113: and SOC_INTEL_ALDERLAKE_PCH_N together not needed ``` config SOC_INTEL_TWINLAKE bool select SOC_INTEL_ALDERLAKE_PCH_N help Intel Twinlake support. Mainboards using TWL should select SOC_INTEL_TWINLAKE. ``` https://review.coreboot.org/c/coreboot/+/80688/comment/3cf24e41_e3e6c349 : PS1, Line 406: alderlake_n shouldn't this be `twinlake` -- To view, visit https://review.coreboot.org/c/coreboot/+/80688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie4c5d137ee54512313344f853e7ca66d1fd25003 Gerrit-Change-Number: 80688 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:56:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
by Elyes Haouas (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Balázs Vinarz, Mike Banon, Vlado Ilic. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email ) Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > This is really ugly & not easy to review .... ! […] then* flash the board ... -- To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c Gerrit-Change-Number: 79838 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com> Gerrit-CC: awokd(a)danwin1210.me Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
by Elyes Haouas (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Balázs Vinarz, Mike Banon, Vlado Ilic. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79838?usp=email ) Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: This is really ugly & not easy to review .... ! what if you just run this (just copy paste this line and hit enter ): "git reset --hard origin/main && git pull && git submodule update --init --checkout && make crossgcc-clean && make crossgcc && git checkout 5e8e911b7caee021faff96c4e82a77a42544ea62 && make distclean && make menuconfig && make" the flash the board and check if it is ok or not. -- To view, visit https://review.coreboot.org/c/coreboot/+/79838?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia97e80ffaad9459e54ff5cb01f20d9129241433c Gerrit-Change-Number: 79838 Gerrit-PatchSet: 6 Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Reviewer: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Vlado Ilic <kakonema(a)gmail.com> Gerrit-CC: awokd(a)danwin1210.me Gerrit-Attention: Balázs Vinarz <vinibali1(a)gmail.com> Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com> Gerrit-Attention: Vlado Ilic <kakonema(a)gmail.com> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:53:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XL] Change in coreboot[main]: libpayload: Remove legacy CBFS API
by Maximilian Brune (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Julius Werner. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80650?usp=email ) Change subject: libpayload: Remove legacy CBFS API ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80650?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ed157ac2d1376b8dff4537af9a63731064b45f6 Gerrit-Change-Number: 80650 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:35:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake: Add kconfig for Twin Lake
by Kapil Porwal (Code Review) 21 Feb '24

21 Feb '24

Kapil Porwal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80688?usp=email ) Change subject: soc/intel/alderlake: Add kconfig for Twin Lake ...................................................................... soc/intel/alderlake: Add kconfig for Twin Lake Mainboards using Twin Lake (TWL) shall select SOC_INTEL_TWINLAKE and SOC_INTEL_ALDERLAKE_PCH_N together. BRANCH=firmware-nissa-15217.B TEST=Build and boot Google/Yaviks with Twin Lake kconfig enabled Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Change-Id: Ie4c5d137ee54512313344f853e7ca66d1fd25003 --- M src/soc/intel/alderlake/Kconfig 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/80688/1 diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 8411e76..4f1958f 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -106,6 +106,12 @@ Intel Raptorlake support. Mainboards using RPL should select SOC_INTEL_RAPTORLAKE and SOC_INTEL_ALDERLAKE_PCH_* together. +config SOC_INTEL_TWINLAKE + bool + help + Intel Twinlake support. Mainboards using TWL should select + SOC_INTEL_TWINLAKE and SOC_INTEL_ALDERLAKE_PCH_N together. + config SOC_INTEL_ALDERLAKE_PCH_M bool select SOC_INTEL_ALDERLAKE @@ -397,6 +403,7 @@ config FSP_HEADER_PATH string "Location of FSP headers" + default "src/vendorcode/intel/fsp/fsp2_0/alderlake_n/" if SOC_INTEL_TWINLAKE && !FSP_USE_REPO default "src/vendorcode/intel/fsp/fsp2_0/alderlake_n/" if SOC_INTEL_ALDERLAKE_PCH_N && !FSP_USE_REPO default "src/vendorcode/intel/fsp/fsp2_0/raptorlake/" if SOC_INTEL_RAPTORLAKE && !FSP_USE_REPO default "3rdparty/fsp/RaptorLakeFspBinPkg/IoT/RaptorLakeS/Include/" if SOC_INTEL_RAPTORLAKE_PCH_S && FSP_TYPE_IOT -- To view, visit https://review.coreboot.org/c/coreboot/+/80688?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie4c5d137ee54512313344f853e7ca66d1fd25003 Gerrit-Change-Number: 80688 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake)
by Michał Kopeć (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Nicholas Sudsgaard, Paul Menzel. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80610?usp=email ) Change subject: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake) ...................................................................... Patch Set 8: (2 comments) File src/mainboard/lenovo/m900_tiny/devicetree.cb: https://review.coreboot.org/c/coreboot/+/80610/comment/0221e64e_41dfc940 : PS7, Line 4: register "s0ix_enable" = "0" > Another one set to 0 ;) Ah, removed :) https://review.coreboot.org/c/coreboot/+/80610/comment/bf297e8d_9913e546 : PS7, Line 192: #register "gen4_dec" = "0x000c0081" > Are these supposed to be commented out? Yes, I got these from vendor firmware and kept them for reference, I can remove them, it's no problem. Removed. -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:32:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake)
by Michał Kopeć (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Alexander Couzens, Arthur Heymans, Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Nicholas Sudsgaard, Paul Menzel. Hello Alexander Couzens, Arthur Heymans, Felix Singer, Krystian Hebel, Maciej Pijanowski, Michał Żygowski, Nicholas Sudsgaard, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80610?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+2 by Felix Singer, Verified+1 by build bot (Jenkins) Change subject: mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake) ...................................................................... mb/lenovo: Add ThinkCentre M700/M900 Tiny board (Skylake/Kaby Lake) The M700 / M900 Tiny boards are USFF PCs that come with Skylake LGA1151 processors. M700 comes with B150 chipset, M900 comes with Q170 and is vPro capable. There is an onboard discrete TPM 1.2. Intel PTT fTPM can also be enabled in vendor FW, but for now it's not used here. LPSS UART for debugging is available on pins 17,18 on the underside of the mainboard, but it is not enabled by default. Tested unit is M900 with i5-6500T. Boots to Fedora 38 w/ kernel 6.5.5 and Windows 11. Tested and working: - Serial port (via optional module) - Rear DisplayPort connectors - Graphics w/ libgfxinit - Ethernet - SATA - NVMe - Internal speaker, front combo jack, rear line-out - Discrete TPM 1.2 - USB ports (Port 1 untested, apparently broken on my unit) - M.2 2230 Wi-Fi slot (needs ASPM L1s disabled) - S3 suspend - ME disable via NVRAM setting Untested: - Front mic input - Optional expansion headers: DisplayPort, USB, PS/2, SATA / PCIe Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Signed-off-by: Michał Kopeć <michal.kopec(a)3mdeb.com> --- A src/mainboard/lenovo/m900_tiny/Kconfig A src/mainboard/lenovo/m900_tiny/Kconfig.name A src/mainboard/lenovo/m900_tiny/Makefile.mk A src/mainboard/lenovo/m900_tiny/acpi/ec.asl A src/mainboard/lenovo/m900_tiny/acpi/superio.asl A src/mainboard/lenovo/m900_tiny/board_info.txt A src/mainboard/lenovo/m900_tiny/bootblock.c A src/mainboard/lenovo/m900_tiny/cmos.default A src/mainboard/lenovo/m900_tiny/cmos.layout A src/mainboard/lenovo/m900_tiny/data.vbt A src/mainboard/lenovo/m900_tiny/devicetree.cb A src/mainboard/lenovo/m900_tiny/dsdt.asl A src/mainboard/lenovo/m900_tiny/gma-mainboard.ads A src/mainboard/lenovo/m900_tiny/gpio.c A src/mainboard/lenovo/m900_tiny/gpio_early.c A src/mainboard/lenovo/m900_tiny/hda_verb.c A src/mainboard/lenovo/m900_tiny/include/mainboard/gpio.h A src/mainboard/lenovo/m900_tiny/ramstage.c A src/mainboard/lenovo/m900_tiny/romstage.c 19 files changed, 854 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/80610/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/80610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6786e068ec03c8bf243e1767cd7b9d50512ea77f Gerrit-Change-Number: 80610 Gerrit-PatchSet: 8 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp: Add memory type check utils
by Lean Sheng Tan (Code Review) 21 Feb '24

21 Feb '24

Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Jincheng Li, Johnny Lin, Nico Huber, Patrick Rudolph, Shuo Liu, Tim Chu. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80632?usp=email ) Change subject: soc/intel/xeon_sp: Add memory type check utils ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/80632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f5f3c0f16dc50bc739146e46afce2e5fbf4f62c Gerrit-Change-Number: 80632 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Wed, 21 Feb 2024 16:23:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Lean Sheng Tan (Code Review) 21 Feb '24

21 Feb '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80615?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id 507ef01: 2024-01-11 10:49:14 +0800 - (IoT ADL-S MR6 (4115_09) FSP) to commit id dd98487: 2024-02-16 17:16:05 -0800 - (Fix EagleStreamFspBinPkg Path) This brings in 6 new commits: dd98487 Fix EagleStreamFspBinPkg Path fcf623b Fix MAX_VMD_STACKS_PER_SOCKET e07f875 Fix EagleStream BSF File 85f37ab Idaville FSP - New UPDs for SSC 98e497f IoT RPL-P MR1 (4445_03) FSP fc5e3c9 IoT RPL-P MR1 (4445_03) FSP Change-Id: If7d852e1a92d8409a5161797c0aa3a55a71c8b49 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80615 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved diff --git a/3rdparty/fsp b/3rdparty/fsp index 507ef01..dd98487 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 507ef01cce16dc1e1af898e60de96dbb8e9d6d17 +Subproject commit dd98487fdef49068cf0df5e88ea886c1884ef510 -- To view, visit https://review.coreboot.org/c/coreboot/+/80615?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7d852e1a92d8409a5161797c0aa3a55a71c8b49 Gerrit-Change-Number: 80615 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024