coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[M] Change in coreboot[main]: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
by CoolStar (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: CoolStar, Matt DeVillier, Nick Vaccaro, Subrata Banik. Hello Matt DeVillier, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80719?usp=email to look at the new patch set (#3). Change subject: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL ...................................................................... soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL Port fix from Alder Lake to not set/reset IOM MCTP during D3 cold entry or exit. Ports 5008d340033d9289dade91569e356f9317f9b3a9 (soc/intel/adl: Remove IOM Mctp command from TCSS ASL): ` Recently as part of s0ix hang issue, it was found that sending IOM MCTP command as part of TCSS D3 Cold enter-exit sequence created an issue. We discovered that due to change in hardware sequence, ADL should not set/reset IOM MCTP during D3 cold entry or exit. This patch removes the bit setting from ASL file to prevent hang in the system. This patch also removes obsolete Pcode mailbox communication which is no longer required for ADL. BUG=b:220796339 BRANCH=firmware-brya-14505.B TEST=Check if hang issue is resolved with the CL and no other regression observed https://review.coreboot.org/c/coreboot/+/62861 ` Test: build/boot drobit to Win11. Verify TCSS XHCI power management working and USB Root Hub doesn't Code 43 in device manager Change-Id: I40a537fd2b0c821caf282f52aaff1874f54325f1 Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> --- M src/soc/intel/tigerlake/acpi/tcss.asl 1 file changed, 1 insertion(+), 142 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/80719/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80719?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40a537fd2b0c821caf282f52aaff1874f54325f1 Gerrit-Change-Number: 80719 Gerrit-PatchSet: 3 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
by CoolStar (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: CoolStar, Matt DeVillier, Nick Vaccaro, Subrata Banik. Hello Matt DeVillier, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80718?usp=email to look at the new patch set (#2). Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device ...................................................................... soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device Port 9c348a7b7ea3422a74af9b820275751e9abb4a12 (soc/intel/alderlake: Fix processor hang while plug unplug of TBT device) from Alder Lake to fix a similar issue present on Tiger Lake: `Processor hang is observed while hot plug unplug of TBT device. BIOS should execute TBT PCIe RP RTD3 flow based on the value of TBT_DMA_CFG_VS_CAP_9[30]. It should skip TBT PCIe RP RTD3 flow, if BIT30 in TBT FW version is not set. BUG=b:194880254 https://review.coreboot.org/c/coreboot/+/56503 ` Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c Signed-off-by: CoolStar <coolstarorganization(a)gmail.com> --- M src/soc/intel/tigerlake/acpi/tcss.asl M src/soc/intel/tigerlake/acpi/tcss_dma.asl 2 files changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80718/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c Gerrit-Change-Number: 80718 Gerrit-PatchSet: 2 Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Kapil Porwal, Paz Zcharya, Shelley Chen. Hello Kapil Porwal, Paz Zcharya, Shelley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80738?usp=email to look at the new patch set (#5). Change subject: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection ...................................................................... vc/google/chromeos: Enable dynamic ChromeOS boot logo selection * Introduces logic to display context-specific boot splash logos. * Logo selection considers: * Chromebook-Plus hardware compliance (using factory_config). * VPD-based product segmentation (soft-branded vs. regular chromebook). * Default Chromebook logo as fallback for regular chromebook. BUG=b:324107408 TEST=Verified logo selection based on compliance and product requirements. Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/Makefile.mk M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/splash.c M src/vendorcode/google/chromeos/tpm_factory_config.c A src/vendorcode/google/chromeos/vpd_device_feature.c 5 files changed, 92 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/80738/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: Documentation/tutorial/part1.md: Update Debian packages
by Juan José García-Castro Crespo (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Martin L Roth. Juan José García-Castro Crespo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80722?usp=email ) Change subject: Documentation/tutorial/part1.md: Update Debian packages ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/80722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5df06611a934d1ef85c8335764f4f6e0f241c9a9 Gerrit-Change-Number: 80722 Gerrit-PatchSet: 1 Gerrit-Owner: Juan José García-Castro Crespo Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 18:21:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Kapil Porwal, Paz Zcharya, Shelley Chen. Hello Kapil Porwal, Paz Zcharya, Shelley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80738?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection ...................................................................... vc/google/chromeos: Enable dynamic ChromeOS boot logo selection * Introduces logic to display context-specific boot splash logos. * Logo selection considers: * Chromebook-Plus hardware compliance (using factory_config). * VPD-based product segmentation (soft-branded vs. regular chromebook). * Default Chromebook logo as fallback for regular chromebook. BUG=b:324107408 TEST=Verified logo selection based on compliance and product requirements. Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/Makefile.mk M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/splash.c M src/vendorcode/google/chromeos/tpm_factory_config.c A src/vendorcode/google/chromeos/vpd_device_feature.c 5 files changed, 93 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/80738/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: util/crossgcc/buildgcc: Use Intel mirror for ACPICA
by Felix Singer (Code Review) 24 Feb '24

24 Feb '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80721?usp=email ) Change subject: util/crossgcc/buildgcc: Use Intel mirror for ACPICA ...................................................................... util/crossgcc/buildgcc: Use Intel mirror for ACPICA Change-Id: If3738b0cdab07c37ac1459a53e399e5de54435d5 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/crossgcc/buildgcc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/80721/1 diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index e90117c..9255c1e 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -40,7 +40,7 @@ MPC_VERSION=1.3.1 GCC_VERSION=13.2.0 BINUTILS_VERSION=2.42 -IASL_VERSION="R06_28_23" +IASL_VERSION="20230628" # CLANG version number CLANG_VERSION=17.0.6 CMAKE_VERSION=3.27.7 @@ -52,7 +52,7 @@ MPC_ARCHIVE="mpc-${MPC_VERSION}.tar.gz" GCC_ARCHIVE="gcc-${GCC_VERSION}.tar.xz" BINUTILS_ARCHIVE="binutils-${BINUTILS_VERSION}.tar.xz" -IASL_ARCHIVE="${IASL_VERSION}.tar.gz" +IASL_ARCHIVE="acpica-unix-${IASL_VERSION}.tar.gz" # CLANG toolchain FILE locations LLVM_ARCHIVE="llvm-${CLANG_VERSION}.src.tar.xz" CLANG_ARCHIVE="clang-${CLANG_VERSION}.src.tar.xz" @@ -72,7 +72,7 @@ MPC_BASE_URL="https://ftpmirror.gnu.org/mpc" GCC_BASE_URL="https://ftpmirror.gnu.org/gcc/gcc-${GCC_VERSION}" BINUTILS_BASE_URL="https://ftpmirror.gnu.org/binutils" -IASL_BASE_URL="https://github.com/acpica/acpica/archive/refs/tags" +IASL_BASE_URL="https://downloadmirror.intel.com/783534" # CLANG toolchain archive locations LLVM_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" CLANG_BASE_URL="https://github.com/llvm/llvm-project/releases/download/llvmorg-${CLANG_VERS…" -- To view, visit https://review.coreboot.org/c/coreboot/+/80721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If3738b0cdab07c37ac1459a53e399e5de54435d5 Gerrit-Change-Number: 80721 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection
by Subrata Banik (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Kapil Porwal, Paz Zcharya, Shelley Chen. Hello Kapil Porwal, Paz Zcharya, Shelley Chen, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80738?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vc/google/chromeos: Enable dynamic ChromeOS boot logo selection ...................................................................... vc/google/chromeos: Enable dynamic ChromeOS boot logo selection * Introduces logic to display context-specific boot splash logos. * Logo selection considers: * Chromebook-Plus hardware compliance (using factory_config). * VPD-based product segmentation (soft-branded vs. regular chromebook). * Default Chromebook logo as fallback for regular chromebook. BUG=b:324107408 TEST=Verified logo selection based on compliance and product requirements. Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/vendorcode/google/chromeos/Makefile.mk M src/vendorcode/google/chromeos/chromeos.h M src/vendorcode/google/chromeos/splash.c M src/vendorcode/google/chromeos/tpm_factory_config.c A src/vendorcode/google/chromeos/vpd_device_feature.c 5 files changed, 93 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/80738/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/80738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9bb1e868764738333977bd8c990bea4253c9d37b Gerrit-Change-Number: 80738 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paz Zcharya <pazz(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Paz Zcharya <pazz(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: include/device: Merge enums from azalia_device.h and azalia.h
by Nico Huber (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Michael Niewöhner, Nicholas Chin, Nicholas Sudsgaard. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email ) Change subject: include/device: Merge enums from azalia_device.h and azalia.h ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80695/comment/fa9ac821_d53f6e3e : PS3, Line 15: - All enum names now use the `AZALIA_` prefix. > I don't have a very strong opionion, let's see what others think If I had a strong opinion, I'd have told you already :) If in doubt, I always say it's up to the author. So IMO it's your call, Nicholas. Looking at the two boards, I'd say keep the prefix if you'd do one line per argument anyway. Or drop the prefix if you'd want to save lines then. (also see other comment about scoping) File src/include/device/azalia_device.h: https://review.coreboot.org/c/coreboot/+/80695/comment/acc96df5_bb1c6fa6 : PS4, Line 128: conn If I'm not mistaken, you could do `AZALIA_##conn` here. Then the macro user wouldn't have to provide the AZALIA_ prefix for every argument. But the enum values still would have the prefix to not pollute the global scope. -- To view, visit https://review.coreboot.org/c/coreboot/+/80695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Gerrit-Change-Number: 80695 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 17:27:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: include/device: Merge enums from azalia_device.h and azalia.h
by Michael Niewöhner (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Nicholas Chin, Nicholas Sudsgaard, Nico Huber. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email ) Change subject: include/device: Merge enums from azalia_device.h and azalia.h ...................................................................... Patch Set 4: (1 comment) File src/include/device/azalia_device.h: https://review.coreboot.org/c/coreboot/+/80695/comment/8d253e7e_9528a660 : PS3, Line 85: = 0x2, > I would use explicit values too, when they have to match a spec or any other […] fine for me, thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/80695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Gerrit-Change-Number: 80695 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 16:36:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: include/device: Merge enums from azalia_device.h and azalia.h
by Michael Niewöhner (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Nicholas Chin, Nicholas Sudsgaard. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80695?usp=email ) Change subject: include/device: Merge enums from azalia_device.h and azalia.h ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80695/comment/b661cedf_269dbb3d : PS3, Line 15: - All enum names now use the `AZALIA_` prefix. > I stated my reason here: https://review.coreboot.org/c/coreboot/+/80577/comments/d3f8e945_d2cbea76. […] Thanks for pointing me there. Well, I think that it's pretty unlikely that any of these would ever conflict with something else. Also, if that ever happens, prefixes could still be added. I don't have a very strong opionion, let's see what others think -- To view, visit https://review.coreboot.org/c/coreboot/+/80695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie874b083a18963679981a9cd2b25d123890d628e Gerrit-Change-Number: 80695 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 16:14:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024