coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3066 discussions

[XS] Change in coreboot[main]: lib: Explicitly declare heap as NOLOAD
by Arthur Heymans (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Maximilian Brune. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email ) Change subject: lib: Explicitly declare heap as NOLOAD ...................................................................... Patch Set 4: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/80735/comment/db65e65a_0e310f22 : PS4, Line 120: .bss . : { > By the way: > Doesn't the same apply to the bss section? Bss is initialized on load. -- To view, visit https://review.coreboot.org/c/coreboot/+/80735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Gerrit-Change-Number: 80735 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 06:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/haswell: Disable iGPU when dGPU is used
by Leah Rowe (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Angel Pons, Arthur Heymans, Nico Huber. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email ) Change subject: nb/haswell: Disable iGPU when dGPU is used ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/haswell/gma.c: https://review.coreboot.org/c/coreboot/+/80717/comment/1c07b095_5bf0e2fc : PS2, Line 469: dev->enabled = 0; > yes i copied the ivybridge code Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b Gerrit-Change-Number: 80717 Gerrit-PatchSet: 2 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 04:19:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: nb/haswell: Disable iGPU when dGPU is used
by Leah Rowe (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Angel Pons, Arthur Heymans, Nico Huber. Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80717?usp=email ) Change subject: nb/haswell: Disable iGPU when dGPU is used ...................................................................... Patch Set 2: (1 comment) File src/northbridge/intel/haswell/gma.c: https://review.coreboot.org/c/coreboot/+/80717/comment/2d346dbd_f0df6482 : PS2, Line 469: dev->enabled = 0; > There's still the chance that there is a GFX card in another slot. Which is, […] yes i copied the ivybridge code -- To view, visit https://review.coreboot.org/c/coreboot/+/80717?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1df0a3aa42f8475b7741007bf3e28c2e089d916b Gerrit-Change-Number: 80717 Gerrit-PatchSet: 2 Gerrit-Owner: Leah Rowe <leahleahrowerowe(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 04:14:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Kconfig: Allow other Kconfig files to override the default
by Maximilian Brune (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Nico Huber, Yu-Ping Wu. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80580?usp=email ) Change subject: Kconfig: Allow other Kconfig files to override the default ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80580/comment/2373ea17_1ed27cc0 : PS1, Line 7: Kconfig: Allow other Kconfig files to override the default > The patch is specific to `config SEPARATE_ROMSTAGE`, right? […] I agree. Especially when searching for the commit in the git log or gerrit it is useful if SEPARATE_ROMSTAGE is in the title or at least in the commit-msg. -- To view, visit https://review.coreboot.org/c/coreboot/+/80580?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09ab5f8c79917bf93c9d5c9dfd157c652478b186 Gerrit-Change-Number: 80580 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Sat, 24 Feb 2024 03:24:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lib: Explicitly declare heap as NOLOAD
by Maximilian Brune (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Arthur Heymans. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email ) Change subject: lib: Explicitly declare heap as NOLOAD ...................................................................... Patch Set 4: (1 comment) File src/lib/program.ld: https://review.coreboot.org/c/coreboot/+/80735/comment/6d0f1eee_00e62400 : PS4, Line 120: .bss . : { By the way: Doesn't the same apply to the bss section? -- To view, visit https://review.coreboot.org/c/coreboot/+/80735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Gerrit-Change-Number: 80735 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 02:55:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: lib: Explicitly declare heap as NOLOAD
by Julius Werner (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email ) Change subject: lib: Explicitly declare heap as NOLOAD ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80735?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335 Gerrit-Change-Number: 80735 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 02:06:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: lib: Remove heap from rmodules
by Julius Werner (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80733?usp=email ) Change subject: lib: Remove heap from rmodules ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80733?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bc049a5231dabbec1c962a99ef875eddcc4ac6e Gerrit-Change-Number: 80733 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 02:06:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vboot: Enable new arm64 SIMD crypto acceleration
by Julius Werner (Code Review) 24 Feb '24

24 Feb '24

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80710?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: vboot: Enable new arm64 SIMD crypto acceleration ...................................................................... vboot: Enable new arm64 SIMD crypto acceleration This patch passes the correct flag to vboot to enable SIMD crypto acceleration on arm64 devices. This uses a core part of the ISA and should thus be supported on all arm64 SoCs -- so we normally always want it enabled, but there should still be a Kconfig in case a SoC wants to use the hwcrypto interface for its own (off-CPU) crypto acceleration engine instead. (You could also disable it to save a small amount of code size at the cost of speed, if necessary.) Change-Id: I3820bd6b7505202b7edb6768385ce5deb18777a4 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80710 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M payloads/libpayload/vboot/Kconfig M payloads/libpayload/vboot/Makefile.mk M src/security/vboot/Kconfig M src/security/vboot/Makefile.mk 4 files changed, 26 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/payloads/libpayload/vboot/Kconfig b/payloads/libpayload/vboot/Kconfig index 23d61f4..6d71a7c 100644 --- a/payloads/libpayload/vboot/Kconfig +++ b/payloads/libpayload/vboot/Kconfig @@ -49,4 +49,16 @@ help This option enables SHA256 implementation using ARMv8 Crypto Extension. +config VBOOT_ARM64_RSA_ACCELERATION + bool "Use arm64 SIMD instructions to accelerate RSA signature verification" + default y + depends on ARCH_ARM64 + help + Use arm64 SIMD instructions (NEON) to parallelize two multiplications + in the modulus exponentiation algorithm, which speeds up RSA signature + verification in vboot. This is supported on all arm64 CPUs so you'd + generally always want this enabled, unless your SoC is overriding + vboot's hwcrypto API with its own crypto accelerator IP instead (or + you're trying really hard to save on code size). + endif diff --git a/payloads/libpayload/vboot/Makefile.mk b/payloads/libpayload/vboot/Makefile.mk index bdc9ad2a..554fec8 100644 --- a/payloads/libpayload/vboot/Makefile.mk +++ b/payloads/libpayload/vboot/Makefile.mk @@ -46,6 +46,7 @@ X86_SHA_EXT=$(call kconfig-to-binary, $(CONFIG_LP_VBOOT_X86_SHA_EXT)) \ VB2_X86_RSA_ACCELERATION=$(call kconfig-to-binary, $(CONFIG_LP_VBOOT_X86_RSA_ACCELERATION)) \ ARMV8_CRYPTO_EXT=$(call kconfig-to-binary, $(CONFIG_LP_VBOOT_SHA_ARMV8_CE)) \ + ARM64_RSA_ACCELERATION=$(call kconfig-to-binary, $(CONFIG_LP_VBOOT_ARM64_RSA_ACCELERATION)) \ UNROLL_LOOPS=1 \ BUILD="$(VBOOT_BUILD_DIR)" \ V=$(V) \ diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index 56e94d5..4bd36f5 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -318,6 +318,18 @@ help Use ARMv8 Crypto Extension to accelerate SHA hash calculation in vboot. +config VBOOT_ARM64_RSA_ACCELERATION + bool "Use arm64 SIMD instructions to accelerate RSA signature verification" + default y + depends on ARCH_VERSTAGE_ARM64 + help + Use arm64 SIMD instructions (NEON) to parallelize two multiplications + in the modulus exponentiation algorithm, which speeds up RSA signature + verification in vboot. This is supported on all arm64 CPUs so you'd + generally always want this enabled, unless your SoC is overriding + vboot's hwcrypto API with its own crypto accelerator IP instead (or + you're trying really hard to save on code size). + config VBOOT_DEFINE_WIDEVINE_COUNTERS bool default n diff --git a/src/security/vboot/Makefile.mk b/src/security/vboot/Makefile.mk index 1689efb..23271ea 100644 --- a/src/security/vboot/Makefile.mk +++ b/src/security/vboot/Makefile.mk @@ -33,6 +33,7 @@ VB2_X86_RSA_ACCELERATION="$(if $(CONFIG_ARCH_$(call toupper,$(1))_X86_32)$(CONFIG_ARCH_$(call toupper,$(1))_X86_64),$\ $(CONFIG_VBOOT_X86_RSA_ACCELERATION))" \ ARMV8_CRYPTO_EXT="$(if $(CONFIG_ARCH_$(call toupper,$(1))_ARMV8_64),$$(CONFIG_VBOOT_ARMV8_CE_SHA256_ACCELERATION))" \ + ARM64_RSA_ACCELERATION="$(if $(CONFIG_ARCH_$(call toupper,$(1))_ARM64),$$(CONFIG_VBOOT_ARM64_RSA_ACCELERATION))" \ $(MAKE) -C $(VBOOT_SOURCE) \ BUILD=$$(abspath $$(dir $$(VBOOT_LIB_$(1)))) \ V=$(V) \ -- To view, visit https://review.coreboot.org/c/coreboot/+/80710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3820bd6b7505202b7edb6768385ce5deb18777a4 Gerrit-Change-Number: 80710 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: Update vboot submodule to upstream main
by Julius Werner (Code Review) 24 Feb '24

24 Feb '24

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80709?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id 3d37d2aa: 2024-01-15 Makefile: Support FIRMWARE_ARCH=mock for firmware unit tests to commit id 09fcd218: 2024-02-22 Makefile: Test compiler for -Wincompatible-function-pointer-types This brings in 26 new commits: 09fcd218 Makefile: Test compiler for -Wincompatible-function-pointer-types 00e8c2d8 tests: Run hwcrypto RSA tests for arm64 d3387824 firmware: Add vectorized modexp() implementation for arm64 (NEON) 8856e04b tests: Stop exporting ENABLE_HWCRYPTO_RSA_TESTS to test scripts 6abd9cc0 Makefile: Separate ${ARCH_DIR}, split arm/arm64, remove symlinks e7f567d1 test_update: Skip ifdtool-dependent tests when not available 1a0f8df8 libvboot_host: Check for undefined symbols c0806280 vboot_host: Expose dynamic library 2ff5784d vboot: Remove 2kernel.c from vboot_host library 6e472468 Add crdyshim keygen script and devkeys 8a711468 scripts/keygeneration: Move generate_ed25519_key to common.sh 57e2092d scripts/image_signing: Call futility instead of its symlinks 0fa2ea47 scripts/image_signing/make_dev_ssh.sh: Improve parameter removal 1d32db3b Makefile: Remove genfuzztestcases from runtestscripts prerequisites f6ff822b README: Add 'futility sign' and 'futility verify' to useful utilities a717c83d tests: Replace vbutil_{firmware,kernel} with 'futility sign' 94c82417 *.sh: Unify indentation with 2 spaces 23d25957 utility/dev_debug_vboot: Replace vbutil_firmware with 'futility verify' fd20901f cgpt/futility: bundle as a subtool dccc5a31 image_signing: Add support for signing Flexor kernel image 660b6675 futility/cmd_show: Add "::verified" summary to vblock parseable output 2fcff1e4 tests/*.sh: Replace vbutil_firmware with 'futility verify' c6b13823 make_dev_firmware.sh: Replace vbutil_firmware with 'futility show' d260d094 firmware: 2modpow_sse2: Clean up calculation of `mu` 2596679a Add -Wint-conversion and -Wincompatible-function-pointer-types 39fb6201 futility: update: Use ifdtool to unlock ME f8016c2b make_keyblock: change to parsing key prefix Change-Id: Ibc6daef30092b1b31f3dd08f3aed02ba31fd12d2 Signed-off-by: Julius Werner <jwerner(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80709 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yu-Ping Wu: Looks good to me, approved build bot (Jenkins): Verified diff --git a/3rdparty/vboot b/3rdparty/vboot index 3d37d2a..09fcd21 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit 3d37d2aafe1f941c532def2a1fbbb58c8dd84182 +Subproject commit 09fcd2184f9c714829503e84b8a7dfe7f2584e00 -- To view, visit https://review.coreboot.org/c/coreboot/+/80709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibc6daef30092b1b31f3dd08f3aed02ba31fd12d2 Gerrit-Change-Number: 80709 Gerrit-PatchSet: 4 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: arch/arm64: Add Clang as supported target
by Julius Werner (Code Review) 24 Feb '24

24 Feb '24

Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74501?usp=email ) Change subject: arch/arm64: Add Clang as supported target ...................................................................... Patch Set 23: (1 comment) File src/arch/arm64/Kconfig: https://review.coreboot.org/c/coreboot/+/74501/comment/ec6665c4_6a23f4af : PS23, Line 7: default y if ARCH_ARM64 > > Should move under the `if` below. […] Sorry, I don't really understand... I'm pretty sure that should work. This is only a default override for a symbol that was already declared earlier. If you look at `src/mainboard/google/gru/Kconfig`, for example, you see a `config DRIVER_TPM_I2C_ADDR` that overrides the default inside the `if BOARD_GOOGLE_GRU_COMMON` block. How is this case any different? Can you maybe upload the version that gives you the error so we can make sure we mean the same thing? -- To view, visit https://review.coreboot.org/c/coreboot/+/74501?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940a1ccf5cc4ec7bed5b6c8be92fc47922e1e747 Gerrit-Change-Number: 74501 Gerrit-PatchSet: 23 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 24 Feb 2024 02:02:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024