Attention is currently required from: Arthur Heymans, Michael Niewöhner.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80720?usp=email )
Change subject: mb/clevo/tgl-u: hda_verbs: correct vendor value comments
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Rebase this on top of CB:80740.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80720?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I45b1d09d5a11b357ac2a20ef448ea642540cdc99
Gerrit-Change-Number: 80720
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 25 Feb 2024 01:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Michael Niewöhner.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80720?usp=email )
Change subject: mb/clevo/tgl-u: hda_verbs: correct vendor value comments
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Just my 2 cents, maybe the `/* vendor/linux: AZALIA_... */` comments are superfluous. As long as you provide the vendor values (which you do) you can decode these using the hda-decoder I wrote relatively easily.
File src/mainboard/clevo/tgl-u/variants/l140mu/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/80720/comment/c58b3b6c_c00f6d0c :
PS1, Line 54: vendor
linux.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80720?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I45b1d09d5a11b357ac2a20ef448ea642540cdc99
Gerrit-Change-Number: 80720
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Sun, 25 Feb 2024 00:20:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Elyes Haouas, Martin L Roth.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80648?usp=email )
Change subject: crossgcc: Upgrade CMake from 3.27.7 to version 3.28.3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80648?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17758e23da25d610a0b462dfd388c53b89315242
Gerrit-Change-Number: 80648
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sat, 24 Feb 2024 22:26:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80718?usp=email )
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80718/comment/846cde83_1986093a :
PS1, Line 9: Backport 9c348a7b7ea3422a74af9b820275751e9abb4a12 from Alder Lake to
> > `Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'comm […]
fixed
https://review.coreboot.org/c/coreboot/+/80718/comment/43c6a80e_1d3c9a70 :
PS1, Line 10: fix a similar issue present on Tiger Lake
> Please add a dot/period at the end of sentences.
fixed
https://review.coreboot.org/c/coreboot/+/80718/comment/f2e97ff9_a4e06183 :
PS1, Line 11:
> It’d be great if you copied the other commit message to ease review.
fixed
--
To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 2
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sat, 24 Feb 2024 19:26:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Fred Reitberger, Jason Glenesk, Matt DeVillier, Matt DeVillier, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77742?usp=email )
Change subject: soc/amd/common/acpi/upep: Fix UUID conditional and add notifications required for Windows Modern Standby notifications
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> It’d be great to get these in?
it's still sort-of on my todo list to look into this, but this topic is a bit complicated, since there have been 3 versions of how things are done here. at least we're down to only two versions being used by now though
--
To view, visit https://review.coreboot.org/c/coreboot/+/77742?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie3adf74c613ae2a00a3e8fa6707c40ff2c6b3401
Gerrit-Change-Number: 77742
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Sat, 24 Feb 2024 19:26:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80719?usp=email )
Change subject: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80719/comment/56dbc3cc_592dc04e :
PS1, Line 9: Backport
> By the way, why “backport” and not just “port”?
Either way is fine, I just went with backport since ADL is a newer platform than TGL
https://review.coreboot.org/c/coreboot/+/80719/comment/56fb4d41_4f2c0ab8 :
PS1, Line 14: Verify TCSS XHCI power management
: working
> How can this be tested?
Device Manager no longer Code 43's on default settings (Controller has the option to "Allow the computer to turn off this device to save power" enabled)
--
To view, visit https://review.coreboot.org/c/coreboot/+/80719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40a537fd2b0c821caf282f52aaff1874f54325f1
Gerrit-Change-Number: 80719
Gerrit-PatchSet: 3
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sat, 24 Feb 2024 19:26:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment