Attention is currently required from: Arthur Heymans, Felix Held.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69792?usp=email )
Change subject: payloads/Kconfig: Don't show FIT payload option on x86
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/69792?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88
Gerrit-Change-Number: 69792
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 25 Feb 2024 12:19:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathon Hall, Matt DeVillier, Nico Huber.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80601?usp=email )
Change subject: mb/purism/librem_cnl/var/librem_mini: Set RTC register defaults
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80601/comment/7872f3b0_c071c5fc :
PS2, Line 9: throw an error in cbmem
Excuse my ignorance. I do not understand what “in cbmem” means here. Do you mean CBMEM console, or when CBMEM is set up, or something else?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80601?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I310a834a1fa7b8428879fbc160e4aae0a519e063
Gerrit-Change-Number: 80601
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Comment-Date: Sun, 25 Feb 2024 08:57:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69792?usp=email )
Change subject: payloads/Kconfig: Don't show FIT payload option on x86
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69792/comment/6ad7d08f_dddab460 :
PS2, Line 10: show
show*n*
Patchset:
PS2:
Thank you for cleaning this up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/69792?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7afc3b94c5ab8044af0920c87cc8d190467c2a88
Gerrit-Change-Number: 69792
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Sun, 25 Feb 2024 08:52:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Singer.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80638?usp=email )
Change subject: vendorcode/cavium: Fix bitfields with signed integers
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80638/comment/ed79ab88_a439c2cf :
PS1, Line 7: Fix bitfields with signed integers
Maybe:
> Use unsigned integers in bitfields
> Make integers in bitfields unsigned
… for valid C
--
To view, visit https://review.coreboot.org/c/coreboot/+/80638?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0b2add2f1078a88347fea7dc65d422d0e5a210a1
Gerrit-Change-Number: 80638
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 25 Feb 2024 08:35:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Matt DeVillier, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80719?usp=email )
Change subject: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/80719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40a537fd2b0c821caf282f52aaff1874f54325f1
Gerrit-Change-Number: 80719
Gerrit-PatchSet: 3
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Feb 2024 07:38:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Juan José García-Castro Crespo, Martin L Roth.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80722?usp=email )
Change subject: Documentation/tutorial/part1.md: Update Debian packages
......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80722/comment/bdb6fdcf_61cd1b5c :
PS1, Line 7: Update Debian packages
:
You could be more specific:
> Install libssl-dev and pkg-config on Debian
https://review.coreboot.org/c/coreboot/+/80722/comment/f3f9fe81_1fc0997c :
PS1, Line 10: Added
We normally use present tense in commit messages: Add …
https://review.coreboot.org/c/coreboot/+/80722/comment/3d44db8b_406b07aa :
PS1, Line 12: Also converted multiline package list to one-line code markup.
As written, this should be a separate change-set/commit.
Patchset:
PS1:
Welcome to coreboot! Thank you for your contribution. I added some nits. You can split out the unrelated change, and then commit that and amend the commit message with `git commit --amend -a` and then just run `git push`. As the Change-Id did not change, Gerrit is able to map the new commit to this change-set. If you have any questions, don’t hesitate to ask.
(Sorry, if you are already familiar to git and Gerrit, and my comment is too long.)
File Documentation/tutorial/part1.md:
https://review.coreboot.org/c/coreboot/+/80722/comment/e9f1f796_da359c8f :
PS1, Line 39: `sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++
: ncurses-devel wget zlib-devel patch`
This seems unrelated to the change at hand. Please split this into a separate patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80722?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5df06611a934d1ef85c8335764f4f6e0f241c9a9
Gerrit-Change-Number: 80722
Gerrit-PatchSet: 1
Gerrit-Owner: Juan José García-Castro Crespo
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Juan José García-Castro Crespo
Gerrit-Comment-Date: Sun, 25 Feb 2024 07:33:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Martin L Roth.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80737?usp=email )
Change subject: [WIP]util/crossgcc: Build compiler-rt using runtimes
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Don't you need to change CLANG_RUNTIME="libgcc"
by CLANG_RUNTIME="compiler-rt" into xcompile ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacd9b5f1fc1444b3dd1a785b91510f346e7a2f51
Gerrit-Change-Number: 80737
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Sun, 25 Feb 2024 07:07:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment