Attention is currently required from: Matt DeVillier, Nick Vaccaro, Paul Menzel, Subrata Banik.
CoolStar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80718?usp=email )
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80718/comment/7087921d_4f6a070a :
PS2, Line 9: 9c348a7b7ea3422a74af9b820275751e9abb4a12
> truncate to 12 digits
Done
https://review.coreboot.org/c/coreboot/+/80718/comment/187d1a37_559cd098 :
PS2, Line 9: soc/intel/alderlake:
: Fix processor hang while plug unplug of TBT device
> commit msg in quotes
Done
https://review.coreboot.org/c/coreboot/+/80718/comment/5e56abff_73742a0e :
PS2, Line 21: `
> use 3-5 dashes vs single quotes?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:05:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Nick Vaccaro, Paul Menzel, Subrata Banik.
Hello Matt DeVillier, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80718?usp=email
to look at the new patch set (#4).
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
Port 9c348a7b7ea3 "soc/intel/alderlake: Fix processor hang while plug
unplug of TBT device" from
Alder Lake to fix a similar issue present on Tiger Lake:
```Processor hang is observed while hot plug unplug of TBT device. BIOS
should execute TBT PCIe RP RTD3 flow based on the value of
TBT_DMA_CFG_VS_CAP_9[30]. It should skip TBT PCIe RP RTD3 flow, if
BIT30 in TBT FW version is not set.
BUG=b:194880254
https://review.coreboot.org/c/coreboot/+/56503
```
Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Signed-off-by: CoolStar <coolstarorganization(a)gmail.com>
---
M src/soc/intel/tigerlake/acpi/tcss.asl
M src/soc/intel/tigerlake/acpi/tcss_dma.asl
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80718/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 4
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: CoolStar, Nick Vaccaro, Paul Menzel, Subrata Banik.
Hello Matt DeVillier, Nick Vaccaro, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80718?usp=email
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
Port 9c348a7b7ea3 "soc/intel/alderlake: Fix processor hang while plug
unplug of TBT device" from
Alder Lake to fix a similar issue present on Tiger Lake:
`Processor hang is observed while hot plug unplug of TBT device. BIOS
should execute TBT PCIe RP RTD3 flow based on the value of
TBT_DMA_CFG_VS_CAP_9[30]. It should skip TBT PCIe RP RTD3 flow, if
BIT30 in TBT FW version is not set.
BUG=b:194880254
https://review.coreboot.org/c/coreboot/+/56503
`
Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Signed-off-by: CoolStar <coolstarorganization(a)gmail.com>
---
M src/soc/intel/tigerlake/acpi/tcss.asl
M src/soc/intel/tigerlake/acpi/tcss_dma.asl
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80718/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 3
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Martin Roth, Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80645?usp=email )
Change subject: device/pnp_device: Demote unassigned resource printk to NOTICE
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80645/comment/b395a793_96ccfd83 :
PS1, Line 11: the printk but demote it so it doesn't pollute a normal cbmem log.
> BIOS_ERR seems too much indeed, but it can be a mistake, so I'd say it […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/80645?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3d9f22a06088596e14680190aede2d69880001fa
Gerrit-Change-Number: 80645
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:04:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80719?usp=email )
Change subject: soc/intel/tigerlake: Remove IOM Mctp command from TCSS ASL
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80719/comment/99bc9195_13ba61e4 :
PS3, Line 1: Parent: e7ee525c (soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device)
same comments here as previous patch: truncate commit hash to 12 digits, add quotes around commit msg, use dashes vs single quotes
--
To view, visit https://review.coreboot.org/c/coreboot/+/80719?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40a537fd2b0c821caf282f52aaff1874f54325f1
Gerrit-Change-Number: 80719
Gerrit-PatchSet: 3
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:03:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Nick Vaccaro, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80718?usp=email )
Change subject: soc/intel/tigerlake: Fix processor hang while plug unplug of TBT device
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80718/comment/fe282cc6_3f6f0588 :
PS2, Line 9: 9c348a7b7ea3422a74af9b820275751e9abb4a12
truncate to 12 digits
https://review.coreboot.org/c/coreboot/+/80718/comment/d32f8700_7f6fa901 :
PS2, Line 9: soc/intel/alderlake:
: Fix processor hang while plug unplug of TBT device
commit msg in quotes
https://review.coreboot.org/c/coreboot/+/80718/comment/db744c33_abd50028 :
PS2, Line 21: `
use 3-5 dashes vs single quotes?
File src/soc/intel/tigerlake/acpi/tcss_dma.asl:
https://review.coreboot.org/c/coreboot/+/80718/comment/07d95b3a_6b6624ed :
PS2, Line 15: /* ITBT FW Version Bit30 */
extra tab
--
To view, visit https://review.coreboot.org/c/coreboot/+/80718?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5409111d4239be86c0b153f01b4fe5fc6af352c
Gerrit-Change-Number: 80718
Gerrit-PatchSet: 2
Gerrit-Owner: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-CC: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Juan José García-Castro Crespo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80749?usp=email )
Change subject: Documentation/tutorial/part1.md: Reformat Redhat package description
......................................................................
Patch Set 1:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80749?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1ba38bf2fc767a3f1694c55cf50e137ce10bfd75
Gerrit-Change-Number: 80749
Gerrit-PatchSet: 1
Gerrit-Owner: Juan José García-Castro Crespo
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Sun, 25 Feb 2024 18:13:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Paul Menzel.
Juan José García-Castro Crespo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80722?usp=email )
Change subject: Documentation/tutorial/part1.md: Install libssl-dev and pkg-config on Debian
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80722/comment/75a3e014_931be479 :
PS1, Line 7: Update Debian packages
:
> You could be more specific: […]
Done
https://review.coreboot.org/c/coreboot/+/80722/comment/ec141da5_10669f7b :
PS1, Line 10: Added
> We normally use present tense in commit messages: Add …
Done
https://review.coreboot.org/c/coreboot/+/80722/comment/673c37e2_76143281 :
PS1, Line 12: Also converted multiline package list to one-line code markup.
> As written, this should be a separate change-set/commit.
80749: Documentation/tutorial/part1.md: Reformat Redhat package description | https://review.coreboot.org/c/coreboot/+/80749
File Documentation/tutorial/part1.md:
https://review.coreboot.org/c/coreboot/+/80722/comment/3700a9fc_811d0fbc :
PS1, Line 39: `sudo dnf install git make gcc-gnat flex bison xz bzip2 gcc g++
: ncurses-devel wget zlib-devel patch`
> This seems unrelated to the change at hand. Please split this into a separate patch.
Moved to a separate patch.
80749: Documentation/tutorial/part1.md: Reformat Redhat package description | https://review.coreboot.org/c/coreboot/+/80749
--
To view, visit https://review.coreboot.org/c/coreboot/+/80722?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5df06611a934d1ef85c8335764f4f6e0f241c9a9
Gerrit-Change-Number: 80722
Gerrit-PatchSet: 2
Gerrit-Owner: Juan José García-Castro Crespo
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 25 Feb 2024 18:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Juan José García-Castro Crespo, Martin L Roth.
Hello Martin L Roth, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80722?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: Documentation/tutorial/part1.md: Install libssl-dev and pkg-config on Debian
......................................................................
Documentation/tutorial/part1.md: Install libssl-dev and pkg-config on Debian
Missing pkg-config and libcrypto when building coreboot (Step 6) on
Debian 12 (bookworm). Add required packages to Step 1, libssl-dev and
pkg-config.
Change-Id: I5df06611a934d1ef85c8335764f4f6e0f241c9a9
Signed-off-by: Juan José García-Castro Crespo <jjgcc(a)posteo.net>
---
M Documentation/tutorial/part1.md
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/80722/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80722?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5df06611a934d1ef85c8335764f4f6e0f241c9a9
Gerrit-Change-Number: 80722
Gerrit-PatchSet: 2
Gerrit-Owner: Juan José García-Castro Crespo
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Juan José García-Castro Crespo
Gerrit-MessageType: newpatchset
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73685?usp=email )
Change subject: soc/intel/alderlake: Select `X86_CLFLUSH_CAR` config
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
How were the platforms selected in this patch train? i.e. why these
platforms specifically and not all?
--
To view, visit https://review.coreboot.org/c/coreboot/+/73685?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fe6072a3c23a02c9a691406f179bfc8f0f18a93
Gerrit-Change-Number: 73685
Gerrit-PatchSet: 5
Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sun, 25 Feb 2024 15:01:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment