coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[S] Change in em100[main]: em100: exit when using an invalid device name
by Stefan Reinauer (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: c.koehne(a)beckhoff.com. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/80249?usp=email ) Change subject: em100: exit when using an invalid device name ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/em100/+/80249?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: If0f7b8b576224a9db6ab319c2212bc245110c5c1 Gerrit-Change-Number: 80249 Gerrit-PatchSet: 2 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: c.koehne(a)beckhoff.com Gerrit-Comment-Date: Fri, 02 Feb 2024 16:13:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in em100[main]: em100: free device list when calling em100 --list
by Stefan Reinauer (Code Review) 02 Feb '24

02 Feb '24

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/80248?usp=email ) Change subject: em100: free device list when calling em100 --list ...................................................................... em100: free device list when calling em100 --list After querying the device list by calling libusb_get_device_list, you have to free the list with lib_usb_free_device_list to properly clean up the resources allocated by libusb. This solves some warnings issued by libusb when calling `em100 --list`. Change-Id: Id1849bb69d534928016256dd01e9550ef414d330 Signed-off-by: Corvin Köhne <c.koehne(a)beckhoff.com> Reviewed-on: https://review.coreboot.org/c/em100/+/80248 Reviewed-by: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Reviewed-by: Jakub Czapiga <czapiga(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M em100.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jakub Czapiga: Looks good to me, approved Stefan Reinauer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/em100.c b/em100.c index 90bf882..cfcecb9 100644 --- a/em100.c +++ b/em100.c @@ -539,6 +539,7 @@ } if (count == 0) printf("No EM100pro devices found.\n"); + libusb_free_device_list(devs, 1); libusb_exit(ctx); return 1; } -- To view, visit https://review.coreboot.org/c/em100/+/80248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: Id1849bb69d534928016256dd01e9550ef414d330 Gerrit-Change-Number: 80248 Gerrit-PatchSet: 3 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in em100[main]: em100: free device list when calling em100 --list
by Stefan Reinauer (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: c.koehne(a)beckhoff.com. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/80248?usp=email ) Change subject: em100: free device list when calling em100 --list ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/em100/+/80248?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: em100 Gerrit-Branch: main Gerrit-Change-Id: Id1849bb69d534928016256dd01e9550ef414d330 Gerrit-Change-Number: 80248 Gerrit-PatchSet: 2 Gerrit-Owner: c.koehne(a)beckhoff.com Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: c.koehne(a)beckhoff.com Gerrit-Comment-Date: Fri, 02 Feb 2024 16:12:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: drivers/wifi: Add MTCL function to ACPI SSDT
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Arthur Heymans, Cliff Huang, Eric Lai, Kapil Porwal, Lance Zhao, Nick Vaccaro, Nico Huber, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak. David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email ) Change subject: drivers/wifi: Add MTCL function to ACPI SSDT ...................................................................... Patch Set 19: (1 comment) File src/drivers/wifi/generic/Kconfig: https://review.coreboot.org/c/coreboot/+/80170/comment/d9b94574_eb7cf391 : PS18, Line 66: bool > > but only one depends hmm. the path already depends MTCL. […] Done. As a bonus I sent another patch that removes the if guarding around the SAR part. -- To view, visit https://review.coreboot.org/c/coreboot/+/80170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 Gerrit-Change-Number: 80170 Gerrit-PatchSet: 19 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Feb 2024 16:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: drivers/wifi: Use depends instead of if in Kconfig
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: David Ruth. Hello David Ruth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80307?usp=email to look at the new patch set (#2). Change subject: drivers/wifi: Use depends instead of if in Kconfig ...................................................................... drivers/wifi: Use depends instead of if in Kconfig Cleanup to make the file follow the same convention after USE_MTCL was added and the depends structure was requested instead of the if guards. Signed-off-by: David Ruth <druth(a)google.com> Change-Id: I3604b394f999b28de4723337b3b6b4e21139c83b --- M src/drivers/wifi/generic/Kconfig 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/80307/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3604b394f999b28de4723337b3b6b4e21139c83b Gerrit-Change-Number: 80307 Gerrit-PatchSet: 2 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: David Ruth <druth(a)google.com> Gerrit-Attention: David Ruth <druth(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: drivers/wifi: Use depends instead of if in KConfig
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: David Ruth. Hello David Ruth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/80307?usp=email to review the following change. Change subject: drivers/wifi: Use depends instead of if in KConfig ...................................................................... drivers/wifi: Use depends instead of if in KConfig Cleanup to make the file follow the same convention after USE_MTCL was added and the depends structure was requested instead of the if guards. Signed-off-by: David Ruth <druth(a)google.com> Change-Id: I3604b394f999b28de4723337b3b6b4e21139c83b --- M src/drivers/wifi/generic/Kconfig 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/80307/1 diff --git a/src/drivers/wifi/generic/Kconfig b/src/drivers/wifi/generic/Kconfig index 814059e..5efd471 100644 --- a/src/drivers/wifi/generic/Kconfig +++ b/src/drivers/wifi/generic/Kconfig @@ -23,11 +23,10 @@ When enabled, add identifiers in ACPI tables to make OS drivers work with certain MediaTek PCI-e WiFi chipsets. -if DRIVERS_WIFI_GENERIC - config USE_SAR bool default n + depends on DRIVERS_WIFI_GENERIC help Enable it when wifi driver uses SAR configuration feature. @@ -58,8 +57,6 @@ help There can be up to 3 optional SAR table sets. -endif # DRIVERS_WIFI_GENERIC - config USE_MTCL bool default n -- To view, visit https://review.coreboot.org/c/coreboot/+/80307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3604b394f999b28de4723337b3b6b4e21139c83b Gerrit-Change-Number: 80307 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: David Ruth <druth(a)google.com> Gerrit-Attention: David Ruth <druth(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik. David Ruth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80305?usp=email ) Change subject: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80305/comment/0a2ddd9d_0631c7fc : PS1, Line 7: mb > > mb/google/nissa/var/yaviks: […] Done File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/80305/comment/22e02a5b_c516744a : PS1, Line 489: select USE_MTCL > > miss DRIVERS_MTK_WIFI? […] Nothing declares DRIVERS_INTEL_WIFI, but almost all of these boards have variants with Intel WiFi chips. I tried to figure out why that was, and I found the following: PCIEXP_PLUGIN_SUPPORT is enabled by default (see /src/third_party/coreboot/src/device/Kconfig), so DRIVERS_MTK_WIFI and DRIVERS_INTEL_WIFI are both effectively enabled by default. This isn't technically necessary (I've tested it multiple times at this point), and it seems to go against convention. My inclination (unless there's a strong preference otherwise) is to not add this. -- To view, visit https://review.coreboot.org/c/coreboot/+/80305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec54fc582d68b443665fceda47187c28f1a9216c Gerrit-Change-Number: 80305 Gerrit-PatchSet: 1 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Feb 2024 16:01:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: David Ruth, Eric Lai, Kapil Porwal, Nick Vaccaro. Hello Eric Lai, Kapil Porwal, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80305?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS ...................................................................... mb/google/nissa/var/yaviks: Enable USE_MTCL for YAVIKS Yaviks will be the first model to take advantage of this feature. BUG=b:295544553 TEST=Build on similar model (PUJJO) that I have access to and verify the flag and feature work as intended. TEST=Add wifi_mtcls.bin blob to cbfs TEST=Build coreboot for pujjo `emerge-nissa coreboot chromeos-bootimage` TEST=Verify that MTCL defined in the file is present: TEST=`acpidump -b` TEST=`iasl ssdt.dat` TEST=`less ssdt.dsl` TEST=Search for MTCL Change-Id: Iec54fc582d68b443665fceda47187c28f1a9216c Signed-off-by: David Ruth <druth(a)chromium.org> --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/80305/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80305?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iec54fc582d68b443665fceda47187c28f1a9216c Gerrit-Change-Number: 80305 Gerrit-PatchSet: 2 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: drivers/wifi: Add MTCL function to ACPI SSDT
by David Ruth (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Arthur Heymans, Cliff Huang, David Ruth, Eric Lai, Kapil Porwal, Lance Zhao, Nick Vaccaro, Nico Huber, Paul Menzel, Subrata Banik, Subrata Banik, Tim Wawrzynczak. Hello Arthur Heymans, Cliff Huang, Eric Lai, Kapil Porwal, Lance Zhao, Nick Vaccaro, Nico Huber, Subrata Banik, Tim Wawrzynczak, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80170?usp=email to look at the new patch set (#19). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Code-Review+2 by Subrata Banik, Verified+1 by build bot (Jenkins) Change subject: drivers/wifi: Add MTCL function to ACPI SSDT ...................................................................... drivers/wifi: Add MTCL function to ACPI SSDT The MTCL function provides a country list to the Linux kernel via an ACPI function in SSDT for MediaTek WiFi chipsets that are capable of operating on the 6GHz band. The country list is used to selectively disable 6GHz and 5.9GHz operation based on the country the device is operating in. The function needs to read a binary file and send it as a package via the MTCL method in SSDT for PCIe WiFi with MediaTek chipsets. Change Summary: * Add src/drivers/wifi/generic/mtcl.c to abstract functionaltity related to MTCL * Add write_mtcl_aml function to convert the byte data into the format expected by the MTCL functionality in the Linux kernel. * Add validate_mtcl function to validate that the byte data read in from a file is in the expected format. * Add write_mtcl_function function to read a binary file called "wifi_mtcl".bin" from cbfs, then call validate_mtcl to verify that it is in an expected format, and if so write the aml via acpigen * Add config flag DRIVERS_MTK_WIFI to src/drivers/wifi/generic in order to include MediaTek WiFi specific functionality * Add config flag USE_MTCL which depends on DRIVERS_MTK_WIFI and enables including the specific ACPI function defined in SSDT * Add config flag CONFIG_MTCL_CBFS_FILEPATH which depends on DRIVERS_MTK_WIFI which enables configuring the file to add as "wifi_mtcl.bin" * Add a call to write_mtcl_function to src/drivers/wifi/generic/acpi.c to include the MTCL function in SSDT for MTK WiFi devices when USE_MTCL is enabled. * Add MediaTek VID to src/include/device/pci_ids.h. BUG=b:295544553 TEST=Add Kconfig entry USE_MTCL for pujjo TEST=Add wifi_mtcl_defaults.bin blob to cbfs TEST=Build coreboot for pujjo `emerge-nissa coreboot chromeos-bootimage` TEST=Verify that MTCL defined in the file is present: TEST=`acpidump -b` TEST=`iasl ssdt.dat` TEST=`less ssdt.dsl` TEST=Search for MTCL Signed-off-by: David Ruth <druth(a)chromium.org> Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 --- M src/drivers/wifi/generic/Kconfig M src/drivers/wifi/generic/Makefile.mk M src/drivers/wifi/generic/acpi.c A src/drivers/wifi/generic/mtcl.c M src/include/device/pci_ids.h A src/include/mtcl.h 6 files changed, 223 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/80170/19 -- To view, visit https://review.coreboot.org/c/coreboot/+/80170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b5e7312a44e114270e664b983626faa6cfee350 Gerrit-Change-Number: 80170 Gerrit-PatchSet: 19 Gerrit-Owner: David Ruth <druth(a)chromium.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subi.banik(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: David Ruth <druth(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: lib/romstage_handoff.c: Initialize using a cbmem hook
by Nico Huber (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Andrey Petrov, Angel Pons, Arthur Heymans, Damien Zammit, Felix Held, Huang Jin, Julius Werner, Lee Leahy, Matt DeVillier, Ronak Kanabar. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52933?usp=email ) Change subject: lib/romstage_handoff.c: Initialize using a cbmem hook ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93abf33a6eb055eeaba1fed5042387822de1aa20 Gerrit-Change-Number: 52933 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Damien Zammit Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Huang Jin Gerrit-Reviewer: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Damien Zammit Gerrit-Attention: Lee Leahy <leroy.p.leahy(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Huang Jin Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Feb 2024 15:57:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024