coreboot-gerrit February 2024

coreboot-gerrit@coreboot.org

1 participants
3067 discussions

[S] Change in coreboot[main]: cpu/x86: Link page tables in stage if possible
by Patrick Rudolph (Code Review) 03 Feb '24

03 Feb '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80337?usp=email ) Change subject: cpu/x86: Link page tables in stage if possible ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80337/comment/4dc73f13_a6583b01 : PS1, Line 9: When switching back and forward from 32 to 64, for example to call a I don't understand this. Where's the relation between protected mode calls and linking page tables into the stage? Doesn't this increase the stage size and thus occupies more flash in the end? That should be mentioned here as well. What's the benefit of linking instead over having it in CBFS? -- To view, visit https://review.coreboot.org/c/coreboot/+/80337?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied54b66b930187cba5fbc578a81ed5859a616562 Gerrit-Change-Number: 80337 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 03 Feb 2024 10:06:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: cpu/x86/smm: Set up page tables in safe SMRAM
by Patrick Rudolph (Code Review) 03 Feb '24

03 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80336?usp=email ) Change subject: cpu/x86/smm: Set up page tables in safe SMRAM ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80336?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icb3086abd577b9abb9966dd910a264a873ace4ed Gerrit-Change-Number: 80336 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 03 Feb 2024 10:02:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/(sipi|smm): Pass on CR3 from ramstage
by Patrick Rudolph (Code Review) 03 Feb '24

03 Feb '24

Attention is currently required from: Arthur Heymans, Jérémy Compostella. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80335?usp=email ) Change subject: cpu/x86/(sipi|smm): Pass on CR3 from ramstage ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80335?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1250ea6f63c65228178ee66e06d988dadfcc2a37 Gerrit-Change-Number: 80335 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 03 Feb 2024 09:59:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: cpu/x86/64bit: Turn jumping to long mode into a macro
by Patrick Rudolph (Code Review) 03 Feb '24

03 Feb '24

Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Jérémy Compostella, Matt DeVillier. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79261?usp=email ) Change subject: cpu/x86/64bit: Turn jumping to long mode into a macro ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: `src/cpu/intel/car/core2/cache_as_ram.S` is missing -- To view, visit https://review.coreboot.org/c/coreboot/+/79261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ida861338004187e4e714be41e17c8447fa4cf935 Gerrit-Change-Number: 79261 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 03 Feb 2024 09:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM
by Patrick Rudolph (Code Review) 03 Feb '24

03 Feb '24

Attention is currently required from: Andrey Petrov, Arthur Heymans, Chen, Gang C, David Hendricks, Johnny Lin, Lean Sheng Tan, Paul Menzel, Ronak Kanabar, Shuo Liu. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80328?usp=email ) Change subject: drivers/intel/fsp2_0: Add FSP_DOES_NOT_NEED_TEMP_RAM ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80328/comment/eda8b30a_c2dceda0 : PS3, Line 8: > Yeah, it is for the 2S issue. https://review.coreboot. […] Wouldn't it be easier to select `PLATFORM_USES_FSP2_0` instead of `PLATFORM_USES_FSP2_2`? -- To view, visit https://review.coreboot.org/c/coreboot/+/80328?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17a73e4f627c91808ed17c712b72937662ae9293 Gerrit-Change-Number: 80328 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Sat, 03 Feb 2024 07:11:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: device/azalia: Rework the verb table
by Nicholas Sudsgaard (Code Review) 02 Feb '24

02 Feb '24

Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80333?usp=email ) Change subject: device/azalia: Rework the verb table ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Did some quick tests on compiler explorer and it seems like using pointers can cut down the instructions roughly 35%. -- To view, visit https://review.coreboot.org/c/coreboot/+/80333?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54 Gerrit-Change-Number: 80333 Gerrit-PatchSet: 5 Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Sat, 03 Feb 2024 04:52:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching
by Shelley Chen (Code Review) 02 Feb '24

02 Feb '24

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80215?usp=email ) Change subject: mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching ...................................................................... mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching Follow reference design rex0, keep the GPIO settings of CNVi/PCIe. Only set GPP_F04,GPP_F05/GPP_S01,GPP_S02 to NC when WIFI_PCIE/WIFI_CNVI is selected. BUG=none TEST=Build and test on karis Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1 Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80215 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Eran Mitrani <mitrani(a)google.com> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/rex/variants/karis/fw_config.c 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Eran Mitrani: Looks good to me, approved build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/mainboard/google/rex/variants/karis/fw_config.c b/src/mainboard/google/rex/variants/karis/fw_config.c index 6dbf31d..c209295 100644 --- a/src/mainboard/google/rex/variants/karis/fw_config.c +++ b/src/mainboard/google/rex/variants/karis/fw_config.c @@ -35,14 +35,6 @@ }; static const struct pad_config cnvi_bt_disable_pads[] = { - /* GPP_F00 : [] ==> CNV_BRI_DT_R */ - PAD_NC(GPP_F00, NONE), - /* GPP_F01 : [] ==> CNV_BRI_RSP */ - PAD_NC(GPP_F01, NONE), - /* GPP_F02 : [] ==> CNV_RGI_DT_Rl */ - PAD_NC(GPP_F02, NONE), - /* GPP_F03 : [] ==> CNV_RGI_RSP */ - PAD_NC(GPP_F03, NONE), /* GPP_F04 : [] ==> CNV_RF_RST_L */ PAD_NC(GPP_F04, NONE), /* GPP_F05 : [] ==> CNV_CLKREQ */ @@ -54,8 +46,6 @@ PAD_NC(GPP_S01, NONE), /* GPP_S02 : [] ==> DMIC_SOC_CLK0_WLAN_PCM_OUT */ PAD_NC(GPP_S02, NONE), - /* GPP_D21 : [] ==> WLAN_CLKREQ_ODLl */ - PAD_NC(GPP_D21, NONE), }; static const struct pad_config bt_i2s_enable_pads[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/80215?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1 Gerrit-Change-Number: 80215 Gerrit-PatchSet: 6 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Update fw_config KB_TYPE field
by Shelley Chen (Code Review) 02 Feb '24

02 Feb '24

Shelley Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80331?usp=email ) Change subject: mb/google/rex/var/karis: Update fw_config KB_TYPE field ...................................................................... mb/google/rex/var/karis: Update fw_config KB_TYPE field Update element "KB_TYPE_CA" for align fw_config. Only EC will reference KB_TYPE field in fw_config. This CL is just for align fw_config. BUG=none TEST=emerge coreboot pass Change-Id: Ied54f78dddd9dddca1272fc31c9502fc11c61dde Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80331 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> Reviewed-by: Eran Mitrani <mitrani(a)google.com> --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Subrata Banik: Looks good to me, approved Eran Mitrani: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 371109a..fcff2c9 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -24,6 +24,7 @@ end field KB_TYPE 12 option KB_TYPE_DEFAULT 0 + option KB_TYPE_CA 1 end field WIFI_TYPE 13 option WIFI_CNVI 0 -- To view, visit https://review.coreboot.org/c/coreboot/+/80331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ied54f78dddd9dddca1272fc31c9502fc11c61dde Gerrit-Change-Number: 80331 Gerrit-PatchSet: 2 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching
by Eran Mitrani (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: David Wu, Dinesh Gehlot, Jack Lai, Jakub Czapiga, Kapil Porwal, Mac Chiang, Paul Menzel, Tarun, Tyler Wang. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80215?usp=email ) Change subject: mb/google/rex/var/karis: Follow rex0 CNVi/PCIe switching ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80215?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id23a2cfe0639f2d423980db9badc16c1477434d1 Gerrit-Change-Number: 80215 Gerrit-PatchSet: 5 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Jack Lai <jack.lai(a)intel.corp-partner.google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Sat, 03 Feb 2024 01:45:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0
by Shelley Chen (Code Review) 02 Feb '24

02 Feb '24

Attention is currently required from: Ivy Jian. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80300?usp=email ) Change subject: mb/google/brox: Initialize TCHSCR_RST_L/EN_PP3300_TCHSCR to 0 ...................................................................... Patch Set 2: (1 comment) This change is ready for review. File src/mainboard/google/brox/variants/baseboard/brox/gpio.c: https://review.coreboot.org/c/coreboot/+/80300/comment/e603478c_94cd5f8d : PS1, Line 265: PAD_CFG_GPO(GPP_F17, 0, DEEP), > If we have declared "generic.detect" = "1" in devicetree. […] Thank you very much for your help Ivy! This was exactly the information that we were looking for. -- To view, visit https://review.coreboot.org/c/coreboot/+/80300?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5bf1901a3a40a38237b950abcb758f96aebcc1cf Gerrit-Change-Number: 80300 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Sat, 03 Feb 2024 01:37:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2024