Alper Nebi Yasak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80364?usp=email )
Change subject: mainboard/qemu-aarch64: Get top of memory from device-tree blob
......................................................................
mainboard/qemu-aarch64: Get top of memory from device-tree blob
Trying to probe RAM space to figure out top of memory causes an
exception on AArch64 virtual machines with recent versions of QEMU, but
we temporarily enable exception handlers for that and use it to help
detect if a RAM address is usable or not. However, QEMU docs recommend
reading device information from the device-tree blob it provides us at
the start of RAM.
A previous commit adds a library function to parse device-tree blob that
QEMU provides us. Use it to determine top of memory in AArch64 QEMU
virtual machines, but still fall back to the RAM probing approach as a
last-ditch effort.
Change-Id: I4cc888b57cf98e0797ce7f9ddfa2eb34d14cd9c1
Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
---
M src/mainboard/emulation/qemu-aarch64/Kconfig
M src/mainboard/emulation/qemu-aarch64/cbmem.c
2 files changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/80364/1
diff --git a/src/mainboard/emulation/qemu-aarch64/Kconfig b/src/mainboard/emulation/qemu-aarch64/Kconfig
index dcb4f23..c0f579e 100644
--- a/src/mainboard/emulation/qemu-aarch64/Kconfig
+++ b/src/mainboard/emulation/qemu-aarch64/Kconfig
@@ -11,6 +11,7 @@
select ARCH_VERSTAGE_ARMV8_64
select ARCH_ROMSTAGE_ARMV8_64
select ARCH_RAMSTAGE_ARMV8_64
+ select FLATTENED_DEVICE_TREE
select ARM64_USE_ARCH_TIMER
select BOARD_ROMSIZE_KB_16384
select BOOTBLOCK_CUSTOM
diff --git a/src/mainboard/emulation/qemu-aarch64/cbmem.c b/src/mainboard/emulation/qemu-aarch64/cbmem.c
index 389ff4e..cb798e0 100644
--- a/src/mainboard/emulation/qemu-aarch64/cbmem.c
+++ b/src/mainboard/emulation/qemu-aarch64/cbmem.c
@@ -3,8 +3,15 @@
#include <cbmem.h>
#include <ramdetect.h>
#include <symbols.h>
+#include <device_tree.h>
uintptr_t cbmem_top_chipset(void)
{
+ uintptr_t top;
+
+ top = fdt_get_memory_top((void *)_dram);
+ if (top)
+ return top;
+
return (uintptr_t)_dram + (probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB) * MiB);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/80364?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4cc888b57cf98e0797ce7f9ddfa2eb34d14cd9c1
Gerrit-Change-Number: 80364
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Philipp Hug, ron minnich.
Alper Nebi Yasak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80363?usp=email )
Change subject: mainboard/qemu-riscv: Get top of memory from device-tree blob
......................................................................
mainboard/qemu-riscv: Get top of memory from device-tree blob
Trying to probe RAM space to figure out top of memory causes an error on
RISC-V virtual machines with recent versions of QEMU. A previous commit
adds a library function to parse device-tree blob that QEMU provides us.
Use it to determine top of memory in RISC-V QEMU virtual machines, but
still fall back to the RAM probing approach as a last-ditch effort.
Change-Id: I9e4a95f49ad373675939329eef40d7423a4132ab
Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
---
M src/mainboard/emulation/qemu-riscv/Kconfig
M src/soc/ucb/riscv/cbmem.c
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/80363/1
diff --git a/src/mainboard/emulation/qemu-riscv/Kconfig b/src/mainboard/emulation/qemu-riscv/Kconfig
index 091c432..d2ac846 100644
--- a/src/mainboard/emulation/qemu-riscv/Kconfig
+++ b/src/mainboard/emulation/qemu-riscv/Kconfig
@@ -26,6 +26,7 @@
select SOC_UCB_RISCV
select BOARD_ROMSIZE_KB_16384
select BOOT_DEVICE_NOT_SPI_FLASH
+ select FLATTENED_DEVICE_TREE
select MISSING_BOARD_RESET
select DRIVERS_UART_8250MEM
select RISCV_HAS_OPENSBI
diff --git a/src/soc/ucb/riscv/cbmem.c b/src/soc/ucb/riscv/cbmem.c
index 5c423a0..1bc26a3 100644
--- a/src/soc/ucb/riscv/cbmem.c
+++ b/src/soc/ucb/riscv/cbmem.c
@@ -3,8 +3,16 @@
#include <cbmem.h>
#include <symbols.h>
#include <ramdetect.h>
+#include <device_tree.h>
+#include <mcall.h>
uintptr_t cbmem_top_chipset(void)
{
+ uintptr_t top;
+
+ top = fdt_get_memory_top((void *)HLS()->fdt);
+ if (top)
+ return top;
+
return (uintptr_t)_dram + (probe_ramsize((uintptr_t)_dram, CONFIG_DRAM_SIZE_MB) * MiB);
}
--
To view, visit https://review.coreboot.org/c/coreboot/+/80363?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e4a95f49ad373675939329eef40d7423a4132ab
Gerrit-Change-Number: 80363
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Gerrit-MessageType: newchange
Alper Nebi Yasak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80322?usp=email )
Change subject: device_tree: Add function to get top of memory from a FDT blob
......................................................................
device_tree: Add function to get top of memory from a FDT blob
Coreboot needs to figure out top of memory to place CBMEM data. On some
non-x86 QEMU virtual machines, this is achieved by probing the RAM space
to find where the VM starts discarding data since it's not backed by
actual RAM. This behaviour seems to have changed on the QEMU side since
then, VMs using the "virt" model have started raising exceptions/errors
instead of silently discarding data (likely [1] for example) which has
broken coreboot on these emulation boards.
The qemu-aarch64 mainboard is intended for the "virt" model and had this
issue, which was fixed by using exception handlers in the RAM detection
process [2].
The qemu-riscv mainboard is also for "virt" and still has this issue.
There is a potential fix based on the exception handler approach [3],
but it fails to build for 32-bit RISC-V. There's also a WIP attempt on
parsing the in-memory device-tree that QEMU provides us [4], but it
relies on unflattening which wouldn't work on romstage.
The qemu-armv7 mainboard code is intended for the "vexpress-a9" model VM
which doesn't appear to suffer from this issue. Still, the issue can be
observed on the ARMv7 "virt" model via a port based on qemu-aarch64.
QEMU docs for ARM and RISC-V "virt" models [5][6] recommend reading the
device tree blob it provides for device information (incl. RAM size).
Implement a function that parses the device tree blob to find the top of
memory in order to use it in mainboard code as an alternative to probing
RAM space. ARM64 code initializes CBMEM in romstage where malloc isn't
available, so take care to do parsing without unflattening the blob and
make the code available in romstage as well.
This assumes a single memory node with a single reg range which seems
to be enough for what QEMU provides for now, support for more complex
device-trees (as supported by specification) is left as future work.
[1] https://lore.kernel.org/qemu-devel/1504626814-23124-1-git-send-email-peter.…
[2] https://review.coreboot.org/c/coreboot/+/34774
[3] https://review.coreboot.org/c/coreboot/+/36486
[4] https://review.coreboot.org/c/coreboot/+/78981
[5] https://qemu-project.gitlab.io/qemu/system/arm/virt.html
[6] https://qemu-project.gitlab.io/qemu/system/riscv/virt.html
Change-Id: I8bef09bc1bc4e324ebeaa37f78d67d3aa315f52c
Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
---
M src/include/device_tree.h
M src/lib/Makefile.mk
M src/lib/device_tree.c
3 files changed, 102 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/80322/1
diff --git a/src/include/device_tree.h b/src/include/device_tree.h
index 02fcaa7..95fb30c 100644
--- a/src/include/device_tree.h
+++ b/src/include/device_tree.h
@@ -100,6 +100,9 @@
void fdt_print_node(const void *blob, uint32_t offset);
int fdt_skip_node(const void *blob, uint32_t offset);
+ /* Find top of memory from a flat device-tree. */
+uintptr_t fdt_get_memory_top(const void *blob);
+
/* Read a flattened device tree into a hierarchical structure which refers to
the contents of the flattened tree in place. Modifying the flat tree
invalidates the unflattened one. */
diff --git a/src/lib/Makefile.mk b/src/lib/Makefile.mk
index 2a95be9..ae149e4 100644
--- a/src/lib/Makefile.mk
+++ b/src/lib/Makefile.mk
@@ -162,10 +162,12 @@
ramstage-$(CONFIG_GENERIC_UDELAY) += timer.c
ramstage-y += b64_decode.c
ramstage-$(CONFIG_ACPI_NHLT) += nhlt.c
-ramstage-$(CONFIG_FLATTENED_DEVICE_TREE) += device_tree.c
ramstage-$(CONFIG_PAYLOAD_FIT_SUPPORT) += fit.c
ramstage-$(CONFIG_PAYLOAD_FIT_SUPPORT) += fit_payload.c
+romstage-$(CONFIG_FLATTENED_DEVICE_TREE) += device_tree.c
+ramstage-$(CONFIG_FLATTENED_DEVICE_TREE) += device_tree.c
+
romstage-$(CONFIG_TIMER_QUEUE) += timer_queue.c
ramstage-$(CONFIG_TIMER_QUEUE) += timer_queue.c
diff --git a/src/lib/device_tree.c b/src/lib/device_tree.c
index ab9c937b..ed2b56f 100644
--- a/src/lib/device_tree.c
+++ b/src/lib/device_tree.c
@@ -11,6 +11,7 @@
#include <string.h>
#include <stddef.h>
#include <stdlib.h>
+#include <limits.h>
/*
* Functions for picking apart flattened trees.
@@ -166,6 +167,101 @@
return offset - start_offset + sizeof(uint32_t);
}
+/*
+ * Find top of memory from a flat device-tree.
+ */
+uintptr_t fdt_get_memory_top(const void *blob)
+{
+ struct fdt_property prop;
+ struct fdt_header *header;
+ int size, offset;
+ const char *name;
+
+ header = (struct fdt_header *)blob;
+ if (be32_to_cpu(header->magic) != FDT_HEADER_MAGIC)
+ return 0;
+
+ offset = be32toh(header->structure_offset);
+ size = fdt_node_name(blob, offset, &name);
+ offset += size;
+
+ int addr_cells = 0;
+ int size_cells = 0;
+ while ((size = fdt_next_property(blob, offset, &prop))) {
+ if (!strncmp(prop.name, "#address-cells", sizeof("#address-cells")))
+ addr_cells = be32toh(*(uint32_t *)prop.data);
+ else if (!strncmp(prop.name, "#size-cells", sizeof("#size-cells")))
+ size_cells = be32toh(*(uint32_t *)prop.data);
+
+ offset += size;
+ }
+ if (!addr_cells || !size_cells)
+ return 0;
+
+ /* TODO: Handle multiple memory nodes */
+ uint32_t mem_offset = 0;
+ while ((size = fdt_skip_node(blob, offset))) {
+ fdt_node_name(blob, offset, &name);
+ if (!strncmp(name, "memory", sizeof("memory") ||
+ !strncmp(name, "memory@", sizeof("memory@") - 1))) {
+ mem_offset = offset;
+ break;
+ }
+
+ offset += size;
+ }
+ if (!mem_offset)
+ return 0;
+
+ uint32_t reg_size = 0;
+ uint32_t *reg_data = NULL;
+ size = fdt_node_name(blob, mem_offset, &name);
+ offset = mem_offset + size;
+ while ((size = fdt_next_property(blob, offset, &prop))) {
+ offset += size;
+ if (!strncmp(prop.name, "reg", sizeof("reg"))) {
+ reg_data = (uint32_t *)prop.data;
+ reg_size = prop.size;
+ break;
+ }
+ }
+ if (!reg_size || !reg_data)
+ return 0;
+
+ /* TODO: Handle multiple ranges in reg property */
+ int i;
+ uintptr_t mem_base = 0;
+ uintptr_t mem_size = 0;
+ uintptr_t top = 0;
+ for (i = 0; i < addr_cells; i++) {
+ if (i >= (addr_cells - sizeof(uintptr_t) / 4)) {
+ mem_base = (uintptr_t)((uint64_t)mem_base << 32);
+ mem_base |= be32toh(reg_data[i]);
+ } else if (be32toh(reg_data[i])) {
+ mem_base = UINTPTR_MAX;
+ break;
+ }
+ }
+ for (i = 0; i < size_cells; i++) {
+ if (i >= (size_cells - sizeof(uintptr_t) / 4)) {
+ mem_size = (uintptr_t)((uint64_t)mem_size << 32);
+ mem_size |= be32toh(reg_data[addr_cells + i]);
+ } else if (be32toh(reg_data[addr_cells + i])) {
+ mem_size = UINTPTR_MAX;
+ break;
+ }
+ }
+
+ if (mem_size > UINTPTR_MAX - mem_base)
+ top = UINTPTR_MAX;
+ else
+ top = mem_base + mem_size;
+
+ printk(BIOS_DEBUG, "FDT: Found %u MiB of addressable RAM\n",
+ (uint32_t)((top - mem_base) / MiB));
+
+ return top;
+}
/*
--
To view, visit https://review.coreboot.org/c/coreboot/+/80322?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8bef09bc1bc4e324ebeaa37f78d67d3aa315f52c
Gerrit-Change-Number: 80322
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-MessageType: newchange
Alper Nebi Yasak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80321?usp=email )
Change subject: mainboard/qemu-aarch64: Map entire RAM space as read-write memory
......................................................................
mainboard/qemu-aarch64: Map entire RAM space as read-write memory
Commit 977b8e83cb0a ("mb/emulation/qemu-aarch64: Add MMU support") adds
MMU support for ARM64 QEMU VMs, but registers a limited 1GiB region for
the DRAM, with a note that ramstage should update it.
However on recent versions of QEMU "virt" VMs, accessing RAM outside
this registered region results in an exception even if the address is
backed by actual RAM. This interferes with RAM detection which catches
these exceptions, effectively limiting us to detecting a maximum 1GiB of
RAM even if more is available.
Register the entire RAM space to MMU instead of just the 1GiB, so that
probing RAM addresses can correctly detect how much RAM we have.
Change-Id: I3afbd27b91ab37304a29a62506f965ac3cfb1c06
Signed-off-by: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
---
M src/mainboard/emulation/qemu-aarch64/bootblock.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/80321/1
diff --git a/src/mainboard/emulation/qemu-aarch64/bootblock.c b/src/mainboard/emulation/qemu-aarch64/bootblock.c
index 5fe0888..5561d6f 100644
--- a/src/mainboard/emulation/qemu-aarch64/bootblock.c
+++ b/src/mainboard/emulation/qemu-aarch64/bootblock.c
@@ -10,8 +10,7 @@
/* Everything below DRAM is device memory */
mmu_config_range((void *)0, (uintptr_t)_dram, MA_DEV | MA_RW);
- /* Set a dummy value for DRAM. ramstage should update the mapping. */
- mmu_config_range(_dram, 1 * GiB, MA_MEM | MA_RW);
+ mmu_config_range(_dram, (uintptr_t)CONFIG_DRAM_SIZE_MB * MiB, MA_MEM | MA_RW);
mmu_config_range(_ttb, REGION_SIZE(ttb), MA_MEM | MA_S | MA_RW);
mmu_config_range(_bootblock, REGION_SIZE(bootblock), MA_MEM | MA_S | MA_RW);
--
To view, visit https://review.coreboot.org/c/coreboot/+/80321?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3afbd27b91ab37304a29a62506f965ac3cfb1c06
Gerrit-Change-Number: 80321
Gerrit-PatchSet: 1
Gerrit-Owner: Alper Nebi Yasak <alpernebiyasak(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Derek Huang, Dolan Liu, Kapil Porwal, Nick Vaccaro, Subrata Banik, Weimin Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80316?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa: Skip locking for GPP_F15 GPIO
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80316/comment/6a973a35_37ba8da6 :
PS5, Line 7: Skip locking for GPP_F15 GPIO
Maybe: Skip GPP_F15 GPIO locking to avoid IRQ storm
https://review.coreboot.org/c/coreboot/+/80316/comment/e129a2f1_477cbcd8 :
PS5, Line 16: will occurs
occurs or will occur
https://review.coreboot.org/c/coreboot/+/80316/comment/db8f15ec_25d9b030 :
PS5, Line 9: There is an existing issue for nissa where wake up from
: RTC wake is not working during suspend_stress_test.
:
: The phenomenon of the issue is that after pulling out the
: stylus, can see an interrupt storm occurs checking through
: "cat /proc/interrupts | grep acpi".
: When the counter of interrupt is greater than a certain
: value, "Disabling IRQ #9" will occurs, so RTC wake is not
: working.
Please make use of the whole length of 72 characters per line. Please also add a blank line between paragraphs.
https://review.coreboot.org/c/coreboot/+/80316/comment/795ce50c_c80e9ca1 :
PS5, Line 22: dispeared
Present tense: disappears
--
To view, visit https://review.coreboot.org/c/coreboot/+/80316?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie143c43e0555d17d8a290f17637b537fba806144
Gerrit-Change-Number: 80316
Gerrit-PatchSet: 5
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Derek Huang <derekhuang(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 09:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80320?usp=email )
Change subject: libpayload: timer: Revert timer_hz() return type to 64-bits
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Commenting here too: I saw it once with emulation/qemu-i440fx with FILO payload on a Dell XPS 13 9360 (i7-7500U) with Debian sid/unstable and qemu-systemd-x86_64 1:8.2.1+ds-1.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80320?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I471c7de7a28aec5bb965b23525ed579481ac8361
Gerrit-Change-Number: 80320
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 07 Feb 2024 09:02:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Dolan Liu, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik, Weimin Wu.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80259?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/anraggar: Config DP AUX BIAS according to fw_config
......................................................................
Patch Set 13:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80259/comment/9d81b27d_d6df7adb :
PS13, Line 9: EVT mini-build changes redriver IC from PS8745 to ANX7493, the
: ANX7493 not support DP AUX BIAS, so connects DP AUX BIAS
: of DB to SOC directly. Add DB_AUX_BIAS bit field to fw_config
: for compatibility.
Please re-flow for 72 characters per line.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80259?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53974ec7444912a63d0fe0a9303c9e5d6941f68d
Gerrit-Change-Number: 80259
Gerrit-PatchSet: 13
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 09:01:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Yidi Lin.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email )
Change subject: libpayload/libc/time: Fix possible overflow in multiplication
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78888/comment/c7a85c27_845b4a28 :
PS11, Line 15: counter should never be that fast.
> Okay, uploaded CB:80320 to doo that for now.
I saw it *once* with emulation/qemu-i440fx with FILO payload on a Dell XPS 13 9360 (i7-7500U) with Debian sid/unstable and *qemu-systemd-x86_64* 1:8.2.1+ds-1.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78888?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89
Gerrit-Change-Number: 78888
Gerrit-PatchSet: 11
Gerrit-Owner: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Wed, 07 Feb 2024 09:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Paul Menzel.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80320?usp=email )
Change subject: libpayload: timer: Revert timer_hz() return type to 64-bits
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
We also need to revert http://crrev.com/c/5010436 in depthcharge
--
To view, visit https://review.coreboot.org/c/coreboot/+/80320?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I471c7de7a28aec5bb965b23525ed579481ac8361
Gerrit-Change-Number: 80320
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 07 Feb 2024 08:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80319?usp=email )
Change subject: commonlib: Change GCD function to always use 64 bits
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80319?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I028361444c4048a0d76ba4f80c7334a9d9983c87
Gerrit-Change-Number: 80319
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Wed, 07 Feb 2024 08:48:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment