coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: util/crossgcc: Update CMake from 3.30.2 to 3.31.2
by Elyes Haouas (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Felix Singer, Martin L Roth. Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85168?usp=email ) Change subject: util/crossgcc: Update CMake from 3.30.2 to 3.31.2 ...................................................................... Patch Set 5: (2 comments) Patchset: PS4: > Blocking until release is finished Done Patchset: PS5: Please upgrade to 3.31.3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85168?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I573dace3b752a0d3c4614ece9c0845f8334e2857 Gerrit-Change-Number: 85168 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Sat, 21 Dec 2024 05:32:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: Update vboot submodule to upstream main
by Yu-Ping Wu (Code Review) 21 Dec '24

21 Dec '24

Yu-Ping Wu has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85676?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Update vboot submodule to upstream main ...................................................................... Update vboot submodule to upstream main Updating from commit id f1f70f46dc54: 2024-07-31 14:57:49 +0000 - (2lib: Add gbb flag to enforce CSE sync) to commit id 3f94e2c7ed58: 2024-12-18 16:14:28 -0800 - (Makefile: Allow cross-compilation for RISC-V) This brings in 49 new commits: 3f94e2c7ed58 Makefile: Allow cross-compilation for RISC-V 44c19d1893aa futility/updater: Remove obsolete write protection help URL d1813a4666d7 futility: Add shell-parseable manifest format 2935820d404e vboot.rc: Mount tmpfs with SELinux context c57a588f8029 crossystem: Change cros_debug to rely on mainfw_type, not devsw_boot 3ff18c08ee7d Android.bp: Remove host_supported for crossystem dfd2b7c7404e Android.bp: Remove unused static libraries for firmware builds f8eb37d14935 Makefile: Drop vboot_fw.a dependency for futility 0d49b8fdf002 recovery_kernel: add signing type recovery_kernel 1f7ca823da09 gpt_misc: Return uint64_t from GptGetEntrySize functions 3662103165a3 Reland "host/lib/flashrom: Use flashrom provided in PATH" 26e8011fd517 Add configurable temporary directory path a0f83f9f3a0c futility: Drop futility execution logging to /tmp/futility.log 862e250e672c crossystem: Make crossystem vendor_available 3246e484ca08 futility: updater: Increase try count from 11 to 13 2ab8888bddac make_dev_ssd: add upstream cmdline flag for ptracers 3c2ef9400c05 Update Rust OWNERS file to include libchromeos-rs/OWNERS c5af1fd8490d make_dev_ssd.sh: avoid page cache aliasing 38f9c255d31d Revert "host/lib/flashrom: Use flashrom provided in PATH" 7d4b23f9a054 futility: updater: Revise the test script 8494502d9f0b futility: updater: Support emulation in the output mode 54be900d8e1a futility: updater: Handle flashrom read failure in load_system_firmware 2a78755815d6 futility: updater: Drop `signature_id` from implementation 90f591700475 futility: updater: Add a new config 'output_only' 94d884d8a5bb futility: updater: Deprecate `--signature_id` by `--model` 24fd715c90e8 host/lib/flashrom: Use flashrom provided in PATH ac49f1ca939b Build thin archives 640fe19f5f92 host/lib/crossystem: Make CROSSYSTEM_LOCK_PATH configurable 86b42b6a930c sign_android_image: calculate and store the vb meta digest da1d153b4eed Move futility and cgpt to vendor partition 80955816aee0 futility: updater: Remove 'allow_empty_custom_label_tag' quirk 7ad2b0ab5035 futility: updater: Process custom label as standard models 13400d696a5e futility: updater: Remove signature_id from manifest f770c7d074a2 futility: updater: Remove the legacy 'setvars.sh' manifest ed4556edb968 tests/futility: Add test cases for unmodified RO 219026290256 futility/file_type_bios.c: Skip keyblock checks if magic is invalid f5924321909d Fix partition type check for miniOS B 83f845b3b5da signing: clean up owners dc5102f2f061 signing: miniOS signing in docker. 16e6aa8907fc futility: updater: Provide default DUT properties for emulation e56f3686526c tests/futility/test_update: Fix --sys_props argument 7e2828a1bacf futility: updater: cleanup: Remove duplicated comments 060efa0cf64d vboot: Only execute TPM clear on nonchrome FW 2fc6815bf6b5 sign_official_build: Include full loem.ini path 47658f3c89e2 2lib/2load_kernel: Remove unused VB2_LOAD_PARTITION_WORKBUF_BYTES 7cc2ce4c902b futility: Skip printing EC RW version if non-printable 8365d546ce06 futility/load_fmap: Erase remaining bytes if file smaller than area ec01126c04cd swap_ec_rw: Search for keyset in source tree too b76d74dc08ac futility/load_fmap: use WARN() on non-critical error Change-Id: I48f960235088c17dc59235b07926acd52e03deb2 Signed-off-by: Carlos López <carlos.lopez(a)openchip.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85676 Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/3rdparty/vboot b/3rdparty/vboot index f1f70f4..3f94e2c 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit f1f70f46dc5482bb7c654e53ed58d4001e386df2 +Subproject commit 3f94e2c7ed58c4e67d6e7dc6052ec615dbbb9bb4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85676?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I48f960235088c17dc59235b07926acd52e03deb2 Gerrit-Change-Number: 85676 Gerrit-PatchSet: 3 Gerrit-Owner: Carlos López <carlos.lopezr4096(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: amdfwtool: Clean up the code to make it more logical
by Bao Zheng (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru. Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84531?usp=email ) Change subject: amdfwtool: Clean up the code to make it more logical ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84531/comment/e989ae18_f80ed214?us… : PS6, Line 1: Parent: f0dcf8f9 (amdfwtool: Reorder the PSP L2 and BIOS L2 for A/B recovery) Put all the steps for A/B recovery into one branches. -- To view, visit https://review.coreboot.org/c/coreboot/+/84531?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f7213fd42c7f0ff5ecd9e504a6654cdfb1e3513 Gerrit-Change-Number: 84531 Gerrit-PatchSet: 6 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 21 Dec 2024 02:11:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: amdfwtool: Set address mode as relative table
by Bao Zheng (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Felix Held, Julius Werner, Marshall Dawson, Zheng Bao, ritul guru. Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84530?usp=email ) Change subject: amdfwtool: Set address mode as relative table ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84530/comment/1217ba90_ec6e5f0f?us… : PS5, Line 9: defines define https://review.coreboot.org/c/coreboot/+/84530/comment/02102818_2fd6510b?us… : PS5, Line 9: new newer -- To view, visit https://review.coreboot.org/c/coreboot/+/84530?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I156b315d350d9e7217afc7442ca80277bb7f9095 Gerrit-Change-Number: 84530 Gerrit-PatchSet: 5 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 21 Dec 2024 02:00:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: amdfwtool: Check fletcher of each header
by Bao Zheng (Code Review) 21 Dec '24

21 Dec '24

Attention is currently required from: Felix Held, Julius Werner, Zheng Bao. Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email ) Change subject: amdfwtool: Check fletcher of each header ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84338/comment/9ee0e31c_98060104?us… : PS4, Line 10: is are -- To view, visit https://review.coreboot.org/c/coreboot/+/84338?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7540386027c6449317e9b7c0b4fd22d09d4a3a3 Gerrit-Change-Number: 84338 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Zheng Bao Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sat, 21 Dec 2024 01:57:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: util/crossgcc: Update variable use
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Jon Murphy, Martin L Roth. Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85718?usp=email ) Change subject: util/crossgcc: Update variable use ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85718/comment/c3538332_ef3e4f48?us… : PS2, Line 14: Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2 missing sign-off -- To view, visit https://review.coreboot.org/c/coreboot/+/85718?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2 Gerrit-Change-Number: 85718 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 22:31:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/system76/mtl: Enable NPU
by Felix Singer (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Jeremy Soller, Tim Crawford. Felix Singer has posted comments on this change by Tim Crawford. ( https://review.coreboot.org/c/coreboot/+/85721?usp=email ) Change subject: mb/system76/mtl: Enable NPU ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85721?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b5c3030c6378c0998a2ac792126c15d2e17bbf9 Gerrit-Change-Number: 85721 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 22:30:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: commonlib: Refactor CSE sync eventLog
by Karthik Ramasubramanian (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Subrata Banik. Karthik Ramasubramanian has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/85622?usp=email ) Change subject: commonlib: Refactor CSE sync eventLog ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85622?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5db3ffb43b2ceac821de72ef9e88ed62e617d41 Gerrit-Change-Number: 85622 Gerrit-PatchSet: 2 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:48:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add indexed IO support
by Caveh Jalali (Code Review) 20 Dec '24

20 Dec '24

Attention is currently required from: Boris Mittelberg, Jayvik Desai, Kapil Porwal, Subrata Banik. Caveh Jalali has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85449?usp=email ) Change subject: ec/google/chromeec: Add indexed IO support ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85449?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1aab3fc914eb5af2736a8ea3adf447040905e0 Gerrit-Change-Number: 85449 Gerrit-PatchSet: 6 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 20 Dec 2024 21:34:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Prevent HECI commands when flash descript...
by Tim Crawford (Code Review) 20 Dec '24

20 Dec '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82728?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/common/block/cse: Prevent HECI commands when flash descriptor override is set ...................................................................... soc/intel/common/block/cse: Prevent HECI commands when flash descriptor override is set Sending the disable and EOP commands will not work if flash descriptor override is set on Meteor Lake. Change-Id: I3b5a56229434c9cc326141d48359faa7759541ee Signed-off-by: Jeremy Soller <Jeremy(a)system76.com> Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c M src/soc/intel/common/block/fast_spi/fast_spi.c M src/soc/intel/common/block/include/intelblocks/fast_spi.h 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/82728/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/82728?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3b5a56229434c9cc326141d48359faa7759541ee Gerrit-Change-Number: 82728 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024