coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add MT6685 adc init
by Yidi Lin (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email ) Change subject: soc/mediatek/mt8196: Add MT6685 adc init ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85734/comment/14acc74d_23eac403?us… : PS3, Line 7: adc > Actually configs MT6685 ADC SW initial setting here, TIA will read thermal info in HW. Please mention this in the commit message. If the initial setting includes other features, please also mention them in the commit message. File src/soc/mediatek/common/mt6685.c: https://review.coreboot.org/c/coreboot/+/85734/comment/10eb0df7_d945e34d?us… : PS3, Line 59: wdata = mt6685_read_field(MT6685_TOP_RST_MISC, 0xFFFF, 0); : printk(BIOS_INFO, "[%s]MT6685 TOP_RST_MISC = %#x\n", __func__, wdata); > Done done what ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e Gerrit-Change-Number: 85734 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 24 Dec 2024 14:32:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/corsola: Refactor mipi_panel_power_on function
by Yang Wu (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu. Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/85745?usp=email ) Change subject: mb/google/corsola: Refactor mipi_panel_power_on function ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85745/comment/26487b41_0517afd9?us… : PS6, Line 7: mb/google/corsola: refactor mipi_panel_power_on function > Upper case Refactor Done File src/mainboard/google/corsola/panel_starmie.c: https://review.coreboot.org/c/coreboot/+/85745/comment/caf49275_ce1d4457?us… : PS6, Line 4: #include <delay.h> : #include <gpio.h> : #include <soc/regulator.h> > unused includes ? Done File src/mainboard/google/corsola/panel_tps65132s.c: https://review.coreboot.org/c/coreboot/+/85745/comment/6774b48b_e0bb52c3?us… : PS6, Line 14: const struct tps65132s_reg_setting reg_settings[] = { > Tab after const Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0561e57d99ab55e6dcbb7744b2228c4cebb0d88 Gerrit-Change-Number: 85745 Gerrit-PatchSet: 7 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 24 Dec 2024 14:29:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/corsola: Refactor mipi_panel_power_on function
by Yang Wu (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yidi Lin. Hello Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85745?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by Yidi Lin, Verified+1 by build bot (Jenkins) Change subject: mb/google/corsola: Refactor mipi_panel_power_on function ...................................................................... mb/google/corsola: Refactor mipi_panel_power_on function Refactor mipi_panel_power_on function in panel-starmie.c to reduce code duplication. BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage and check FW screen BRANCH=corsola Change-Id: Ic0561e57d99ab55e6dcbb7744b2228c4cebb0d88 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Makefile.mk M src/mainboard/google/corsola/panel.h M src/mainboard/google/corsola/panel_starmie.c A src/mainboard/google/corsola/panel_tps65132s.c 4 files changed, 49 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/85745/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/85745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic0561e57d99ab55e6dcbb7744b2228c4cebb0d88 Gerrit-Change-Number: 85745 Gerrit-PatchSet: 7 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/corsola: Add new board variant Wyrdeer
by Yang Wu (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Hung-Te Lin, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85742?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by Xinxiong Xu, Code-Review+1 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: mb/google/corsola: Add new board variant Wyrdeer ...................................................................... mb/google/corsola: Add new board variant Wyrdeer Add a new Staryu follower device 'Wyrdeer'. And add MIPI panel support. BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage and check FW screen BRANCH=corsola Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name M src/mainboard/google/corsola/Makefile.mk A src/mainboard/google/corsola/panel_wyrdeer.c 4 files changed, 46 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/85742/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I07b73c97d8d51b32f557e31d834ffc6cfb8420ed Gerrit-Change-Number: 85742 Gerrit-PatchSet: 6 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[L] Change in coreboot[main]: Documentation: Update information about intelp2m
by Maxim Polyakov (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Felix Singer, Filip Lewiński, Maxim Polyakov, Paul Menzel. Hello Felix Singer, Filip Lewiński, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/71757?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Documentation: Update information about intelp2m ...................................................................... Documentation: Update information about intelp2m Change-Id: I80d5fb5d46b50193e8fecc647d9052a2e29af93f Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com> --- M Documentation/util.md D Documentation/util/intelp2m/gopackages.png M Documentation/util/intelp2m/index.md M util/README.md 4 files changed, 215 insertions(+), 152 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/71757/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/71757?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80d5fb5d46b50193e8fecc647d9052a2e29af93f Gerrit-Change-Number: 71757 Gerrit-PatchSet: 11 Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for KD_KD110N11_51IE panel
by Yidi Lin (Code Review) 24 Dec '24

24 Dec '24

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85741?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: drivers/mipi: Add support for KD_KD110N11_51IE panel ...................................................................... drivers/mipi: Add support for KD_KD110N11_51IE panel Add K&D panel KD_KD110N11_51IE serializable data to CBFS. Datasheet: KD110N11-51IE-A008_SPEC_A00_20241219.pdf BUG=b:379810871 TEST=build and check the CBFS include the panel BRANCH=None Change-Id: Iecf7957185afd1c62f768d163bba69ed373b7f92 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85741 Reviewed-by: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-KD_KD110N11_51IE.c 3 files changed, 110 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved Xinxiong Xu: Looks good to me, but someone else must approve diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index d70e92d..a7049ba 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -48,6 +48,9 @@ config MIPI_PANEL_KD_KD101NE3_40TI bool +config MIPI_PANEL_KD_KD110N11_51IE + bool + config MIPI_PANEL_LCE_LMFBX101117480 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index a71cff6..0c4a5c9 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -24,6 +24,7 @@ panel-params-$(CONFIG_MIPI_PANEL_IVO_T109NW41) += panel-IVO_T109NW41 panel-params-$(CONFIG_MIPI_PANEL_KD_KD101NE3_40TI) += panel-KD_KD101NE3_40TI +panel-params-$(CONFIG_MIPI_PANEL_KD_KD110N11_51IE) += panel-KD_KD110N11_51IE panel-params-$(CONFIG_MIPI_PANEL_LCE_LMFBX101117480) += panel-LCE_LMFBX101117480 diff --git a/src/drivers/mipi/panel-KD_KD110N11_51IE.c b/src/drivers/mipi/panel-KD_KD110N11_51IE.c new file mode 100644 index 0000000..6d44375 --- /dev/null +++ b/src/drivers/mipi/panel-KD_KD110N11_51IE.c @@ -0,0 +1,106 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data KD_KD110N11_51IE = { + .edid = { + .ascii_string = "KD110N11-51IE", + .manufacturer_name = "KD", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 182888, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 284, .hso = 124, .hspw = 80, + .va = 1920, .vbl = 134, .vso = 88, .vspw = 8, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + + .init = { + PANEL_DELAY(24), + PANEL_DCS(0x11), + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD9, 0xD1), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB1, 0x2C, 0xB3, 0xB3, 0x31, 0xF1, 0x33, 0xE0, 0x54, + 0x36, 0x36, 0x3A, 0x3A, 0x32, 0x8B, 0x11, 0xE5, 0x98), + PANEL_DCS(0xE9, 0xD9), + PANEL_DCS(0xB1, 0x8B, 0x33), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x2C, 0x80, 0x3C, + 0x9F, 0x22, 0x20, 0x00, 0x00, 0x98, 0x51), + PANEL_DCS(0xB4, 0x64, 0x64, 0x64, 0x64, 0x64, 0x64, 0x40, 0x84, + 0x64, 0x84, 0x01, 0x9D, 0x01, 0x02, 0x01, 0x00, 0x00), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4, 0x80, 0x9C, 0x36, 0x00, 0x0D, 0x04), + PANEL_DCS(0xC0, 0x32, 0x32, 0x22, 0x11, 0x22, 0xA0, 0x31, 0x08, + 0xF5, 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xC8, 0x97), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x13, 0x88, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x36), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xD1, 0x07, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x40, 0x04, 0x08, 0x04, + 0x08, 0x37, 0x07, 0x44, 0x37, 0x2B, 0x2B, 0x03, 0x03, 0x32, + 0x10, 0x22, 0x00, 0x25, 0x32, 0x10, 0x29, 0x00, 0x29, 0x32, + 0x10, 0x08, 0x00, 0x08, 0x00, 0x00), + PANEL_DCS(0xD5, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, + 0x18, 0x18, 0x07, 0x06, 0x07, 0x06, 0x05, 0x04, 0x05, 0x04, + 0x03, 0x02, 0x03, 0x02, 0x01, 0x00, 0x01, 0x00, 0x18, 0x18, + 0x25, 0x24, 0x25, 0x24, 0x1F, 0x1F, 0x1F, 0x1F, 0x1E, 0x1E, + 0x1E, 0x1E, 0x20, 0x20, 0x20, 0x20), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xE7, 0xE0, 0x10, 0x10, 0x0D, 0x1E, 0x9D, 0x02, 0x52, + 0x9D, 0x14, 0x14), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD2, 0x64), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xD3, 0x00), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0, 0x05, 0x15, 0x55, 0x45, 0x55, 0x50, + 0x05, 0x15, 0x55, 0x45, 0x55, 0x50), + PANEL_DCS(0xE7, 0x02, 0x00, 0x24, 0x01, 0x7E, 0x0F, 0x7C, 0x10, + 0xA0, 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xCB, 0x03, 0x07, 0x00, 0x10, 0x7B), + PANEL_DCS(0xD8, 0x0F, 0x3F, 0xFF, 0xCF, 0xFF, 0xF0, 0x0F, 0x3F, + 0xFF, 0xCF, 0xFF, 0xF0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, + 0x00, 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20, 0x9D, + 0x02, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xB2, 0x66, 0x81), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, + 0xAA, 0x8A, 0xAA, 0xA0, 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, + 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, 0x0A, 0x2A, 0xAA, 0x8A, + 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xB9, 0x00, 0x00, 0x00, 0x00), + + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/85741?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iecf7957185afd1c62f768d163bba69ed373b7f92 Gerrit-Change-Number: 85741 Gerrit-PatchSet: 4 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: ec/google/chromeec: Add API to check if a USB PD charger is attached
by Kapil Porwal (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Pranava Y N, Subrata Banik. Kapil Porwal has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85743?usp=email ) Change subject: ec/google/chromeec: Add API to check if a USB PD charger is attached ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I47c934ee8a7563d4ba5124bff5613e61dd66e923 Gerrit-Change-Number: 85743 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Tue, 24 Dec 2024 14:02:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake)
by Name of user not set (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Alicja Michalska. Name of user not set #1004406 has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email ) Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) ...................................................................... Patch Set 21: (2 comments) File src/mainboard/asrock/h370m/devicetree.cb: https://review.coreboot.org/c/coreboot/+/65225/comment/6c84b57e_8f0e9190?us… : PS20, Line 14: device ref igpu on end > i have no igpu. […] Acknowledged https://review.coreboot.org/c/coreboot/+/65225/comment/3507894d_540ca251?us… : PS20, Line 59: device ref sata on > Check your GPIO config against Intel's PCH documentaton gpio changes have no effect on the sata/pcie m.2 behaviour. if sata is used last with the original bios, sata is also working with coreboot. the same is true for pcie m.2. -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 21 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Comment-Date: Tue, 24 Dec 2024 14:01:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com> Comment-In-Reply-To: Name of user not set #1004406

1 0

[L] Change in coreboot[main]: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake)
by Name of user not set (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Alicja Michalska, Name of user not set #1004406. Name of user not set #1004406 has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email ) Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) ...................................................................... Patch Set 21: (2 comments) File src/mainboard/asrock/h370m/devicetree.cb: https://review.coreboot.org/c/coreboot/+/65225/comment/c37fd090_c6993a09?us… : PS20, Line 6: register "s0ix_enable" = "1" > you are right. removing s0ix_enable and setting PchPmSlpS3* result in a correct sleep down. […] Acknowledged https://review.coreboot.org/c/coreboot/+/65225/comment/ada69cdc_fe9dee6e?us… : PS20, Line 115: device ref lpc_espi on > thanks for that information. i will contact nuvoton. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 21 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Name of user not set #1004406 Gerrit-Comment-Date: Tue, 24 Dec 2024 13:55:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com> Comment-In-Reply-To: Name of user not set #1004406

1 0

[L] Change in coreboot[main]: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake)
by Name of user not set (Code Review) 24 Dec '24

24 Dec '24

Attention is currently required from: Alicja Michalska. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65225?usp=email to look at the new patch set (#21). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) ...................................................................... mb/asrock: Add ASRock H370m-ITX support (Coffee Lake) I tested my code on a Intel i3-9100F under Ubuntu 24.04 and Windows 10 with SeaBIOS. the following things are working flawlessly: * all PCIe slots * all USB ports * VGA init in SeaBIOS (discrete nvida gpu) * WiFi and onboard sound * both Ethernet ports * all SATA ports (besides m.2) what was not tested: * front audio jacks whats not working: * suspend to ram, it won't poweroff correctly * edk2 with Windows 10+ * m.2 sata port/pcie is working romstage changes: * corrects resistor cfg (see 573387) * removes unused dq/dqs mappings * adds default config for Asrock H370M-ITX * uses devicetree pci aliases * removes unncesseray keys in devicetree.cb * rename Makefile.inc to Makefile.mk * load gpio config after FSP-S init * move gpio_table to C file * cleanup gpio.c * adds smbios_slot_desc * fixes pcie devicetree * adds superio config, still no s3 working :( Change-Id: I79302247311471153ebbba991081365d9265791b Signed-off-by: Max Fritz <antischmock(a)googlemail.com> --- A configs/config.asrock_h370m_itx A src/mainboard/asrock/h370m/Kconfig A src/mainboard/asrock/h370m/Kconfig.name A src/mainboard/asrock/h370m/Makefile.mk A src/mainboard/asrock/h370m/board_info.txt A src/mainboard/asrock/h370m/bootblock.c A src/mainboard/asrock/h370m/cmos.default A src/mainboard/asrock/h370m/cmos.layout A src/mainboard/asrock/h370m/devicetree.cb A src/mainboard/asrock/h370m/dsdt.asl A src/mainboard/asrock/h370m/gpio.c A src/mainboard/asrock/h370m/include/gpio.h A src/mainboard/asrock/h370m/ramstage.c A src/mainboard/asrock/h370m/romstage.c 14 files changed, 795 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/65225/21 -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 21 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024