Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85734?usp=email )
Change subject: soc/mediatek/mt8196: Add MT6685 Clock IC driver
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85734?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I26ae4f416202f04a8030259c49e009b19a60712e
Gerrit-Change-Number: 85734
Gerrit-PatchSet: 8
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>
Gerrit-Comment-Date: Sat, 28 Dec 2024 14:22:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Maxim Polyakov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85791?usp=email )
Change subject: Documentation/util/intelp2m: Add info for developers
......................................................................
Documentation/util/intelp2m: Add info for developers
Change-Id: I9cc886e607c1aba92b94e06419d45d9581371065
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M Documentation/util/intelp2m/index.md
1 file changed, 103 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/85791/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9cc886e607c1aba92b94e06419d45d9581371065
Gerrit-Change-Number: 85791
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Maxim Polyakov has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85791?usp=email )
Change subject: Documentation/util/intelp2m: Add info for developers
......................................................................
Documentation/util/intelp2m: Add info for developers
Change-Id: I9cc886e607c1aba92b94e06419d45d9581371065
Signed-off-by: Maxim Polyakov <max.senia.poliak(a)gmail.com>
---
M Documentation/util/intelp2m/index.md
1 file changed, 102 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/85791/1
diff --git a/Documentation/util/intelp2m/index.md b/Documentation/util/intelp2m/index.md
index 758f8c4..af689cb 100644
--- a/Documentation/util/intelp2m/index.md
+++ b/Documentation/util/intelp2m/index.md
@@ -28,7 +28,6 @@
```bash
cd util/intelp2m
make
-./intelp2m -version
```
Set automatic argument completion:
@@ -263,7 +262,108 @@
./intelp2m -fields ?
```
-## Unit testing
+## For developers
+
+### Version
+
+The version string includes several parts:
+
+```text
+{major}.{minor}-{last commit in the intelp2m directory}-{?dirty}
+```
+It depends on the changes: the `major` is incremented if a new platform is added, `minor` - if
+changes in functionality are made. Add `dirty` if the changes were not taken into account using
+git.
+
+The version is added to the generated `gpio.h` file and it is necessary to support the project.
+
+The version can also be printed in the console using the following command:
+
+```bash
+./intelp2m -version
+```
+
+### Adding support for new platforms
+
+The platform-dependent code is located in `./platforms/`. Each PCH and SoC is in a separate
+package with a name corresponding to this platform (adl, apl, snr, ...). The macro generation
+code for all platforms is in the `common` directory.
+
+The package file must contain the structure `BasePlatform struct{}` with methods for the
+`PlatformIf interface{}` from the `common` package:
+
+```Go
+type PlatformIf interface {
+ RemapResetSource(*Macro)
+ Pull(*Macro)
+ AddGpiMacro(*Macro)
+ AddGpoMacro(*Macro)
+ AddNativeFunctionMacro(*Macro)
+ AddNoConnMacro(*Macro)
+ GetRegisterDW0() *register.DW0
+ GetRegisterDW1() *register.DW1
+}
+```
+
+Some methods (for example, register access methods: `GetRegisterDW0()` and `GetRegisterDW1()`)
+are already defined in the base platform from `common`. Therefore, embedding should be used in
+the basic platform structure to avoid code duplication:
+
+```Go
+type BasePlatform struct {
+ common.BasePlatform
+}
+```
+
+Since GPIO controllers are similar across intel platforms, the macro generation code can also be
+reused. You can use any platform instead of `common.BasePlatform` from the catalog to reuse its
+methods and redefine those that differ in logic.
+
+The platform file should also contain the slice `GPPGroups[]` with templates for pad names from
+`inteltool.log`, register masks `DW0` and `DW1` (the analysis will be only for the bits in these
+masks), the base platform constructor - `InitBasePlatform()`, and `GetPlatform()` that provides
+the platform interface.
+
+```Go
+const (
+ DW0Mask = (0b1 << 27) | (0b1 << 18) | (0b00111111 << 11) | (0b00111111 << 2) | (0b1 << 1)
+ DW1Mask = 0b11111101111111111100001111111111
+)
+
+// "GPP_A", "GPP_B", "GPP_C", "GPP_D", "GPP_E", "GPP_F", "GPP_G", "GPP_H", "GPP_R", "GPP_S",
+// "GPP_T", "GPD", "HVMOS", "VGPIO5"
+var GPPGroups = []string{"GPP_", "GPD", "VGPIO"}
+
+type BasePlatform struct {
+ // based on the Cannon Lake platform
+ cnl.BasePlatform
+}
+
+func InitBasePlatform(dw0, dw0mask uint32, dw1, dw1mask uint32) BasePlatform {
+ return BasePlatform{cnl.InitBasePlatform(dw0, dw0mask, dw1, dw1mask)}
+}
+
+func GetPlatform(dw0, dw1 uint32) common.PlatformIf {
+ p := InitBasePlatform(dw0, DW0Mask, dw1, DW1Mask)
+ return &p
+}
+
+// Override BasePlatform.RemapResetSource()
+func (p *BasePlatform) RemapResetSource(m *common.Macro) {
+ // Some code is here
+}
+```
+
+- Use `GetPlatform()` and `GPPGroups[]` in the file `./platform/platform.go` to define the
+ resources for the parser.
+- Add the platform argument for the options `-p` (`-platform`) to `cli/options.go`.
+- Update the documentation in `Documentation/util/intelp2m/index.md`.
+- Add unit tests.
+
+[Here](https://review.coreboot.org/c/coreboot/+/84191) is an example of porting the Intel
+Jasper lake platform.
+
+### Unit testing
Please run the tests before creating a new commit:
--
To view, visit https://review.coreboot.org/c/coreboot/+/85791?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9cc886e607c1aba92b94e06419d45d9581371065
Gerrit-Change-Number: 85791
Gerrit-PatchSet: 1
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Attention is currently required from: Jérémy Compostella, Kapil Porwal, Paul Menzel, Pranava Y N.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85131?usp=email )
Change subject: soc/intel/pantherlake: Bind SoC config VR settings to respective UPD
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS6:
> Actually, the UPDs are still missing (I grepped the wrong directory this morning, I clearly need more coffee). We can review but we cannot submit.
can we push a UPD list CL inside FSP and partial header to include the missing UPDs ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/85131?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie72e4725cb97b4af7843a43eeaedd687d28b6752
Gerrit-Change-Number: 85131
Gerrit-PatchSet: 7
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Sat, 28 Dec 2024 03:08:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>
Nicholas Chin has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/85790?usp=email )
Change subject: util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
......................................................................
util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
Commit e24294ff9ade ("lsusb -t: print ports and busses and devices with
same width") [1] in the usbutils repository changed the format of the
lsusb -t output, breaking the find_usbdebug.sh script. This commit is
present in usbutils version 016 and later.
Use the output of lsusb -V to set the parsing patterns based on the
version in order to maintain compatibility with older versions of
usbutils. A simple integer comparison of the version number is used for
this, which will not work with versions older than v001 as those use a
0.nn version number format. However, since v001 was released in late
2010, it is probably safe to assume that no one will be using a version
of usbutils older than that. Usbutils v016 was released in late 2023 so
there could still conceivably be systems using older versions, such as
Ubuntu 22.04 LTS which is on v014.
TEST=find_usbdebug.sh works as expected with both lsusb v015 and v017
[1] https://github.com/gregkh/usbutils/commit/e24294ff9ade6dafcd1909763e888d97b…
Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/find_usbdebug/find_usbdebug.sh
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/85790/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/85790?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Gerrit-Change-Number: 85790
Gerrit-PatchSet: 3
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Nicholas Chin has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85790?usp=email )
Change subject: util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
......................................................................
util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
Commit e24294ff9ade ("lsusb -t: print ports and busses and devices with
same width") [1] in the usbutils repository changed the format of the
lsusb -t output, breaking the find_usbdebug.sh script. This commit is
present in usbutils version 016 and later.
Use the output of lsusb -V to determine the version and set the bus/port
parsing patterns accordingly to fix lsusb -t parsing for newer versions
of usbutils while maintaining compatibility with older versions. A
simple integer comparison of the version number is used, which will not
work with versions of usbutils older than v001 which used a 0.nn version
numbers. However, the newer version number format has been used since
2010, so it is probably safe to assume that no one will be using a
version of usbutils older than that.
TEST=find_usbdebug.sh works as expected with both lsusb v015 and v017
[1] https://github.com/gregkh/usbutils/commit/e24294ff9ade6dafcd1909763e888d97b…
Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/find_usbdebug/find_usbdebug.sh
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/85790/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85790?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Gerrit-Change-Number: 85790
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85790?usp=email )
Change subject: util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
......................................................................
util/find_usbdebug: Fix lsusb -t parsing for usbutils v016 and newer
Commit e24294ff9ade ("lsusb -t: print ports and busses and devices with
same width") [1] in the usbutils repository changed the format of the
lsusb -t output, breaking the find_usbdebug.sh script. This commit is
present in usbutils version 016 and later.
Use the output of lsusb -V to determine the version and set the bus/port
parsing patterns accordingly to fix lsusb -t parsing for newer versions
of usbutils while maintaining compatibility with older versions. A
simple integer comparison of the version number is used, which will not
work with versions of usbutils older than v001 which used a 0.nn version
numbers. However, the newer version number format has been used since
2010, so it is probably safe to assume that no one will be using a
version of usbutils older than that.
[1] https://github.com/gregkh/usbutils/commit/e24294ff9ade6dafcd1909763e888d97b…
Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com>
---
M util/find_usbdebug/find_usbdebug.sh
1 file changed, 9 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/85790/1
diff --git a/util/find_usbdebug/find_usbdebug.sh b/util/find_usbdebug/find_usbdebug.sh
index de370b1..ed5527e 100755
--- a/util/find_usbdebug/find_usbdebug.sh
+++ b/util/find_usbdebug/find_usbdebug.sh
@@ -32,8 +32,15 @@
find_devs_in_tree () {
bus=$1
port=$2
- busstr=`printf "Bus %02d" "$bus"`
- portstr="Port $port"
+
+ # lsusb -t uses 3 digits for bus/port nunmbers as of version 016 and later
+ if [ $(lsusb -V | cut -f 3 -d " ") -lt 16 ]; then
+ busstr=`printf "Bus %02d" "$bus"`
+ portstr="Port $port"
+ else
+ busstr=`printf "Bus %03d" "$bus"`
+ portstr=`printf "Port %03d" "$port"`
+ fi
hubs_to_ignore="8087:0020 8087:0024 8087:8000 8087:8008"
reqlvl=1
--
To view, visit https://review.coreboot.org/c/coreboot/+/85790?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iffa1238b995d387d6e51459f85ae96da52a5c0ff
Gerrit-Change-Number: 85790
Gerrit-PatchSet: 1
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Attention is currently required from: Benjamin Doron, Maxim Polyakov, Michael Niewöhner, Paul Menzel.
David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/56887?usp=email )
Change subject: util/intelp2m: Drop non-DWx register analysis support
......................................................................
Patch Set 21: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56887?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5c77ff942a620897c085be4135cb879a0d40a00
Gerrit-Change-Number: 56887
Gerrit-PatchSet: 21
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Fri, 27 Dec 2024 22:19:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Daniel Maslowski, Maxim Polyakov.
David Hendricks has posted comments on this change by Maxim Polyakov. ( https://review.coreboot.org/c/coreboot/+/70542?usp=email )
Change subject: util/intelp2m: Add logger
......................................................................
Patch Set 17: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/70542?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97aba146b6d8866a7fa46bac80c27c0896b26cf7
Gerrit-Change-Number: 70542
Gerrit-PatchSet: 17
Gerrit-Owner: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Comment-Date: Fri, 27 Dec 2024 22:19:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Kyösti Mälkki, Maximilian Brune, Patrick Rudolph.
Lean Sheng Tan has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/74122?usp=email )
Change subject: mb/prodrive/atlas: Add initial support for options
......................................................................
Patch Set 32:
(1 comment)
File src/mainboard/prodrive/atlas/cfr.c:
https://review.coreboot.org/c/coreboot/+/74122/comment/a035c31f_c28559a0?us… :
PS28, Line 219: (const struct sm_object *[])
> The thing I highlighted when adding the comment, and the same thing I said a few messages earlier. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/74122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I47585a9a6f94ab5005f2ab63a0df267c0caef231
Gerrit-Change-Number: 74122
Gerrit-PatchSet: 32
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-CC: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-CC: yuchi.chen(a)intel.com
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Comment-Date: Fri, 27 Dec 2024 20:27:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Lean Sheng Tan <tanleansheng(a)outlook.com>