coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

Start a nNew thread

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 driver
by Yu-Ping Wu (Code Review) 03 Dec '24

03 Dec '24

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
by Yu-Ping Wu (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ...................................................................... Patch Set 14: (4 comments) File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/b2741a3d_810e9043?us… : PS4, Line 61: static struct pmif *pmif_arb = NULL; : : static u32 mt6363_auxadc_read_value(u32 reg) : { : u32 data; : : assert(pmif_arb); : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &data); : return data; : } : : static void mt6363_auxadc_write_value(u32 reg, u8 reg_val) : { : assert(pmif_arb); : pmif_arb->write(pmif_arb, SPMI_SLAVE_4, reg, reg_val); : } : : static u32 mt6363_auxadc_read_value16(u32 reg) : { : u16 rdata = 0; : : assert(pmif_arb); : pmif_arb->read16(pmif_arb, SPMI_SLAVE_4, reg, &rdata); : return rdata; : } > The APIs for adc code, adc code and 6363 code has been split into two patches. If you remove `mt6363_sdmadc_init` from this file, then these functions must be moved to mt6363.c as well. Otherwise, `pmif_arb` will also be NULL. I agree with Yidi that these should be moved to mt6363.c. As these functions are similar to the read/write functions in common/mt6363.c, I'd prefer adding them in CB:85127. You'll need to add them to mt6363.h as well. ``` u8 mt6363_read8(u32 reg); // this is mt6363_auxadc_read_value u16 mt6363_read16(u32 reg); // this is mt6363_auxadc_read_value16 void mt6363_write8(u32 reg, u8 data); // this is mt6363_auxadc_write_value ``` File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/c4bbd3d6_8a4e0315?us… : PS14, Line 46: remove https://review.coreboot.org/c/coreboot/+/85128/comment/ccd9acd7_db770173?us… : PS14, Line 52: SDMADC_CHAN_SPEC(1), `[AUXADC_CHAN_VIN1] = SDMADC_CHAN_SPEC(1),` https://review.coreboot.org/c/coreboot/+/85128/comment/229fe5ab_71f3bd64?us… : PS14, Line 60: ``` _Static_assert(ARRAY_SIZE(mt6363_sdmadc_chan_specs) == AUXADC_CHAN_MAX), "Wrong array size for mt6363_sdmadc_chan_specs"); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a Gerrit-Change-Number: 85128 Gerrit-PatchSet: 14 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:21:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: drivers/usb/intel_bluetooth: Change the Power Resource to S0
by Nicholas Sudsgaard (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Sean Rhodes. Nicholas Sudsgaard has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84988?usp=email ) Change subject: drivers/usb/intel_bluetooth: Change the Power Resource to S0 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84988/comment/25949fd6_2660beb8?us… : PS2, Line 9: This resource is applicable is S0 nit: "This resource is only applicable to S0" It would also be nice if you could explain why it is only applicable to S0 as well. File src/drivers/usb/acpi/intel_bluetooth.c: https://review.coreboot.org/c/coreboot/+/84988/comment/3b686614_f53b7187?us… : PS2, Line 101: 0x00, 0x0000 nit: Decimal feels more appropriate for both these values. -- To view, visit https://review.coreboot.org/c/coreboot/+/84988?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9ae710ef452c717ec414324d2847bf3218fd62d3 Gerrit-Change-Number: 84988 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:20:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: Documentation/drivers/smmstorev2.md: describe capsule update API
by Sergii Dmytruk (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Michał Żygowski, Patrick Rudolph, Paul Menzel. Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83426?usp=email ) Change subject: Documentation/drivers/smmstorev2.md: describe capsule update API ...................................................................... Patch Set 14: (1 comment) File Documentation/drivers/smmstorev2.md: https://review.coreboot.org/c/coreboot/+/83426/comment/1046326c_0755f222?us… : PS13, Line 213: Attempts to write the protected memory regions can lead to undesired. When > unfinished sentence? Yes, thanks. Completed the sentence. -- To view, visit https://review.coreboot.org/c/coreboot/+/83426?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94761d18be567e5302d1a836f09f0a7eecb4fb00 Gerrit-Change-Number: 83426 Gerrit-PatchSet: 14 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:07:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: Documentation/drivers/smmstorev2.md: describe capsule update API
by Sergii Dmytruk (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Arthur Heymans, Martin L Roth, Patrick Rudolph, Paul Menzel, Sergii Dmytruk. Hello Arthur Heymans, Krystian Hebel, Patrick Rudolph, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83426?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: Documentation/drivers/smmstorev2.md: describe capsule update API ...................................................................... Documentation/drivers/smmstorev2.md: describe capsule update API This commit adds a description of capsule update commands implemented in SMMSTORE in previous patches. Change-Id: I94761d18be567e5302d1a836f09f0a7eecb4fb00 Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> --- M Documentation/drivers/smmstorev2.md 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/83426/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/83426?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94761d18be567e5302d1a836f09f0a7eecb4fb00 Gerrit-Change-Number: 83426 Gerrit-PatchSet: 14 Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[M] Change in coreboot[main]: Documentation/tutorial/managing_local_additions.md: Add symlink info
by Felix Held (Code Review) 03 Dec '24

03 Dec '24

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84740?usp=email ) Change subject: Documentation/tutorial/managing_local_additions.md: Add symlink info ...................................................................... Documentation/tutorial/managing_local_additions.md: Add symlink info Add information about how the symlink target can be used to develop and test additions to the coreboot tree from site-local. Change-Id: I75f9e9575005e9ee2f255848a21c5e57c30e9e72 Signed-off-by: Nicolas Kochlowski <nickkochlowski(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84740 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Ana Carolina Cabral Reviewed-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M Documentation/tutorial/managing_local_additions.md 1 file changed, 56 insertions(+), 9 deletions(-) Approvals: Nicholas Chin: Looks good to me, approved Ana Carolina Cabral: Looks good to me, but someone else must approve build bot (Jenkins): Verified diff --git a/Documentation/tutorial/managing_local_additions.md b/Documentation/tutorial/managing_local_additions.md index 6ca5971..29ebcb3 100644 --- a/Documentation/tutorial/managing_local_additions.md +++ b/Documentation/tutorial/managing_local_additions.md @@ -1,11 +1,9 @@ -Managing local additions -======================== +# Managing local additions This section describes the site-local mechanism, what it is good for and how it can be used. -What is site-local? -------------------- +## What is site-local? site-local is the name of a directory that won't ever appear in the upstream coreboot repository but is referred to in several key places of its configuration and build system. The intent is provide a single location to @@ -18,15 +16,64 @@ This optional directory is searched for in the top-level of the coreboot repo and is called `site-local`. -Integration into the configuration system ------------------------------------------ +A common approach for developing and testing internal additions to coreboot +from the site-local directory is to use `symlink` targets. By replicating +the coreboot directory structure within site-local and creating a +`symlink.txt` file that contains the path (relative to the root of the +coreboot directory), the `symlink` target can recursively scan the +site-local directory and create symbolic links into the coreboot tree, +allowing the build process to proceed as if the additions were integrated +directly into the main coreboot tree. The `symlink.txt` file must be placed +at the root of the new directory. + +The following targets can be used to create/remove the symlinks: + +`make symlink` - Creates symbolic links from site-local into coreboot tree +`make clean-symlink` - Removes symbolic links created by `make symlink` +`make cleanall-symlink` - Removes all symbolic links in the coreboot tree + +### Example symlink usage +Directory structure with symlink from site-local into coreboot: + +``` +coreboot/ +├── src/ +│ └── soc/ +│ ├── amd/ +│ ├── cavium/ +│ ├── example/ +│ ├── ... +│ └── test-soc-from-site-local -> ../../site-local/src/soc/test-soc-from-site-local/ +└── site-local/ + ├── Kconfig + ├── Makefile.mk + └── src/ + └── soc/ + └── test-soc-from-site-local/ + └── symlink.txt +``` + +Contents of `symlink.txt`: + +``` +src/soc/test-soc-from-site-local +``` + +*Note:* To keep the symlinks updated throughout development, the following +line may be added to `site-local/Makefile.mk` to declare symlink as a +`site-local-target` dependency, ensuring the symlink target is run anytime +`make` is executed: +``` +site-local-target:: symlink +``` + +## Integration into the configuration system Kconfig includes `site-local/Kconfig` relatively early, so it can be used to pre-define some configuration before coreboot's regular ruleset sets up defaults. -Integration into the build system ---------------------------------- -The build system includes, if present, `site-local/Makefile.inc`. The main +## Integration into the build system +The build system includes, if present, `site-local/Makefile.mk`. The main purpose so far has been to add additional files to a CBFS image. A single Makefile.inc can serve multiple boards, for example: -- To view, visit https://review.coreboot.org/c/coreboot/+/84740?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I75f9e9575005e9ee2f255848a21c5e57c30e9e72 Gerrit-Change-Number: 84740 Gerrit-PatchSet: 10 Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 driver
by Yu-Ping Wu (Code Review) 03 Dec '24

03 Dec '24

1 0

[XS] Change in coreboot[main]: drivers/usb/intel_bluetooth: Fix GBTE to return Local0
by Nicholas Sudsgaard (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Paul Menzel, Sean Rhodes. Nicholas Sudsgaard has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84989?usp=email ) Change subject: drivers/usb/intel_bluetooth: Fix GBTE to return Local0 ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84989?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I13263d479d1a4520abaf1b6b38514d021e7d4dc9 Gerrit-Change-Number: 84989 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:02:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIF and PMIC driver support
by Yu-Ping Wu (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85126?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIF and PMIC driver support ...................................................................... Patch Set 12: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85126/comment/677edb09_2c59b46a?us… : PS12, Line 11: fix low : probability boot failure issue Which part of this patch fix the issue? I thought this patch simply adds PMIF feature support instead of fixing issues. File src/soc/mediatek/mt8196/include/soc/pmif.h: https://review.coreboot.org/c/coreboot/+/85126/comment/e012cf3a_78150702?us… : PS12, Line 142: + Space around `+` https://review.coreboot.org/c/coreboot/+/85126/comment/6c79e218_756c690b?us… : PS12, Line 142: Just one tab. https://review.coreboot.org/c/coreboot/+/85126/comment/21f3027c_d377896a?us… : PS12, Line 142: #define SPMI_SCL_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_M_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SCL_P_PD_ADDR (IOCFG_LM2_BASE+0x80) : #define SPMI_SDA_P_PD_ADDR (IOCFG_LM2_BASE+0x80) Why do we need 4 macros, if their values are all the same? https://review.coreboot.org/c/coreboot/+/85126/comment/b41eb9d1_f0e4ebf0?us… : PS12, Line 147: ) remove File src/soc/mediatek/mt8196/pmif_spmi.c: https://review.coreboot.org/c/coreboot/+/85126/comment/805d6f32_79a664a1?us… : PS12, Line 164: IOCFG_LM2_BASE + 0x4 Define macros for `IOCFG_LM2_BASE + 0x4` and `IOCFG_LM2_BASE + 0x8`, respecitvely, just like `SPMI_SCL_M_PD_ADDR`. https://review.coreboot.org/c/coreboot/+/85126/comment/a96977b3_8ecef491?us… : PS12, Line 221: ( remove -- To view, visit https://review.coreboot.org/c/coreboot/+/85126?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I232015f45735ee5278b09d0352410617a1565177 Gerrit-Change-Number: 85126 Gerrit-PatchSet: 12 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 03 Dec 2024 14:00:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver
by Hope Wang (Code Review) 03 Dec '24

03 Dec '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Hope Wang has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email ) Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ...................................................................... Patch Set 14: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85128/comment/2c36297a_2a1ec635?us… : PS4, Line 7: mt6363 > MT6363 ADC Done https://review.coreboot.org/c/coreboot/+/85128/comment/b1e39d0b_67b92a31?us… : PS4, Line 9: add > Add Done https://review.coreboot.org/c/coreboot/+/85128/comment/d7287547_06f88e53?us… : PS4, Line 9: auxadc > AUXADC Done File src/soc/mediatek/common/include/soc/mt6363_sdmadc.h: https://review.coreboot.org/c/coreboot/+/85128/comment/33360c7f_2f627fca?us… : PS4, Line 88: enum auxadc_val_type type); > move to the next line Done File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/034e66c4_8c51f7ab?us… : PS4, Line 61: static struct pmif *pmif_arb = NULL; : : static u32 mt6363_auxadc_read_value(u32 reg) : { : u32 data; : : assert(pmif_arb); : pmif_arb->read(pmif_arb, SPMI_SLAVE_4, reg, &data); : return data; : } : : static void mt6363_auxadc_write_value(u32 reg, u8 reg_val) : { : assert(pmif_arb); : pmif_arb->write(pmif_arb, SPMI_SLAVE_4, reg, reg_val); : } : : static u32 mt6363_auxadc_read_value16(u32 reg) : { : u16 rdata = 0; : : assert(pmif_arb); : pmif_arb->read16(pmif_arb, SPMI_SLAVE_4, reg, &rdata); : return rdata; : } > move those functions to `common/mt6363.c`. The APIs for adc code, adc code and 6363 code has been split into two patches. https://review.coreboot.org/c/coreboot/+/85128/comment/161ae5b0_04084518?us… : PS4, Line 135: : void mt6363_sdmadc_init(void) : { : if (!pmif_arb) { : pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); : assert(pmif_arb); : } : : if (pmif_arb->is_pmif_init_done(pmif_arb)) : die("ERROR - Failed to initialize pmif spi"); : : printk(BIOS_INFO, "[%s]CHIP ID = 0x%x\n", __func__, : mt6363_auxadc_read_value(PMIC_SWCID1)); : } > Remove. We can just call `mt6363_init_pmif_arb`. Done File src/soc/mediatek/common/mt6363_sdmadc.c: https://review.coreboot.org/c/coreboot/+/85128/comment/032fbac6_d6a05d06?us… : PS7, Line 52: SDMADC_CHAN_SPEC(AUXADC_CHAN_VIN1, 1), > I'd prefer […] Done File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/85128/comment/aa21a7d4_cd5cff9a?us… : PS4, Line 32: romstage-y += ../common/mt6363_sdmadc.c > We don't need ADC in romstage. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85128?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ice3c286cd207e445392d5f0126a07ce4f40dcf8a Gerrit-Change-Number: 85128 Gerrit-PatchSet: 14 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 03 Dec 2024 12:42:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024