coreboot-gerrit December 2024

coreboot-gerrit@coreboot.org

1 participants
3018 discussions

[XS] Change in coreboot[main]: mb/topton/adl: Disable mapped SATA port
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85609?usp=email ) Change subject: mb/topton/adl: Disable mapped SATA port ...................................................................... mb/topton/adl: Disable mapped SATA port According to Intel mFIT tool, SATA Port 0 is mapped as RP11 (PCI-E). Disable SATA mapping on that port. Setting SATAXPCIE1 GPIO fixes broken SATA port. Therefore, this port is now fully functional. TEST: Plug in 2.5in SATA drive, check detection in EDK2/Linux. Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85609 Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/topton/adl/devicetree.cb M src/mainboard/topton/adl/gpio.h 2 files changed, 1 insertion(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved diff --git a/src/mainboard/topton/adl/devicetree.cb b/src/mainboard/topton/adl/devicetree.cb index f21687a..5dcca69 100644 --- a/src/mainboard/topton/adl/devicetree.cb +++ b/src/mainboard/topton/adl/devicetree.cb @@ -42,11 +42,8 @@ end device ref shared_sram on end - - # Not working, resource conflict(?) device ref sata on register "sata_ports_enable" = "{ - [0] = 1, [1] = 1, }" end diff --git a/src/mainboard/topton/adl/gpio.h b/src/mainboard/topton/adl/gpio.h index 6b990c2..ffc528c 100644 --- a/src/mainboard/topton/adl/gpio.h +++ b/src/mainboard/topton/adl/gpio.h @@ -68,7 +68,7 @@ _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K) | PAD_IOSSTATE(IGNORE)), /* ESPI_CLK */ _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_IOSSTATE(IGNORE)), /* ESPI_RESET# */ PAD_CFG_GPO(GPP_A11, 1, PLTRST), /* GPIO */ - PAD_NC(GPP_A12, NONE), /* GPIO */ + PAD_CFG_NF(GPP_A12, UP_20K, DEEP, NF1), /* SATAXPCIE1 */ PAD_CFG_GPO(GPP_A13, 1, DEEP), /* GPIO */ _PAD_CFG_STRUCT(GPP_A14, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_IOSSTATE(IGNORE)), /* USB_OC1# */ _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(EDGE_SINGLE) | PAD_IRQ_ROUTE(IOAPIC) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), /* GPIO */ -- To view, visit https://review.coreboot.org/c/coreboot/+/85609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Gerrit-Change-Number: 85609 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/topton/adl: Disable mapped SATA port
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Alicja Michalska. Felix Singer has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/85609?usp=email ) Change subject: mb/topton/adl: Disable mapped SATA port ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85609?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9556383952d163a145ac73cb846740a4ce67a1e1 Gerrit-Change-Number: 85609 Gerrit-PatchSet: 5 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:48:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Drop GPIO by I/O
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Felix Singer, Keith Hui. Felix Singer has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/84617?usp=email ) Change subject: mb/asus/p8z77-m: Drop GPIO by I/O ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I've removed the URL to 75145, since we reference unmerged patches with just their change number. -- To view, visit https://review.coreboot.org/c/coreboot/+/84617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39739ab71bc644619667b3e123cc9ad85f9d109f Gerrit-Change-Number: 84617 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Drop GPIO by I/O
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Felix Singer has uploaded a new patch set (#2) to the change originally created by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/84617?usp=email ) Change subject: mb/asus/p8z77-m: Drop GPIO by I/O ...................................................................... mb/asus/p8z77-m: Drop GPIO by I/O Per Fabian Groffen <grobian(a)gentoo.org> in CB:75145: This particular setting results in [ERROR] PNP: 002e.308 missing read_resources The underlying root cause was fixed by commit f5b993de4fcf (sio/nuvoton/nct6779d: Correct GPIOBASE virtual LDN). However, to make GPIO by I/O work requires setting up an I/O port resource here and a generic LPC I/O decode at southbridge/intel/bd82x6x, and both weren't done. Even if done, this newfound capability still doesn't offer much. Change-Id: I39739ab71bc644619667b3e123cc9ad85f9d109f Signed-off-by: Keith Hui <buurin(a)gmail.com> --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/84617/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84617?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39739ab71bc644619667b3e123cc9ad85f9d109f Gerrit-Change-Number: 84617 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>

1 0

[S] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 19 Dec '24

19 Dec '24

Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 15: (1 comment) Patchset: PS5: > I don't disagree with all what you say. I just find it hard to draw a line that way. […] Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 15 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Revert SIO IRQ settings carried from OEM
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email ) Change subject: mb/asus/p8z77-m: Revert SIO IRQ settings carried from OEM ...................................................................... mb/asus/p8z77-m: Revert SIO IRQ settings carried from OEM Revert super I/O IRQ polarity settings replicated from OEM firmware back to its power-on defaults. With OEM settings COM 1/UART A/serial port 1 gets blocked right after the kernel boots. It no longer works or responds, which actually means the Linux boot process gets stuck forever when configured to write to ttyS0. Also revised the comment on another SIO setting to say it's being set for PECI. TEST=Not using these settings, I have not found any downside. Serial keeps working, sensors still work, S3 suspend/resume works correctly. Reported by Fabian and confirmed by Keith. Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Signed-off-by: Keith Hui <buurin(a)gmail.com> Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Reviewed-on: https://review.coreboot.org/c/coreboot/+/75137 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: coreboot org <coreboot.org(a)gmail.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Fabian Groffen: Looks good to me, but someone else must approve Felix Singer: Looks good to me, approved coreboot org: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb index 41351b5..9ff794b 100644 --- a/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb +++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-m/overridetree.cb @@ -40,12 +40,9 @@ io 0x60 = 0x3f8 # COM1 address irq 0x70 = 4 # Below are global config settings to replicate OEM - drq 0x26 = 0x10 # Before accessing CR10/11/13/14, CR26:4 must be set to 1 - drq 0x13 = 0xff # IRQs 0-15 active low - drq 0x14 = 0xff drq 0x1a = 0x02 drq 0x1b = 0x60 - drq 0x2c = 0x00 # GP27, 3VSBSW#, No TSI + drq 0x2c = 0x00 # PECI end device pnp 2e.3 off end # UART B, IR device pnp 2e.5 on # PS2 KBC -- To view, visit https://review.coreboot.org/c/coreboot/+/75137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Gerrit-Change-Number: 75137 Gerrit-PatchSet: 12 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/asus/p8z77-m: Revert SIO IRQ settings carried from OEM
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Fabian Groffen, Keith Hui, Keith Hui. Felix Singer has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/coreboot/+/75137?usp=email ) Change subject: mb/asus/p8z77-m: Revert SIO IRQ settings carried from OEM ...................................................................... Patch Set 11: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75137?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae526762e79e9e2d46d06e12c338f375e5555e8c Gerrit-Change-Number: 75137 Gerrit-PatchSet: 11 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:38:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Alicja Michalska, Angel Pons. Felix Singer has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/erying/tgl/tgl_matx_board.jpg: PS6: > Been thinking the same. […] Yes please. Let's not merge representation images into the repo. I know a better way, but that's unrelated to this patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:29:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Alicja Michalska (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Angel Pons, Felix Singer. Alicja Michalska has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/erying/tgl/tgl_matx_board.jpg: PS6: > Do we really need that image? It doesn't show something special and one can find the board in Google […] Been thinking the same. I think it's nice to have a visual representation in documentation, but I can remove it if that's better for you (and storage space). -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:23:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[M] Change in coreboot[main]: Documentation: Add Erying Polestar G613 Pro
by Felix Singer (Code Review) 19 Dec '24

19 Dec '24

Attention is currently required from: Alicja Michalska, Angel Pons. Felix Singer has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/81611?usp=email ) Change subject: Documentation: Add Erying Polestar G613 Pro ...................................................................... Patch Set 6: (1 comment) File Documentation/mainboard/erying/tgl/tgl_matx_board.jpg: PS6: Do we really need that image? It doesn't show something special and one can find the board in Google as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/81611?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d60508dbde10373b0da2fb4ece0992760d3121c Gerrit-Change-Number: 81611 Gerrit-PatchSet: 6 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: coreboot org <coreboot.org(a)gmail.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 19 Dec 2024 20:22:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit December 2024