coreboot-gerrit November 2024

coreboot-gerrit@coreboot.org

1 participants
2192 discussions

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Elyes Haouas (Code Review) 26 Nov '24

26 Nov '24

Attention is currently required from: Felix Singer, Sean Rhodes. Elyes Haouas has posted comments on this change by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85295?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56f0179301af7894ed854ed87a4b7a09a8cf11cc Gerrit-Change-Number: 85295 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 26 Nov 2024 01:27:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: added bare Asrock H370m-ITX support
by Felix Singer (Code Review) 26 Nov '24

26 Nov '24

1 0

[L] Change in coreboot[master]: added bare Asrock H370m-ITX support
by Felix Singer (Code Review) 26 Nov '24

26 Nov '24

Attention is currently required from: Name of user not set #1004406. Felix Singer has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email ) Change subject: added bare Asrock H370m-ITX support ...................................................................... Patch Set 6: (6 comments) Patchset: PS6: > hi, i want to continue work on this PR. but i want fix some problems: […] I would start with rebasing on the main branch, so that we don't try to debug a very old state. See my other comments. File src/mainboard/asrock/h370m/Makefile.inc: PS6: Please rename this file to `Makefile.mk` File src/mainboard/asrock/h370m/devicetree.cb: https://review.coreboot.org/c/coreboot/+/65225/comment/9b455aeb_3a2d2639?us… : PS6, Line 3: device cpu_cluster 0 on : device lapic 0 on end : end Not needed anymore. https://review.coreboot.org/c/coreboot/+/65225/comment/1e540451_648d4d9f?us… : PS6, Line 8: register "RMT" = "0" Set to 0 by default, remove. https://review.coreboot.org/c/coreboot/+/65225/comment/d5ba09e3_d06bcdf0?us… : PS6, Line 14: device domain 0 on Please have a look in `src/soc/intel/cannonlake/chipset_pch_h.cb` and use the alias names instead of like `pci 00.0`. There are many other mainboards in the tree using them. So you have some examples. Also, remove PCI devices which have an equivalent configuration in the chipset device tree and remove devices which are turned off anyway. File src/mainboard/asrock/h370m/ramstage.c: https://review.coreboot.org/c/coreboot/+/65225/comment/d2169185_9ca58d8b?us… : PS6, Line 12: gpio_configure_pads(gpio_table, ARRAY_SIZE(gpio_table)); We don't do the GPIO configuration before the FSP-S runs. In some cases, FSP did GPIO configuration itself. So in order to be sure only our configuration is used, we do the configuration after FSP-S. Please have a look into `src/mainboard/kontron/bsl6/ramstage.c` and use that way. You can do that in this file, but just move the configuration into the chip_operations driver as shown in the other mainboard. -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Name of user not set #1004406 Gerrit-Comment-Date: Tue, 26 Nov 2024 01:01:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Name of user not set #1004406

1 0

[L] Change in coreboot[master]: added bare Asrock H370m-ITX support
by Name of user not set (Code Review) 25 Nov '24

25 Nov '24

1 0

[L] Change in coreboot[master]: added bare Asrock H370m-ITX support
by Name of user not set (Code Review) 25 Nov '24

25 Nov '24

Name of user not set #1004406 has restored this change. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email ) Change subject: added bare Asrock H370m-ITX support ...................................................................... Restored -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de>

1 0

[L] Change in coreboot[master]: added bare Asrock H370m-ITX support
by Name of user not set (Code Review) 25 Nov '24

25 Nov '24

Name of user not set #1004406 has posted comments on this change by Name of user not set #1004406. ( https://review.coreboot.org/c/coreboot/+/65225?usp=email ) Change subject: added bare Asrock H370m-ITX support ...................................................................... Patch Set 6: (7 comments) File configs/config.asrock_h370m_itx: PS3: > Looks like default config? yes File src/mainboard/asrock/h370m/devicetree.cb: https://review.coreboot.org/c/coreboot/+/65225/comment/8359ae1c_5a1f3fd2?us… : PS2, Line 27: register "PcieClkSrcClkReq" = "{ \ : [0] = 0, \ : [1] = 1, \ : [2] = 2, \ : [3] = 3, \ : [4] = 4, \ : [5] = 6, \ : [6] = 5, \ : [7] = 15, \ : [8] = 7, \ : [9] = 9, \ : [10] = 10, \ : [11] = 11, \ : [12] = 12, \ : [13] = 13, \ : [14] = 14, \ : [15] = 8, \ : }" > Please put these under their specific root ports. Ack https://review.coreboot.org/c/coreboot/+/65225/comment/58958464_6d6da4b8?us… : PS2, Line 46: register "PcieClkSrcUsage[0]" = "0x20" # [01]----00.000:01.0 : register "PcieClkSrcUsage[9]" = "0x24" # +-1c.0-[02]----00.0 Intel Corporation I211 Gigabit Network Connection : register "PcieClkSrcUsage[14]" = "0x40" # +-1d.0-[03]----00.0 Samsung Electronics Co Ltd NVMe SSD Controller SM981/PM981/PM983 : register "PcieClkSrcUsage[15]" = "0x18" # +-1c.6-[02]----00.0 Intel Corporation Dual Band Wireless-AC 3168NGW [Stone Peak : register "PcieClkSrcUsage[10]" = "0x70" # -1f.6 Intel Corporation Ethernet Connection (7) I219-V > Please put these under their specific root ports. Ack File src/mainboard/asrock/h370m/dsdt.asl: https://review.coreboot.org/c/coreboot/+/65225/comment/896ae02f_abdcf762?us… : PS2, Line 16: // global NVS and variables > Remove, it doesn't add useful value. Ack https://review.coreboot.org/c/coreboot/+/65225/comment/2204d730_35632b69?us… : PS2, Line 19: Scope (\_SB) { > Device (\_SB. […] Ack https://review.coreboot.org/c/coreboot/+/65225/comment/7a6328c6_d54d217a?us… : PS2, Line 28: > Remove empty line Ack File src/mainboard/asrock/h370m/romstage.c: https://review.coreboot.org/c/coreboot/+/65225/comment/3a8797e3_9a33bd6f?us… : PS1, Line 27: 50 > Should be `60` according to intel doc 573387. Probably doesn't make much […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/65225?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79302247311471153ebbba991081365d9265791b Gerrit-Change-Number: 65225 Gerrit-PatchSet: 6 Gerrit-Owner: Name of user not set #1004406 Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Mon, 25 Nov 2024 23:43:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master
by Felix Singer (Code Review) 25 Nov '24

25 Nov '24

Felix Singer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84597?usp=email ) Change subject: Update fsp submodule to upstream master ...................................................................... Abandoned Superseded by CB:84986 -- To view, visit https://review.coreboot.org/c/coreboot/+/84597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib414495bd2b7e6fe363277bad1031e06ab8d503c Gerrit-Change-Number: 84597 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: coreboot org <coreboot.org(a)gmail.com>

1 0

[XS] Change in coreboot[main]: 3rdparty/fsp: Update submodule to upstream master
by Felix Singer (Code Review) 25 Nov '24

25 Nov '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85295?usp=email ) Change subject: 3rdparty/fsp: Update submodule to upstream master ...................................................................... 3rdparty/fsp: Update submodule to upstream master Updating from commit id d7931859bfb1: 2024-10-14 15:15:03 +0800 - (NEX MTL-UH_MTL-PS MR1 (4053_58) FSP) to commit id 851f7105d803: 2024-11-22 14:59:29 +0800 - (NEX TGL IPU 2025.1 (7341_01) FSP) This brings in 8 new commits: 851f7105d803 NEX TGL IPU 2025.1 (7341_01) FSP d9d0cfbdf26b NEX RPL-S MR5/RPL-S Refresh MR3 (5401_01) FSP 360733f79a2f NEX RPL-P MR3 (5401_01) FSP 51caa72d5df6 NEX ADL-PS IPU 2025.1 (5401_01) FSP fea3c6643c2f NEX ADL-S IPU 2025.1 (5401_01) FSP 507145c279de NEX ADL-P IPU 2025.1 (5401_01) FSP bd5df1993f52 Merge branch 'master' of https://github.com/intel/FSP e26be9c400db Elkhart Lake IPU2025.1 FSP Change-Id: I56f0179301af7894ed854ed87a4b7a09a8cf11cc Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/85295/1 diff --git a/3rdparty/fsp b/3rdparty/fsp index d793185..851f710 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit d7931859bfb1f7949bb455d53b9494dd731e9642 +Subproject commit 851f7105d803672e17202bc2f598a5a4dbf659d3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85295?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56f0179301af7894ed854ed87a4b7a09a8cf11cc Gerrit-Change-Number: 85295 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[M] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Jon Murphy (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth. Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > Where and how is that used? it's used by chromeos to build code for the EC/ISH on new platforms. We're building picolibc from the zephyr repo, and libstdc++ here -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 5 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 25 Nov 2024 22:12:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[M] Change in coreboot[main]: util/crossgcc: Add libstdcxx target
by Felix Singer (Code Review) 25 Nov '24

25 Nov '24

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Martin L Roth. Felix Singer has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email ) Change subject: util/crossgcc: Add libstdcxx target ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Where and how is that used? -- To view, visit https://review.coreboot.org/c/coreboot/+/85275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie0c06ffaeab632c27a992dee8abcc403cceabeed Gerrit-Change-Number: 85275 Gerrit-PatchSet: 5 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 25 Nov 2024 22:08:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2024