coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: MAINTAINERS: Update maintainers list for INTEL Xeon Scalable Processo...
by Shuo Liu (Code Review) 30 Jan '24

30 Jan '24

Shuo Liu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80240?usp=email ) Change subject: MAINTAINERS: Update maintainers list for INTEL Xeon Scalable Processor Family ...................................................................... MAINTAINERS: Update maintainers list for INTEL Xeon Scalable Processor Family Change-Id: Ide3aa87fca69be6b0f1ffe0b18d7ffb410e5c563 Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> --- M MAINTAINERS 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/80240/1 diff --git a/MAINTAINERS b/MAINTAINERS index 2648f36..8b4f26d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -941,6 +941,9 @@ M: Tim Chu <Tim.Chu(a)quantatw.com> M: Arthur Heymans <arthur(a)aheymans.xyz> M: Christian Walter <christian.walter(a)9elements.com> +M: Shuo Liu <shuo.liu(a)intel.com> +M: Patrick Rudolph <patrick.rudolph(a)9elements.com> +M: Lean Sheng Tan <sheng.tan(a)9elements.com> S: Supported F: src/soc/intel/xeon_sp/ F: src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ -- To view, visit https://review.coreboot.org/c/coreboot/+/80240?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide3aa87fca69be6b0f1ffe0b18d7ffb410e5c563 Gerrit-Change-Number: 80240 Gerrit-PatchSet: 1 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: util/ifdtool: Add new cmdline to enable GPR0 protection
by Subrata Banik (Code Review) 30 Jan '24

30 Jan '24

Attention is currently required from: Reka Norman. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email ) Change subject: util/ifdtool: Add new cmdline to enable GPR0 protection ...................................................................... Patch Set 3: (12 comments) File util/ifdtool/ifdtool.c: https://review.coreboot.org/c/coreboot/+/80235/comment/6dc86e82_6bcab88d : PS3, Line 47: CSE_REGION_DATA_PARTITION_OFFSET > > > This applies to BPDT v1.7 (TGL onwards) only, referring to util/cbfstool/bpdt_formats/{bpdt_1_6. […] Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/7f286198_958f95d4 : PS3, Line 1556: uint32_t gprd > nit: make `union gprd_info` public and use it here instead of manual bit shifting? Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/4d0998ba_28bded66 : PS3, Line 1610: fpsba->pchstrp[gpr0_offset] & 0x80000000 > nit: use `union gprd_info` here too Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/99308517_5e108a39 : PS3, Line 1624: FIT > FITC? Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/9361dc4f_9d0af6b2 : PS3, Line 1624: FITC > FPT? Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/a9b6168f_dd17014e : PS3, Line 1648: } > Fail if FITC is not found? Right now it will silently continue and fill in an incorrect range. Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/5ea2f6e6_db12f68b : PS3, Line 1663: region.size <= 0xfff > Why 0xfff (not 0)? Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/1c01891d_e0cc7c35 : PS3, Line 1712: fpsba->pchstrp[gpr0_offset] & 0x80000000 > nit: use `union gprd_info` here too done https://review.coreboot.org/c/coreboot/+/80235/comment/726af3cb_bd3bd9b7 : PS3, Line 1724: union gprd_info > nit: just `union gprd`? This is more consistent with other places where we just use the register nam […] Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/003cdadb_47702446 : PS3, Line 1726: start:16 > I think bit 16 is actually read protect enable, referring to `union spi_bios_gpr0` in src/soc/intel/ […] Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/6c474f45_5af4addd : PS3, Line 1733: /* : * Start Address: bit 0-15 of the GPRD represents the protected region start address, : * where bit 0-11 of the start address are assumed to be zero. : */ > nit: maybe move these comments to the struct definition, so we don't have to duplicate them here and […] Acknowledged https://review.coreboot.org/c/coreboot/+/80235/comment/41efbe1a_b678f672 : PS3, Line 1737: 0xffff > 0x7fff, based on my comment about read protect enable. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/80235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I27c533ae4109c79299f4e7ff75e750d7cc64280f Gerrit-Change-Number: 80235 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Tue, 30 Jan 2024 12:19:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for CXL IIO stacks
by Shuo Liu (Code Review) 30 Jan '24

30 Jan '24

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80087?usp=email ) Change subject: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for CXL IIO stacks ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80087/comment/0b87a279_634ce2a8 : PS4, Line 7: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for : CXL IIO stacks > Oh, thanks all! I will take care the next time. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/80087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1b1343991bc73d90a433d959f6618bbf59532f Gerrit-Change-Number: 80087 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 30 Jan 2024 12:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for CXL IIO stacks
by Shuo Liu (Code Review) 30 Jan '24

30 Jan '24

Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80087?usp=email ) Change subject: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for CXL IIO stacks ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80087/comment/8b8e0453_7f9837db : PS4, Line 7: soc/intel/xeon_sp/spr: Create CXL ACPI resources only for : CXL IIO stacks > oh, missed that one too Oh, thanks all! I will take care the next time. -- To view, visit https://review.coreboot.org/c/coreboot/+/80087?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c1b1343991bc73d90a433d959f6618bbf59532f Gerrit-Change-Number: 80087 Gerrit-PatchSet: 4 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 30 Jan 2024 12:17:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: crossgcc: Distinguish bootstrap and target compiler options
by Patrick Georgi (Code Review) 30 Jan '24

30 Jan '24

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80229?usp=email ) Change subject: crossgcc: Distinguish bootstrap and target compiler options ...................................................................... crossgcc: Distinguish bootstrap and target compiler options GCC_OPTIONS is only used for target specific options right now, so rename to TARGET_GCC_OPTIONS and only use them in the non-bootstrap build. Adapt BINUTILS_OPTIONS for consistency, even though it doesn't have the same problem. Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> Reviewed-on: https://review.coreboot.org/c/coreboot/+/80229 Reviewed-by: Martin L Roth <gaumless(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Martin L Roth: Looks good to me, approved diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 23a5caf..b294da5 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -722,7 +722,7 @@ --enable-multilib \ --disable-docs \ --disable-texinfo \ - ${BINUTILS_OPTIONS} \ + ${TARGET_BINUTILS_OPTIONS} \ CFLAGS="$HOSTCFLAGS" \ CXXFLAGS="$HOSTCFLAGS" || touch .failed # shellcheck disable=SC2086 @@ -811,6 +811,7 @@ --disable-libcc1 \ --disable-decimal-float \ ${GCC_OPTIONS} \ + ${TARGET_GCC_OPTIONS} \ --enable-languages="${LANGUAGES}" \ --with-system-zlib \ --with-gmp="$DESTDIR$TARGETDIR" \ @@ -995,8 +996,8 @@ i386-elf) ;; i386-mingw32) ;; riscv-elf) TARGETARCH=riscv64-elf - GCC_OPTIONS="$GCC_OPTIONS --with-isa-spec=20191213" - BINUTILS_OPTIONS="$BINUTILS_OPTIONS --with-isa-spec=20191213";; + TARGET_GCC_OPTIONS="$TARGET_GCC_OPTIONS --with-isa-spec=20191213" + TARGET_BINUTILS_OPTIONS="$TARGET_BINUTILS_OPTIONS --with-isa-spec=20191213";; powerpc64*-linux*) ;; i386*) TARGETARCH=i386-elf;; arm*) TARGETARCH=arm-eabi;; -- To view, visit https://review.coreboot.org/c/coreboot/+/80229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Gerrit-Change-Number: 80229 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: crossgcc: Distinguish bootstrap and target compiler options
by Felix Singer (Code Review) 30 Jan '24

30 Jan '24

Attention is currently required from: Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80229?usp=email ) Change subject: crossgcc: Distinguish bootstrap and target compiler options ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Gerrit-Change-Number: 80229 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2024 11:58:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: crossgcc: Distinguish bootstrap and target compiler options
by Felix Singer (Code Review) 30 Jan '24

30 Jan '24

Attention is currently required from: Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80229?usp=email ) Change subject: crossgcc: Distinguish bootstrap and target compiler options ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80229/comment/4bff4361_28f1e79c : PS1, Line 7: Ensure that compiler options for the target don't affect bootstrap > I went for something slightly different, but good call on improving it. Sounds good! -- To view, visit https://review.coreboot.org/c/coreboot/+/80229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Gerrit-Change-Number: 80229 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Comment-Date: Tue, 30 Jan 2024 11:58:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: util/ifdtool: Add new cmdline to enable GPR0 protection
by Subrata Banik (Code Review) 30 Jan '24

30 Jan '24

1 0

[XS] Change in coreboot[main]: crossgcc: Distinguish bootstrap and target compiler options
by Patrick Georgi (Code Review) 30 Jan '24

30 Jan '24

Attention is currently required from: Felix Singer. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80229?usp=email ) Change subject: crossgcc: Distinguish bootstrap and target compiler options ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/80229/comment/20456b0b_9c2faf4d : PS1, Line 7: Ensure that compiler options for the target don't affect bootstrap > How about: […] I went for something slightly different, but good call on improving it. -- To view, visit https://review.coreboot.org/c/coreboot/+/80229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Gerrit-Change-Number: 80229 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Comment-Date: Tue, 30 Jan 2024 11:17:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: crossgcc: Distinguish bootstrap and target compiler options
by Patrick Georgi (Code Review) 30 Jan '24

30 Jan '24

Attention is currently required from: Patrick Georgi. Hello Felix Singer, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/80229?usp=email to look at the new patch set (#2). Change subject: crossgcc: Distinguish bootstrap and target compiler options ...................................................................... crossgcc: Distinguish bootstrap and target compiler options GCC_OPTIONS is only used for target specific options right now, so rename to TARGET_GCC_OPTIONS and only use them in the non-bootstrap build. Adapt BINUTILS_OPTIONS for consistency, even though it doesn't have the same problem. Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Signed-off-by: Patrick Georgi <patrick(a)georgi.software> --- M util/crossgcc/buildgcc 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/80229/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80229?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5e4f54b758dd7daf4e69101c19dfa1212fa64cf6 Gerrit-Change-Number: 80229 Gerrit-PatchSet: 2 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024