Attention is currently required from: Jeremy Soller, Michael Niewöhner, Nick Vaccaro, Nico Huber, Subrata Banik, Tim Crawford.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79920?usp=email )
Change subject: soc/intel/tigerlake: Drop redundant PcieRpEnable
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> https://qa.coreboot. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iacfef5f032278919f1fcf49e31fa42bcbf1eaf20
Gerrit-Change-Number: 79920
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Comment-Date: Wed, 17 Jan 2024 23:40:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Andrey Petrov, Jérémy Compostella, Martin L Roth, Maximilian Brune, Nico Huber, Ronak Kanabar.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79905?usp=email )
Change subject: [RFC] region: Introduce region_create() functions
......................................................................
Patch Set 6:
(2 comments)
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/79905/comment/f5f6e130_ee00d7a7 :
PS6, Line 103: int
nit: should return value be `enum cb_err`?
File src/commonlib/include/commonlib/region.h:
https://review.coreboot.org/c/coreboot/+/79905/comment/4519bfbe_1c594031 :
PS1, Line 106: offset > SIZE_MAX || size > SIZE_MAX
> Well, the _unstrusted version is supposed to not make assumptions, but here […]
Hmmm... well, okay, if you feel strongly about it I guess it doesn't really hurt.
However, don't you need to cast down to `size_t` for the overlap check?
(Also, it would be a little more efficient to just create the region struct directly rather than calling `region_create()`, since you've already checked the overlap here, you don't need to go through that `assert()` again.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/79905?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ae3e6274c981c9ab4fb1263c2a72fa68ef1c32b
Gerrit-Change-Number: 79905
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Jan 2024 23:23:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80019?usp=email )
Change subject: payload/grub2: Update from 2.06 to 2.12
......................................................................
payload/grub2: Update from 2.06 to 2.12
Change-Id: I267d341075b907ac72439cf28c2c1458cbeb8d4b
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/GRUB2/Kconfig
M payloads/external/GRUB2/Makefile
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/80019/1
diff --git a/payloads/external/GRUB2/Kconfig b/payloads/external/GRUB2/Kconfig
index e41c562..7adbdd0 100644
--- a/payloads/external/GRUB2/Kconfig
+++ b/payloads/external/GRUB2/Kconfig
@@ -15,7 +15,7 @@
default GRUB2_STABLE
config GRUB2_STABLE
- bool "2.06"
+ bool "2.12"
help
Stable GRUB2 version
diff --git a/payloads/external/GRUB2/Makefile b/payloads/external/GRUB2/Makefile
index 1691e9b..4382ae6 100644
--- a/payloads/external/GRUB2/Makefile
+++ b/payloads/external/GRUB2/Makefile
@@ -1,9 +1,9 @@
TAG-$(CONFIG_GRUB2_MASTER)=origin/HEAD
TAG-$(CONFIG_GRUB2_REVISION)=$(CONFIG_GRUB2_REVISION_ID)
-TAG-$(CONFIG_GRUB2_STABLE)=grub-2.06
+TAG-$(CONFIG_GRUB2_STABLE)=grub-2.12
NAME-$(CONFIG_GRUB2_MASTER)=HEAD
NAME-$(CONFIG_GRUB2_REVISION)=$(CONFIG_GRUB2_REVISION_ID)
-NAME-$(CONFIG_GRUB2_STABLE)=2.06
+NAME-$(CONFIG_GRUB2_STABLE)=2.12
project_git_repo=https://git.savannah.gnu.org/git/grub.git/
project_dir=grub2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80019?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I267d341075b907ac72439cf28c2c1458cbeb8d4b
Gerrit-Change-Number: 80019
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newchange
Attention is currently required from: Martin L Roth, Stefan Reinauer.
Hello Martin L Roth, Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80018?usp=email
to look at the new patch set (#2).
Change subject: payload/seabios: Update from 1.16.2 to 1.16.3
......................................................................
payload/seabios: Update from 1.16.2 to 1.16.3
Change-Id: Idfe479272abf2db93f8fc4bc1ba02d8b8072fcfe
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M payloads/external/SeaBIOS/Kconfig
M payloads/external/SeaBIOS/Makefile
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/80018/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80018?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idfe479272abf2db93f8fc4bc1ba02d8b8072fcfe
Gerrit-Change-Number: 80018
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nico Huber.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79945?usp=email )
Change subject: [NEEDS TEST] region: Check for overflows after offset calculation
......................................................................
Patch Set 3:
(2 comments)
File src/commonlib/region.c:
https://review.coreboot.org/c/coreboot/+/79945/comment/3492bc7f_f992d52e :
PS3, Line 16: if (region_end(c) < region_offset(c))
> It's not 100% the same thing, and IMHO, it looked like it's in the wrong place. […]
Yeah okay, fair enough, I definitely wasn't trying to say that this code is the end all, be all already. I just meant we already have this here, we don't need the same check again below. I believe once you replace `region_end()` with `region_last()`, the check here should be safe for all cases?
If we want to move the wraparound check to `region_create()` and just assume that all created regions are valid that's fine by me too, but then we need to make sure the remaining uses in this file (e.g. in `rdev_mmap()`) adhere to that as well.
https://review.coreboot.org/c/coreboot/+/79945/comment/ea0f481c_c202292c :
PS3, Line 25: return region_end(inner) - 1 >= region_offset(inner) &&
> This version of the check would allow an inner region at the end of the address […]
I haven't been able to think of a use case for it yet, so I'd say let's try forbidding it and see if anything breaks. (We definitely *do* have use cases of regions ending at the end of the address space, so since we basically have to decide between only allowing one or the other, prioritizing that seems to make more sense.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/79945?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia6054e6e9b6f13502351a2d94c8a0af15266e43e
Gerrit-Change-Number: 79945
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Wed, 17 Jan 2024 23:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
Zebreus has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79922?usp=email )
Change subject: check-style: Support incremental adoption of clang-format
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/79922?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib583503d268e002882af03c41b150f7c0fe17796
Gerrit-Change-Number: 79922
Gerrit-PatchSet: 3
Gerrit-Owner: Zebreus <lennarteichhorn(a)googlemail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Wed, 17 Jan 2024 22:49:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bob Moragues, Bob Moragues, Nick Vaccaro, YH Lin.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79997?usp=email )
Change subject: mb/google/brox: Fix user facing camera acronym
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79997/comment/fbaa9dc5_c9335315 :
PS1, Line 20: UFC_CAMERA
> I am good either way. Will match this name change in the config. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/79997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f8240ae51aad1e077f325a9eab5a2a92f1402cb
Gerrit-Change-Number: 79997
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Wed, 17 Jan 2024 22:46:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bob Moragues <moragues(a)google.com>
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Bob Moragues, Nick Vaccaro, Shelley Chen, YH Lin.
Hello Bob Moragues, Nick Vaccaro, YH Lin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79997?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/brox: Fix user facing camera acronym
......................................................................
mb/google/brox: Fix user facing camera acronym
I got confused and used UFS (User Facing Side) for the User Facing
Camera (UFC) in the FW_CONFIGs. Change references of the camera from
UFS --> UFC.
BUG=b:300690448
BRANCH=None
TEST=None. The camera has not been enabled yet.
Change-Id: I4f8240ae51aad1e077f325a9eab5a2a92f1402cb
Signed-off-by: Shelley Chen <shchen(a)google.com>
---
M src/mainboard/google/brox/variants/brox/overridetree.cb
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/79997/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/79997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f8240ae51aad1e077f325a9eab5a2a92f1402cb
Gerrit-Change-Number: 79997
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Bob Moragues, Nick Vaccaro, Shelley Chen, YH Lin.
Bob Moragues has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79997?usp=email )
Change subject: mb/google/brox: Fix user facing camera acronym
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79997/comment/41f72097_2cd83543 :
PS1, Line 20: UFC_CAMERA
> NIT - this is redundant, can just be UFC
I am good either way. Will match this name change in the config.star
--
To view, visit https://review.coreboot.org/c/coreboot/+/79997?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4f8240ae51aad1e077f325a9eab5a2a92f1402cb
Gerrit-Change-Number: 79997
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)chromium.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Wed, 17 Jan 2024 22:42:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-MessageType: comment