coreboot-gerrit January 2024

coreboot-gerrit@coreboot.org

1 participants
3043 discussions

[XS] Change in coreboot[main]: Add variant : Kyogre
by Yu-Ping Wu (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Hung-Te Lin, Kei Hiroyoshi, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80135?usp=email ) Change subject: Add variant : Kyogre ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/80135/comment/be14e2a1_9ebf1acb : PS1, Line 7: Add variant : Kyogre mb/google/corsola: Add new board 'Kyogre' File src/mainboard/google/corsola/Kconfig: https://review.coreboot.org/c/coreboot/+/80135/comment/46510222_b1f5a401 : PS1, Line 10: BOARD_GOOGLE_PONYTA || \ Add `BOARD_GOOGLE_KYOGRE` here. -- To view, visit https://review.coreboot.org/c/coreboot/+/80135?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80c29c59fd233dfa5a2297632457176e9301b371 Gerrit-Change-Number: 80135 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 05:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: soc/intel/xeon_sp: Scan and allocate resources on all stacks
by Shuo Liu (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Arthur Heymans, Chen, Gang C, Christian Walter, Jincheng Li, Johnny Lin, Tim Chu. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78332?usp=email ) Change subject: soc/intel/xeon_sp: Scan and allocate resources on all stacks ...................................................................... Patch Set 13: (1 comment) File src/soc/intel/xeon_sp/util.c: https://review.coreboot.org/c/coreboot/+/78332/comment/f62945fe_22719d5b : PS12, Line 118: if (!is_pcie_iio_stack_res(ri)) Should we remove ln 118 so that all stack info will be returned? P.S. this API is only called by CPX as of now -- To view, visit https://review.coreboot.org/c/coreboot/+/78332?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id72c6e4499e99df3b7ca821ab2893cbcc869dbcd Gerrit-Change-Number: 78332 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 05:18:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Add variant : Kyogre
by Kei Hiroyoshi (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Kei Hiroyoshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80135?usp=email ) Change subject: Add variant : Kyogre ...................................................................... Add variant : Kyogre Change-Id: I80c29c59fd233dfa5a2297632457176e9301b371 Signed-off-by: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/Kconfig.name 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/80135/1 diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index fe6e6d6..2e6e006 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -22,6 +22,9 @@ select MIPI_PANEL_STA_HIMAX83102_J02 select MIPI_PANEL_STA_ILI9882T +config BOARD_GOOGLE_KYOGRE + select BOARD_GOOGLE_KINGLER_COMMON + if BOARD_GOOGLE_CORSOLA_COMMON config CORSOLA_SDCARD_INIT @@ -81,6 +84,7 @@ default "Starmie" if BOARD_GOOGLE_STARMIE default "Ponyta" if BOARD_GOOGLE_PONYTA default "Chinchou" if BOARD_GOOGLE_CHINCHOU + default "Kyogre" if BOARD_GOOGLE_KYOGRE config BOOT_DEVICE_SPI_FLASH_BUS int diff --git a/src/mainboard/google/corsola/Kconfig.name b/src/mainboard/google/corsola/Kconfig.name index b716e55f..eef8545 100644 --- a/src/mainboard/google/corsola/Kconfig.name +++ b/src/mainboard/google/corsola/Kconfig.name @@ -12,6 +12,9 @@ config BOARD_GOOGLE_PONYTA bool "-> Ponyta" +config BOARD_GOOGLE_KYOGRE + bool "-> Kyogre" + comment "Krabby" config BOARD_GOOGLE_KRABBY -- To view, visit https://review.coreboot.org/c/coreboot/+/80135?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I80c29c59fd233dfa5a2297632457176e9301b371 Gerrit-Change-Number: 80135 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: test for trainig 4 (do not approve)
by Kei Hiroyoshi (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Kei Hiroyoshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80134?usp=email ) Change subject: test for trainig 4 (do not approve) ...................................................................... test for trainig 4 (do not approve) Change-Id: I7612032e268e6c4d2228d0d827af437395974436 Signed-off-by: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/80134/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index 3f3467b..a1ba5f9 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -15,8 +15,6 @@ #include "gpio.h" #include "panel.h" -fsfsdf+D+fsd+E;;ll;; - static void configure_alc1019(void) { mtcmos_audio_power_on(); -- To view, visit https://review.coreboot.org/c/coreboot/+/80134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7612032e268e6c4d2228d0d827af437395974436 Gerrit-Change-Number: 80134 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: test for training 3 (do not approve)
by Kei Hiroyoshi (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Kei Hiroyoshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80133?usp=email ) Change subject: test for training 3 (do not approve) ...................................................................... test for training 3 (do not approve) Change-Id: I2d517521e10a07113276eae9435f7ce5ba235723 Signed-off-by: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/80133/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index a1ba5f9..3f3467b 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -15,6 +15,8 @@ #include "gpio.h" #include "panel.h" +fsfsdf+D+fsd+E;;ll;; + static void configure_alc1019(void) { mtcmos_audio_power_on(); -- To view, visit https://review.coreboot.org/c/coreboot/+/80133?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d517521e10a07113276eae9435f7ce5ba235723 Gerrit-Change-Number: 80133 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: Test for training 2 (do not approve)
by Kei Hiroyoshi (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Kei Hiroyoshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80132?usp=email ) Change subject: Test for training 2 (do not approve) ...................................................................... Test for training 2 (do not approve) Change-Id: I6907864b92ef8ada7629aa0cabb7a2373690c817 Signed-off-by: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/80132/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index deaceee..a1ba5f9 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -15,8 +15,6 @@ #include "gpio.h" #include "panel.h" -int testVar; // for test - static void configure_alc1019(void) { mtcmos_audio_power_on(); -- To view, visit https://review.coreboot.org/c/coreboot/+/80132?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6907864b92ef8ada7629aa0cabb7a2373690c817 Gerrit-Change-Number: 80132 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: Test for training (do not pprove)
by Kei Hiroyoshi (Code Review) 19 Jan '24

19 Jan '24

Kei Hiroyoshi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80131?usp=email ) Change subject: Test for training (do not pprove) ...................................................................... Test for training (do not pprove) Change-Id: Ib5c3dc64dc876c22f4a006aaf5ef0258d99f7c6f Signed-off-by: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> --- M src/mainboard/google/corsola/mainboard.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/80131/1 diff --git a/src/mainboard/google/corsola/mainboard.c b/src/mainboard/google/corsola/mainboard.c index a1ba5f9..deaceee 100644 --- a/src/mainboard/google/corsola/mainboard.c +++ b/src/mainboard/google/corsola/mainboard.c @@ -15,6 +15,8 @@ #include "gpio.h" #include "panel.h" +int testVar; // for test + static void configure_alc1019(void) { mtcmos_audio_power_on(); -- To view, visit https://review.coreboot.org/c/coreboot/+/80131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib5c3dc64dc876c22f4a006aaf5ef0258d99f7c6f Gerrit-Change-Number: 80131 Gerrit-PatchSet: 1 Gerrit-Owner: Kei Hiroyoshi <hiroyoshi.kei(a)fujitsu.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: drivers/uart/sifive.c: Fix divisor calculation
by Maximilian Brune (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Jonathan Neuschäfer, Patrick Rudolph, Philipp Hug. Hello Jonathan Neuschäfer, Patrick Rudolph, Philipp Hug, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79951?usp=email to look at the new patch set (#3). Change subject: drivers/uart/sifive.c: Fix divisor calculation ...................................................................... drivers/uart/sifive.c: Fix divisor calculation The divisor is calculated using the following formula: div = (frequency / baudrate) - 1; The current implementation however essentially calculates: div = (frequency / baudrate); Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I8a0898ce9016a70c0f91dc8a99fc1cf9e46d20c4 --- M src/drivers/uart/sifive.c 1 file changed, 10 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/79951/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a0898ce9016a70c0f91dc8a99fc1cf9e46d20c4 Gerrit-Change-Number: 79951 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp.hug(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Philipp Hug <philipp.hug(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: drivers/uart/sifive.c: Fix divisor calculation
by Maximilian Brune (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Jonathan Neuschäfer, Patrick Rudolph, Philipp Hug. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79951?usp=email ) Change subject: drivers/uart/sifive.c: Fix divisor calculation ...................................................................... Patch Set 2: (1 comment) File src/drivers/uart/sifive.c: https://review.coreboot.org/c/coreboot/+/79951/comment/b506ec55_e6e1ad37 : PS1, Line 50: // according to FU740 manual: > please use C style comments `/*` Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8a0898ce9016a70c0f91dc8a99fc1cf9e46d20c4 Gerrit-Change-Number: 79951 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp.hug(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Neuschäfer <j.neuschaefer(a)gmx.net> Gerrit-Attention: Philipp Hug <philipp.hug(a)gmail.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 05:14:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/riscv/boot.c: Comment OpenSBI Supervisor mode switch
by Maximilian Brune (Code Review) 19 Jan '24

19 Jan '24

Attention is currently required from: Patrick Rudolph, Paul Menzel, Philipp Hug, ron minnich. Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79949?usp=email ) Change subject: arch/riscv/boot.c: Comment OpenSBI Supervisor mode switch ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79949/comment/c9e5c799_c1a0af65 : PS1, Line 7: Add comment for clarity > Maybe: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79949?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib62be0c2ff59361200df4c65f9aca5f7456a0ada Gerrit-Change-Number: 79949 Gerrit-PatchSet: 2 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Fri, 19 Jan 2024 05:14:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2024