Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80128?usp=email )
Change subject: Documentation: Update Makefile .inc references to .mak
......................................................................
Documentation: Update Makefile .inc references to .mak
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I464170e60a22f39225044c6794d091455d931e9c
---
M Documentation/getting_started/build_system.md
M Documentation/getting_started/kconfig.md
M Documentation/sbom/sbom.md
M Documentation/technotes/2020-03-unit-testing-coreboot.md
M Documentation/tutorial/part3.md
5 files changed, 13 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/80128/1
diff --git a/Documentation/getting_started/build_system.md b/Documentation/getting_started/build_system.md
index 4013bc6..78b60e3 100644
--- a/Documentation/getting_started/build_system.md
+++ b/Documentation/getting_started/build_system.md
@@ -7,10 +7,10 @@
The overhead of learning this new syntax is (hopefully) offset by its lower
complexity.
-The build system is defined in the toplevel `Makefile` and `toolchain.inc`
+The build system is defined in the toplevel `Makefile` and `toolchain.mak`
and is supposed to be generic (and is in fact used with a number of other
projects). Project specific configuration should reside in files called
-`Makefile.inc`.
+`Makefile.mak`.
In general, the build system provides a number of "classes" that describe
various parts of the build. These cover the various build targets in coreboot
@@ -36,7 +36,7 @@
### subdirs
`subdirs` contains subdirectories (relative to the current directory) that
should also be handled by the build system. The build system expects these
-directories to contain a file called `Makefile.inc`.
+directories to contain a file called `Makefile.mak`.
Subdirectories are not read at the point where the `subdirs` statement
resides but later, after the current directory is handled (and potentially
@@ -66,7 +66,7 @@
You can use the `add_intermediate` helper to add new post-processing steps for
the final `coreboot.rom` image. For example you can add new files to CBFS by
-adding something like this to `site-local/Makefile.inc`
+adding something like this to `site-local/Makefile.mak`
```
$(call add_intermediate, add_mrc_data)
@@ -100,4 +100,4 @@
all files.
vboot provides its own implementation of `regions-for-file` that can be used
-as reference in `src/vboot/Makefile.inc`.
+as reference in `src/vboot/Makefile.mak`.
diff --git a/Documentation/getting_started/kconfig.md b/Documentation/getting_started/kconfig.md
index d40a4cc..4c691ee 100644
--- a/Documentation/getting_started/kconfig.md
+++ b/Documentation/getting_started/kconfig.md
@@ -963,7 +963,7 @@
for all of its symbols.
The coreboot makefile forces the config.h file to be included into all coreboot
-C files. This is done in Makefile.inc on the compiler command line using the
+C files. This is done in Makefile.mak on the compiler command line using the
“-include $(obj)/config.h” command line option.
Example of various symbol types in the config.h file:
diff --git a/Documentation/sbom/sbom.md b/Documentation/sbom/sbom.md
index c4984f9..560acaf 100644
--- a/Documentation/sbom/sbom.md
+++ b/Documentation/sbom/sbom.md
@@ -114,7 +114,7 @@
as part of your software's build process. For example in form of a
Makefile target.
-2. Change src/sbom/Makefile.inc (in order to know where to find the
+2. Change src/sbom/Makefile.mak (in order to know where to find the
CoSWID/SWID/uSWID file) as well as the Makefile in coreboot which
builds said software. For example for GRUB2 that could mean to add a
Makefile target in payloads/external/GRUB2/Makefile.
diff --git a/Documentation/technotes/2020-03-unit-testing-coreboot.md b/Documentation/technotes/2020-03-unit-testing-coreboot.md
index a4d283f..9ac4340 100644
--- a/Documentation/technotes/2020-03-unit-testing-coreboot.md
+++ b/Documentation/technotes/2020-03-unit-testing-coreboot.md
@@ -247,13 +247,13 @@
│ ├── include
│ │ ├── mocks <- mock headers, which replace original headers
│ │
-│ ├── Makefile.inc <- top Makefile for unit tests subsystem
+│ ├── Makefile.mak <- top Makefile for unit tests subsystem
│ ├── lib
-│ │ ├── Makefile.inc
+│ │ ├── Makefile.mak
│ │ ├── string-test.c <- test code for src/lib/string.c
│ │ │
│ ├── device
-│ │ ├── Makefile.inc
+│ │ ├── Makefile.mak
│ ├── i2c-test.c
│
├── build
diff --git a/Documentation/tutorial/part3.md b/Documentation/tutorial/part3.md
index 39d6ed5..f1578bd 100644
--- a/Documentation/tutorial/part3.md
+++ b/Documentation/tutorial/part3.md
@@ -96,8 +96,8 @@
be registered with the coreboot unit testing infrastructure.
```
-Every directory under `tests/` should contain a Makefile.inc, similar to
-what can be seen under the `src/`. Register a new test in Makefile.inc,
+Every directory under `tests/` should contain a Makefile.mak, similar to
+what can be seen under the `src/`. Register a new test in Makefile.mak,
by __appending__ test name to the `tests-y` variable.
```eval_rst
@@ -285,7 +285,7 @@
coreboot unit test infrastructure supports overriding of functions at
link time. This is as simple as adding a `name_of_function` to be
-mocked into <test_name>-mocks variable in Makefile.inc. The result is
+mocked into <test_name>-mocks variable in Makefile.mak. The result is
that the test's implementation of that function is called instead of
coreboot's.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80128?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I464170e60a22f39225044c6794d091455d931e9c
Gerrit-Change-Number: 80128
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80127?usp=email )
Change subject: util/autoport: Update Makefile.inc generation to Makefile.mak
......................................................................
util/autoport: Update Makefile.inc generation to Makefile.mak
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib77cb3a0852092ac414fe0160fe10d6e58fcf660
---
M util/autoport/main.go
M util/autoport/readme.md
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/80127/1
diff --git a/util/autoport/main.go b/util/autoport/main.go
index ed7cb0e..7efed9c 100644
--- a/util/autoport/main.go
+++ b/util/autoport/main.go
@@ -739,7 +739,7 @@
}
if len(BootBlockFiles) > 0 || len(ROMStageFiles) > 0 || len(RAMStageFiles) > 0 || len(SMMFiles) > 0 {
- mf := Create(ctx, "Makefile.inc")
+ mf := Create(ctx, "Makefile.mak")
defer mf.Close()
writeMF(mf, BootBlockFiles, "bootblock")
writeMF(mf, ROMStageFiles, "romstage")
diff --git a/util/autoport/readme.md b/util/autoport/readme.md
index 907d600..43a89fc 100644
--- a/util/autoport/readme.md
+++ b/util/autoport/readme.md
@@ -238,7 +238,7 @@
Then, move the generated file into your mainboard's directory
and hook it up to the build system by adding the following
-lines to `Makefile.inc`:
+lines to `Makefile.mak`:
cbfs-files-y += spd.bin
spd.bin-file := spd.bin
--
To view, visit https://review.coreboot.org/c/coreboot/+/80127?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib77cb3a0852092ac414fe0160fe10d6e58fcf660
Gerrit-Change-Number: 80127
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Christian Walter, Michał Żygowski, Patrick Rudolph, Piotr Król, Werner Zeh.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80125?usp=email )
Change subject: src, util: Clean up makefile.inc in text, help & comments
......................................................................
src, util: Clean up makefile.inc in text, help & comments
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
---
M src/Kconfig
M src/mainboard/cavium/cn8100_sff_evb/board.fmd
M src/mainboard/google/glados/variants/asuka/variant.c
M src/mainboard/google/nyan_big/bct/Makefile.mak
M src/mainboard/google/nyan_blaze/bct/Makefile.mak
M src/mainboard/intel/strago/Kconfig
M src/mainboard/opencellular/elgon/board.fmd
M src/mainboard/opencellular/elgon/vboot.fmd
M src/mainboard/protectli/vault_bsw/Kconfig
M src/mainboard/siemens/mc_apl1/Makefile.mak
M src/sbom/Makefile.mak
M util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
M util/scripts/rm_unused_code
13 files changed, 17 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/80125/1
diff --git a/src/Kconfig b/src/Kconfig
index 21c50c5..0e2c282 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -1492,7 +1492,7 @@
This variable allows SoC/mainboard to supply in a custom linker file
if required. This determines the linker file used for all the stages
(bootblock, romstage, verstage, ramstage, postcar) in
- src/arch/${ARCH}/Makefile.inc.
+ src/arch/${ARCH}/Makefile.mak.
###############################################################################
# Set default values for symbols created before mainboards. This allows the
diff --git a/src/mainboard/cavium/cn8100_sff_evb/board.fmd b/src/mainboard/cavium/cn8100_sff_evb/board.fmd
index 34f3161..0c57a49 100644
--- a/src/mainboard/cavium/cn8100_sff_evb/board.fmd
+++ b/src/mainboard/cavium/cn8100_sff_evb/board.fmd
@@ -6,7 +6,7 @@
FMAP@0x0 0x1000
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mak.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0x77c000
}
diff --git a/src/mainboard/google/glados/variants/asuka/variant.c b/src/mainboard/google/glados/variants/asuka/variant.c
index 68392fe..e937bc2 100644
--- a/src/mainboard/google/glados/variants/asuka/variant.c
+++ b/src/mainboard/google/glados/variants/asuka/variant.c
@@ -38,6 +38,6 @@
int is_dual_channel(const int spd_index)
{
- /* Per Makefile.inc, dual channel indices 1,3,5 */
+ /* Per Makefile.mak, dual channel indices 1,3,5 */
return (spd_index & 0x1);
}
diff --git a/src/mainboard/google/nyan_big/bct/Makefile.mak b/src/mainboard/google/nyan_big/bct/Makefile.mak
index f83c932..cf9be82 100644
--- a/src/mainboard/google/nyan_big/bct/Makefile.mak
+++ b/src/mainboard/google/nyan_big/bct/Makefile.mak
@@ -5,5 +5,5 @@
bct-cfg-y += odmdata.cfg
# Note when SDRAM config (sdram-*.cfg) files are changed, we have to regenerate
-# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.inc for more
+# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.mak for more
# information.
diff --git a/src/mainboard/google/nyan_blaze/bct/Makefile.mak b/src/mainboard/google/nyan_blaze/bct/Makefile.mak
index 02f32a59..837c56d 100644
--- a/src/mainboard/google/nyan_blaze/bct/Makefile.mak
+++ b/src/mainboard/google/nyan_blaze/bct/Makefile.mak
@@ -5,5 +5,5 @@
bct-cfg-y += odmdata.cfg
# Note when SDRAM config (sdram-*.cfg) files are changed, we have to regenerate
-# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.inc for more
+# the include files (sdram-*.inc). See ../../nyan/bct/Makefile.mak for more
# information.
diff --git a/src/mainboard/intel/strago/Kconfig b/src/mainboard/intel/strago/Kconfig
index 5cd7880..0e679ef 100644
--- a/src/mainboard/intel/strago/Kconfig
+++ b/src/mainboard/intel/strago/Kconfig
@@ -35,7 +35,7 @@
default "8086,22b0"
help
The VGA_BIOS_ID for the C0 version of the video BIOS is hardcoded
- in soc/intel/braswell/Makefile.inc as 8086,22b1
+ in soc/intel/braswell/Makefile.mak as 8086,22b1
config CBFS_SIZE
default 0x200000
diff --git a/src/mainboard/opencellular/elgon/board.fmd b/src/mainboard/opencellular/elgon/board.fmd
index 784f3b0..17552dc 100644
--- a/src/mainboard/opencellular/elgon/board.fmd
+++ b/src/mainboard/opencellular/elgon/board.fmd
@@ -6,7 +6,7 @@
FMAP@0x0 0x1000
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mak.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0xf7c000
}
diff --git a/src/mainboard/opencellular/elgon/vboot.fmd b/src/mainboard/opencellular/elgon/vboot.fmd
index 0d6af2d..28e87c7 100644
--- a/src/mainboard/opencellular/elgon/vboot.fmd
+++ b/src/mainboard/opencellular/elgon/vboot.fmd
@@ -8,7 +8,7 @@
RO_FRID@0x1000 0x100
# bootblock includes trusted/non-trusted CLIB, CSIB,
# and BL1FWs packaged in
- # src/soc/cavium/common/Makefile.inc.
+ # src/soc/cavium/common/Makefile.mak.
BOOTBLOCK@0x10000 0x70000
COREBOOT(CBFS)@0x80000 0x2fc000
GBB@0x37c000 0x80000
diff --git a/src/mainboard/protectli/vault_bsw/Kconfig b/src/mainboard/protectli/vault_bsw/Kconfig
index e169392..77d0ee2 100644
--- a/src/mainboard/protectli/vault_bsw/Kconfig
+++ b/src/mainboard/protectli/vault_bsw/Kconfig
@@ -57,7 +57,7 @@
default "8086,22b0"
help
The VGA_BIOS_ID for the C0 version of the video bios is hardcoded
- in soc/intel/braswell/Makefile.inc as 8086,22b1
+ in soc/intel/braswell/Makefile.mak as 8086,22b1
endif #RUN_FSP_GOP
diff --git a/src/mainboard/siemens/mc_apl1/Makefile.mak b/src/mainboard/siemens/mc_apl1/Makefile.mak
index e179201..338ed30 100644
--- a/src/mainboard/siemens/mc_apl1/Makefile.mak
+++ b/src/mainboard/siemens/mc_apl1/Makefile.mak
@@ -4,7 +4,7 @@
# The inclusion of romstage.c is not necessary here.
# It is put down only to the better understanding.
-# The file is already included over src/arch/x86/Makefile.inc.
+# The file is already included over src/arch/x86/Makefile.mak.
romstage-y += romstage.c
ramstage-y += mainboard.c
diff --git a/src/sbom/Makefile.mak b/src/sbom/Makefile.mak
index 7783f09..0afa57c 100644
--- a/src/sbom/Makefile.mak
+++ b/src/sbom/Makefile.mak
@@ -65,7 +65,7 @@
vboot-pkgconfig-files = $(obj)/external/vboot_reference-bootblock/vboot_host.pc $(obj)/external/vboot_reference-romstage/vboot_host.pc $(obj)/external/vboot_reference-ramstage/vboot_host.pc $(obj)/external/vboot_reference-postcar/vboot_host.pc
swid-files-$(CONFIG_SBOM_VBOOT) += $(vboot-pkgconfig-files)
-$(vboot-pkgconfig-files): $(VBOOT_LIB_bootblock) $(VBOOT_LIB_romstage) $(VBOOT_LIB_ramstage) $(VBOOT_LIB_postcar) # src/security/vboot/Makefile.inc
+$(vboot-pkgconfig-files): $(VBOOT_LIB_bootblock) $(VBOOT_LIB_romstage) $(VBOOT_LIB_ramstage) $(VBOOT_LIB_postcar) # src/security/vboot/Makefile.mak
ifeq ($(CONFIG_SBOM_COMPILER),y)
compiler-toolchain = $(CC_bootblock) $(CC_romstage) $(CC_ramstage) $(CC_postcar) $(CC_verstage) $(LD_bootblock) $(LD_romstage) $(LD_ramstage) $(LD_postcar) $(LD_verstage) $(AS_bootblock) $(AS_romstage) $(AS_ramstage) $(AS_postcar) $(AS_verstage)
diff --git a/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch b/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
index 688b387..35eafcb 100644
--- a/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
+++ b/util/kconfig/patches/0008-kconfig-Add-wildcard-support-for-source.patch
@@ -8,7 +8,7 @@
makes automatic inclusion of all boards a tedious task
and prevents us from implementing "drop in" boards.
-In our Makefile.inc files we already include mainboard
+In our Makefile.mak files we already include mainboard
directories per wildcard, so let's add the infrastructure
to do the same with Kconfig.
@@ -28,7 +28,7 @@
+++ kconfig/lexer.l
@@ -8,6 +8,7 @@
%{
-
+
#include <assert.h>
+#include <glob.h>
#include <limits.h>
@@ -37,7 +37,7 @@
@@ -439,6 +440,32 @@ void zconf_nextfile(const char *name)
current_file = file;
}
-
+
+void zconf_nextfiles(const char *wildcard)
+{
+ glob_t g;
@@ -78,7 +78,7 @@
+void zconf_nextfiles(const char *name);
int zconf_lineno(void);
const char *zconf_curname(void);
-
+
Index: kconfig/parser.y
===================================================================
--- kconfig.orig/parser.y
@@ -91,4 +91,4 @@
+ zconf_nextfiles($2);
free($2);
};
-
+
diff --git a/util/scripts/rm_unused_code b/util/scripts/rm_unused_code
index 53c0b65..d4b42b6 100755
--- a/util/scripts/rm_unused_code
+++ b/util/scripts/rm_unused_code
@@ -259,7 +259,7 @@
remove_unused() {
local dir
# Most files can be removed simply by looking at the time, but
- # all Kconfig and Makefile.inc files in the entire tree are accessed
+ # all Kconfig and Makefiles in the entire tree are accessed
# whether they're used or not.
remove_kconfigs
--
To view, visit https://review.coreboot.org/c/coreboot/+/80125?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib69236fb5d68272f92405512dc231fa75ecccaa6
Gerrit-Change-Number: 80125
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-MessageType: newchange
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80124?usp=email )
Change subject: util/mb: Update variant template Makefiles from .inc to .mak
......................................................................
util/mb: Update variant template Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I2a6a4d1eb7e0d0cd32c8690caf3eff340cdb0d8c
---
R util/mainboard/google/brya0/template/memory/Makefile.mak
R util/mainboard/google/dalboz/template/Makefile.mak
R util/mainboard/google/dalboz/template/spd/Makefile.mak
R util/mainboard/google/guybrush/template/Makefile.mak
R util/mainboard/google/guybrush/template/memory/Makefile.mak
R util/mainboard/google/hatch/template/Makefile.mak
R util/mainboard/google/nissa/template/memory/Makefile.mak
R util/mainboard/google/puff/template/Makefile.mak
R util/mainboard/google/rex0/template/Makefile.mak
R util/mainboard/google/rex0/template/memory/Makefile.mak
R util/mainboard/google/trembyle/template/Makefile.mak
R util/mainboard/google/trembyle/template/spd/Makefile.mak
R util/mainboard/google/volteer/template/memory/Makefile.mak
R util/mainboard/google/waddledee/template/memory/Makefile.mak
R util/mainboard/google/waddledoo/template/memory/Makefile.mak
15 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/80124/1
diff --git a/util/mainboard/google/brya0/template/memory/Makefile.inc b/util/mainboard/google/brya0/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/brya0/template/memory/Makefile.inc
rename to util/mainboard/google/brya0/template/memory/Makefile.mak
diff --git a/util/mainboard/google/dalboz/template/Makefile.inc b/util/mainboard/google/dalboz/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/dalboz/template/Makefile.inc
rename to util/mainboard/google/dalboz/template/Makefile.mak
diff --git a/util/mainboard/google/dalboz/template/spd/Makefile.inc b/util/mainboard/google/dalboz/template/spd/Makefile.mak
similarity index 100%
rename from util/mainboard/google/dalboz/template/spd/Makefile.inc
rename to util/mainboard/google/dalboz/template/spd/Makefile.mak
diff --git a/util/mainboard/google/guybrush/template/Makefile.inc b/util/mainboard/google/guybrush/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/guybrush/template/Makefile.inc
rename to util/mainboard/google/guybrush/template/Makefile.mak
diff --git a/util/mainboard/google/guybrush/template/memory/Makefile.inc b/util/mainboard/google/guybrush/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/guybrush/template/memory/Makefile.inc
rename to util/mainboard/google/guybrush/template/memory/Makefile.mak
diff --git a/util/mainboard/google/hatch/template/Makefile.inc b/util/mainboard/google/hatch/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/hatch/template/Makefile.inc
rename to util/mainboard/google/hatch/template/Makefile.mak
diff --git a/util/mainboard/google/nissa/template/memory/Makefile.inc b/util/mainboard/google/nissa/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/nissa/template/memory/Makefile.inc
rename to util/mainboard/google/nissa/template/memory/Makefile.mak
diff --git a/util/mainboard/google/puff/template/Makefile.inc b/util/mainboard/google/puff/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/puff/template/Makefile.inc
rename to util/mainboard/google/puff/template/Makefile.mak
diff --git a/util/mainboard/google/rex0/template/Makefile.inc b/util/mainboard/google/rex0/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/rex0/template/Makefile.inc
rename to util/mainboard/google/rex0/template/Makefile.mak
diff --git a/util/mainboard/google/rex0/template/memory/Makefile.inc b/util/mainboard/google/rex0/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/rex0/template/memory/Makefile.inc
rename to util/mainboard/google/rex0/template/memory/Makefile.mak
diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.mak
similarity index 100%
rename from util/mainboard/google/trembyle/template/Makefile.inc
rename to util/mainboard/google/trembyle/template/Makefile.mak
diff --git a/util/mainboard/google/trembyle/template/spd/Makefile.inc b/util/mainboard/google/trembyle/template/spd/Makefile.mak
similarity index 100%
rename from util/mainboard/google/trembyle/template/spd/Makefile.inc
rename to util/mainboard/google/trembyle/template/spd/Makefile.mak
diff --git a/util/mainboard/google/volteer/template/memory/Makefile.inc b/util/mainboard/google/volteer/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/volteer/template/memory/Makefile.inc
rename to util/mainboard/google/volteer/template/memory/Makefile.mak
diff --git a/util/mainboard/google/waddledee/template/memory/Makefile.inc b/util/mainboard/google/waddledee/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/waddledee/template/memory/Makefile.inc
rename to util/mainboard/google/waddledee/template/memory/Makefile.mak
diff --git a/util/mainboard/google/waddledoo/template/memory/Makefile.inc b/util/mainboard/google/waddledoo/template/memory/Makefile.mak
similarity index 100%
rename from util/mainboard/google/waddledoo/template/memory/Makefile.inc
rename to util/mainboard/google/waddledoo/template/memory/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80124?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2a6a4d1eb7e0d0cd32c8690caf3eff340cdb0d8c
Gerrit-Change-Number: 80124
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Julius Werner, Stefan Reinauer.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80123?usp=email )
Change subject: util: Rename Makefiles from .inc to .mak
......................................................................
util: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I434940ebb46853980596f7ad55d27a62c90280fa
---
M Makefile.mak
R util/amdfwtool/Makefile.mak
R util/bincfg/Makefile.mak
M util/cbfstool/Makefile
R util/cbfstool/Makefile.mak
R util/cbfstool/bpdt_formats/Makefile.mak
R util/cbfstool/fpt_formats/Makefile.mak
R util/crossgcc/Makefile.mak
M util/futility/Makefile
R util/futility/Makefile.mak
M util/ifdtool/Makefile
R util/ifdtool/Makefile.mak
R util/marvell/Makefile.mak
R util/marvell/doimage_mv/Makefile.mak
R util/nvidia/Makefile.mak
R util/nvramtool/Makefile.mak
R util/qemu/Makefile.mak
R util/sconfig/Makefile.mak
R util/supermicro/Makefile.mak
19 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/80123/1
diff --git a/Makefile.mak b/Makefile.mak
index de2598c..386c633 100644
--- a/Makefile.mak
+++ b/Makefile.mak
@@ -768,7 +768,7 @@
install-git-commit-clangfmt:
cp util/scripts/prepare-commit-msg.clang-format .git/hooks/prepare-commit-msg
-include util/crossgcc/Makefile.inc
+include util/crossgcc/Makefile.mak
.PHONY: tools
tools: $(objutil)/kconfig/conf $(objutil)/kconfig/toada $(CBFSTOOL) $(objutil)/cbfstool/cbfs-compression-tool $(FMAPTOOL) $(RMODTOOL) $(IFWITOOL) $(objutil)/nvramtool/nvramtool $(objutil)/sconfig/sconfig $(IFDTOOL) $(CBOOTIMAGE) $(AMDFWTOOL) $(AMDCOMPRESS) $(FUTILITY) $(BINCFG) $(IFITTOOL) $(objutil)/supermicro/smcbiosinfo $(CSE_FPT) $(CSE_SERGER) $(AMDFWREAD)
diff --git a/util/amdfwtool/Makefile.inc b/util/amdfwtool/Makefile.mak
similarity index 100%
rename from util/amdfwtool/Makefile.inc
rename to util/amdfwtool/Makefile.mak
diff --git a/util/bincfg/Makefile.inc b/util/bincfg/Makefile.mak
similarity index 100%
rename from util/bincfg/Makefile.inc
rename to util/bincfg/Makefile.mak
diff --git a/util/cbfstool/Makefile b/util/cbfstool/Makefile
index 034aca2..0b13693 100644
--- a/util/cbfstool/Makefile
+++ b/util/cbfstool/Makefile
@@ -91,7 +91,7 @@
.SILENT:
endif
-include Makefile.inc
+include Makefile.mak
$(objutil)/cbfstool/cbfstool.o: $(VBOOT_SOURCE)/firmware/include/vb2_sha.h
$(objutil)/cbfstool/elogtool.o: $(VBOOT_SOURCE)/firmware/include/vb2_sha.h
diff --git a/util/cbfstool/Makefile.inc b/util/cbfstool/Makefile.mak
similarity index 98%
rename from util/cbfstool/Makefile.inc
rename to util/cbfstool/Makefile.mak
index 80aab67..783ea95 100644
--- a/util/cbfstool/Makefile.inc
+++ b/util/cbfstool/Makefile.mak
@@ -98,14 +98,14 @@
elogobj += common.o
elogobj += flashrom.o
-include $(top)/util/cbfstool/fpt_formats/Makefile.inc
+include $(top)/util/cbfstool/fpt_formats/Makefile.mak
cse_fpt_obj :=
cse_fpt_obj += cse_fpt.o
cse_fpt_obj += common.o
cse_fpt_obj += cse_helpers.o
cse_fpt_obj += $(foreach var, $(fpt_formats_obj), $(var))
-include $(top)/util/cbfstool/bpdt_formats/Makefile.inc
+include $(top)/util/cbfstool/bpdt_formats/Makefile.mak
cse_serger_obj :=
cse_serger_obj += cse_serger.o
cse_serger_obj += common.o
diff --git a/util/cbfstool/bpdt_formats/Makefile.inc b/util/cbfstool/bpdt_formats/Makefile.mak
similarity index 100%
rename from util/cbfstool/bpdt_formats/Makefile.inc
rename to util/cbfstool/bpdt_formats/Makefile.mak
diff --git a/util/cbfstool/fpt_formats/Makefile.inc b/util/cbfstool/fpt_formats/Makefile.mak
similarity index 100%
rename from util/cbfstool/fpt_formats/Makefile.inc
rename to util/cbfstool/fpt_formats/Makefile.mak
diff --git a/util/crossgcc/Makefile.inc b/util/crossgcc/Makefile.mak
similarity index 100%
rename from util/crossgcc/Makefile.inc
rename to util/crossgcc/Makefile.mak
diff --git a/util/futility/Makefile b/util/futility/Makefile
index 6901948..200b423 100644
--- a/util/futility/Makefile
+++ b/util/futility/Makefile
@@ -23,4 +23,4 @@
endif
endif
-include Makefile.inc
+include Makefile.mak
diff --git a/util/futility/Makefile.inc b/util/futility/Makefile.mak
similarity index 100%
rename from util/futility/Makefile.inc
rename to util/futility/Makefile.mak
diff --git a/util/ifdtool/Makefile b/util/ifdtool/Makefile
index c021069..cb01966 100644
--- a/util/ifdtool/Makefile
+++ b/util/ifdtool/Makefile
@@ -10,7 +10,7 @@
HOSTCFLAGS ?= $(CFLAGS)
top := ../..
objutil := ..
-include Makefile.inc
+include Makefile.mak
PROGRAM=$(objutil)/ifdtool/ifdtool
diff --git a/util/ifdtool/Makefile.inc b/util/ifdtool/Makefile.mak
similarity index 100%
rename from util/ifdtool/Makefile.inc
rename to util/ifdtool/Makefile.mak
diff --git a/util/marvell/Makefile.inc b/util/marvell/Makefile.mak
similarity index 100%
rename from util/marvell/Makefile.inc
rename to util/marvell/Makefile.mak
diff --git a/util/marvell/doimage_mv/Makefile.inc b/util/marvell/doimage_mv/Makefile.mak
similarity index 100%
rename from util/marvell/doimage_mv/Makefile.inc
rename to util/marvell/doimage_mv/Makefile.mak
diff --git a/util/nvidia/Makefile.inc b/util/nvidia/Makefile.mak
similarity index 100%
rename from util/nvidia/Makefile.inc
rename to util/nvidia/Makefile.mak
diff --git a/util/nvramtool/Makefile.inc b/util/nvramtool/Makefile.mak
similarity index 100%
rename from util/nvramtool/Makefile.inc
rename to util/nvramtool/Makefile.mak
diff --git a/util/qemu/Makefile.inc b/util/qemu/Makefile.mak
similarity index 93%
rename from util/qemu/Makefile.inc
rename to util/qemu/Makefile.mak
index e1181ad..ff82b09 100644
--- a/util/qemu/Makefile.inc
+++ b/util/qemu/Makefile.mak
@@ -2,10 +2,10 @@
# This automatically adds a `qemu` make target if a compatible
# configuration is selected. There are some notable variables
-# that can be set or adapted in `Makefile.inc` files, the make
+# that can be set or adapted in `Makefile.mak` files, the make
# command line or the environment:
#
-# Primarily for `Makefile.inc` use:
+# Primarily for `Makefile.mak` use:
# QEMU-y the QEMU executable
# QEMU_CFG-y a QEMU config that sets the available default devices,
# used to run more comprehensive tests by default,
diff --git a/util/sconfig/Makefile.inc b/util/sconfig/Makefile.mak
similarity index 100%
rename from util/sconfig/Makefile.inc
rename to util/sconfig/Makefile.mak
diff --git a/util/supermicro/Makefile.inc b/util/supermicro/Makefile.mak
similarity index 100%
rename from util/supermicro/Makefile.inc
rename to util/supermicro/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80123?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I434940ebb46853980596f7ad55d27a62c90280fa
Gerrit-Change-Number: 80123
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Jakub Czapiga.
Martin L Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/80122?usp=email )
Change subject: tests: Rename Makefiles from .inc to .mak
......................................................................
tests: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Id09eafd293a54198aab87281f529749325df8b07
---
M tests/Makefile.common
M tests/Makefile.mak
R tests/acpi/Makefile.mak
R tests/commonlib/Makefile.mak
R tests/commonlib/bsd/Makefile.mak
R tests/console/Makefile.mak
R tests/device/Makefile.mak
R tests/drivers/Makefile.mak
R tests/lib/Makefile.mak
9 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/80122/1
diff --git a/tests/Makefile.common b/tests/Makefile.common
index e51d253..d64053b 100644
--- a/tests/Makefile.common
+++ b/tests/Makefile.common
@@ -42,7 +42,7 @@
TEST_INCLUDES += -I$(dir $(TEST_KCONFIG_AUTOHEADER))
# Note: This is intentionally just a subset of the warnings in the toplevel
-# Makefile.inc. We don't need to be as strict with test code, and things like
+# Makefile.mak. We don't need to be as strict with test code, and things like
# -Wmissing-prototypes just make working with the test framework cumbersome.
# Only put conservative warnings here that really detect code that's obviously
# unintentional.
@@ -95,7 +95,7 @@
$(1)-config-file := $(testobj)/$(1)/config.h
$$($(1)-config-file): $(TEST_KCONFIG_AUTOHEADER)
mkdir -p $$(dir $$@)
- printf '// File generated by tests/Makefile.inc\n// Do not change\n' > $$@
+ printf '// File generated by tests/Makefile.mak\n// Do not change\n' > $$@
printf '#include <%s>\n\n' "$(notdir $(TEST_KCONFIG_AUTOHEADER))" >> $$@
for kv in $$($(1)-config); do \
key="`echo $$$$kv | cut -d '=' -f -1`"; \
diff --git a/tests/Makefile.mak b/tests/Makefile.mak
index 584b4c0..10d3326 100644
--- a/tests/Makefile.mak
+++ b/tests/Makefile.mak
@@ -44,7 +44,7 @@
$(eval $(1)$(2)-stage := $(if $($(1)$(2)-stage),$($(1)$(2)-stage),ramstage))
$(if $(findstring $($(1)$(2)-stage), $(stages)),,
$(error Wrong $(1)$(2)-stage value $($(1)$(2)-stage). \
- Check your $(dir $(1)$(2))Makefile.inc))
+ Check your $(dir $(1)$(2))Makefile.mak))
endef
$(call add-special-class, tests)
diff --git a/tests/acpi/Makefile.inc b/tests/acpi/Makefile.mak
similarity index 100%
rename from tests/acpi/Makefile.inc
rename to tests/acpi/Makefile.mak
diff --git a/tests/commonlib/Makefile.inc b/tests/commonlib/Makefile.mak
similarity index 100%
rename from tests/commonlib/Makefile.inc
rename to tests/commonlib/Makefile.mak
diff --git a/tests/commonlib/bsd/Makefile.inc b/tests/commonlib/bsd/Makefile.mak
similarity index 100%
rename from tests/commonlib/bsd/Makefile.inc
rename to tests/commonlib/bsd/Makefile.mak
diff --git a/tests/console/Makefile.inc b/tests/console/Makefile.mak
similarity index 100%
rename from tests/console/Makefile.inc
rename to tests/console/Makefile.mak
diff --git a/tests/device/Makefile.inc b/tests/device/Makefile.mak
similarity index 100%
rename from tests/device/Makefile.inc
rename to tests/device/Makefile.mak
diff --git a/tests/drivers/Makefile.inc b/tests/drivers/Makefile.mak
similarity index 100%
rename from tests/drivers/Makefile.inc
rename to tests/drivers/Makefile.mak
diff --git a/tests/lib/Makefile.inc b/tests/lib/Makefile.mak
similarity index 100%
rename from tests/lib/Makefile.inc
rename to tests/lib/Makefile.mak
--
To view, visit https://review.coreboot.org/c/coreboot/+/80122?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id09eafd293a54198aab87281f529749325df8b07
Gerrit-Change-Number: 80122
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jason Nien, Martin L Roth, Martin Roth, Nick Vaccaro.
Hello Jason Nien, Martin Roth, Nick Vaccaro, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80109?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/google/sarien to zork: Rename Makefiles from .inc to .mak
......................................................................
mb/google/sarien to zork: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: Ib8a2ae26ed4380592d15e1a7b2d682639413af01
---
R src/mainboard/google/sarien/Makefile.mak
R src/mainboard/google/sarien/variants/arcada/Makefile.mak
R src/mainboard/google/sarien/variants/sarien/Makefile.mak
R src/mainboard/google/skyrim/Makefile.mak
R src/mainboard/google/skyrim/variants/baseboard/Makefile.mak
R src/mainboard/google/skyrim/variants/crystaldrift/Makefile.mak
R src/mainboard/google/skyrim/variants/crystaldrift/memory/Makefile.mak
R src/mainboard/google/skyrim/variants/frostflow/Makefile.mak
R src/mainboard/google/skyrim/variants/frostflow/memory/Makefile.mak
R src/mainboard/google/skyrim/variants/markarth/Makefile.mak
R src/mainboard/google/skyrim/variants/markarth/memory/Makefile.mak
R src/mainboard/google/skyrim/variants/skyrim/Makefile.mak
R src/mainboard/google/skyrim/variants/skyrim/memory/Makefile.mak
R src/mainboard/google/skyrim/variants/winterhold/Makefile.mak
R src/mainboard/google/skyrim/variants/winterhold/memory/Makefile.mak
R src/mainboard/google/slippy/Makefile.mak
R src/mainboard/google/slippy/variants/falco/Makefile.mak
R src/mainboard/google/slippy/variants/leon/Makefile.mak
R src/mainboard/google/slippy/variants/peppy/Makefile.mak
R src/mainboard/google/slippy/variants/wolf/Makefile.mak
R src/mainboard/google/smaug/Makefile.mak
R src/mainboard/google/smaug/bct/Makefile.mak
R src/mainboard/google/storm/Makefile.mak
R src/mainboard/google/stout/Makefile.mak
R src/mainboard/google/trogdor/Makefile.mak
R src/mainboard/google/veyron/Makefile.mak
R src/mainboard/google/veyron_mickey/Makefile.mak
R src/mainboard/google/veyron_rialto/Makefile.mak
R src/mainboard/google/volteer/Makefile.mak
R src/mainboard/google/volteer/spd/Makefile.mak
R src/mainboard/google/volteer/variants/baseboard/Makefile.mak
R src/mainboard/google/volteer/variants/chronicler/Makefile.mak
R src/mainboard/google/volteer/variants/chronicler/memory/Makefile.mak
R src/mainboard/google/volteer/variants/collis/Makefile.mak
R src/mainboard/google/volteer/variants/collis/memory/Makefile.mak
R src/mainboard/google/volteer/variants/copano/Makefile.mak
R src/mainboard/google/volteer/variants/copano/memory/Makefile.mak
R src/mainboard/google/volteer/variants/delbin/Makefile.mak
R src/mainboard/google/volteer/variants/delbin/memory/Makefile.mak
R src/mainboard/google/volteer/variants/drobit/Makefile.mak
R src/mainboard/google/volteer/variants/drobit/memory/Makefile.mak
R src/mainboard/google/volteer/variants/eldrid/Makefile.mak
R src/mainboard/google/volteer/variants/eldrid/memory/Makefile.mak
R src/mainboard/google/volteer/variants/elemi/Makefile.mak
R src/mainboard/google/volteer/variants/elemi/memory/Makefile.mak
R src/mainboard/google/volteer/variants/halvor/Makefile.mak
R src/mainboard/google/volteer/variants/halvor/memory/Makefile.mak
R src/mainboard/google/volteer/variants/lillipup/memory/Makefile.mak
R src/mainboard/google/volteer/variants/lindar/Makefile.mak
R src/mainboard/google/volteer/variants/lindar/memory/Makefile.mak
R src/mainboard/google/volteer/variants/malefor/Makefile.mak
R src/mainboard/google/volteer/variants/malefor/memory/Makefile.mak
R src/mainboard/google/volteer/variants/terrador/Makefile.mak
R src/mainboard/google/volteer/variants/terrador/memory/Makefile.mak
R src/mainboard/google/volteer/variants/todor/Makefile.mak
R src/mainboard/google/volteer/variants/todor/memory/Makefile.mak
R src/mainboard/google/volteer/variants/trondo/Makefile.mak
R src/mainboard/google/volteer/variants/trondo/memory/Makefile.mak
R src/mainboard/google/volteer/variants/voema/Makefile.mak
R src/mainboard/google/volteer/variants/voema/memory/Makefile.mak
R src/mainboard/google/volteer/variants/volet/Makefile.mak
R src/mainboard/google/volteer/variants/volet/memory/Makefile.mak
R src/mainboard/google/volteer/variants/volteer/Makefile.mak
R src/mainboard/google/volteer/variants/volteer/memory/Makefile.mak
R src/mainboard/google/volteer/variants/volteer2/Makefile.mak
R src/mainboard/google/volteer/variants/volteer2/memory/Makefile.mak
R src/mainboard/google/volteer/variants/voxel/Makefile.mak
R src/mainboard/google/volteer/variants/voxel/memory/Makefile.mak
R src/mainboard/google/zork/Makefile.mak
R src/mainboard/google/zork/spd/Makefile.mak
R src/mainboard/google/zork/variants/baseboard/Makefile.mak
R src/mainboard/google/zork/variants/baseboard/dalboz/Makefile.mak
R src/mainboard/google/zork/variants/baseboard/trembyle/Makefile.mak
R src/mainboard/google/zork/variants/berknip/Makefile.mak
R src/mainboard/google/zork/variants/berknip/spd/Makefile.mak
R src/mainboard/google/zork/variants/dalboz/Makefile.mak
R src/mainboard/google/zork/variants/dalboz/spd/Makefile.mak
R src/mainboard/google/zork/variants/dirinboz/Makefile.mak
R src/mainboard/google/zork/variants/dirinboz/spd/Makefile.mak
R src/mainboard/google/zork/variants/ezkinil/Makefile.mak
R src/mainboard/google/zork/variants/ezkinil/spd/Makefile.mak
R src/mainboard/google/zork/variants/gumboz/Makefile.mak
R src/mainboard/google/zork/variants/gumboz/spd/Makefile.mak
R src/mainboard/google/zork/variants/morphius/Makefile.mak
R src/mainboard/google/zork/variants/morphius/spd/Makefile.mak
R src/mainboard/google/zork/variants/shuboz/Makefile.mak
R src/mainboard/google/zork/variants/shuboz/spd/Makefile.mak
R src/mainboard/google/zork/variants/trembyle/Makefile.mak
R src/mainboard/google/zork/variants/trembyle/spd/Makefile.mak
R src/mainboard/google/zork/variants/vilboz/Makefile.mak
R src/mainboard/google/zork/variants/vilboz/spd/Makefile.mak
R src/mainboard/google/zork/variants/woomax/Makefile.mak
R src/mainboard/google/zork/variants/woomax/spd/Makefile.mak
93 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/80109/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80109?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib8a2ae26ed4380592d15e1a7b2d682639413af01
Gerrit-Change-Number: 80109
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Jason Nien, Martin Roth, Nick Vaccaro, Subrata Banik, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Jason Nien, Martin Roth, Nick Vaccaro, Subrata Banik, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80107?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/gale to nyan_blaze: Rename Makefiles from .inc to .mak
......................................................................
mb/google/gale to nyan_blaze: Rename Makefiles from .inc to .mak
The .inc suffix is confusing to various tools as it's not specific to
Makefiles. This means that editors don't recognize the files, and don't
open them with highlighting and any other specific editor functionality.
This issue is also seen in the release notes generation script where
Makefiles get renamed before running cloc.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I92f8bd7e1c9fc6e4120fb94c2299a266304e19de
---
R src/mainboard/google/gale/Makefile.mak
R src/mainboard/google/geralt/Makefile.mak
R src/mainboard/google/glados/Makefile.mak
R src/mainboard/google/glados/variants/asuka/Makefile.mak
R src/mainboard/google/glados/variants/caroline/Makefile.mak
R src/mainboard/google/glados/variants/cave/Makefile.mak
R src/mainboard/google/glados/variants/chell/Makefile.mak
R src/mainboard/google/glados/variants/glados/Makefile.mak
R src/mainboard/google/glados/variants/lars/Makefile.mak
R src/mainboard/google/glados/variants/sentry/Makefile.mak
R src/mainboard/google/gru/Makefile.mak
R src/mainboard/google/gru/sdram_params/Makefile.mak
R src/mainboard/google/guybrush/Makefile.mak
R src/mainboard/google/guybrush/variants/baseboard/Makefile.mak
R src/mainboard/google/guybrush/variants/dewatt/Makefile.mak
R src/mainboard/google/guybrush/variants/dewatt/memory/Makefile.mak
R src/mainboard/google/guybrush/variants/guybrush/Makefile.mak
R src/mainboard/google/guybrush/variants/guybrush/memory/Makefile.mak
R src/mainboard/google/guybrush/variants/nipperkin/Makefile.mak
R src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.mak
R src/mainboard/google/hatch/Makefile.mak
R src/mainboard/google/hatch/variants/akemi/Makefile.mak
R src/mainboard/google/hatch/variants/baseboard/Makefile.mak
R src/mainboard/google/hatch/variants/dratini/Makefile.mak
R src/mainboard/google/hatch/variants/hatch/Makefile.mak
R src/mainboard/google/hatch/variants/helios/Makefile.mak
R src/mainboard/google/hatch/variants/jinlon/Makefile.mak
R src/mainboard/google/hatch/variants/kindred/Makefile.mak
R src/mainboard/google/hatch/variants/kohaku/Makefile.mak
R src/mainboard/google/hatch/variants/mushu/Makefile.mak
R src/mainboard/google/hatch/variants/nightfury/Makefile.mak
R src/mainboard/google/hatch/variants/palkia/Makefile.mak
R src/mainboard/google/herobrine/Makefile.mak
R src/mainboard/google/jecht/Makefile.mak
R src/mainboard/google/jecht/spd/Makefile.mak
R src/mainboard/google/kahlee/Makefile.mak
R src/mainboard/google/kahlee/variants/aleena/Makefile.mak
R src/mainboard/google/kahlee/variants/baseboard/Makefile.mak
R src/mainboard/google/kahlee/variants/baseboard/spd/Makefile.mak
R src/mainboard/google/kahlee/variants/careena/Makefile.mak
R src/mainboard/google/kahlee/variants/careena/spd/Makefile.mak
R src/mainboard/google/kahlee/variants/grunt/Makefile.mak
R src/mainboard/google/kahlee/variants/liara/Makefile.mak
R src/mainboard/google/kahlee/variants/nuwani/Makefile.mak
R src/mainboard/google/kahlee/variants/nuwani/spd/Makefile.mak
R src/mainboard/google/kahlee/variants/treeya/Makefile.mak
R src/mainboard/google/kahlee/variants/treeya/spd/Makefile.mak
R src/mainboard/google/kukui/Makefile.mak
R src/mainboard/google/kukui/sdram_params/Makefile.mak
R src/mainboard/google/link/Makefile.mak
R src/mainboard/google/mistral/Makefile.mak
R src/mainboard/google/myst/Makefile.mak
R src/mainboard/google/myst/variants/baseboard/Makefile.mak
R src/mainboard/google/myst/variants/myst/Makefile.mak
R src/mainboard/google/myst/variants/myst/memory/Makefile.mak
R src/mainboard/google/nyan/Makefile.mak
R src/mainboard/google/nyan/bct/Makefile.mak
R src/mainboard/google/nyan_big/Makefile.mak
R src/mainboard/google/nyan_big/bct/Makefile.mak
R src/mainboard/google/nyan_blaze/Makefile.mak
R src/mainboard/google/nyan_blaze/bct/Makefile.mak
61 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/80107/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80107?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I92f8bd7e1c9fc6e4120fb94c2299a266304e19de
Gerrit-Change-Number: 80107
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Simon Yang, Subrata Banik.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80001?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/anraggar: Enable BT audio offload
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Do you need vGpio change for this too?
--
To view, visit https://review.coreboot.org/c/coreboot/+/80001?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e6731c8ceaad6ee58b525d4246fa769bfe1b0c7
Gerrit-Change-Number: 80001
Gerrit-PatchSet: 3
Gerrit-Owner: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Jianeng Ceng <cengjianeng(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 19 Jan 2024 02:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment