coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: mb/google/brya/var/skolas: add nau8318 speaker support
by AlanKY Lee (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: David Lin, Eric Lai, Mac Chiang, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli. AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email ) Change subject: mb/google/brya/var/skolas: add nau8318 speaker support ...................................................................... Patch Set 20: (1 comment) Patchset: PS20: > Yes, NAU8318 for SPK, NAU8825 for Headphone. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76925?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1 Gerrit-Change-Number: 76925 Gerrit-PatchSet: 20 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Lin <CTLIN0(a)nuvoton.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 23:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/skolas: add nau8318 speaker support
by AlanKY Lee (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: David Lin, Eric Lai, Mac Chiang, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli. AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email ) Change subject: mb/google/brya/var/skolas: add nau8318 speaker support ...................................................................... Patch Set 20: (1 comment) Patchset: PS20: > oh NAU8318 should be AMP not SPK? Yes, NAU8318 for SPK, NAU8825 for Headphone. -- To view, visit https://review.coreboot.org/c/coreboot/+/76925?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1 Gerrit-Change-Number: 76925 Gerrit-PatchSet: 20 Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Lin <CTLIN0(a)nuvoton.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 23:34:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Fix PMC GPIO group route to GPE
by Cliff Huang (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Anil Kumar K, Bora Guvendik, Eran Mitrani, Eric Lai, Hannah Williams, Ivy Jian, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76537?usp=email ) Change subject: mb/google/rex: Fix PMC GPIO group route to GPE ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb: https://review.coreboot.org/c/coreboot/+/76537/comment/20dc13b9_5c80355f : PS4, Line 24: none > `TPM_TIS_ACPI_INTERRUPT` is GPP E03. […] thx for pointing out. add missed bit description. For TPM_TIS_ACPI_INTERRUPT, it is not configured to route to SCI and its GPE0_EN is not set. However, its bit from GPE0_STS was checked, so I also add this pad. -- To view, visit https://review.coreboot.org/c/coreboot/+/76537?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1 Gerrit-Change-Number: 76537 Gerrit-PatchSet: 4 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 22:22:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Fix PMC GPIO group route to GPE
by Cliff Huang (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Eran Mitrani, Eric Lai, Hannah Williams, Ivy Jian, Jakub Czapiga, Jamie Ryu, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim. Hello Anil Kumar K, Bora Guvendik, Eran Mitrani, Eric Lai, Ivy Jian, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76537?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rex: Fix PMC GPIO group route to GPE ...................................................................... mb/google/rex: Fix PMC GPIO group route to GPE The defines in PMC should be used rather than the ones from GPIO defines. Signed-off-by: Cliff Huang <cliff.huang(a)intel.com> Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1 --- M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb 1 file changed, 32 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/76537/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/76537?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1 Gerrit-Change-Number: 76537 Gerrit-PatchSet: 5 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/amd/genoa: Add Kconfig/Makefile to generate PSP image
by Marshall Dawson (Code Review) 01 Sep '23

01 Sep '23

Attention is currently required from: Arthur Heymans, Varshit Pandya. Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76498?usp=email ) Change subject: soc/amd/genoa: Add Kconfig/Makefile to generate PSP image ...................................................................... Patch Set 4: (13 comments) File src/soc/amd/genoa/Kconfig: https://review.coreboot.org/c/coreboot/+/76498/comment/77a020ff_051979ef : PS4, Line 75: config AMD_FWM_POSITION_INDEX : default 5 With no prompt, this won't be choosable by the developer via menuconfig. https://review.coreboot.org/c/coreboot/+/76498/comment/557342e2_1e12b84c : PS4, Line 93: config PSP_LOAD_MP2_FW Looks like unsupported in Epyc? So it could be omitted here. https://review.coreboot.org/c/coreboot/+/76498/comment/40fb4a01_737ade76 : PS4, Line 117: "3rdparty/amd_blobs_internal/genoa/PSP/wtl-gno.bin" Ideally this should be in "site-local/3rdparty/amd_blobs/genoa/PSP/wtl-gno.sbin" instead. https://review.coreboot.org/c/coreboot/+/76498/comment/0af7b8a0_0bbf9aad : PS4, Line 125: "3rdparty/amd_blobs_internal/genoa/PSP/PspDirL10_Typex55_BLAntiRB.bin Maybe 3rdparty/amd_blobs/genoa/PSP/Typex55_0_0_0_BLAntiRB.bin? Is that the same one? https://review.coreboot.org/c/coreboot/+/76498/comment/8272db6b_3f6f178a : PS4, Line 137: Bit 29: Disable MP2 firmware loading (Set by PSP_LOAD_MP2_FW) and here https://review.coreboot.org/c/coreboot/+/76498/comment/dd1b79e0_562e2b3f : PS4, Line 139: 55758 #57299 https://review.coreboot.org/c/coreboot/+/76498/comment/1ca1be35_5852e9bb : PS4, Line 156: Remove extra blank line https://review.coreboot.org/c/coreboot/+/76498/comment/c34668b6_8436eb6c : PS4, Line 157: endif : nit: for consistency maybe endif # SOC_AMD_GENOA File src/soc/amd/genoa/Makefile.inc: https://review.coreboot.org/c/coreboot/+/76498/comment/7e9550f2_f02a1450 : PS4, Line 23: PSPDIR ADDR | BIOSDIR ADDR If I'm reading the spec right BIOSDIR_ADDR may be 0x28. Or maybe the spec is ambiguous. https://review.coreboot.org/c/coreboot/+/76498/comment/c5ccf0a7_3b28d75b : PS4, Line 26: GENOA_FWM_POSITION=0x20000 Hmm, we seem to do MDN differently than other SOCs. Without taking the time to dig, it seems like this ought to be derived from the position index instead of hardcoded. https://review.coreboot.org/c/coreboot/+/76498/comment/c2c4b7d1_bd12b296 : PS4, Line 51: ifeq ($(CONFIG_PSP_LOAD_MP2_FW),y) : OPT_PSP_LOAD_MP2_FW="--load-mp2-fw" : else : # Disable MP2 firmware loading : PSP_SOFTFUSE_BITS += 29 : endif remove, I think https://review.coreboot.org/c/coreboot/+/76498/comment/28708d61_b9dc1ec4 : PS4, Line 58: ifeq ($(CONFIG_PSP_S0I3_RESUME_VERSTAGE),y) : PSP_SOFTFUSE_BITS += 58 : endif remove https://review.coreboot.org/c/coreboot/+/76498/comment/89a0a7dc_944d0250 : PS4, Line 130: $(OPT_PSP_LOAD_MP2_FW) \ remove -- To view, visit https://review.coreboot.org/c/coreboot/+/76498?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I95d84f93663a80f322fd4d7cdeb35ccfe0ec7d21 Gerrit-Change-Number: 76498 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 31 Aug 2023 22:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Documentation: Update coding_style.md with refactoring section
by Matt DeVillier (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Felix Singer, Martin L Roth. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71067?usp=email ) Change subject: Documentation: Update coding_style.md with refactoring section ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71067?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic3508529f639ea0609d2ea2032cc52407e9543e5 Gerrit-Change-Number: 71067 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 21:39:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amd/soc/common: Use relative offset for AMDFW
by Felix Held (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Bao Zheng, Jason Glenesk, Matt DeVillier, Paul Menzel, Raul Rangel, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72961?usp=email ) Change subject: amd/soc/common: Use relative offset for AMDFW ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72961?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2add8e4e6755e582b3be6a150cf83d1468f2f1be Gerrit-Change-Number: 72961 Gerrit-PatchSet: 18 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 31 Aug 2023 21:35:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: qemu-riscv: Improve Documentation
by Martin L Roth (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Ayan Agrawal, Daniel Maslowski, Daniel Maslowski, Philipp Hug, ron minnich. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77410?usp=email ) Change subject: qemu-riscv: Improve Documentation ...................................................................... Patch Set 3: (2 comments) File src/arch/riscv/romstage.S: https://review.coreboot.org/c/coreboot/+/77410/comment/632b28be_a25f9588 : PS3, Line 39: Unrelated to the documentation. Normally I'd let something like this go by, but the other file is also unrelated to documentation, so we might as well remove this as well. File src/mainboard/emulation/qemu-riscv/memlayout.ld: https://review.coreboot.org/c/coreboot/+/77410/comment/475b4365_3a603206 : PS3, Line 35: This removal is unrelated to the documentation - Move it to a cleanup patch? -- To view, visit https://review.coreboot.org/c/coreboot/+/77410?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6dbddb6d8801c456196142c3c7d0a2cbf2ed0fb7 Gerrit-Change-Number: 77410 Gerrit-PatchSet: 3 Gerrit-Owner: Ayan Agrawal <ayanagr03(a)gmail.com> Gerrit-Reviewer: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Reviewer: Daniel Maslowski <info(a)orangecms.org> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Ayan Agrawal <ayanagr03(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Daniel Maslowski <info(a)orangecms.org> Gerrit-Attention: Daniel Maslowski <cyrevolt(a)googlemail.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 21:31:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool: Add FW type FUSE_CHAIN in the config file
by Felix Held (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Bao Zheng, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77506?usp=email ) Change subject: amdfwtool: Add FW type FUSE_CHAIN in the config file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77506?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb546f761ae10b0d19a9879a9a644b788828d523 Gerrit-Change-Number: 77506 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 21:29:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: commonlib: Drop unused CBMEM IDs due to unified MRC cache store logic
by Martin L Roth (Code Review) 31 Aug '23

31 Aug '23

Attention is currently required from: Arthur Heymans, Kapil Porwal, Lean Sheng Tan, Subrata Banik. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77595?usp=email ) Change subject: commonlib: Drop unused CBMEM IDs due to unified MRC cache store logic ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: Please don't drop things from cbmem as soon as they're obsoleted. The cbmem *tool* built with the latest version of the tree can still be run against older versions of the firmware, and it would be nice to be able to have it identify the regions. -- To view, visit https://review.coreboot.org/c/coreboot/+/77595?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9f2a5427e481c3fa326adb30d2f37d4091ec985a Gerrit-Change-Number: 77595 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 21:28:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
672
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023