Alexander Couzens has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35438 )
Change subject: LinuxBoot: fix `make clean` for linux builds
......................................................................
LinuxBoot: fix `make clean` for linux builds
The kernel_dir variable was never correct, because targets/linux.mk
is using build directories based on the version e.g. kernel_4.19.73.
Change-Id: I749200bd32d86303ae02903afd96f730ac36b307
Signed-off-by: Alexander Couzens <lynxis(a)fe80.eu>
---
M payloads/external/LinuxBoot/Makefile
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/35438/1
diff --git a/payloads/external/LinuxBoot/Makefile b/payloads/external/LinuxBoot/Makefile
index 5840e8e..8b81c8a 100644
--- a/payloads/external/LinuxBoot/Makefile
+++ b/payloads/external/LinuxBoot/Makefile
@@ -14,7 +14,6 @@
##
project_dir=linuxboot
-kernel_dir=$(project_dir)/kernel
unexport $(COREBOOT_EXPORTS)
@@ -65,7 +64,7 @@
linuxboot: kernel initramfs_compressed
clean:
- if [ -d "$(kernel_dir)" ]; then rm -rf $(kernel_dir); fi
+ rm -rf $(project_dir)/kernel*
rm -f $(project_dir)/u-root
rm -f $(project_dir)/initramfs*
--
To view, visit https://review.coreboot.org/c/coreboot/+/35438
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I749200bd32d86303ae02903afd96f730ac36b307
Gerrit-Change-Number: 35438
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-MessageType: newchange
Attention is currently required from: David Lin, Eric Lai, Mac Chiang, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli.
AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email )
Change subject: mb/google/brya/var/skolas: add nau8318 speaker support
......................................................................
Patch Set 20:
(1 comment)
Patchset:
PS20:
Hi, Google please help to code review. Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1
Gerrit-Change-Number: 76925
Gerrit-PatchSet: 20
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 23:35:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: David Lin, Eric Lai, Mac Chiang, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli.
AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email )
Change subject: mb/google/brya/var/skolas: add nau8318 speaker support
......................................................................
Patch Set 20:
(1 comment)
Patchset:
PS20:
> Yes, NAU8318 for SPK, NAU8825 for Headphone.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1
Gerrit-Change-Number: 76925
Gerrit-PatchSet: 20
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 23:34:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Comment-In-Reply-To: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Lin, Eric Lai, Mac Chiang, Nick Vaccaro, Nick Vaccaro, Paul Menzel, Subrata Banik, Tarun Tuli.
AlanKY Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email )
Change subject: mb/google/brya/var/skolas: add nau8318 speaker support
......................................................................
Patch Set 20:
(1 comment)
Patchset:
PS20:
> oh NAU8318 should be AMP not SPK?
Yes, NAU8318 for SPK, NAU8825 for Headphone.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76925?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife47a83fca902cf63e09d11206e9d99fac0dc9a1
Gerrit-Change-Number: 76925
Gerrit-PatchSet: 20
Gerrit-Owner: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: AlanKY Lee <alanky_lee(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: David Lin <CTLIN0(a)nuvoton.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 23:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K, Bora Guvendik, Eran Mitrani, Eric Lai, Hannah Williams, Ivy Jian, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76537?usp=email )
Change subject: mb/google/rex: Fix PMC GPIO group route to GPE
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/76537/comment/20dc13b9_5c80355f :
PS4, Line 24: none
> `TPM_TIS_ACPI_INTERRUPT` is GPP E03. […]
thx for pointing out. add missed bit description. For TPM_TIS_ACPI_INTERRUPT, it is not configured to route to SCI and its GPE0_EN is not set. However, its bit from GPE0_STS was checked, so I also add this pad.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76537?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1
Gerrit-Change-Number: 76537
Gerrit-PatchSet: 4
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 31 Aug 2023 22:22:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang, Eran Mitrani, Eric Lai, Hannah Williams, Ivy Jian, Jakub Czapiga, Jamie Ryu, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim.
Hello Anil Kumar K, Bora Guvendik, Eran Mitrani, Eric Lai, Ivy Jian, Jakub Czapiga, Jamie Ryu, Kapil Porwal, Subrata Banik, Tarun, Tarun Tuli, Wonkyu Kim, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76537?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/google/rex: Fix PMC GPIO group route to GPE
......................................................................
mb/google/rex: Fix PMC GPIO group route to GPE
The defines in PMC should be used rather than the ones
from GPIO defines.
Signed-off-by: Cliff Huang <cliff.huang(a)intel.com>
Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1
---
M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
1 file changed, 32 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/76537/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/76537?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3bf27c71658f177c0ba544fb90712a82a058aa1
Gerrit-Change-Number: 76537
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: newpatchset