Attention is currently required from: Kane Chen, Kapil Porwal, Sridhar Siricilla, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76880?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/mtl: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76880/comment/ff0dafa5_f2a6430a :
PS2, Line 7: Set SOC_INTEL_METEORLAKE_DEBUG_CONSENT to 6
Maybe:
> Change default for debug consent from 3 to 6
https://review.coreboot.org/c/coreboot/+/76880/comment/3b47d743_2d566f57 :
PS2, Line 9: SOC_INTEL_METEORLAKE_DEBUG_CONSENT=6 is more common use case
: for soc debug with usb dbc.
Please extend, and so why it is more common.
File src/soc/intel/meteorlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/76880/comment/05b7c43e_d062f044 :
PS2, Line 357: 0:Disabled, 2:Enabled Trace Active, 4:Enabled Trace Ready,
: 6:Enable Trace Power-Off, 7:Manual
So 3, used before wasn’t even a valid value?
--
To view, visit https://review.coreboot.org/c/coreboot/+/76880?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic12528bdd8b1feda7f1b65045c863341f932d3a2
Gerrit-Change-Number: 76880
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:48:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hsuan-ting Chen, Yu-Ping Wu.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76253?usp=email )
Change subject: tests/lib: Add unit tests for ux_locales_get_text()
......................................................................
Patch Set 16:
(1 comment)
File tests/lib/ux_locales-test.c:
https://review.coreboot.org/c/coreboot/+/76253/comment/625f0483_ac5e362a :
PS16, Line 201: Because of the design limitations of cmocka, using #_expect will cause build failure.
: This is because #_expect will cause the test name to have double quotes.
> Unfortunately CMocka ToT is the same. […]
I can create PR and then migrate coreboot to new CMocka.
Anyway, @roccochen please fix what Yu-Ping pointed out, so we can close this thread.
--
To view, visit https://review.coreboot.org/c/coreboot/+/76253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d73419c02478870942828d324c258ef0eaa983c
Gerrit-Change-Number: 76253
Gerrit-PatchSet: 16
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Attention: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:44:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Subrata Banik, Sukumar Ghorai, Tarun Tuli.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76826?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/meteorlake: Hook up UPD for C1 C-state auto-demotion
......................................................................
Patch Set 6:
(3 comments)
File src/soc/intel/meteorlake/chip.h:
https://review.coreboot.org/c/coreboot/+/76826/comment/2c41672d_dd12b0a9 :
PS6, Line 374: demotes
… the C-state.
https://review.coreboot.org/c/coreboot/+/76826/comment/11dedd32_b94caeb7 :
PS6, Line 376: need
needs
https://review.coreboot.org/c/coreboot/+/76826/comment/34b3ec9d_ca48ab38 :
PS6, Line 376: disable
disabled
--
To view, visit https://review.coreboot.org/c/coreboot/+/76826?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2cc60bd297271fcb3000c0298af71208e3be60fc
Gerrit-Change-Number: 76826
Gerrit-PatchSet: 6
Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:29:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Pratikkumar V Prajapati, Ravishankar Sarawadi, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75626?usp=email )
Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
......................................................................
Patch Set 15: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75626?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d
Gerrit-Change-Number: 75626
Gerrit-PatchSet: 15
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Pratikkumar Prajapati <pratikkumar.v.prajapati(a)intel.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:20:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Subrata Banik, Tarun Tuli, Won Chung.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76776?usp=email )
Change subject: mb/google: Add more comment on GFX devices for the future reference
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76776?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59e82ee954a7d502e419046c1c2d7a20ea8a9224
Gerrit-Change-Number: 76776
Gerrit-PatchSet: 5
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Won Chung <wonchung(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:13:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Paul Menzel, Subrata Banik, Sukumar Ghorai, Tarun Tuli.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76827?usp=email )
Change subject: mb/google/{rex,ovis}: Disable C1-state auto demotion for rex & ovis
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Please rebase it
--
To view, visit https://review.coreboot.org/c/coreboot/+/76827?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I548e0e5340dec537d05718dd2f4652e10fb36ac0
Gerrit-Change-Number: 76827
Gerrit-PatchSet: 4
Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Comment-Date: Wed, 02 Aug 2023 11:11:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment