coreboot-gerrit August 2023

coreboot-gerrit@coreboot.org

1 participants
6717 discussions

[S] Change in coreboot[master]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Angel Pons (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anjaneya "Reddy" Chagam, Arthur Heymans, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Marc Jones, Patrick Rudolph, Patrick Rudolph, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:56:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP
by Angel Pons (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Anjaneya "Reddy" Chagam, Arthur Heymans, Arthur Heymans, Christian Walter, Felix Held, Johnny Lin, Jonathan Zhang, Marc Jones, Patrick Rudolph, Patrick Rudolph, Tim Chu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61164?usp=email ) Change subject: arch/x86/car.ld: Accomodate for FSP spec violation on Xeon-SP ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/61164?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie682bfa376d699c0eee8de0752cd6ae6d8d81fee Gerrit-Change-Number: 61164 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jay Talbott <JayTalbott(a)sysproconsulting.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks <david.hendricks(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:56:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libgfxinit[main]: [WIP] try to make LSPCON work
by Angel Pons (Code Review) 03 Aug '23

03 Aug '23

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/libgfxinit/+/67451?usp=email ) Change subject: [WIP] try to make LSPCON work ...................................................................... Abandoned Can't even remember what this does, or if it works. libgfxinit has troubles waking up the LSPCON after a warm reboot (apparently Linux messes it up?) as well as with a few specific displays. -- To view, visit https://review.coreboot.org/c/libgfxinit/+/67451?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libgfxinit Gerrit-Branch: main Gerrit-Change-Id: I5b09472965118feede6b7e227aaf23bb48a53af7 Gerrit-Change-Number: 67451 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in libhwbase[main]: Makefile: Add bincompare target
by Angel Pons (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Alex Thiessen, Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/27144?usp=email ) Change subject: Makefile: Add bincompare target ...................................................................... Patch Set 1: Code-Review+1 (4 comments) Commit Message: https://review.coreboot.org/c/libhwbase/+/27144/comment/36464ddf_811f00c9 : PS1, Line 7: Makefile: Add bincompare target > What is the problem you are trying to solve? From a quick glance, looks like this allows doing reproducibility tests. There are some changes (e.g. fixing whitespace, renaming things) that do not affect the produced executables, so there's no need to test on actual hardware. This is especially useful for coreboot, as boot testing changes requires having access to specific hardware. And even then, one can't possibly test that everything still works. In coreboot, this is especially important when touching RAM init code: RAM init is very delicate arcane magic that causes system instability and/or boot failures when something goes wrong, and depends on the DIMMs, CPU, mainboard and even environmental conditions (temperature). For example, CB:51880 would be unreviewable if it wasn't reproducible (see "Tested with BUILD_TIMELESS=1, Roda RK9 remains identical." in the commit message, "Roda RK9" is a mainboard that uses the gm45 northbridge code). That being said, the commit message is indeed a bit thin on words. It would be nice to have a brief description of what this target does (and instructions on how to use it, although these would be better placed inside a README or similar). Patchset: PS1: Just realised this is a 5-year-old change, but it's worth rescuing from Gerrit-oblivion File Makefile.compare: PS1: > no copyright header? Makefile doesn't have one either. Not sure how this should be addressed. https://review.coreboot.org/c/libhwbase/+/27144/comment/1589531b_d3f7b8eb : PS1, Line 10: [ "$$(git rev-parse $(ref))" = "$$(git rev-parse HEAD)" ] || { \ : git checkout $(ref) && \ : $(MAKE) objprefix=bincmp.ref $(bincompare-targets) || \ : { git checkout HEAD@{1}; exit 1; } && \ : git checkout HEAD@{1} && \ : $(MAKE) objprefix=bincmp.head $(bincompare-targets) && \ : res=0 && \ : for t in $(patsubst bincompare-%,%,$(bincompare-targets)); \ : do \ : b=$$t/$(notdir $(binary)); \ : r=$$(objdump -d bincmp.ref/$$b | grep -v bincmp); \ : h=$$(objdump -d bincmp.head/$$b | grep -v bincmp); \ : if [ "$$r" != "$$h" ]; then \ : printf "Binaries for %s differ.\n" "$$t"; \ : res=1; \ : fi; \ : done; exit $$res; } > hard to comprehend, making it an extra script should help @Nico Huber: is this designed so that projects using libhwbase (e.g. libgfxinit) can also use the bincompare target? A script may be more flexible (one could specify the two git references to compare), but may also be harder to reuse. -- To view, visit https://review.coreboot.org/c/libhwbase/+/27144?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: libhwbase Gerrit-Branch: main Gerrit-Change-Id: I7d2dfc7a2e34851fe01a9d72e0d90db00a284eaf Gerrit-Change-Number: 27144 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-CC: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:52:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Alex Thiessen <alex.thiessen.de+coreboot(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: docker/coreboot-jenkins-node: apt install python3-jinja2
by Martin L Roth (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76737?usp=email ) Change subject: docker/coreboot-jenkins-node: apt install python3-jinja2 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I wrote the following comment for the sphinx patch, but the same applies here: ``` I seem to recall that we needed to use specific versions. They should match the versions in the doc.coreboot.org makefile, and we want to be able to update them separately. I'm fine with installing using apt, but we should specify the versions and coordinate with the other dockerfile. We also probably want to verify that the versions currently installed by apt work with our documentation. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/76737?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53c2ebdf0c8fba68f5974b377cda48f0dda6968a Gerrit-Change-Number: 76737 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:50:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: docker/coreboot-jenkins-node/Dockerfile: apt install python3-recommon...
by Martin L Roth (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76738?usp=email ) Change subject: docker/coreboot-jenkins-node/Dockerfile: apt install python3-recommonmark ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I wrote the following comment for the sphinx patch, but the same applies here: ``` I seem to recall that we needed to use specific versions. They should match the versions in the doc.coreboot.org makefile, and we want to be able to update them separately. I'm fine with installing using apt, but we should specify the versions and coordinate with the other dockerfile. We also probably want to verify that the versions currently installed by apt work with our documentation. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/76738?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib8e5f0785fe0d9427b38d7b0a646598c338962ad Gerrit-Change-Number: 76738 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:49:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: docker/coreboot-jenkins-node/Dockerfile: apt install sphinx
by Martin L Roth (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Elyes Haouas. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76739?usp=email ) Change subject: docker/coreboot-jenkins-node/Dockerfile: apt install sphinx ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I seem to recall that we needed to use specific versions. They should match the versions in the doc.coreboot.org makefile, and we want to be able to update them separately. I'm fine with installing using apt, but we should specify the versions and coordinate with the other dockerfile. We also probably want to verify that the versions currently installed by apt work with our documentation. -- To view, visit https://review.coreboot.org/c/coreboot/+/76739?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I868ac39ee15fa8a91d2c05993390773e09b444f4 Gerrit-Change-Number: 76739 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/tcss: Configure USB-C ports with attached devices
by Matt DeVillier (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Angel Pons, Eric Lai, Jakub Czapiga, John Su, John Zhao, Kapil Porwal, Sean Rhodes, Subrata Banik. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email ) Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72909/comment/16f65b44_031a9f76 : PS5, Line 9: TCC > What does TCC mean? Done File src/soc/intel/common/block/tcss/tcss.c: https://review.coreboot.org/c/coreboot/+/72909/comment/172e18a3_704f506c : PS5, Line 363: zd > `%zu` ? %zd is consistent with the function above from which this one is adapted. If you want them changed across the board, I can do that in a follow-on https://review.coreboot.org/c/coreboot/+/72909/comment/23a72bbd_7473bfd7 : PS5, Line 459: if (CONFIG(EC_GOOGLE_CHROMEEC)) > > This condition seems wrong. […] the guard needs to be devices which implement usbc_ops, otherwise compilation fails. I couldn't figure out a better guard to use than EC_GOOGLE_CHROMEEC -- To view, visit https://review.coreboot.org/c/coreboot/+/72909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812 Gerrit-Change-Number: 72909 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CoolStar <coolstarorganization(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/intel/common/tcss: Configure USB-C ports with attached devices
by Matt DeVillier (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Angel Pons, Eric Lai, Jakub Czapiga, John Su, John Zhao, Kapil Porwal, Matt DeVillier, Sean Rhodes. Hello Angel Pons, Frank Wu, John Su, John Zhao, Kapil Porwal, Sean Rhodes, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/72909?usp=email to look at the new patch set (#6). Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices ...................................................................... soc/intel/common/tcss: Configure USB-C ports with attached devices Inspect all type-C USB ports, check if there is a USB device attached, and if so, send the connection request to the PMC. This allows for any attached USB2/USB3 devices to be used for booting by the payload. TEST=build/boot google/banshee, verify able to boot from USB ports in edk2 payload Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/soc/intel/common/block/tcss/tcss.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/72909/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/72909?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69522dbcc8cae6bbf41659ae653107d0e031c812 Gerrit-Change-Number: 72909 Gerrit-PatchSet: 6 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: CoolStar <coolstarorganization(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: soc/amd/genoa: Add minimal viable code for compilation
by Martin L Roth (Code Review) 03 Aug '23

03 Aug '23

Attention is currently required from: Arthur Heymans. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76495?usp=email ) Change subject: soc/amd/genoa: Add minimal viable code for compilation ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/genoa/Kconfig: https://review.coreboot.org/c/coreboot/+/76495/comment/5ed484b6_3e4af5f4 : PS3, Line 61: config ROMSTAGE_ADDR : hex : default 0x7040000 : help : Sets the address in DRAM where romstage should be loaded. : : config ROMSTAGE_SIZE : hex : default 0x80000 : help : Sets the size of DRAM allocation for romstage in linker script. : Please use tabs instead of spaces. -- To view, visit https://review.coreboot.org/c/coreboot/+/76495?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I69253466084d17c4359d7e824d69f12490b076e4 Gerrit-Change-Number: 76495 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 03 Aug 2023 15:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2023