coreboot-gerrit July 2023

coreboot-gerrit@coreboot.org

1 participants
4441 discussions

[S] Change in coreboot[master]: mb/google/nissa/var/joxer: Disable external fivr
by Eric Lai (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Felix Held, Marco Chen, Mark Hsieh, Shou-Chieh Hsu, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76187?usp=email ) Change subject: mb/google/nissa/var/joxer: Disable external fivr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > We have verified this CL on proto MB, both eMMC and UFS can enter S0i3 successfully, thanks. oh weird, but fine. -- To view, visit https://review.coreboot.org/c/coreboot/+/76187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fd7ad90e1544966170df402243604379f5790db Gerrit-Change-Number: 76187 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Comment-In-Reply-To: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/joxer: Disable external fivr
by Eric Lai (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Felix Held, Marco Chen, Mark Hsieh, Shou-Chieh Hsu, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76187?usp=email ) Change subject: mb/google/nissa/var/joxer: Disable external fivr ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fd7ad90e1544966170df402243604379f5790db Gerrit-Change-Number: 76187 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:05:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/inventec: Add Intel SPR server board Inventec Transformers
by Annie Chen (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel. Annie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email ) Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers ...................................................................... Patch Set 10: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75598/comment/840f4757_7d513b57 : PS9, Line 23: The board boots to Linux 4.19.6 with all 192 cores available. > Pretty old version. ;-) […] @Paul Menzel Here's the log for different dmesg level <3>usb usb1-port3: over-current condition <3>usb usb1-port5: over-current condition <3>usb usb1-port6: over-current condition <3>usb usb1-port7: over-current condition <3>usb usb1-port8: over-current condition <4>nvme nvme0: missing or invalid SUBNQN field. <4>pnp 00:01: disabling [io 0x0010-0x001f] because it overlaps 0000:00:18.0 BAR 4 [io 0x0000-0x001f] File src/mainboard/inventec/transformers/Kconfig: https://review.coreboot.org/c/coreboot/+/75598/comment/ea8fc787_8ccf930f : PS8, Line 24: string > @ @Felix Singer, mainboard_dir will bw used in our uboot and kernel, it's not useless define. https://review.coreboot.org/c/coreboot/+/75598/comment/29061b4b_84182388 : PS8, Line 28: string > same here Done https://review.coreboot.org/c/coreboot/+/75598/comment/1d21a43b_19dab929 : PS8, Line 32: string > same Done https://review.coreboot.org/c/coreboot/+/75598/comment/a67fe00d_943859e1 : PS8, Line 36: int > same Done File src/mainboard/inventec/transformers/devicetree.cb: PS8: > Please use tabs instead of spaces in lines 9-11 and 25-39. […] Done File src/mainboard/inventec/transformers/ramstage.c: https://review.coreboot.org/c/coreboot/+/75598/comment/f0b6c1d2_4c3f88b7 : PS8, Line 10: #define SLOT_ID_LEN 2 : static char slot_id_str[SLOT_ID_LEN]; : extern uint32_t heci_fw_sts(void); : extern uint32_t heci_cse_normal(void); : extern uint32_t heci_cse_done(void); : : //extern void cse_init(uintptr_t tempbar); : > I just noticed these declarations. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 10 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:02:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Annie Chen <chen.annieet(a)inventec.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/inventec: Add Intel SPR server board Inventec Transformers
by Annie Chen (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel. Hello Angel Pons, Arthur Heymans, David Hendricks, Felix Singer, Hung-Wei Chen, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75598?usp=email to look at the new patch set (#10). Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers ...................................................................... mb/inventec: Add Intel SPR server board Inventec Transformers CPU: - 2 SPR sockets - 64 total PCIe 5.0 lanes with up to 64 lanes of Flex Bus/CXL per CPU - Up to 32 DDR5 DIMM - 1 Gbase-T NIC port - 1 USB3.0 type A, 1 USB2.0 connector - 1 VGA connector BMC: - ASPEED AST2600 BMC - 1 DDR4 8Gb memory - 1 8GB eMMC Test: The board boots to Linux 4.19.6 with all 192 cores available. dmesg --level alert,crit,err,warn: <3>usb usb1-port3: over-current condition <3>usb usb1-port5: over-current condition <3>usb usb1-port6: over-current condition <3>usb usb1-port7: over-current condition <3>usb usb1-port8: over-current condition <4>nvme nvme0: missing or invalid SUBNQN field. <4>pnp 00:01: disabling [io 0x0010-0x001f] because it overlaps 0000:00:18.0 BAR 4 [io 0x0000-0x001f] Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Signed-off-by: Annie Chen <Chen.AnnieET(a)inventec.com> --- A configs/builder/config.transformers A src/mainboard/inventec/Kconfig A src/mainboard/inventec/Kconfig.name A src/mainboard/inventec/transformers/Kconfig A src/mainboard/inventec/transformers/Kconfig.name A src/mainboard/inventec/transformers/Makefile.inc A src/mainboard/inventec/transformers/acpi/platform.asl A src/mainboard/inventec/transformers/board.fmd A src/mainboard/inventec/transformers/board_info.txt A src/mainboard/inventec/transformers/bootblock.c A src/mainboard/inventec/transformers/devicetree.cb A src/mainboard/inventec/transformers/dsdt.asl A src/mainboard/inventec/transformers/include/mainboard_ras.h A src/mainboard/inventec/transformers/include/sprsp_ac_iio.h A src/mainboard/inventec/transformers/include/sprsp_gpio.h A src/mainboard/inventec/transformers/ipmi.c A src/mainboard/inventec/transformers/ipmi.h A src/mainboard/inventec/transformers/ramstage.c A src/mainboard/inventec/transformers/romstage.c 19 files changed, 936 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/75598/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 10 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/joxer: Disable external fivr
by Mark Hsieh (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Eric Lai, Felix Held, Marco Chen, Shou-Chieh Hsu, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76187?usp=email ) Change subject: mb/google/nissa/var/joxer: Disable external fivr ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Do you want add FW config for it? Or let previous device fail at suspend? We have verified this CL on proto MB, both eMMC and UFS can enter S0i3 successfully, thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/76187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7fd7ad90e1544966170df402243604379f5790db Gerrit-Change-Number: 76187 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Marco Chen <marcochen(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:00:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: acpi: Set checksum for SPCR table
by Kyösti Mälkki (Code Review) 03 Jul '23

03 Jul '23

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email ) Change subject: acpi: Set checksum for SPCR table ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: The zeroes presented in generated SPCR possibly come from a later ACPI spec than what fwts is aware of. Update FWTS ? + lava-test-case fwts-spcr --shell fwts spcr -q -r stdout --log-filter=SKP,PAS,FAL,ABT,INO --log-level high <LAVA_SIGNAL_STARTTC fwts-spcr> Received signal: <STARTTC> fwts-spcr FAILED [HIGH] SPCRInterfaceReserved: Test 1, SPCR Serial interface type 0x12 is a reserved interface FAILED [HIGH] SPCRUnknownInterruptType: Test 1, SPCR interrupt type field is zero, expecting support bits to be set FAILED [HIGH] SPCRBaudRateReserved: Test 1, SPCR Serial baud rate type 0x00 is a reserved baud rate -- To view, visit https://review.coreboot.org/c/coreboot/+/76158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2 Gerrit-Change-Number: 76158 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 06:55:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: acpi: Add SPCR table
by Paul Menzel (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email ) Change subject: acpi: Add SPCR table ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: 9elements QA also reports > Automatic boot test returned (PASS/FAIL/TOTAL): 8 / 8 / 16 on the change-set CB:76158, so there is more going on. -- To view, visit https://review.coreboot.org/c/coreboot/+/75685?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc Gerrit-Change-Number: 75685 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 03 Jul 2023 06:45:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/uldren: Modify DPTF parameters
by Paul Menzel (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Dtrain Hsu, Shou-Chieh Hsu, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76105?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/uldren: Modify DPTF parameters ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76105/comment/f60611b7_9dd0a25a : PS1, Line 7: Modify That’s too broad. Please use a more specific verb. https://review.coreboot.org/c/coreboot/+/76105/comment/f5e2a032_e6d086b3 : PS1, Line 11: Please list/enumerate the changes. https://review.coreboot.org/c/coreboot/+/76105/comment/957bc1d2_61baee36 : PS1, Line 14: TEST=emerge-nissa coreboot chromeos-bootimage Don’t you need to boot it also and run some tests? File src/mainboard/google/brya/variants/uldren/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76105/comment/45c443b1_80605235 : PS1, Line 109: register "tcc_offset" = "3" Please add a comment what value that actually results in. -- To view, visit https://review.coreboot.org/c/coreboot/+/76105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Gerrit-Change-Number: 76105 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 06:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo:Fix touchsreen thd:dat test fail
by Paul Menzel (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76190?usp=email ) Change subject: mb/google/rex/var/screebo:Fix touchsreen thd:dat test fail ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76190/comment/1932b37a_7ddb624b : PS2, Line 7: Fix touchsreen thd:dat test fail Maybe: > Double data hold time to 100 ns for touchscreen test failure https://review.coreboot.org/c/coreboot/+/76190/comment/d1c0a9f5_f29368e7 : PS2, Line 7: mb/google/rex/var/screebo:Fix Please add a space after the colon. https://review.coreboot.org/c/coreboot/+/76190/comment/b79689c8_9d26cebe : PS2, Line 9: thd:dat test fail Please elaborate, what that test does and how that test can be run. https://review.coreboot.org/c/coreboot/+/76190/comment/618227a2_1b59b011 : PS2, Line 10: Change i2c[0]: data_hold_time_ns > 100ns. Where is it documented, that this is the correct value? -- To view, visit https://review.coreboot.org/c/coreboot/+/76190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30e7c87d788f7f144276c45e8475af65f1f132ae Gerrit-Change-Number: 76190 Gerrit-PatchSet: 2 Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 06:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/inventec: Add Intel SPR server board Inventec Transformers
by Paul Menzel (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Felix Singer, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email ) Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75598/comment/d3af8642_4d5b12c4 : PS9, Line 23: The board boots to Linux 4.19.6 with all 192 cores available. Pretty old version. ;-) Would you be so kind and also paste the output of `dmesg --level alert,crit,err,warn` to the commit message? -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 9 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: David Hendricks Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 06:38:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2023