Attention is currently required from: Julius Werner, Yu-Ping Wu.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76202?usp=email )
Change subject: arch/arm64/Makefile.inc: Fix Kconfig name in comment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93860a20a425c833b41e16347722e9a879f83ab1
Gerrit-Change-Number: 76202
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 09:00:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Hung-Wei Chen, Jonathan Zhang, Lean Sheng Tan, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email )
Change subject: mb/inventec: Add Intel SPR server board Inventec Transformers
......................................................................
Patch Set 10:
(4 comments)
Patchset:
PS10:
Please add an entry to the MAINTAINERS file. In case of someone pushes a patch related to your mainboard, then you get automatically added as a reviewer and you get notified. You can add multiple people It's also helpful when questions appear and people want to contact you 😊
Your entry could look like this:
```
INVENTEC MAINBOARDS
M: Annie Chen <Chen.AnnieET(a)inventec.com>
S: Maintained
F: src/mainboard/inventec/
```
The list is sorted, so please add it after Intel Harcuvar. You can add multiple people by adding more M lines.
File src/mainboard/inventec/Kconfig:
https://review.coreboot.org/c/coreboot/+/75598/comment/80adf561_c4127f36 :
PS10, Line 4: Manboard
typo: `Mainboard`
File src/mainboard/inventec/transformers/Kconfig:
https://review.coreboot.org/c/coreboot/+/75598/comment/18e588e7_24959405 :
PS8, Line 24: string
> @Felix Singer, mainboard_dir will bw used in our uboot and kernel, it's not useless define.
It's definitely useful and also needed. Sorry for being unclear.
I was just referring to the type declaration "string" since the types are already defined in other Kconfigs and so it's not needed here. In this case it's src/mainboard/Kconfig. So you can leave the setting. Just remove the types from this and the others please :)
File src/mainboard/inventec/transformers/ramstage.c:
https://review.coreboot.org/c/coreboot/+/75598/comment/4d0d9046_b1f5d2c7 :
PS8, Line 10: #define SLOT_ID_LEN 2
: static char slot_id_str[SLOT_ID_LEN];
: extern uint32_t heci_fw_sts(void);
: extern uint32_t heci_cse_normal(void);
: extern uint32_t heci_cse_done(void);
:
: //extern void cse_init(uintptr_t tempbar);
:
> Done
It would be great if you could explain what these are doing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684
Gerrit-Change-Number: 75598
Gerrit-PatchSet: 10
Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: David Hendricks
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Wei Chen <Chen.HW(a)inventec.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:58:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Comment-In-Reply-To: Annie Chen <chen.annieet(a)inventec.com>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Yu-Ping Wu.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76202?usp=email )
Change subject: arch/arm64/Makefile.inc: Fix Kconfig name in comment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93860a20a425c833b41e16347722e9a879f83ab1
Gerrit-Change-Number: 76202
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:43:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Bora Guvendik, Michał Żygowski, Name of user not set #1004406, Paul Menzel, Subrata Banik, Tim Crawford.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69798?usp=email )
Change subject: soc/intel/alderlake: Add support for Raptor Lake S CPUs
......................................................................
Patch Set 14:
(1 comment)
File src/include/cpu/intel/cpu_ids.h:
https://review.coreboot.org/c/coreboot/+/69798/comment/428ca24d_14cb0d1f :
PS14, Line 76: #define CPUID_RAPTORLAKE_S_A0 0xb0670
: #define CPUID_RAPTORLAKE_S_B0 0xb0671
: #define CPUID_RAPTORLAKE_S_C0_1 0xb0672
: #define CPUID_RAPTORLAKE_S_C0_2 0xb0675
: #define CPUID_RAPTORLAKE_P_J0 0xb06a2
: #define CPUID_RAPTORLAKE_P_Q0 0xb06a3
> One question I had when doing HX was what to actually call these. […]
I think we can if we get it reported right in report_platform.c
--
To view, visit https://review.coreboot.org/c/coreboot/+/69798?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I767dd08a169a6af59188d9ecd73520b916f69155
Gerrit-Change-Number: 69798
Gerrit-PatchSet: 14
Gerrit-Owner: Name of user not set #1004406
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <miczyg94(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Name of user not set #1004406
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michał Żygowski <miczyg94(a)gmail.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Gerrit-MessageType: comment
Attention is currently required from: Julius Werner, Yu-Ping Wu.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76202?usp=email )
Change subject: arch/arm64/Makefile.inc: Fix Kconfig name in comment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I93860a20a425c833b41e16347722e9a879f83ab1
Gerrit-Change-Number: 76202
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:40:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Jincheng Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/76215?usp=email )
Change subject: vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING
......................................................................
Abandoned
Repeat in 76214
--
To view, visit https://review.coreboot.org/c/coreboot/+/76215?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf9505837d18fb8cf522af8044581b2826df7855
Gerrit-Change-Number: 76215
Gerrit-PatchSet: 1
Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Chen, Gang C.
Hello Chen, Gang C,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/coreboot/+/76215?usp=email
to review the following change.
Change subject: vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING
......................................................................
vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING
Edk2-stable202302 adds wchar_t check and limit L'A' equals to 2.
Add CFLAGS to override gcc default wchar_t size.
w/o this patch:
src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h:795:1: note: in expansion of macro 'STATIC_ASSERT'
795 | STATIC_ASSERT (sizeof (L'A') == 2, "sizeof (L'A') does not meet UEFI Specification Data Type requirements");
| ^~~~~~~~~~~~~
src/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include/Base.h:796:1: note: in expansion of macro 'STATIC_ASSERT'
796 | STATIC_ASSERT (sizeof (L"A") == 4, "sizeof (L\"A\") does not meet UEFI Specification Data Type requirements");
| ^~~~~~~~~~~~~
Change-Id: Idf9505837d18fb8cf522af8044581b2826df7855
Signed-off-by: Jincheng Li <jincheng.li(a)intel.com>
Signed-off-by: Gang Chen <gang.c.chen(a)intel.com>
---
M src/soc/intel/meteorlake/Makefile.inc
M src/vendorcode/intel/Makefile.inc
2 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/76215/1
diff --git a/src/soc/intel/meteorlake/Makefile.inc b/src/soc/intel/meteorlake/Makefile.inc
index aa82381..688f75c 100644
--- a/src/soc/intel/meteorlake/Makefile.inc
+++ b/src/soc/intel/meteorlake/Makefile.inc
@@ -59,5 +59,4 @@
CPPFLAGS_common += -I$(src)/soc/intel/meteorlake
CPPFLAGS_common += -I$(src)/soc/intel/meteorlake/include
-CFLAGS_common += -fshort-wchar
endif
diff --git a/src/vendorcode/intel/Makefile.inc b/src/vendorcode/intel/Makefile.inc
index 4396ed3..ea690ba 100644
--- a/src/vendorcode/intel/Makefile.inc
+++ b/src/vendorcode/intel/Makefile.inc
@@ -27,4 +27,5 @@
CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include
CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include
CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/UefiCpuPkg/Include/
+CFLAGS_common += -fshort-wchar
endif
--
To view, visit https://review.coreboot.org/c/coreboot/+/76215?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf9505837d18fb8cf522af8044581b2826df7855
Gerrit-Change-Number: 76215
Gerrit-PatchSet: 1
Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com>
Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com>
Gerrit-MessageType: newchange
Attention is currently required from: Jakub Czapiga, Paul Menzel, Subrata Banik, Tarun Tuli, zhongtian wu.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76190?usp=email )
Change subject: mb/google/rex/var/screebo: Double data hold time to 100 ns for touchscreen test failure
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76190?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30e7c87d788f7f144276c45e8475af65f1f132ae
Gerrit-Change-Number: 76190
Gerrit-PatchSet: 3
Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 03 Jul 2023 08:23:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment