coreboot-gerrit July 2023

coreboot-gerrit@coreboot.org

1 participants
4441 discussions

[XS] Change in coreboot[master]: mb/google/rex: Enable Bluetooth offload for soundwire audio
by Kapil Porwal (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Jakub Czapiga, Subrata Banik, Tarun Tuli, Uday Bhat. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75924?usp=email ) Change subject: mb/google/rex: Enable Bluetooth offload for soundwire audio ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75924?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3 Gerrit-Change-Number: 75924 Gerrit-PatchSet: 10 Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 08:15:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: arch/arm64/Makefile.inc: Fix Kconfig name in comment
by Yu-Ping Wu (Code Review) 03 Jul '23

03 Jul '23

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76202?usp=email ) Change subject: arch/arm64/Makefile.inc: Fix Kconfig name in comment ...................................................................... arch/arm64/Makefile.inc: Fix Kconfig name in comment Change-Id: I93860a20a425c833b41e16347722e9a879f83ab1 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/arch/arm64/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/76202/1 diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.inc index 6b49743..a5b034a 100644 --- a/src/arch/arm64/Makefile.inc +++ b/src/arch/arm64/Makefile.inc @@ -150,7 +150,7 @@ # Build ARM TF in debug mode (with assertions) if coreboot has hard assertions ifeq ($(CONFIG_FATAL_ASSERTS),y) BL31_MAKEARGS += DEBUG=1 -endif # CONFIG_CONSOLE_SERIAL +endif # CONFIG_FATAL_ASSERTS # ARM TF's VERBOSE (50) is *very* spammy, so default to INFO (40) BL31_MAKEARGS += LOG_LEVEL=40 -- To view, visit https://review.coreboot.org/c/coreboot/+/76202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93860a20a425c833b41e16347722e9a879f83ab1 Gerrit-Change-Number: 76202 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: acpi: Set checksum for SPCR table
by Felix Singer (Code Review) 03 Jul '23

03 Jul '23

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email ) Change subject: acpi: Set checksum for SPCR table ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > The zeroes presented in generated SPCR possibly come from a later ACPI spec than what fwts is aware […] Thanks for digging :) Arthur already created a PR at fwts fixing the issues https://github.com/ColinIanKing/fwts/pull/13. It's also linked in a comment on a change, but I can't find it now. -- To view, visit https://review.coreboot.org/c/coreboot/+/76158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2 Gerrit-Change-Number: 76158 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:55:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Double data hold time to 100 ns for touchs...
by zhongtian wu (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli. zhongtian wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76190?usp=email ) Change subject: mb/google/rex/var/screebo: Double data hold time to 100 ns for touchscreen test failure ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76190/comment/f113c278_5c35bf41 : PS2, Line 7: mb/google/rex/var/screebo:Fix > Please add a space after the colon. Done https://review.coreboot.org/c/coreboot/+/76190/comment/44e29db5_d747274a : PS2, Line 7: Fix touchsreen thd:dat test fail > Maybe: […] Done https://review.coreboot.org/c/coreboot/+/76190/comment/c5a9bb18_a914ea08 : PS2, Line 9: thd:dat test fail > Please elaborate, what that test does and how that test can be run. Done https://review.coreboot.org/c/coreboot/+/76190/comment/7b03db60_d376da4b : PS2, Line 10: Change i2c[0]: data_hold_time_ns > 100ns. > Where is it documented, that this is the correct value? This CL has been verified and passed by EE. -- To view, visit https://review.coreboot.org/c/coreboot/+/76190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30e7c87d788f7f144276c45e8475af65f1f132ae Gerrit-Change-Number: 76190 Gerrit-PatchSet: 3 Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Double data hold time to 100 ns for touchs...
by zhongtian wu (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu. Hello Eric Lai, Jakub Czapiga, Kapil Porwal, Kun Liu, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76190?usp=email to look at the new patch set (#3). Change subject: mb/google/rex/var/screebo: Double data hold time to 100 ns for touchscreen test failure ...................................................................... mb/google/rex/var/screebo: Double data hold time to 100 ns for touchscreen test failure Change i2c[0] parameter to met touchscreen timing. Thd:dat > 100ns. BUG=b:287898252 BRANCH=none TEST=Test success by EE. Change-Id: I30e7c87d788f7f144276c45e8475af65f1f132ae Signed-off-by: Zhongtian Wu <wuzhongtian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/76190/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/76190?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I30e7c87d788f7f144276c45e8475af65f1f132ae Gerrit-Change-Number: 76190 Gerrit-PatchSet: 3 Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Change ILI2901 stop_gpio to LOW
by Kun Liu (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, zhongtian wu. Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76201?usp=email ) Change subject: mb/google/rex/var/screebo: Change ILI2901 stop_gpio to LOW ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/76201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea36ba948a1d731a5794c156c4fb4e8373d5d9bc Gerrit-Change-Number: 76201 Gerrit-PatchSet: 1 Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:39:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/rex/var/screebo: Change ILI2901 stop_gpio to LOW
by zhongtian wu (Code Review) 03 Jul '23

03 Jul '23

zhongtian wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76201?usp=email ) Change subject: mb/google/rex/var/screebo: Change ILI2901 stop_gpio to LOW ...................................................................... mb/google/rex/var/screebo: Change ILI2901 stop_gpio to LOW Change ILI2901 stop_gpio to ACPI_GPIO_OUTPUT_ACTIVE_LOW. BUG=b:278167967 BRANCH=none TEST=Build and boot to Google Screebo. Verify touchscreen works. Change-Id: Iea36ba948a1d731a5794c156c4fb4e8373d5d9bc Signed-off-by: Zhongtian Wu <wuzhongtian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/variants/screebo/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/76201/1 diff --git a/src/mainboard/google/rex/variants/screebo/overridetree.cb b/src/mainboard/google/rex/variants/screebo/overridetree.cb index 453e897..df461e3 100644 --- a/src/mainboard/google/rex/variants/screebo/overridetree.cb +++ b/src/mainboard/google/rex/variants/screebo/overridetree.cb @@ -384,7 +384,7 @@ register "generic.reset_delay_ms" = "200" register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C00)" register "generic.enable_delay_ms" = "12" - register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C06)" + register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C06)" register "generic.stop_off_delay_ms" = "2" register "generic.has_power_resource" = "1" register "hid_desc_reg_offset" = "0x01" -- To view, visit https://review.coreboot.org/c/coreboot/+/76201?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iea36ba948a1d731a5794c156c4fb4e8373d5d9bc Gerrit-Change-Number: 76201 Gerrit-PatchSet: 1 Gerrit-Owner: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING
by Jincheng Li (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Chen, Gang C. Hello Chen, Gang C, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/76214?usp=email to review the following change. Change subject: vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING ...................................................................... vc/intel/edk: Add CFLAGS -fshort-wchar for UDK_202302_BINDING Edk2-stable202302 add wchar_t check and limit L'A' equals to 2. Add CFLAGS to override gcc default wchar_t size. Change-Id: I3ff364a8b2cf7762a53e552ebeafa7d274f3bbb8 Signed-off-by: Li, Jincheng <jincheng.li(a)intel.com> Signed-off-by: Gang Chen <gang.c.chen(a)intel.com> --- M src/soc/intel/meteorlake/Makefile.inc M src/vendorcode/intel/Makefile.inc 2 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/76214/1 diff --git a/src/soc/intel/meteorlake/Makefile.inc b/src/soc/intel/meteorlake/Makefile.inc index aa82381..688f75c 100644 --- a/src/soc/intel/meteorlake/Makefile.inc +++ b/src/soc/intel/meteorlake/Makefile.inc @@ -59,5 +59,4 @@ CPPFLAGS_common += -I$(src)/soc/intel/meteorlake CPPFLAGS_common += -I$(src)/soc/intel/meteorlake/include -CFLAGS_common += -fshort-wchar endif diff --git a/src/vendorcode/intel/Makefile.inc b/src/vendorcode/intel/Makefile.inc index 4396ed3..ea690ba 100644 --- a/src/vendorcode/intel/Makefile.inc +++ b/src/vendorcode/intel/Makefile.inc @@ -27,4 +27,5 @@ CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/MdePkg/Include CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include CPPFLAGS_common += -I$(src)/vendorcode/intel/edk2/edk2-stable202302/UefiCpuPkg/Include/ +CFLAGS_common += -fshort-wchar endif -- To view, visit https://review.coreboot.org/c/coreboot/+/76214?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ff364a8b2cf7762a53e552ebeafa7d274f3bbb8 Gerrit-Change-Number: 76214 Gerrit-PatchSet: 1 Gerrit-Owner: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-Attention: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset
by Dtrain Hsu (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Paul Menzel, Shou-Chieh Hsu, Tarun Tuli. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76105?usp=email ) Change subject: mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/76105/comment/ce54d729_539e131e : PS1, Line 7: Modify > That’s too broad. Please use a more specific verb. Done https://review.coreboot.org/c/coreboot/+/76105/comment/a45e6e3c_ebe44f82 : PS1, Line 11: > Please list/enumerate the changes. Done https://review.coreboot.org/c/coreboot/+/76105/comment/46acc222_0bf2ee86 : PS1, Line 14: TEST=emerge-nissa coreboot chromeos-bootimage > Don’t you need to boot it also and run some tests? Done File src/mainboard/google/brya/variants/uldren/overridetree.cb: https://review.coreboot.org/c/coreboot/+/76105/comment/1869dc79_9be9945d : PS1, Line 109: register "tcc_offset" = "3" > Please add a comment what value that actually results in. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Gerrit-Change-Number: 76105 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:09:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset
by Dtrain Hsu (Code Review) 03 Jul '23

03 Jul '23

Attention is currently required from: Dtrain Hsu, Shou-Chieh Hsu, Tarun Tuli. Hello Derek Huang, Eric Lai, Ivan Chen, Paul Yang, Shou-Chieh Hsu, Sumeet R Pawnikar, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76105?usp=email to look at the new patch set (#2). Change subject: mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset ...................................................................... mb/google/nissa/var/uldren: Update DPTF parameters and tcc_offset Follow the Project_Uldren_Thermal_paramters_list_2023_0626.xlsx to modify DPTF parameters and tcc_offset. - Set tcc_offset to 3. - Update Critical Policy trip point. - Update Power Limits PL1 minimum step size to control limits (in mW). BUG=b:282598257 BRANCH=firmware-nissa-15217.B TEST=boot uldren to ChromeOS and pass thermal test. Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldren/overridetree.cb 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/76105/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Gerrit-Change-Number: 76105 Gerrit-PatchSet: 2 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Paul Yang <paul.f.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2023