coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: mb/google/nissa/var/uldren: Modify DPTF parameters
by Dtrain Hsu (Code Review) 27 Jun '23

27 Jun '23

Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76105?usp=email ) Change subject: mb/google/nissa/var/uldren: Modify DPTF parameters ...................................................................... mb/google/nissa/var/uldren: Modify DPTF parameters Follow the Project_Uldren_Thermal_paramters_list_2023_0626.xlsx to modify DPTF parameters. BUG=b:282598257 BRANCH=firmware-nissa-15217.B TEST=emerge-nissa coreboot chromeos-bootimage Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Signed-off-by: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/uldren/overridetree.cb 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/76105/1 diff --git a/src/mainboard/google/brya/variants/uldren/overridetree.cb b/src/mainboard/google/brya/variants/uldren/overridetree.cb index a873a62..973a6de 100644 --- a/src/mainboard/google/brya/variants/uldren/overridetree.cb +++ b/src/mainboard/google/brya/variants/uldren/overridetree.cb @@ -106,6 +106,8 @@ .vnn_icc_max_ma = 500, }" + register "tcc_offset" = "3" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | @@ -175,10 +177,10 @@ }" ## Critical Policy register "policies.critical" = "{ - [0] = DPTF_CRITICAL(CPU, 105, SHUTDOWN), - [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 98, SHUTDOWN), - [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 98, SHUTDOWN), - [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 98, SHUTDOWN), + [0] = DPTF_CRITICAL(CPU, 130, SHUTDOWN), + [1] = DPTF_CRITICAL(TEMP_SENSOR_0, 105, SHUTDOWN), + [2] = DPTF_CRITICAL(TEMP_SENSOR_1, 105, SHUTDOWN), + [3] = DPTF_CRITICAL(TEMP_SENSOR_2, 105, SHUTDOWN), }" register "controls.power_limits" = "{ @@ -187,7 +189,7 @@ .max_power = 6000, .time_window_min = 28 * MSECS_PER_SEC, .time_window_max = 28 * MSECS_PER_SEC, - .granularity = 250 + .granularity = 125 }, .pl2 = { .min_power = 25000, -- To view, visit https://review.coreboot.org/c/coreboot/+/76105?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5bbb3aa3b036a1eae8a95f63b570db2dc6da978 Gerrit-Change-Number: 76105 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/bytedance: Add 2 SPR sockets server board bd_egs
by TangYiwei (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Elyes Haouas, Felix Held, Felix Singer, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, niehaitao(a)bytedance.com. TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75722?usp=email ) Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs ...................................................................... Patch Set 13: (1 comment) File src/mainboard/bytedance/bd_egs/Kconfig: https://review.coreboot.org/c/coreboot/+/75722/comment/b13e8d3b_ab7a1b34 : PS10, Line 32: default "\\_SB.C%03d" > Hi Yiwei, could you check if you remove this line will it still works on your side? Hi Sheng, It's workable on my side because below PR has been merged, https://review.coreboot.org/c/coreboot/+/73368 -- To view, visit https://review.coreboot.org/c/coreboot/+/75722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d Gerrit-Change-Number: 75722 Gerrit-PatchSet: 13 Gerrit-Owner: TangYiwei Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: laykong <lay.kong(a)intel.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 27 Jun 2023 02:55:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Lean Sheng Tan <sheng.tan(a)9elements.com> Comment-In-Reply-To: TangYiwei Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/pirika: Add new Codec ALC5650
by Daniel Peng (Code Review) 27 Jun '23

27 Jun '23

Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75918?usp=email ) Change subject: mb/google/dedede/var/pirika: Add new Codec ALC5650 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/75918?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39703a950620c90aa3740b7313b7d32cc68eede4 Gerrit-Change-Number: 75918 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Tue, 27 Jun 2023 02:53:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/dedede/var/pirika: Add new Codec ALC5650
by Daniel Peng (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Daniel Peng. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75918?usp=email to look at the new patch set (#2). Change subject: mb/google/dedede/var/pirika: Add new Codec ALC5650 ...................................................................... mb/google/dedede/var/pirika: Add new Codec ALC5650 1.Add Codec ALC5650 setings for drivers/i2c/generic 2.Add option value '3' to AUDIO_CODEC_SOURCE for SSFC BUG=b:284060672 BRANCH=master TEST=emerge-dedede coreboot chromeos-ec chromeos-bootimage Confirm the device is existed on system. Change-Id: I39703a950620c90aa3740b7313b7d32cc68eede4 Signed-off-by: Daniel_Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/75918/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75918?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39703a950620c90aa3740b7313b7d32cc68eede4 Gerrit-Change-Number: 75918 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: mb/bytedance: Add 2 SPR sockets server board bd_egs
by TangYiwei (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Arthur Heymans, Christian Walter, David Hendricks, Elyes Haouas, Felix Held, Felix Singer, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, TangYiwei, niehaitao(a)bytedance.com. Hello Arthur Heymans, Christian Walter, David Hendricks, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nico Huber, Nill Ge, Patrick Rudolph, Paul Menzel, build bot (Jenkins), niehaitao(a)bytedance.com, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75722?usp=email to look at the new patch set (#13). The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Code-Review+2 by Lean Sheng Tan, Verified+1 by build bot (Jenkins) Change subject: mb/bytedance: Add 2 SPR sockets server board bd_egs ...................................................................... mb/bytedance: Add 2 SPR sockets server board bd_egs Bytedance bd_egs is a dual socket MB with Intel Sapphire Rapids Scalable Processor chipset. It's utilising: - 2 SPR sockets - Max 32 DIMMs - 33x CPU PCIe slots - AST2600 for VGA and BMC remote management Test: The board boots to Linux 5.10 with all 192 cores available. All PCIe devices and DIMMS are working. # sudo dmesg --level alert,crit,err,warn [ 46.636896] netlink: 'consul': attribute type 1 has an invalid length. Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d Co-authored-by: Jinfeng Li <lijinfeng01(a)ieisystem.com> Co-authored-by: Long Cao <caolong01(a)inspur.com> Co-authored-by: Hao Wang <wanghao11(a)inspur.com> Co-authored-by: Chenyu Lan <lanchenyu(a)inspur.com> Co-authored-by: Lay Kong <lay.kong(a)intel.com> Co-authored-by: Kehong Chen <kehong.chen(a)intel.com> Co-authored-by: Ziang Wang <ziang.wang(a)intel.com> Co-authored-by: Dong Wei <weidong.wd(a)bytedance.com> Co-authored-by: Chenchen Li <lichenchen.carl(a)bytedance.com> Signed-off-by: Yiwei Tang <tangyiwei.2022(a)bytedance.com> Reviewed-by: Haitao Nie <niehaitao(a)bytedance.com> Reviewed-by: Shijian Ge <geshijian(a)bytedance.com> --- A src/mainboard/bytedance/Kconfig A src/mainboard/bytedance/Kconfig.name A src/mainboard/bytedance/bd_egs/Kconfig A src/mainboard/bytedance/bd_egs/Kconfig.name A src/mainboard/bytedance/bd_egs/Makefile.inc A src/mainboard/bytedance/bd_egs/acpi/platform.asl A src/mainboard/bytedance/bd_egs/board.fmd A src/mainboard/bytedance/bd_egs/board_info.txt A src/mainboard/bytedance/bd_egs/bootblock.c A src/mainboard/bytedance/bd_egs/devicetree.cb A src/mainboard/bytedance/bd_egs/dsdt.asl A src/mainboard/bytedance/bd_egs/gpio.c A src/mainboard/bytedance/bd_egs/gpio.h A src/mainboard/bytedance/bd_egs/include/sprsp_bd_iio.h A src/mainboard/bytedance/bd_egs/ramstage.c A src/mainboard/bytedance/bd_egs/romstage.c 16 files changed, 757 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/75722/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/75722?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I091bc78e39cd76b3c6b9a10a1fcf58e9d671ef5d Gerrit-Change-Number: 75722 Gerrit-PatchSet: 13 Gerrit-Owner: TangYiwei Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nill Ge <geshijian(a)bytedance.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: niehaitao(a)bytedance.com Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: laykong <lay.kong(a)intel.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nill Ge <geshijian(a)bytedance.com> Gerrit-Attention: TangYiwei Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: niehaitao(a)bytedance.com Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/nissa: Setup driver for gothrax
by Yunlong Jia (Code Review) 27 Jun '23

27 Jun '23

Yunlong Jia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76104?usp=email ) Change subject: mb/google/nissa: Setup driver for gothrax ...................................................................... mb/google/nissa: Setup driver for gothrax Setup the driver for the keyboard/LTE/SAR/WWAN, and configure the I2C for the TPM. BUG=b:274707912 BRANCH=None Signed-off-by: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Change-Id: I1203ca13bd55b8ab96ce5d323a36ffde06860fa9 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name 2 files changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/76104/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 2a9941a..99c6c9f 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -163,6 +163,7 @@ default 0x3 if BOARD_GOOGLE_HADES default 0x0 if BOARD_GOOGLE_YAVILLA default 0x0 if BOARD_GOOGLE_ULDREN + default 0x0 if BOARD_GOOGLE_GOTHRAX config DRIVER_TPM_I2C_ADDR hex diff --git a/src/mainboard/google/brya/Kconfig.name b/src/mainboard/google/brya/Kconfig.name index ceac90e..2b28f69 100644 --- a/src/mainboard/google/brya/Kconfig.name +++ b/src/mainboard/google/brya/Kconfig.name @@ -383,3 +383,8 @@ config BOARD_GOOGLE_GOTHRAX bool "-> Gothrax" select BOARD_GOOGLE_BASEBOARD_NISSA + select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_GENESYSLOGIC_GL9750 + select DRIVERS_I2C_SX9324 + select DRIVERS_I2C_SX9324_SUPPORT_LEGACY_LINUX_DRIVER + select HAVE_WWAN_POWER_SEQUENCE -- To view, visit https://review.coreboot.org/c/coreboot/+/76104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1203ca13bd55b8ab96ce5d323a36ffde06860fa9 Gerrit-Change-Number: 76104 Gerrit-PatchSet: 1 Gerrit-Owner: Yunlong Jia <yunlong.jia(a)ecs.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[master]: util/docker/coreboot-sdk: Drop legacy libftdi package
by Felix Singer (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth. Hello Edward O'Callaghan, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76084?usp=email to look at the new patch set (#8). Change subject: util/docker/coreboot-sdk: Drop legacy libftdi package ...................................................................... util/docker/coreboot-sdk: Drop legacy libftdi package flashrom does not support libftdi 0.20 anymore and it's not used by anything else. Its build systems (Makefile and Meson) only reference libftdi1 and it still compiles fine without the legacy package. Thus, drop it from the package list. Change-Id: If1b575bc9abfd192e93811a83d8615bed61eba0c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/76084/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/76084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b575bc9abfd192e93811a83d8615bed61eba0c Gerrit-Change-Number: 76084 Gerrit-PatchSet: 8 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: util/docker/coreboot-sdk: Drop legacy libusb package
by Felix Singer (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth. Hello Edward O'Callaghan, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76083?usp=email to look at the new patch set (#7). Change subject: util/docker/coreboot-sdk: Drop legacy libusb package ...................................................................... util/docker/coreboot-sdk: Drop legacy libusb package flashrom does not support libusb 0.1 anymore and it's not used by anything else. Its build systems (Makefile and Meson) only reference libusb1 and it still compiles fine without the legacy package. Thus, drop it from the package list. Change-Id: Ib9b7530e5b707e12fbf3f8058999456dc1f8dff4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/76083/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/76083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9b7530e5b707e12fbf3f8058999456dc1f8dff4 Gerrit-Change-Number: 76083 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: util/docker/coreboot-sdk: Drop legacy libftdi package
by Felix Singer (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth. Hello Edward O'Callaghan, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76084?usp=email to look at the new patch set (#7). Change subject: util/docker/coreboot-sdk: Drop legacy libftdi package ...................................................................... util/docker/coreboot-sdk: Drop legacy libftdi package flashrom does not support libftdi 0.20 anymore and it's not used by anything else. Its build systems (Makefile and Meson) only references libftdi1 and it still compiles fine without the legacy package. Thus, drop it from the package list. Change-Id: If1b575bc9abfd192e93811a83d8615bed61eba0c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/76084/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/76084?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If1b575bc9abfd192e93811a83d8615bed61eba0c Gerrit-Change-Number: 76084 Gerrit-PatchSet: 7 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: util/docker/coreboot-sdk: Drop legacy libusb package
by Felix Singer (Code Review) 27 Jun '23

27 Jun '23

Attention is currently required from: Edward O'Callaghan, Martin L Roth. Hello Edward O'Callaghan, Martin L Roth, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76083?usp=email to look at the new patch set (#6). Change subject: util/docker/coreboot-sdk: Drop legacy libusb package ...................................................................... util/docker/coreboot-sdk: Drop legacy libusb package flashrom does not support libusb 0.1 anymore and it's not used by anything else. Its build systems (Makefile and Meson) only references libusb1 and it still compiles fine without the legacy package. Thus, drop it from the package list. Change-Id: Ib9b7530e5b707e12fbf3f8058999456dc1f8dff4 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-sdk/Dockerfile 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/76083/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/76083?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9b7530e5b707e12fbf3f8058999456dc1f8dff4 Gerrit-Change-Number: 76083 Gerrit-PatchSet: 6 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023