Attention is currently required from: Jakub Czapiga, Paul Menzel, Tarun Tuli.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76110?usp=email )
Change subject: mb/google/rex: Set TCC to 90°C
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76110/comment/6a6e1cb7_b7438c00 :
PS3, Line 11:
> Earlier the value was 0 as default.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76110?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0567b6240fcb53f38158c381b700169475cf3795
Gerrit-Change-Number: 76110
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Deepika Punyamurtula <deepika.punyamurtula(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 27 Jun 2023 04:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Balaji Manigandan, Felix Singer, Hannah Williams, Kapil Porwal, Paul Menzel, Subrata Banik, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Vikrant Jadeja.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/75717/comment/f4a8f354_506bd070 :
PS9, Line 253: acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE);
: acpigen_write_store_int_to_namestr(1, THUNDERBOLT_IOM_DPOF);
: acpigen_write_if_end();
> can you please create a helper function and just perform ON/OFF by passing arg0 to the helper functi […]
Subrata, ah right. I noticed the other part of the code that configures for s0ix entry/exit (line 234--243,262--271) and display on/off (line289--298, 304--313) also have the similar repeated code. Is it okay to clean up this file after landing this change? Please let me know what you think. Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/75717?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13
Gerrit-Change-Number: 75717
Gerrit-PatchSet: 9
Gerrit-Owner: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.com>
Gerrit-Reviewer: Utkarsh H Patel <utkarsh.h.patel(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Vikrant Jadeja
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-Attention: Vikrant Jadeja
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Utkarsh H Patel <utkarsh.h.patel(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 04:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Saurabh Mishra, Sridhar Siricilla.
Saurabh Mishra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76111?usp=email )
Change subject: libpayload/arch/x86[INTERNAL]: Update GP register for API handling of CBTABLE handoff
......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
File payloads/libpayload/arch/x86/head.S:
https://review.coreboot.org/c/coreboot/+/76111/comment/8fb7a3a5_b7bf7907 :
PS1, Line 68: movl %esi, loader_ebx
> This is not the one I suggested 😊
Done
https://review.coreboot.org/c/coreboot/+/76111/comment/ab9fb4b3_40866276 :
PS1, Line 72: movl %eax, cb_header_ptr
> + movl %ebx, cb_header_ptr
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/76111?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20d5f68ce60b58533bb048e5363c89a587a1b9b
Gerrit-Change-Number: 76111
Gerrit-PatchSet: 1
Gerrit-Owner: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Appukuttan V K <appukuttan.vk(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 04:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Kapil Porwal, Subrata Banik, Tarun Tuli, Uday Bhat.
Hello Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75924?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Code-Review+2 by Subrata Banik
Change subject: mb/google/rex: Enable Bluetooth offload for soundwire audio
......................................................................
mb/google/rex: Enable Bluetooth offload for soundwire audio
This patch enables BT offload feature for soundwire audio over SSP1.
BT mode is selected via FW_CONFIG and corresponding VGPIOs are
programmed.
BUG=b:275538390
TEST=build and verify BT offload on rex soundwire audio
Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3
Signed-off-by: Uday M Bhat <uday.m.bhat(a)intel.com>
---
M src/mainboard/google/rex/variants/rex0/fw_config.c
M src/mainboard/google/rex/variants/rex0/variant.c
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/75924/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/75924?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99df78787d9f54c91bcedf6f70352890a715cdb3
Gerrit-Change-Number: 75924
Gerrit-PatchSet: 10
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eric Lai, Tarun Tuli.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76118?usp=email )
Change subject: mb/google/hades: Update SD controller from GL9750 to GL9755
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/76118?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia5b3b17d76f02d5114af24535f9a1eecc14358a3
Gerrit-Change-Number: 76118
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 03:32:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Daniel Peng.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75918?usp=email )
Change subject: mb/google/dedede/var/pirika: Add new Codec ALC5650
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75918?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39703a950620c90aa3740b7313b7d32cc68eede4
Gerrit-Change-Number: 75918
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 27 Jun 2023 02:56:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment