coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[NoOp] Change in coreboot[master]: mb/google/rex/var/screebo: Add devicetree config for support audio AL...
by Rui Zhou (Code Review) 01 Jun '23

01 Jun '23

Rui Zhou has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/75461?usp=email ) Change subject: mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/75461?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ad6548e4fe47189b8463f4e796cc3b3f9e6db55 Gerrit-Change-Number: 75461 Gerrit-PatchSet: 5 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add devicetree config for support audio AL...
by Rui Zhou (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Kun Liu, Mac Chiang, Rui Zhou, Tarun Tuli. Hello Kapil Porwal, Kun Liu, Mac Chiang, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75461?usp=email to look at the new patch set (#4). Change subject: mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S ...................................................................... mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S Add devicetree config for ALC1019_ALC5682I_I2S BUG=b:278169268 TEST=emerge-rex coreboot and verified on screebo Change-Id: I2ad6548e4fe47189b8463f4e796cc3b3f9e6db55 Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/screebo/overridetree.cb 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/75461/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75461?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ad6548e4fe47189b8463f4e796cc3b3f9e6db55 Gerrit-Change-Number: 75461 Gerrit-PatchSet: 4 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Update GPIO PAD IO Standby State
by Subrata Banik (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Bora Guvendik, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email ) Change subject: mb/google/rex: Update GPIO PAD IO Standby State ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rex/variants/rex0/gpio.c: https://review.coreboot.org/c/coreboot/+/75555/comment/65e92ed7_d42f5738 : PS3, Line 19: PAD_CFG_NF_IOSSTATE(GPP_A00, UP_20K, DEEP, NF1, IGNORE), let me understand the problem, was the issue due to #1 or #2 below or for both ? 1. CB was not configuring these PADs as Native Function 2. Not skipping the GPIO IO standby programming wondering why can't we configure as below or even adding LOCK PAD_CFG_NF(GPP_A00, UP_20K, DEEP, NF1), -- To view, visit https://review.coreboot.org/c/coreboot/+/75555?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If96c1e71fdde784a55fe079875915ffa5a4f548a Gerrit-Change-Number: 75555 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 01 Jun 2023 09:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/screebo: Add devicetree config for support audio AL...
by Rui Zhou (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Kun Liu, Mac Chiang, Rui Zhou, Tarun Tuli. Hello Kapil Porwal, Kun Liu, Mac Chiang, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75461?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Kun Liu, Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S ...................................................................... mb/google/rex/var/screebo: Add devicetree config for support audio ALC1019_ALC5682I_I2S Add devicetree config for ALC1019_ALC5682I_I2S BUG=b:278169268 TEST=emerge-rex coreboot and verified on screebo Change-Id: I2ad6548e4fe47189b8463f4e796cc3b3f9e6db55 Signed-off-by: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/rex/Kconfig M src/mainboard/google/rex/variants/screebo/overridetree.cb 2 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/75461/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/75461?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ad6548e4fe47189b8463f4e796cc3b3f9e6db55 Gerrit-Change-Number: 75461 Gerrit-PatchSet: 3 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mac Chiang <mac.chiang(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/kukui: change Juniper/Willow Ram table offset to 0x30
by Sheng-Liang Pan (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75563?usp=email to look at the new patch set (#2). Change subject: mb/google/kukui: change Juniper/Willow Ram table offset to 0x30 ...................................................................... mb/google/kukui: change Juniper/Willow Ram table offset to 0x30 for Juniper and Willow, all memory ID can leverage offset 0x30 table, so change ram table default as 0x30 for further 2nd source. BUG=b:284423187 BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/75563/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/75563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5 Gerrit-Change-Number: 75563 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[master]: mb/google/kukui: change Juniper/Willow Ram table offset to 0x30
by Sheng-Liang Pan (Code Review) 01 Jun '23

01 Jun '23

Sheng-Liang Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/75563?usp=email ) Change subject: mb/google/kukui: change Juniper/Willow Ram table offset to 0x30 ...................................................................... mb/google/kukui: change Juniper/Willow Ram table offset to 0x30 for Juniper and Willow, we check all the memory ID can leverage offset 0x30 table, so change Juniper/Willow ram table default as 0x30 for further 2nd source. BUG=b:284423187 BRANCH=kukui TEST=emerge-jacuzzi coreboot Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5 --- M src/mainboard/google/kukui/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/75563/1 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 86dd8f9..0470899 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -92,7 +92,7 @@ hex default 0x10 if BOARD_GOOGLE_FENNEL || BOARD_GOOGLE_CERISE || BOARD_GOOGLE_STERN || BOARD_GOOGLE_MAKOMO || BOARD_GOOGLE_MUNNA default 0x20 if BOARD_GOOGLE_KAKADU || BOARD_GOOGLE_KATSU - default 0x30 if BOARD_GOOGLE_COZMO || BOARD_GOOGLE_PICO + default 0x30 if BOARD_GOOGLE_COZMO || BOARD_GOOGLE_PICO || BOARD_GOOGLE_JUNIPER || BOARD_GOOGLE_WILLOW default 0x40 if BOARD_GOOGLE_KAPPA default 0x50 if BOARD_GOOGLE_BURNET || BOARD_GOOGLE_ESCHE default 0x0 -- To view, visit https://review.coreboot.org/c/coreboot/+/75563?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I92740275dcc27061a94b7db7ce095655c0bd7cf5 Gerrit-Change-Number: 75563 Gerrit-PatchSet: 1 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/rex: Update GPIO PAD IO Standby State
by Subrata Banik (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Bora Guvendik, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email ) Change subject: mb/google/rex: Update GPIO PAD IO Standby State ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75555/comment/e9c1fea5_e016b64c : PS3, Line 9: Type-c Type-C -- To view, visit https://review.coreboot.org/c/coreboot/+/75555?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If96c1e71fdde784a55fe079875915ffa5a4f548a Gerrit-Change-Number: 75555 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:46:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/rex/variants/ovis: Add override devicetree
by Jakub Czapiga (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Jan Dabros, Kapil Porwal, Subrata Banik, Tarun Tuli. Hello Kapil Porwal, Subrata Banik, Tarun Tuli, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/75503?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rex/variants/ovis: Add override devicetree ...................................................................... mb/google/rex/variants/ovis: Add override devicetree BUG=b:274421383 TEST=util/abuild/abuild -p none -t google/rex -x -a -b ovis Change-Id: I1644b1d8f49accbb2ea68e236534df80a5151360 Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> --- M src/mainboard/google/rex/variants/ovis/overridetree.cb 1 file changed, 394 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/75503/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/75503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1644b1d8f49accbb2ea68e236534df80a5151360 Gerrit-Change-Number: 75503 Gerrit-PatchSet: 4 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Dabros <dabros(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jan Dabros <dabros(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: mb/google/rex: Update GPIO PAD IO Standby State
by Subrata Banik (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Bora Guvendik, Kapil Porwal, Tarun Tuli. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75555?usp=email ) Change subject: mb/google/rex: Update GPIO PAD IO Standby State ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: we need to apply this on all other variants as well ? -- To view, visit https://review.coreboot.org/c/coreboot/+/75555?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If96c1e71fdde784a55fe079875915ffa5a4f548a Gerrit-Change-Number: 75555 Gerrit-PatchSet: 3 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: include/cpu/x86: Simplify en/dis cache functions
by Subrata Banik (Code Review) 01 Jun '23

01 Jun '23

Attention is currently required from: Felix Singer, Himanshu Sahdev, Jérémy Compostella, Lean Sheng Tan. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75552?usp=email ) Change subject: include/cpu/x86: Simplify en/dis cache functions ...................................................................... Patch Set 2: (1 comment) File src/include/cpu/x86/cache.h: https://review.coreboot.org/c/coreboot/+/75552/comment/1ce14ce9_22f45617 : PS2, Line 48: CR0_CacheDisable > want me to change it to screaming snake case -> CR0_CACHE_DISABLE? yup, this is what make sense. > > Also, these macros being in use already, better to do it in different CL to change everywhere. sure -- To view, visit https://review.coreboot.org/c/coreboot/+/75552?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81688e8bbb073e1d09ecf63f3f33e1651dbd778e Gerrit-Change-Number: 75552 Gerrit-PatchSet: 2 Gerrit-Owner: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Thu, 01 Jun 2023 08:43:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023