Attention is currently required from: Jon Murphy.
Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75574?usp=email )
Change subject: mb/google/myst: Add USB config to myst
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/75574?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I329aba80f3003a3a5f343b8dcc3efa8502b98e24
Gerrit-Change-Number: 75574
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 15:38:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75506?usp=email )
Change subject: soc/amd/block/ivrs: Add NULL check for IVRS
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/acpi/ivrs.c:
https://review.coreboot.org/c/coreboot/+/75506/comment/f5c3f7c5_e7653465 :
PS1, Line 338: printk(BIOS_WARNING, "%s: AGESA returned NULL IVRS\n", __func__);
> this warning message is misleading, since the ivrs table is generated by coreboot and isn't from age […]
Sure. Will make it like:
'NULL ivrs' ? suggestion ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/75506?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb0ea3bcaa3512a93500588ad4f11046edee61f
Gerrit-Change-Number: 75506
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 01 Jun 2023 15:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Kapil Porwal, Sean Rhodes, Subrata Banik, Tarun Tuli.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75481?usp=email )
Change subject: soc/intel/{alderlake, meteorlake}: Properly assign the FSP ASPM UPD
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/75481/comment/c2b1029f_24f9ec6b :
PS1, Line 899: if (rp_cfg->pcie_rp_aspm)
: s_cfg->PcieRpAspm[i] = get_aspm_control(rp_cfg->pcie_rp_aspm);
: else if (CONFIG(PCIEXP_ASPM)) /* use auto (FSP default) if PCIEXP_ASPM is enabled */
: s_cfg->PcieRpAspm[i] = ASPM_AUTO;
: else
: s_cfg->PcieRpAspm[i] = ASPM_DISABLE;
> > Those aren't disjoint cases. I want both of them. […]
`pcie_rp_aspm` is a *per port* config. So AFAICT, the only way to have ASPM enabled on some ports and disabled on others *is* to disable `PCIEXP_ASPM` and explicitly set `pcie_rp_aspm` per port.
If you leave `PCIEXP_ASPM` enabled and set `pcie_rp_aspm = ASPM_DISABLE` for a single port, then this still sets it to `ASPM_AUTO`.
e.g., CB:63466
--
To view, visit https://review.coreboot.org/c/coreboot/+/75481?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib20c7466c79c3e0757ebda98240a529920c32a16
Gerrit-Change-Number: 75481
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 15:01:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Mario Scheithauer, Maxim Polyakov, Nico Huber, Sean Rhodes, Werner Zeh.
Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75553?usp=email )
Change subject: soc/intel/apollolake: Switch to snake case for SataPortsEnable
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75553/comment/1f287ff1_d1231672 :
PS3, Line 9:
from pascal case
--
To view, visit https://review.coreboot.org/c/coreboot/+/75553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0df35125360eb42a03d5445011d72842cb2b8d7e
Gerrit-Change-Number: 75553
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 15:01:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Mario Scheithauer, Maxim Polyakov, Nico Huber, Sean Rhodes, Werner Zeh.
Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75553?usp=email )
Change subject: soc/intel/apollolake: Switch to snake case for SataPortsEnable
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/75553?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0df35125360eb42a03d5445011d72842cb2b8d7e
Gerrit-Change-Number: 75553
Gerrit-PatchSet: 3
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 14:33:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Ruihai Zhou.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75488?usp=email )
Change subject: soc/mediatek/common: Add support for power supply TPS65132S
......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/tps65132s.c:
https://review.coreboot.org/c/coreboot/+/75488/comment/99a5db69_b8362c1c :
PS5, Line 35: mdelay(10);
Where do these delays come from?
https://review.coreboot.org/c/coreboot/+/75488/comment/63da1d64_5c0ba5de :
PS5, Line 62: mdelay(50);
For such long delays, a comment mentioning section in the datasheet would be nice.
[1]: https://www.ti.com/lit/ds/symlink/tps65132.pdf?ts=1685628433524&ref_url=htt…
--
To view, visit https://review.coreboot.org/c/coreboot/+/75488?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad2c9bdea5824455efcef18b44876111061cfa1a
Gerrit-Change-Number: 75488
Gerrit-PatchSet: 5
Gerrit-Owner: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 14:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment