coreboot-gerrit June 2023

coreboot-gerrit@coreboot.org

1 participants
5387 discussions

[S] Change in coreboot[master]: mb/google/rex/variants/ovis: Add I2C config
by Jan Dabros (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Jakub Czapiga, Tarun Tuli. Jan Dabros has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75503?usp=email ) Change subject: mb/google/rex/variants/ovis: Add I2C config ...................................................................... Patch Set 5: Code-Review+1 (2 comments) File src/mainboard/google/rex/variants/ovis/overridetree.cb: https://review.coreboot.org/c/coreboot/+/75503/comment/cda89d61_e503f567 : PS1, Line 2: register "usb2_ports[0]" = "USB2_PORT_TYPE_C(OC0)" # USB2_C1 > This is based on the "Ovis - USB" tab in the Ovis Platform Mapping doc. […] Done File src/mainboard/google/rex/variants/ovis/overridetree.cb: https://review.coreboot.org/c/coreboot/+/75503/comment/3d9f407b_b1ef7f03 : PS2, Line 218: # Enable SSD Card PCIE 9 using clk 4 > Done. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/75503?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1644b1d8f49accbb2ea68e236534df80a5151360 Gerrit-Change-Number: 75503 Gerrit-PatchSet: 5 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <dabros(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 13:05:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Jan Dabros <dabros(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/nissa/var/joxer: add lp5x SPDs for Joxer
by Mark Hsieh (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Felix Held, Henry Sun, Nick Vaccaro, Reka Norman, Shou-Chieh Hsu. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75610?usp=email ) Change subject: mb/google/nissa/var/joxer: add lp5x SPDs for Joxer ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/75610?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibdc89c882581cfe4e5978faf4c6f70d653e0813d Gerrit-Change-Number: 75610 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:58:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: src/mainboard: Add Inventec setting
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Angel Pons, Annie Chen, Arthur Heymans, David Hendricks, Lean Sheng Tan. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75598?usp=email ) Change subject: src/mainboard: Add Inventec setting ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75598/comment/b72447d4_4699b21f : PS1, Line 7: src/mainboard: Add Inventec setting Maybe something like: > mb/inventec: Add Intel SPR server board Inventec Transformers Patchset: PS1: Please look at commit 30e743e7cc7f (mb/ibm: Add 4 SPR sockets server board IBM SBP1), Ie21c744224e8d9e5232d63b8366d2981c9575d70 [1] how to add a new board, and how to write the commit message. [1]: https://review.coreboot.org/c/coreboot/+/73392 -- To view, visit https://review.coreboot.org/c/coreboot/+/75598?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic9d99c3aadaa9f69e6d14d4b1a6c5157f5590684 Gerrit-Change-Number: 75598 Gerrit-PatchSet: 1 Gerrit-Owner: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Hung-Wei Chen <Chen.HW(a)inventec.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Annie Chen <chen.annieet(a)inventec.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:48:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/myst: Add USB config to myst
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Jon Murphy. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75574?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/myst: Add USB config to myst ...................................................................... Patch Set 2: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75574/comment/f8a7e361_692cb416 : PS2, Line 7: to myst Redundant. https://review.coreboot.org/c/coreboot/+/75574/comment/3841ff0d_97848386 : PS2, Line 9: FSP If you know the version of the fixed FSP, please document it. https://review.coreboot.org/c/coreboot/+/75574/comment/3ae54a77_6f8a7d3f : PS2, Line 14: verify USB works It’d be great if you could specify how exactly. All ports? -- To view, visit https://review.coreboot.org/c/coreboot/+/75574?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I329aba80f3003a3a5f343b8dcc3efa8502b98e24 Gerrit-Change-Number: 75574 Gerrit-PatchSet: 2 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:40:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/variants/ovis: Add display configurarion
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Jakub Czapiga, Kapil Porwal, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75579?usp=email ) Change subject: mb/google/rex/variants/ovis: Add display configurarion ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75579/comment/d8beba79_507f273e : PS1, Line 7: configurarion configuration https://review.coreboot.org/c/coreboot/+/75579/comment/5fea2399_90b3106b : PS1, Line 8: Please elaborate. -- To view, visit https://review.coreboot.org/c/coreboot/+/75579?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40f967b12b11c10a1a9329bfb42ebec5a8d7738f Gerrit-Change-Number: 75579 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Ivy Jian, Kapil Porwal, Subrata Banik, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75607?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75607/comment/54433b09_89e6ae04 : PS1, Line 7: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S I’d make it two commits: > mb/google/rex: Select SOC_INTEL_METEORLAKE_U_P https://review.coreboot.org/c/coreboot/+/75607/comment/5dfc4547_832bfa97 : PS1, Line 9: This patch ensures that mainboards built with Intel Meteor Lake SoC : are able to specify the correct SoC type between MTL-U/P and MTL-S. : : It will help to override the FSP UPD parameters properly. Looking at the diff, that’s too broad? Maybe (for each board): > The rex boards use a Meteor Lake U…, so select it. Currently, > there is no functional difference, but in the future FSP UPD > parameters can be overridden properly. -- To view, visit https://review.coreboot.org/c/coreboot/+/75607?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3 Gerrit-Change-Number: 75607 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Himanshu Sahdev, Kapil Porwal, Ronak Kanabar, Subrata Banik, Tarun Tuli. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75529?usp=email ) Change subject: soc/intel/meteorlake: Hook up UPD PchHdaSdiEnable ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/75529/comment/011d7040_fd82afb0 : PS4, Line 9: upd UPD https://review.coreboot.org/c/coreboot/+/75529/comment/5264304b_a45ce35d : PS4, Line 10: Upd UPD File src/soc/intel/meteorlake/chip.h: https://review.coreboot.org/c/coreboot/+/75529/comment/5d448387_e305a96b : PS4, Line 22: One space, as above? -- To view, visit https://review.coreboot.org/c/coreboot/+/75529?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43f1e59d28fc07218f8e25266f8ce3bdcf3f6e5c Gerrit-Change-Number: 75529 Gerrit-PatchSet: 4 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:36:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/myst: Add PCIe shutdown workaround
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Eric Lai, Jon Murphy, Karthik Ramasubramanian, Martin Roth. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75583?usp=email ) Change subject: mb/google/myst: Add PCIe shutdown workaround ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75583/comment/86a4aa18_4f9f743b : PS3, Line 9: FSP Add a version in case FSP gets fixed in the future? -- To view, visit https://review.coreboot.org/c/coreboot/+/75583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf0aca329f05f15a3ce9edfa6a0e782c2edccabe Gerrit-Change-Number: 75583 Gerrit-PatchSet: 3 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: libpayload/uhci: Re-write UHCI RH driver w/ generic_hub API
by Paul Menzel (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Nico Huber. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75504?usp=email ) Change subject: libpayload/uhci: Re-write UHCI RH driver w/ generic_hub API ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75504/comment/a1769fe8_7ed45f5e : PS1, Line 21: > I couldn't get QEMU's `usb-kbd` driver working, but this combination hangs […] Nice. Thank you. PS: Please feel free to mark my comments as resolved once you reply to them (with a solution). -- To view, visit https://review.coreboot.org/c/coreboot/+/75504?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5211728775eb94dfc23fa82ebf00fe5c99039709 Gerrit-Change-Number: 75504 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:34:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/smm: Check the SMM TSEG size
by Himanshu Sahdev (Code Review) 02 Jun '23

02 Jun '23

Attention is currently required from: Arthur Heymans, Bao Zheng, Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel, Zheng Bao. Himanshu Sahdev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75405?usp=email ) Change subject: soc/amd/smm: Check the SMM TSEG size ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/75405/comment/d0f75c7d_a317ab10 : PS3, Line 10: The SMM TSEG size should be less than SMM reserved size, bigger than : 8M, and power of 2. > > For a number, it is a power of 2 AND it is bigger than 8M, it is 8M, 16M, 32M, ... > > Does it have a "granularity of 128K"? > > granularity 128K mean it needs to be larger than 128K and a power of 2. +1, As per AMD64 Architecture Progrmamer's Manual, Section 10.2.5 SMRAM Protected Areas: `The TSeg range must be aligned to a 128 Kbyte boundary and the minimum TSeg size is 128 Kbytes.` But is Bao Zheng trying to put an extra sanity check here to ensure expected size to be greater than equal to 8Mib for some reason? -- To view, visit https://review.coreboot.org/c/coreboot/+/75405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic4f557c7b77db6fc5ab2783ca4e2ebe7a4476e85 Gerrit-Change-Number: 75405 Gerrit-PatchSet: 3 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Himanshu Sahdev <himanshu.sahdev(a)intel.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Zheng Bao Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 02 Jun 2023 12:31:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2023